Skip to contentSkip to conversation

Staging: speakup: buffers.c: checkpatch.pl fixes

PATCH New Lijo Antony 1 participant 3 messages Jan 8, 2013 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 Staging: speakup: buffers.c: checkpatch.pl fixes

Fixed two camel case issues.

---
 drivers/staging/speakup/buffers.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/staging/speakup/buffers.c +7 -7
index a2db956..382973e 100644
@@ -5,12 +5,12 @@
 #include "speakup.h"
 #include "spk_priv.h"
 
-#define synthBufferSize 8192	/* currently 8K bytes */
+#define SYNTH_BUF_SIZE 8192	/* currently 8K bytes */
 
-static u_char synth_buffer[synthBufferSize];	/* guess what this is for! */
+static u_char synth_buffer[SYNTH_BUF_SIZE];	/* guess what this is for! */
 static u_char *buff_in = synth_buffer;
 static u_char *buff_out = synth_buffer;
-static u_char *buffer_end = synth_buffer+synthBufferSize-1;
+static u_char *buffer_end = synth_buffer + SYNTH_BUF_SIZE - 1;
 
 /* These try to throttle applications by stopping the TTYs
  * Note: we need to make sure that we will restart them eventually, which is
@@ -44,13 +44,13 @@ static void speakup_stop_ttys(void)
 
 static int synth_buffer_free(void)
 {
-	int bytesFree;
+	int bytes_free;
 
 	if (buff_in >= buff_out)
-		bytesFree = synthBufferSize - (buff_in - buff_out);
+		bytes_free = SYNTH_BUF_SIZE - (buff_in - buff_out);
 	else
-		bytesFree = buff_out - buff_in;
-	return bytesFree;
+		bytes_free = buff_out - buff_in;
+	return bytes_free;
 }
 
 int synth_buffer_empty(void)
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 2/3 Staging: speakup: keyhelp.c: checkpatch.pl fixes

Breaking 2 lines to fit 80 char limit

---
 drivers/staging/speakup/keyhelp.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/staging/speakup/keyhelp.c +5 -2
index 4c584ec..5091625 100644
@@ -118,7 +118,8 @@ static void say_key(int key)
 			synth_printf(" %s", spk_msg_get(MSG_STATES_START + i));
 	}
 	if ((key > 0) && (key <= num_key_names))
-		synth_printf(" %s\n", spk_msg_get(MSG_KEYNAMES_START + (key - 1)));
+		synth_printf(" %s\n",
+				spk_msg_get(MSG_KEYNAMES_START + (key - 1)));
 }
 
 static int help_init(void)
@@ -169,7 +170,9 @@ int spk_handle_help(struct vc_data *vc, u_char type, u_char ch, u_short key)
 			cur_item--;
 		else
 			return -1;
-	} else if (type == KT_SPKUP && ch == SPEAKUP_HELP && !spk_special_handler) {
+	} else if (type == KT_SPKUP
+			&& ch == SPEAKUP_HELP
+			&& !spk_special_handler) {
 		spk_special_handler = spk_handle_help;
 		synth_printf("%s\n", spk_msg_get(MSG_HELP_INFO));
 		build_key_data(); /* rebuild each time in case new mapping */
Signature · 1 line
1.7.10.4
#2 lore raw

PATCH 3/3 Staging: speakup: kobjects.c: checkpatch.pl fixes

In reply to Lijo Antony

Fixed two "line over 80 characters" warnings reported by checkpatch.pl

---
 drivers/staging/speakup/kobjects.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/speakup/kobjects.c +4 -4
index 86387f4..35f647c 100644
@@ -654,16 +654,16 @@ ssize_t spk_var_store(struct kobject *kobj, struct kobj_attribute *attr,
 		if (synth && synth->default_pitch) {
 			param = spk_var_header_by_name("pitch");
 			if (param)  {
-				spk_set_num_var(synth->default_pitch[value], param,
-					E_NEW_DEFAULT);
+				spk_set_num_var(synth->default_pitch[value],
+						param, E_NEW_DEFAULT);
 				spk_set_num_var(0, param, E_DEFAULT);
 			}
 		}
 		if (synth && synth->default_vol) {
 			param = spk_var_header_by_name("vol");
 			if (param)  {
-				spk_set_num_var(synth->default_vol[value], param,
-					E_NEW_DEFAULT);
+				spk_set_num_var(synth->default_vol[value],
+						param, E_NEW_DEFAULT);
 				spk_set_num_var(0, param, E_DEFAULT);
 			}
 		}
Signature · 1 line
1.7.10.4