infozip: new package

PATCH New Jan Pedersen 2 participants 2 messages Jan 10, 2013

lore

Share & tools

lore

Jan Pedersen

author

2013-01-10 10:41 UTC #0 lore raw

PATCH 1/1 infozip: new package

This commit adds a package for infozip, compression and file packaging/archive utility.

Signed-off-by Jan Pedersen <[email protected]>

---
 package/Config.in          |    1 +
 package/infozip/Config.in  |   10 ++++++++++
 package/infozip/infozip.mk |   21 +++++++++++++++++++++
 3 files changed, 32 insertions(+)
 create mode 100644 package/infozip/Config.in
 create mode 100644 package/infozip/infozip.mk

package/Config.in +1 -0

index bd1db6b..1c2b228 100644
@@ -14,6 +14,7 @@ endif
 source "package/lzop/Config.in"
 source "package/lzma/Config.in"
 source "package/xz/Config.in"
+source "package/infozip/Config.in"
 endmenu
 
 menu "Debugging, profiling and benchmark"

package/infozip/Config.in new file +10 -0

new file mode 100644
index 0000000..1a4b756
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_INFOZIP
+	bool "infozip"
+	help
+	  Zip is a compression and file packaging/archive utility. 
+	  Although highly compatible both with PKWARE's PKZIP and 
+	  PKUNZIP utilities for MS-DOS and with Info-ZIP's own UnZip, 
+ 	  our primary objectives have been portability and other-than-MSDOS 
+	  functionality. 
+
+	  http://infozip.sourceforge.net/Zip.html

package/infozip/infozip.mk new file +21 -0

new file mode 100644
index 0000000..ce6e88f
@@ -0,0 +1,21 @@
+#############################################################
+#
+# infozip
+#
+#############################################################
+INFOZIP_VERSION = 30
+INFOZIP_SOURCE = zip$(INFOZIP_VERSION).tgz
+INFOZIP_SITE = ftp://ftp.info-zip.org/pub/infozip/src
+INFOZIP_LICENSE = Info-ZIP
+INFOZIP_LICENSE_FILES = LICENCE
+
+define INFOZIP_BUILD_CMDS
+	$(MAKE) -C $(@D) -f unix/Makefile generic CC=$(TARGET_CC)
+endef
+
+define INFOZIP_INSTALL_TARGET_CMDS
+	$(MAKE) -C $(@D) -f unix/Makefile install prefix=$(TARGET_DIR)/usr CC=$(TARGET_CC)
+endef
+
+$(eval $(generic-package))
+

Signature · 1 line

1.7.10.4

Thomas Petazzoni

2013-01-10 11:15 UTC #1 lore raw

PATCH 1/1 infozip: new package

Dear Jan Pedersen,

Quoted 1 line · Jan Pedersen

+INFOZIP_LICENSE_FILES = LICENCE

This is not correct, the file is called LICENSE.

You should run "make legal-info" when you create a new package, to verify that the LICENSE_FILES field is correct.

package/infozip/infozip.mk line 18

Quoted 7 lines

package/infozip/infozip.mk new file +7 -0

+define INFOZIP_BUILD_CMDS
+	$(MAKE) -C $(@D) -f unix/Makefile generic CC=$(TARGET_CC)
+endef
+
+define INFOZIP_INSTALL_TARGET_CMDS
+	$(MAKE) -C $(@D) -f unix/Makefile install prefix=$(TARGET_DIR)/usr CC=$(TARGET_CC)
+endef

Even though the package does not allow to override CFLAGS, I would prefer if $(TARGET_CONFIGURE_OPTS) was used. It avoids for example the mistake of forgetting the quotes around $(TARGET_CC). So, something like:

define INFOZIP_BUILD_CMDS

	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) -f unix/Makefile generic

endef

define INFOZIP_INSTALL_TARGET_CMDS

	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) -f unix/Makefile install prefix=$(TARGET_DIR)/usr

endef

Once this is fixed, you get my Acked-by and Tested-by, as I tested this package.

Thanks!

Thomas

Signature · 4 lines

Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com