Skip to contentSkip to conversation

hiawatha: update to 8.7

PATCH In review [email protected] 2 participants 3 messages Jan 14, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hiawatha: update to 8.7

From: Jack Mitchell <[email protected]>

---
 .../recipes-httpd/hiawatha/files/xslt-fix.patch    | 71 ----------------------
 .../recipes-httpd/hiawatha/hiawatha_8.7.bb         | 56 +++++++++++++++++
 2 files changed, 56 insertions(+), 71 deletions(-)
 delete mode 100644 meta-webserver/recipes-httpd/hiawatha/files/xslt-fix.patch
 create mode 100644 meta-webserver/recipes-httpd/hiawatha/hiawatha_8.7.bb
meta-webserver/recipes-httpd/hiawatha/files/xslt-fix.patch deleted +0 -71
deleted file mode 100644
index 41bf4cc..0000000
@@ -1,71 +0,0 @@
-Upstream Status: Backport
-Signed-off-by: Jack Mitchell <[email protected]>
----
- src/xslt.c | 19 +++++++------------
- 1 file changed, 7 insertions(+), 12 deletions(-)
-
-diff --git a/src/xslt.c b/src/xslt.c
-index 9d8d31a..58ca52d 100644
---- a/src/xslt.c
-+++ b/src/xslt.c
-@@ -23,6 +23,7 @@
- #include <libxslt/transform.h>
- #include <libxslt/xsltutils.h>
- #include "libstr.h"
-+#include "liblist.h"
- #include "send.h"
- #include "log.h"
- #ifdef ENABLE_TOMAHAWK
-@@ -343,10 +344,10 @@ bool can_transform_with_xslt(t_session *session) {
- static int apply_xslt_sheet(t_session *session, xmlDocPtr data_xml) {
- 	xmlDocPtr style_xml, result_xml;
- 	xsltStylesheetPtr xslt;
--	xmlOutputBufferPtr output;
-+	xmlChar *raw_xml;
- 	char value[VALUE_SIZE + 1];
- 	const char **params;
--	int result = 200;
-+	int result = 200, raw_size;
- 
- 	/* Read XML data
- 	 */
-@@ -396,14 +397,8 @@ static int apply_xslt_sheet(t_session *session, xmlDocPtr data_xml) {
- 		xsltFreeStylesheet(xslt);
- 		return 500;
- 	}
--	if ((output = xmlAllocOutputBuffer(NULL)) == NULL) {
--		xmlFreeDoc(result_xml);
--		xsltFreeStylesheet(xslt);
--		return 500;
--	}
--    if (xsltSaveResultTo(output, result_xml, xslt) == -1) {
-+	if (xsltSaveResultToString(&raw_xml, &raw_size, result_xml, xslt) == -1) {
- 		log_file_error(session, session->file_on_disk, "transformation error");
--		xmlOutputBufferClose(output);
- 		xmlFreeDoc(result_xml);
- 		xsltFreeStylesheet(xslt);
- 		return 500;
-@@ -414,17 +409,17 @@ static int apply_xslt_sheet(t_session *session, xmlDocPtr data_xml) {
- 	value[VALUE_SIZE] = '\0';
- 	if (send_buffer(session, hs_conlen, 16) == -1) {
- 		result = -1;
--	} else if (snprintf(value, VALUE_SIZE, "%d\r\n\r\n", output->buffer->use) == -1) {
-+	} else if (snprintf(value, VALUE_SIZE, "%d\r\n\r\n", raw_size) == -1) {
- 		result = -1;
- 	} else if (send_buffer(session, value, strlen(value)) == -1) {
- 		result = -1;
--	} else if (send_buffer(session, (char*)output->buffer->content, output->buffer->use) == -1) {
-+	} else if (send_buffer(session, (char*)raw_xml, raw_size) == -1) {
- 		result = -1;
- 	}
- 
- 	/* Free buffers
- 	 */
--	xmlOutputBufferClose(output);
-+	xmlFree(raw_xml);
- 	xmlFreeDoc(result_xml);
- 	xsltFreeStylesheet(xslt);
- 
--- 
-1.8.0.1
-
meta-webserver/recipes-httpd/hiawatha/hiawatha_8.7.bb new file +56 -0

56 lines not on this page · raw message

Signature · 1 line
1.8.1
#1 lore raw

Hi Jack,

Quoted 10 lines · Le Mon, 14 Jan 2013 13:41:29 +0000, [email protected] a écrit :

From: Jack Mitchell <[email protected]>

---
 .../recipes-httpd/hiawatha/files/xslt-fix.patch    | 71 ----------------------
 .../recipes-httpd/hiawatha/hiawatha_8.7.bb         | 56 +++++++++++++++++
 2 files changed, 56 insertions(+), 71 deletions(-)
 delete mode 100644 meta-webserver/recipes-httpd/hiawatha/files/xslt-fix.patch
 create mode 100644 meta-webserver/recipes-httpd/hiawatha/hiawatha_8.7.bb

I think you forget to delete hiawatha_8.6.bb

Eric

#2 lore raw
Quoted 15 lines · Eric Bénard

Hi Jack,

Quoted 10 lines · Le Mon, 14 Jan 2013 13:41:29 +0000, [email protected] a écrit :

From: Jack Mitchell <[email protected]>

---
  .../recipes-httpd/hiawatha/files/xslt-fix.patch    | 71 ----------------------
  .../recipes-httpd/hiawatha/hiawatha_8.7.bb         | 56 +++++++++++++++++
  2 files changed, 56 insertions(+), 71 deletions(-)

delete mode 100644 meta-webserver/recipes-httpd/hiawatha/files/xslt-fix.patch create mode 100644 meta-webserver/recipes-httpd/hiawatha/hiawatha_8.7.bb

Quoted 3 lines

I think you forget to delete hiawatha_8.6.bb

Eric

That I did, I removed it from the directory but not from git. Will send a v2 (also with correct subject tomorrow), snow permitting for us Brits ;)