v2 [PATCH] sctp_xconnect: memory leak when malloc big buffer
sctp_xconnect: memory leak when malloc big buffer
CLIENT repeatly call process_ready_sockets, which malloc without free, so sctp_xconnect exit unexpectly.
Signed-off-by Fan Du <[email protected]>
v1->v2:
Declare this buffer statically suggested by Neil Horman.
--- apps/sctp_xconnect.c | 12 +----------- 1 files changed, 1 insertions(+), 11 deletions(-)
apps/sctp_xconnect.c +1 -11
@@ -73,6 +73,7 @@ char *remote_host = NULL;sockaddr_storage_t client_loop, server_loop;struct hostent *hst; +char big_buffer[REALLY_BIG ];void usage (char *argv0);void parse_arguments (int argc,char *argv[]);
@@ -380,13 +381,8 @@ void server_mode() {int assoc_num =0 ;struct msghdr inmessage;struct iovec iov; -char *big_buffer;char incmsg[CMSG_SPACE (sizeof (sctp_cmsg_data_t))]; -if ((big_buffer =malloc (REALLY_BIG )) =NULL ) { -printf ("malloc failure: %s\n" ,strerror (errno)); -DUMP_CORE ; - }printf ("Running in Server Mode...\n" );
@@ -530,15 +526,9 @@ void process_ready_sockets(int client_socket[], int assoc_num, fd_set *rfds) {int i, stream, error;struct msghdr inmessage;struct iovec iov; -char *big_buffer;char incmsg[CMSG_SPACE (sizeof (sctp_cmsg_data_t))];sockaddr_storage_t msgname; -if ((big_buffer =malloc (REALLY_BIG )) =NULL ) { -printf ("malloc failure: %s\n" ,strerror (errno)); -DUMP_CORE ; - } -/* Setup inmessage to be able to receive in incomming message */ memset (&inmessage,0 ,sizeof (inmessage)); iov.iov_base = big_buffer;
Signature · 1 line
1.7.1
Neil Horman
Acked-byQuoted 59 lines · Fan Du
sctp_xconnect: memory leak when malloc big bufferCLIENT repeatly call
process_ready_sockets, which malloc without free, sosctp_xconnectexit unexpectly.Signed-off-by Fan Du <[email protected]>
v1->v2:
Declare this buffer statically suggested by Neil Horman.--- apps/sctp_xconnect.c | 12 +----------- 1 files changed, 1 insertions(+), 11 deletions(-)apps/sctp_xconnect.c +1
-11@@ -73,6 +73,7 @@ char *remote_host = NULL;sockaddr_storage_t client_loop, server_loop;struct hostent *hst; +char big_buffer[REALLY_BIG ];void usage (char *argv0);void parse_arguments (int argc,char *argv[]);@@ -380,13 +381,8 @@ void server_mode() {int assoc_num =0 ;struct msghdr inmessage;struct iovec iov; -char *big_buffer;char incmsg[CMSG_SPACE (sizeof (sctp_cmsg_data_t))]; -if ((big_buffer =malloc (REALLY_BIG )) =NULL ) { -printf ("malloc failure: %s\n" ,strerror (errno)); -DUMP_CORE ; - }printf ("Running in Server Mode...\n" );@@ -530,15 +526,9 @@ void process_ready_sockets(int client_socket[], int assoc_num, fd_set *rfds) {int i, stream, error;struct msghdr inmessage;struct iovec iov; -char *big_buffer;char incmsg[CMSG_SPACE (sizeof (sctp_cmsg_data_t))];sockaddr_storage_t msgname; -if ((big_buffer =malloc (REALLY_BIG )) =NULL ) { -printf ("malloc failure: %s\n" ,strerror (errno)); -DUMP_CORE ; - } -/* Setup inmessage to be able to receive in incomming message */ memset (&inmessage,0 ,sizeof (inmessage)); iov.iov_base = big_buffer;Signature · 1 line
1.7.1
Looks good, thank you!
Acked-by Neil Horman <[email protected]>
Daniel Borkmann
AppliedQuoted 9 lines · Neil Horman
Quoted 8 lines · Fan Du
sctp_xconnect: memory leak when malloc big bufferCLIENT repeatly call
process_ready_sockets, which malloc without free, sosctp_xconnectexit unexpectly.Signed-off-by Fan Du <[email protected]>
v1->v2:
Declare this buffer statically suggested by Neil Horman.
[...]
Quoted 2 lines
Looks good, thank you!
Acked-by Neil Horman <[email protected]>
Applied, thanks Fan.