Skip to contentSkip to conversation

hwmon: da9055 change irq state to default

PATCH In review Ashish Jangam 2 participants 2 messages Jan 18, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 3/5 hwmon: da9055 change irq state to default

This patch changes the irq state from high to the now default low state.

This patch is dependent on the DA9055 MFD.

This patch is tested on smdk6410 board.

---
 drivers/hwmon/da9055-hwmon.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/hwmon/da9055-hwmon.c +1 -1
index 9465c05..dfd0db1 100644
@@ -284,7 +284,7 @@ static int da9055_hwmon_probe(struct platform_device *pdev)
 
 	ret = devm_request_threaded_irq(&pdev->dev, hwmon_irq,
 					NULL, da9055_auxadc_irq,
-					IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
+					IRQF_TRIGGER_LOW | IRQF_ONESHOT,
 					"adc-irq", hwmon);
 	if (ret != 0) {
 		dev_err(hwmon->da9055->dev, "DA9055 ADC IRQ failed ret=%d\n",
Signature · 1 line
1.7.0.4
maintainer Acked-by on v1 3/5
#1 lore raw
Quoted 5 lines · Ashish Jangam

This patch changes the irq state from high to the now default low state.

This patch is dependent on the DA9055 MFD.

That statement is a bit confusing. Do you mean it depends on a patch submitted for the DA9055 MFD ?

In other words, should this patch be pushed upstream through the mfd tree, or through the hwmon tree ?

Quoted 3 lines

This patch is tested on smdk6410 board.

Quoted 22 lines
---
 drivers/hwmon/da9055-hwmon.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/hwmon/da9055-hwmon.c +1 -1
index 9465c05..dfd0db1 100644
@@ -284,7 +284,7 @@ static int da9055_hwmon_probe(struct platform_device *pdev)
 
 	ret = devm_request_threaded_irq(&pdev->dev, hwmon_irq,
 					NULL, da9055_auxadc_irq,
-					IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
+					IRQF_TRIGGER_LOW | IRQF_ONESHOT,
 					"adc-irq", hwmon);
 	if (ret != 0) {
 		dev_err(hwmon->da9055->dev, "DA9055 ADC IRQ failed ret=%d\n",
Signature · 1 line
1.7.0.4