Skip to contentSkip to conversation

layer.conf: Use .= for adding to BBPATH and += to BBFILES

PATCH Applied Khem Raj 2 participants 5 messages Jan 21, 2013 – Feb 27, 2013

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/2 layer.conf: Use .= for adding to BBPATH and += to BBFILES

Fixes parsing errors which is appearing after this commit to meta-openembedded

http://cgit.openembedded.org/meta-openembedded/commit/?id=3c21a46020bd0816579648f

This triggers
exception NameError: name 'base_contains' is not defined without this change

---
 conf/layer.conf |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
conf/layer.conf +2 -2
index 6bcf70e..d8cc797 100644
@@ -1,8 +1,8 @@
 # We have a conf and classes directory, add to BBPATH
-BBPATH := "${BBPATH}:${LAYERDIR}"
+BBPATH .= ":${LAYERDIR}"
 
 # We have a recipes directory, add to BBFILES
-BBFILES := "${BBFILES} ${LAYERDIR}/recipes-mono/*/*.bb \
+BBFILES += "${LAYERDIR}/recipes-mono/*/*.bb \
             ${LAYERDIR}/recipes-mono/*/*.bbappend"
 
 BBFILE_COLLECTIONS += "mono"
Signature · 1 line
1.7.9.5
author
#1 lore raw

PATCH 2/2 monotools-server: Remove multiline comment

bitbake/master does not like it anymore

---
 .../monotools-server/monotools-server_2.0.bb       |    2 --
 1 file changed, 2 deletions(-)
recipes-mono/monotools-server/monotools-server_2.0.bb +0 -2
index 551c586..ef738da 100644
@@ -22,8 +22,6 @@ SRC_URI += " \
 	file://fix-pkglib_SCRIPTS.patch \
 	"
 
-#	file://Makefile-pkglib.patch \
-
 DEPENDS = "mono-xsp gtk-sharp"
 
 S = "${WORKDIR}/${PN}"
Signature · 1 line
1.7.9.5
Applied
#2 lore raw

Re: [meta-mono][PATCH 2/2] monotools-server: Remove multiline comment

Quoted 21 lines · Khem Raj

bitbake/master does not like it anymore

---
 .../monotools-server/monotools-server_2.0.bb       |    2 --
 1 file changed, 2 deletions(-)
recipes-mono/monotools-server/monotools-server_2.0.bb +0 -3
index 551c586..ef738da 100644
@@ -22,8 +22,6 @@ SRC_URI += " \
        file://fix-pkglib_SCRIPTS.patch \
        "
 
-#      file://Makefile-pkglib.patch \
-
 DEPENDS = "mono-xsp gtk-sharp"
 
 S = "${WORKDIR}/${PN}"
--
Quoted 2 lines

1.7.9.5

Merged into master

Apologies for late merge - somehow this got lost because of bad email filtering on my part.

author
#3 lore raw

Re: [meta-mono][PATCH 2/2] monotools-server: Remove multiline comment

Quoted 27 lines · Autif Khan
Quoted 21 lines · Khem Raj

bitbake/master does not like it anymore

---
 .../monotools-server/monotools-server_2.0.bb       |    2 --
 1 file changed, 2 deletions(-)
recipes-mono/monotools-server/monotools-server_2.0.bb +0 -3
index 551c586..ef738da 100644
@@ -22,8 +22,6 @@ SRC_URI += " \
        file://fix-pkglib_SCRIPTS.patch \
        "
 
-#      file://Makefile-pkglib.patch \
-
 DEPENDS = "mono-xsp gtk-sharp"
 
 S = "${WORKDIR}/${PN}"
--
Quoted 2 lines

1.7.9.5

Merged into master

Quoted 2 lines

Apologies for late merge - somehow this got lost because of bad email filtering on my part.

you need to update your maintainer email in README. Secondly we have a policy for marking layers maintained in ecosystem if maintainers dont respond in timely fashion its hard to keep layers marked as maintained.

Applied
#4 lore raw
In reply to Khem Raj
Quoted 30 lines · Khem Raj

Fixes parsing errors which is appearing after this commit to meta-openembedded

http://cgit.openembedded.org/meta-openembedded/commit/?id=3c21a46020bd0816579648f

This triggers
exception NameError: name 'base_contains' is not defined without this change

---
 conf/layer.conf |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
conf/layer.conf +2 -3
index 6bcf70e..d8cc797 100644
@@ -1,8 +1,8 @@
 # We have a conf and classes directory, add to BBPATH
-BBPATH := "${BBPATH}:${LAYERDIR}"
+BBPATH .= ":${LAYERDIR}"
 
 # We have a recipes directory, add to BBFILES
-BBFILES := "${BBFILES} ${LAYERDIR}/recipes-mono/*/*.bb \
+BBFILES += "${LAYERDIR}/recipes-mono/*/*.bb \
             ${LAYERDIR}/recipes-mono/*/*.bbappend"
 
 BBFILE_COLLECTIONS += "mono"
--
Quoted 2 lines

1.7.9.5

Merged into master

Apologies for late merge - somehow this got lost because of bad email filtering on my part.