Skip to contentSkip to conversation

ethtool: Fix space-after-if checkpatch errors

PATCH In review Mark Einon 2 participants 2 messages Jan 22, 2013

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Mark Einon

author
#0 lore raw

PATCH 1/1 ethtool: Fix space-after-if checkpatch errors

Some version check statements are lacking a space after the if () statement. Add them in.

Signed-off-by Mark Einon <[email protected]>
---
 e100.c   |    2 +-
 e1000.c  |    2 +-
 et131x.c |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
e100.c +1 -1
index 65627ab..b982e79 100644
@@ -46,7 +46,7 @@ e100_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
 	u32 reg;
 	u16 scb_status, scb_cmd;
 
-	if(version != 1)
+	if (version != 1)
 		return -1;
 
 	reg = regs_buff[0];
e1000.c +1 -1
index d1d3c73..dd47774 100644
@@ -374,7 +374,7 @@ e1000_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
 	enum e1000_mac_type mac_type;
 	u32 reg;
 
-	if(version != 1)
+	if (version != 1)
 		return -1;
 
 	mac_type = e1000_get_mac_type(hw_device_id, hw_revision_id);
et131x.c +1 -1
index 8cdbec0..36abaa2 100644
@@ -7,7 +7,7 @@ int et131x_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
 	u8 version = (u8)(regs->version >> 24);
 	u32 *reg = (u32 *)regs->data;
 
-	if(version != 1)
+	if (version != 1)
 		return -1;
 
 	fprintf(stdout, "PHY Registers\n");
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 4 lines · Mark Einon

Some version check statements are lacking a space after the if () statement. Add them in.

Signed-off-by Mark Einon <[email protected]>

[...]

OK, I've applied this on top of your earlier patch.

Ben.

Signature · 3 lines
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.