mm: don't inline page_mapping()
Subsystems (2)
PATCH v2 1/3 mm: don't inline page_mapping()
According to akpm, this saves 1/2k text and makes things simple of next patch.
--- include/linux/mm.h | 13 +------------ mm/util.c | 16 ++++++++++++++++ 2 files changed, 17 insertions(+), 12 deletions(-)
include/linux/mm.h +1 -12
@@ -817,18 +817,7 @@ void page_address_init(void);#define PAGE_MAPPING_KSM 2#define PAGE_MAPPING_FLAGS (PAGE_MAPPING_ANON | PAGE_MAPPING_KSM) -extern struct address_space swapper_space; -static inline struct address_space *page_mapping (struct page *page) -{ -struct address_space *mapping = page->mapping; - -VM_BUG_ON (PageSlab (page)); -if (unlikely (PageSwapCache (page))) - mapping = &swapper_space; -else if ((unsigned long )mapping &PAGE_MAPPING_ANON ) - mapping =NULL ; -return mapping; -} +extern struct address_space *page_mapping (struct page *page);/* Neutral page->mapping pointer to address_space or anon_vma or other */ static inline void *page_rmapping (struct page *page)
mm/util.c +16 -0
@@ -5,6 +5,7 @@#include <linux/err.h> #include <linux/sched.h> #include <linux/security.h> +#include <linux/swap.h> #include <asm/uaccess.h> #include "internal.h"
@@ -378,6 +379,21 @@ unsigned long vm_mmap(struct file *file, }EXPORT_SYMBOL (vm_mmap); +struct address_space *page_mapping (struct page *page) +{ +struct address_space *mapping = page->mapping; + +VM_BUG_ON (PageSlab (page)); +#ifdef CONFIG_SWAP +if (unlikely (PageSwapCache (page))) + mapping = &swapper_space; + else +#endif +if ((unsigned long )mapping &PAGE_MAPPING_ANON ) + mapping =NULL ; +return mapping; +} +/* Tracepoints definitions. */ EXPORT_TRACEPOINT_SYMBOL (kmalloc);EXPORT_TRACEPOINT_SYMBOL (kmem_cache_alloc);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 5 lines · Shaohua Li
According to akpm, this saves 1/2k text and makes things simple of next patch.
Suggested-by Andrew Morton <[email protected]>Signed-off-by Shaohua Li <[email protected]>
Signature · 7 lines
All rights reversed -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 5 lines · Shaohua Li
According to akpm, this saves 1/2k text and makes things simple of next patch.
Suggested-by Andrew Morton <[email protected]>Signed-off-by Shaohua Li <[email protected]>
FYI,
Feel free to add in changelog if you have evidence. :)
add/remove: 1/0 grow/shrink: 6/22 up/down: 92/-516 (-424)
function old new deltapage_mapping - 48 +48do_task_stat 2292 2308 +16
page_remove_rmap 240 248 +8 load_elf_binary 4500 4508 +8 update_queue 532 536 +4 scsi_probe_and_add_lun 2892 2896 +4 lookup_fast 644 648 +4 vcs_read 1040 1036 -4 __ip_route_output_key 1904 1900 -4 ip_route_input_noref 2508 2500 -8 shmem_file_aio_read 784 772 -12 __isolate_lru_page 272 256 -16 shmem_replace_page 708 688 -20 mark_buffer_dirty 228 208 -20 __set_page_dirty_buffers 240 220 -20 __remove_mapping 276 256 -20 update_mmu_cache 500 476 -24 set_page_dirty_balance 92 68 -24 set_page_dirty 172 148 -24 page_evictable 88 64 -24 page_cache_pipe_buf_steal 248 224 -24 clear_page_dirty_for_io 340 316 -24 test_set_page_writeback 400 372 -28 test_clear_page_writeback 516 488 -28 invalidate_inode_page 156 128 -28 page_mkclean 432 400 -32 flush_dcache_page 360 328 -32 __set_page_dirty_nobuffers 324 280 -44 shrink_page_list 2412 2356 -56
Signature · 8 lines
Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 4 lines · Minchan Kim
Quoted 3 lines · Shaohua Li
According to akpm, this saves 1/2k text and makes things simple of next patch.
Quoted 8 lines
Quoted 2 lines
Suggested-by Andrew Morton <[email protected]>Signed-off-by Shaohua Li <[email protected]>Acked-by Minchan Kim <[email protected]>FYI,
Feel free to add in changelog if you have evidence. :)
Hi Minchan,
Could you tell me how can you get these test result? Which tool or ...? :)
Quoted 23 lines
add/remove: 1/0 grow/shrink: 6/22 up/down: 92/-516 (-424)
function old new deltapage_mapping- 48 +48do_task_stat2292 2308 +16page_remove_rmap 240 248 +8 load_elf_binary 4500 4508 +8 update_queue 532 536 +4 scsi_probe_and_add_lun 2892 2896 +4 lookup_fast 644 648 +4 vcs_read 1040 1036 -4 __ip_route_output_key 1904 1900 -4 ip_route_input_noref 2508 2500 -8 shmem_file_aio_read 784 772 -12 __isolate_lru_page 272 256 -16 shmem_replace_page 708 688 -20 mark_buffer_dirty 228 208 -20 __set_page_dirty_buffers 240 220 -20 __remove_mapping 276 256 -20 update_mmu_cache 500 476 -24 set_page_dirty_balance 92 68 -24 set_page_dirty 172 148 -24 page_evictable 88 64 -24 page_cache_pipe_buf_steal 248 224 -24
Quoted 9 lines
clear_page_dirty_for_io 340 316 -24 test_set_page_writeback 400 372 -28 test_clear_page_writeback 516 488 -28 invalidate_inode_page 156 128 -28 page_mkclean 432 400 -32 flush_dcache_page 360 328 -32 __set_page_dirty_nobuffers 324 280 -44 shrink_page_list 2412 2356 -56
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 7 lines · Simon Jeons
Quoted 6 lines · Minchan Kim
Quoted 5 lines · Shaohua Li
According to akpm, this saves 1/2k text and makes things simple of next patch.
Suggested-by Andrew Morton <[email protected]>Signed-off-by Shaohua Li <[email protected]>
Quoted 8 lines
Quoted 6 lines
Acked-by Minchan Kim <[email protected]>FYI,
Feel free to add in changelog if you have evidence. :)
Hi Minchan,
Hello again,
Quoted 3 lines
Could you tell me how can you get these test result? Which tool or ...? :)
./script/bloat-o-meter :)
Quoted 40 lines
Quoted 24 lines
add/remove: 1/0 grow/shrink: 6/22 up/down: 92/-516 (-424)
function old new deltapage_mapping- 48 +48do_task_stat2292 2308 +16page_remove_rmap 240 248 +8 load_elf_binary 4500 4508 +8 update_queue 532 536 +4 scsi_probe_and_add_lun 2892 2896 +4 lookup_fast 644 648 +4 vcs_read 1040 1036 -4 __ip_route_output_key 1904 1900 -4 ip_route_input_noref 2508 2500 -8 shmem_file_aio_read 784 772 -12 __isolate_lru_page 272 256 -16 shmem_replace_page 708 688 -20 mark_buffer_dirty 228 208 -20 __set_page_dirty_buffers 240 220 -20 __remove_mapping 276 256 -20 update_mmu_cache 500 476 -24 set_page_dirty_balance 92 68 -24 set_page_dirty 172 148 -24 page_evictable 88 64 -24 page_cache_pipe_buf_steal 248 224 -24Quoted 9 lines
clear_page_dirty_for_io 340 316 -24 test_set_page_writeback 400 372 -28 test_clear_page_writeback 516 488 -28 invalidate_inode_page 156 128 -28 page_mkclean 432 400 -32 flush_dcache_page 360 328 -32 __set_page_dirty_nobuffers 324 280 -44 shrink_page_list 2412 2356 -56--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Signature · 8 lines
Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 17 lines · Minchan Kim
Quoted 7 lines · Simon Jeons
Quoted 6 lines · Minchan Kim
Quoted 5 lines · Shaohua Li
According to akpm, this saves 1/2k text and makes things simple of next patch.
Suggested-by Andrew Morton <[email protected]>Signed-off-by Shaohua Li <[email protected]>Quoted 8 lines
Quoted 6 lines
Acked-by Minchan Kim <[email protected]>FYI,
Feel free to add in changelog if you have evidence. :)
Hi Minchan,
Quoted 7 lines
Hello again,
Quoted 3 lines
Could you tell me how can you get these test result? Which tool or ...? :)
./script/bloat-o-meter :)
Got it, thanks. But why don't inline can save text here?
Quoted 36 lines
Quoted 36 lines
Quoted 34 lines
add/remove: 1/0 grow/shrink: 6/22 up/down: 92/-516 (-424)
function old new deltapage_mapping- 48 +48do_task_stat2292 2308 +16page_remove_rmap 240 248 +8 load_elf_binary 4500 4508 +8 update_queue 532 536 +4 scsi_probe_and_add_lun 2892 2896 +4 lookup_fast 644 648 +4 vcs_read 1040 1036 -4 __ip_route_output_key 1904 1900 -4 ip_route_input_noref 2508 2500 -8 shmem_file_aio_read 784 772 -12 __isolate_lru_page 272 256 -16 shmem_replace_page 708 688 -20 mark_buffer_dirty 228 208 -20 __set_page_dirty_buffers 240 220 -20 __remove_mapping 276 256 -20 update_mmu_cache 500 476 -24 set_page_dirty_balance 92 68 -24 set_page_dirty 172 148 -24 page_evictable 88 64 -24 page_cache_pipe_buf_steal 248 224 -24 clear_page_dirty_for_io 340 316 -24 test_set_page_writeback 400 372 -28 test_clear_page_writeback 516 488 -28 invalidate_inode_page 156 128 -28 page_mkclean 432 400 -32 flush_dcache_page 360 328 -32 __set_page_dirty_nobuffers 324 280 -44 shrink_page_list 2412 2356 -56
Quoted 6 lines
Quoted 5 lines
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>