ARM: bootm: allow skipping fdt memory node fixup

PATCH New Rob Herring 4 participants 12 messages Jan 25, 2013 – Feb 20, 2013 Arm (32-bit)

lore

Share & tools

lore

Rob Herring

author

2013-01-25 03:39 UTC #0 lore raw

PATCH 1/2 ARM: bootm: allow skipping fdt memory node fixup

From: Rob Herring <[email protected]>

Currently, u-boot will always fixup the DT memory node on ARM. If the dtb has correct memory information, then we don't want or need u-boot to touch the memory node. Allow platforms to skip this by not filling in dram bank information.

Signed-off-by Rob Herring <[email protected]>

---
 arch/arm/lib/board.c |    2 ++
 arch/arm/lib/bootm.c |    4 ++++
 2 files changed, 6 insertions(+)

arch/arm/lib/board.c +2 -0

index cfe32cc..235f953 100644
@@ -212,8 +212,10 @@ int print_cpuinfo(void);
 
 void __dram_init_banksize(void)
 {
+#if CONFIG_NR_DRAM_BANKS
 	gd->bd->bi_dram[0].start = CONFIG_SYS_SDRAM_BASE;
 	gd->bd->bi_dram[0].size =  gd->ram_size;
+#endif
 }
 void dram_init_banksize(void)
 	__attribute__((weak, alias("__dram_init_banksize")));

arch/arm/lib/bootm.c +4 -0

index 1bd2730..1f54217 100644
@@ -79,6 +79,7 @@ void arch_lmb_reserve(struct lmb *lmb)
 #ifdef CONFIG_OF_LIBFDT
 static int fixup_memory_node(void *blob)
 {
+#if CONFIG_NR_DRAM_BANKS
 	bd_t	*bd = gd->bd;
 	int bank;
 	u64 start[CONFIG_NR_DRAM_BANKS];

@@ -90,6 +91,9 @@ static int fixup_memory_node(void *blob)
 	}
 
 	return fdt_fixup_memory_banks(blob, start, size, CONFIG_NR_DRAM_BANKS);
+#else
+	return 0;
+#endif
 }
 #endif

Signature · 1 line

1.7.10.4

Rob Herring

author

2013-01-25 03:39 UTC #1 lore raw

PATCH 2/2 ARM: highbank: remove DRAM bank setup

From: Rob Herring <[email protected]>

The memory sizes in highbank dtb's are already correct, so remove the DRAM bank setup so the memory node is not fixed up by u-boot.

Signed-off-by Rob Herring <[email protected]>

---
 board/highbank/highbank.c  |    6 ------
 include/configs/highbank.h |    2 +-
 2 files changed, 1 insertion(+), 7 deletions(-)

board/highbank/highbank.c +0 -6

index f41bf05..647bd56 100644
@@ -79,12 +79,6 @@ int dram_init(void)
 	return 0;
 }
 
-void dram_init_banksize(void)
-{
-	gd->bd->bi_dram[0].start = CONFIG_SYS_SDRAM_BASE;
-	gd->bd->bi_dram[0].size =  PHYS_SDRAM_1_SIZE;
-}
-
 void reset_cpu(ulong addr)
 {
 	writel(HB_PWR_HARD_RESET, HB_SREG_A9_PWR_REQ);

include/configs/highbank.h +1 -1

index 62cc08c..a0fe2c3 100644
@@ -97,7 +97,7 @@
 /*-----------------------------------------------------------------------
  * Physical Memory Map
  */
-#define CONFIG_NR_DRAM_BANKS		1
+#define CONFIG_NR_DRAM_BANKS		0
 #define PHYS_SDRAM_1_SIZE		(4089 << 20)
 #define CONFIG_SYS_MEMTEST_START	0x100000
 #define CONFIG_SYS_MEMTEST_END		(PHYS_SDRAM_1_SIZE - 0x100000)

Signature · 1 line

1.7.10.4

Wolfgang Denk

2013-02-19 19:27 UTC #2 lore raw

PATCH 2/2 ARM: highbank: remove DRAM bank setup

Dear Rob Herring,

Quoted 3 lines · In message <[email protected]> you wrote:

The memory sizes in highbank dtb's are already correct, so remove the DRAM bank setup so the memory node is not fixed up by u-boot.

I think you do more here...

Quoted 5 lines

board/highbank/highbank.c +0 -5

-void dram_init_banksize(void)
-{
-	gd->bd->bi_dram[0].start = CONFIG_SYS_SDRAM_BASE;
-	gd->bd->bi_dram[0].size =  PHYS_SDRAM_1_SIZE;
-}

...

include/configs/highbank.h line 100

Quoted 2 lines

include/configs/highbank.h +1 -1

-#define CONFIG_NR_DRAM_BANKS		1
+#define CONFIG_NR_DRAM_BANKS		0

I think this is a very bad idea, as you will now be no longer possible to get information about memory sizes from U-Boot. For exmaple, "bdinfo" will not print any reasonable value any more.

Please don't do that!

Best regards,

Wolfgang Denk

Signature · 5 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Ever try. Ever fail. No matter. Try again. Fail again.  Fail  better.
                                                        -- S. Beckett

Tom Rini

2013-02-19 16:35 UTC #3 lore raw

PATCH 1/2 ARM: bootm: allow skipping fdt memory node fixup

In reply to Rob Herring

Quoted 8 lines · Rob Herring

From: Rob Herring <[email protected]>
Currently, u-boot will always fixup the DT memory node on ARM. If the dtb has correct memory information, then we don't want or need u-boot to touch the memory node. Allow platforms to skip this by not filling in dram bank information.
Signed-off-by Rob Herring <[email protected]>

OK. With the notion that it's best to not fiddle with already correct things, we should have a way "out" there. But this patch means that bd->bi_dram is never set which looks to have some bad side-effects for cache (see arch/arm/lib/cache-cp15.c) so can we come up with some other way out here? Thanks!

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130219/0809c041/attachment.pgp>

Wolfgang Denk

2013-02-19 19:26 UTC #4 lore raw

PATCH 1/2 ARM: bootm: allow skipping fdt memory node fixup

In reply to Rob Herring

Dear Rob Herring,

Quoted 5 lines · In message <[email protected]> you wrote:

Currently, u-boot will always fixup the DT memory node on ARM. If the dtb has correct memory information, then we don't want or need u-boot to touch the memory node. Allow platforms to skip this by not filling in dram bank information.

Well, if this is what you want, then please implement just this, and do not do much more.

arch/arm/lib/board.c int print_cpuinfo(void); · line 219

Quoted 7 lines

void __dram_init_banksize(void)
{

arch/arm/lib/board.c +2 -0

+#if CONFIG_NR_DRAM_BANKS
 	gd->bd->bi_dram[0].start = CONFIG_SYS_SDRAM_BASE;
 	gd->bd->bi_dram[0].size =  gd->ram_size;
+#endif
 }

This change will leave the memory information in struct bd_info uninitialized, so the "bdinfo" command will print just bogus data.

This is not a good idea.

Quoted 11 lines

arch/arm/lib/bootm.c +1 -0

@@ -79,6 +79,7 @@ void arch_lmb_reserve(struct lmb *lmb)
 #ifdef CONFIG_OF_LIBFDT
 static int fixup_memory_node(void *blob)
 {
+#if CONFIG_NR_DRAM_BANKS
 	bd_t	*bd = gd->bd;
 	int bank;
 	u64 start[CONFIG_NR_DRAM_BANKS];

arch/arm/lib/bootm.c static int fixup_memory_node(void *blob) · line 96

Quoted 6 lines

arch/arm/lib/bootm.c +3 -0

@@ -90,6 +91,9 @@ static int fixup_memory_node(void *blob)
 	}
 
 	return fdt_fixup_memory_banks(blob, start, size, CONFIG_NR_DRAM_BANKS);
+#else
+	return 0;
+#endif

I dislike this. If you want to make a property of your device tree "immutable", then you should mark it there as such. Instead of removing the code here, U-Boot should then check for such a property and leave the value unchanged.

Actually you are reaching here a point where it seems necessary that U-Boot itself is able to read the DT to configure itself correctly, i. e. the memory size information it holds should then also be extracted from the DT.

Best regards,

Wolfgang Denk

Signature · 4 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The faster I go, the behinder I get.                 -- Lewis Carroll

Rob Herring

author

2013-02-19 20:39 UTC #5 lore raw

PATCH 1/2 ARM: bootm: allow skipping fdt memory node fixup

Quoted 23 lines · Wolfgang Denk

Dear Rob Herring,
Quoted 5 lines · In message <[email protected]> you wrote:
Currently, u-boot will always fixup the DT memory node on ARM. If the dtb has correct memory information, then we don't want or need u-boot to touch the memory node. Allow platforms to skip this by not filling in dram bank information.
Well, if this is what you want, then please implement just this, and do not do much more.
arch/arm/lib/board.c int print_cpuinfo(void); · line 219
Quoted 7 lines
void __dram_init_banksize(void)
{
arch/arm/lib/board.c +2 -0
+#if CONFIG_NR_DRAM_BANKS
 	gd->bd->bi_dram[0].start = CONFIG_SYS_SDRAM_BASE;
 	gd->bd->bi_dram[0].size =  gd->ram_size;
+#endif
 }
This change will leave the memory information in struct bd_info uninitialized, so the "bdinfo" command will print just bogus data.

Quoted 1 line

This is not a good idea.

This hunk can be dropped I think.

Quoted 13 lines

arch/arm/lib/bootm.c +1 -0

@@ -79,6 +79,7 @@ void arch_lmb_reserve(struct lmb *lmb)
 #ifdef CONFIG_OF_LIBFDT
 static int fixup_memory_node(void *blob)
 {
+#if CONFIG_NR_DRAM_BANKS
 	bd_t	*bd = gd->bd;
 	int bank;
 	u64 start[CONFIG_NR_DRAM_BANKS];

@@ -90,6 +91,9 @@ static int fixup_memory_node(void *blob)
 	}

Quoted 9 lines

arch/arm/lib/bootm.c static int fixup_memory_node(void *blob) · line 96
Quoted 4 lines
arch/arm/lib/bootm.c +3 -0
 	return fdt_fixup_memory_banks(blob, start, size, CONFIG_NR_DRAM_BANKS);
+#else
+	return 0;
+#endif
I dislike this. If you want to make a property of your device tree "immutable", then you should mark it there as such. Instead of removing the code here, U-Boot should then check for such a property and leave the value unchanged.

There is no such way defined to flag that and I'm not going to invent one. It's not that the memory node is immutable, but the default should not be "needs fixups". No one puts purposely wrong data in their DT. So therefore all data should be immutable? What happens when we need to fixup immutable data?

What I would really prefer to do is like powerpc where platforms override this if they need the fixup and the default behavior is no fixup. But that would require knowing which platforms do and don't need the fixup. It only going to get harder to change that.

Quoted 4 lines

Actually you are reaching here a point where it seems necessary that U-Boot itself is able to read the DT to configure itself correctly, i. e. the memory size information it holds should then also be extracted from the DT.

I thought about doing this. That's really an orthogonal issue. The problem is you cannot adjust the amount of memory u-boot uses to be different than the amount of RAM in the /memory node. If you adjust the size in u-boot, the adjusted size is passed to the kernel no matter what.

There's issues with LPAE systems having >4GB of RAM as all the size and address values are 32-bit. This could be fixed, but I'm not sure there is much value in u-boot knowing about memory above 4GB as it can't really access all of it and it would be purely informational.

Rob

Quoted 5 lines

Best regards,
Wolfgang Denk

Wolfgang Denk

2013-02-19 23:14 UTC #6 lore raw

PATCH 1/2 ARM: bootm: allow skipping fdt memory node fixup

Dear Rob Herring,

Quoted 11 lines · In message <[email protected]> you wrote:

Quoted 5 lines
I dislike this. If you want to make a property of your device tree "immutable", then you should mark it there as such. Instead of removing the code here, U-Boot should then check for such a property and leave the value unchanged.
There is no such way defined to flag that and I'm not going to invent one. It's not that the memory node is immutable, but the default should not be "needs fixups". No one puts purposely wrong data in their DT. So therefore all data should be immutable? What happens when we need to fixup immutable data?

There is for example the "status" property, which can take the values "okay" or "disabled". This is used in other places for not so unsimilar purposes.

Quoted 4 lines

What I would really prefer to do is like powerpc where platforms override this if they need the fixup and the default behavior is no fixup. But that would require knowing which platforms do and don't need the fixup. It only going to get harder to change that.

Normally we use get_ramsize() to check / verify the amount of available RAM. And on PPC, we nearly always set the ram size in the DT. I don't know why you think the default was no fixup; this is not true. It's the other way round.

Quoted 10 lines

Quoted 4 lines
Actually you are reaching here a point where it seems necessary that U-Boot itself is able to read the DT to configure itself correctly, i. e. the memory size information it holds should then also be extracted from the DT.
I thought about doing this. That's really an orthogonal issue. The problem is you cannot adjust the amount of memory u-boot uses to be different than the amount of RAM in the /memory node. If you adjust the size in u-boot, the adjusted size is passed to the kernel no matter what.

Quoted 4 lines

There's issues with LPAE systems having >4GB of RAM as all the size and address values are 32-bit. This could be fixed, but I'm not sure there is much value in u-boot knowing about memory above 4GB as it can't really access all of it and it would be purely informational.

Well, let's face it - no matter what you do, if the RAM sizes as used in U-Boot and in Linux differ, at least one of these is wrong. This is a bug that should be fixed. What you attempt to do is implementing a method to paper over such bugs. This is not a good thing to do.

Best regards,

Wolfgang Denk

Signature · 4 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I've got a bad feeling about this.

Rob Herring

author

2013-02-20 14:07 UTC #7 lore raw

PATCH 1/2 ARM: bootm: allow skipping fdt memory node fixup

Quoted 4 lines · Wolfgang Denk

Dear Rob Herring,
Quoted 1 line · In message <[email protected]> you wrote:

[snip]

Quoted 9 lines

Quoted 4 lines
What I would really prefer to do is like powerpc where platforms override this if they need the fixup and the default behavior is no fixup. But that would require knowing which platforms do and don't need the fixup. It only going to get harder to change that.
Normally we use get_ramsize() to check / verify the amount of available RAM. And on PPC, we nearly always set the ram size in the DT. I don't know why you think the default was no fixup; this is not true. It's the other way round.

No it is not.

The fixup is in bootm.c for all of arm, yet appears in all the board/soc files for powerpc. It may be nearly always fixed up because every platform duplicates the fixup code, but it is not the default. It is a per platform decision on powerpc and it is not on arm.

$ git grep fixup_memory
arch/arm/lib/bootm.c:static int fixup_memory_node(void *blob)
arch/arm/lib/bootm.c:   return fdt_fixup_memory_banks(blob, start, size, CONFIG_NR_DRAM_BANKS);
arch/arm/lib/bootm.c:   fixup_memory_node(*of_flat_tree);
arch/powerpc/cpu/74xx_7xx/cpu.c:        fdt_fixup_memory(blob, (u64)bd->bi_memstart, (u64)bd->bi_memsize);
arch/powerpc/cpu/mpc512x/cpu.c: fdt_fixup_memory(blob, (u64)bd->bi_memstart, (u64)bd->bi_memsize);
arch/powerpc/cpu/mpc5xxx/cpu.c: fdt_fixup_memory(blob, (u64)bd->bi_memstart, (u64)bd->bi_memsize);
arch/powerpc/cpu/mpc8260/cpu.c: fdt_fixup_memory(blob, (u64)bd->bi_memstart, (u64)bd->bi_memsize);
arch/powerpc/cpu/mpc83xx/fdt.c: fdt_fixup_memory(blob, (u64)bd->bi_memstart, (u64)bd->bi_memsize);
arch/powerpc/cpu/mpc85xx/fdt.c: fdt_fixup_memory(blob, (u64)bd->bi_memstart, (u64)bd->bi_memsize);
arch/powerpc/cpu/mpc86xx/fdt.c: fdt_fixup_memory(blob, (u64)bd->bi_memstart, (u64)bd->bi_memsize);
arch/powerpc/cpu/mpc8xx/fdt.c:  fdt_fixup_memory(blob, (u64)bd->bi_memstart, (u64)bd->bi_memsize);
arch/powerpc/cpu/ppc4xx/fdt.c:  fdt_fixup_memory(blob, (u64)bd->bi_memstart, (u64)bd->bi_memsize);
board/exmeritus/hww1u1a/hww1u1a.c:      fdt_fixup_memory(blob, (u64)base, (u64)size);
board/freescale/bsc9131rdb/bsc9131rdb.c:        fdt_fixup_memory(blob, (u64)base, (u64)size);
board/freescale/corenet_ds/corenet_ds.c:        fdt_fixup_memory(blob, (u64)base, (u64)size);
board/freescale/mpc7448hpc2/mpc7448hpc2.c:      fdt_fixup_memory(blob, (u64)bd->bi_memstart, (u64)bd->bi_memsize);
board/freescale/mpc8572ds/mpc8572ds.c:  fdt_fixup_memory(blob, (u64)base, (u64)size);
board/freescale/p1010rdb/p1010rdb.c:    fdt_fixup_memory(blob, (u64)base, (u64)size);
board/freescale/p1022ds/p1022ds.c:      fdt_fixup_memory(blob, (u64)base, (u64)size);
board/freescale/p1023rds/p1023rds.c:    fdt_fixup_memory(blob, (u64)base, (u64)size);
board/freescale/p1_p2_rdb/p1_p2_rdb.c:  fdt_fixup_memory(blob, (u64)base, (u64)size);
board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c:    fdt_fixup_memory(blob, (u64)base, (u64)size);
board/freescale/p2020come/p2020come.c:  fdt_fixup_memory(blob, (u64)base, (u64)size);
board/freescale/p2020ds/p2020ds.c:      fdt_fixup_memory(blob, (u64)base, (u64)size);
board/freescale/p2041rdb/p2041rdb.c:    fdt_fixup_memory(blob, (u64)base, (u64)size);
board/freescale/t4qds/t4qds.c:  fdt_fixup_memory(blob, (u64)base, (u64)size);
board/ipek01/ipek01.c:  fdt_fixup_memory (blob, (u64) bd->bi_memstart, (u64) bd->bi_memsize);
board/pdm360ng/pdm360ng.c:      fdt_fixup_memory(blob, (u64)bd->bi_memstart, (u64)bd->bi_memsize);
common/cmd_fdt.c:               err = fdt_fixup_memory(working_fdt, addr, size);
common/fdt_support.c:int fdt_fixup_memory_banks(void *blob, u64 start[], u64 size[], int banks)
common/fdt_support.c:int fdt_fixup_memory(void *blob, u64 start, u64 size)
common/fdt_support.c:   return fdt_fixup_memory_banks(blob, &start, &size, 1);
include/fdt_support.h:int fdt_fixup_memory(void *blob, u64 start, u64 size);
include/fdt_support.h:int fdt_fixup_memory_banks(void *blob, u64 start[], u64 size[], int banks);

Quoted 15 lines

Quoted 10 lines
Quoted 4 lines
Actually you are reaching here a point where it seems necessary that U-Boot itself is able to read the DT to configure itself correctly, i. e. the memory size information it holds should then also be extracted from the DT.
I thought about doing this. That's really an orthogonal issue. The problem is you cannot adjust the amount of memory u-boot uses to be different than the amount of RAM in the /memory node. If you adjust the size in u-boot, the adjusted size is passed to the kernel no matter what.
Quoted 4 lines
There's issues with LPAE systems having >4GB of RAM as all the size and address values are 32-bit. This could be fixed, but I'm not sure there is much value in u-boot knowing about memory above 4GB as it can't really access all of it and it would be purely informational.

Quoted 4 lines

Well, let's face it - no matter what you do, if the RAM sizes as used in U-Boot and in Linux differ, at least one of these is wrong. This is a bug that should be fixed. What you attempt to do is implementing a method to paper over such bugs. This is not a good thing to do.

We'll probably just have to disagree that u-boot needs to know about memory it can't access on 32-bit PAE system unless you want to implement paging.

Rob

Wolfgang Denk

2013-02-20 14:11 UTC #8 lore raw

PATCH 1/2 ARM: bootm: allow skipping fdt memory node fixup

In reply to Wolfgang Denk

Dear Rob,

Quoted 10 lines · In message <[email protected]> I wrote:

Quoted 6 lines
There is no such way defined to flag that and I'm not going to invent one. It's not that the memory node is immutable, but the default should not be "needs fixups". No one puts purposely wrong data in their DT. So therefore all data should be immutable? What happens when we need to fixup immutable data?
There is for example the "status" property, which can take the values "okay" or "disabled". This is used in other places for not so unsimilar purposes.

Actually it's even much simpler than that.

If you look for example at PPC, you will see many memory nodes in the DTB that look like this one (this example is from arch/powerpc/boot/dts/canyonlands.dts):

	memory {
		device_type = "memory";
		reg = <0x00000000 0x00000000 0x00000000>; /* Filled in by U-Boot */
	};

I. e. the DT provides only dummy values.

How about checking for these - if the DT contains such dummy entries, U-Boot will insert valid data; if the DT already contains real data, these take preference? [And if the latter differ from what U-Boot thinks is correct, then a big fat warning should be issued!]

Best regards,

Wolfgang Denk

Signature · 4 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
God made the integers; all else is the work of Man.       - Kronecker

Tom Rini

2013-02-20 14:33 UTC #9 lore raw

PATCH 1/2 ARM: bootm: allow skipping fdt memory node fixup

In reply to Rob Herring

Quoted 1 line · Rob Herring

On 02/19/2013 01:26 PM, Wolfgang Denk wrote:

[snip]

Quoted 10 lines

Quoted 4 lines
I dislike this. If you want to make a property of your device tree "immutable", then you should mark it there as such. Instead of removing the code here, U-Boot should then check for such a property and leave the value unchanged.
There is no such way defined to flag that and I'm not going to invent one. It's not that the memory node is immutable, but the default should not be "needs fixups". No one puts purposely wrong data in their DT. So therefore all data should be immutable? What happens when we need to fixup immutable data?

It's not so simple. The first DTs I checked are the am335x ones and I see they hardcode to 256MB which isn't right, but no one has caught this since it's blindly fixed up. So as Wolfgang suggests next, we might need to go with replacing on 0x0 entries and warning when they don't match what U-Boot has detected.

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130220/01c927c5/attachment.pgp>

Peter Korsgaard

2013-02-20 21:55 UTC #10 lore raw

PATCH 1/2 ARM: bootm: allow skipping fdt memory node fixup

Quoted 1 line

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Tom" == Tom Rini <[email protected]> writes:

Hi,

Tom> It's not so simple. The first DTs I checked are the am335x ones Tom> and I see they hardcode to 256MB which isn't right, but no one has Tom> caught this since it's blindly fixed up. So as Wolfgang suggests Tom> next, we might need to go with replacing on 0x0 entries and Tom> warning when they don't match what U-Boot has detected.

It is correct for the (classic) beaglebone. This also hits people using appended dtb unless they have CONFIG_ARM_ATAG_DTB_COMPAT enabled (which the probably do though).

Signature · 1 line

Bye, Peter Korsgaard

Tom Rini

2013-02-20 22:13 UTC #11 lore raw

PATCH 1/2 ARM: bootm: allow skipping fdt memory node fixup

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 11 lines · Peter Korsgaard

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Tom" == Tom Rini <[email protected]> writes:
Hi,
Tom> It's not so simple. The first DTs I checked are the am335x ones Tom> and I see they hardcode to 256MB which isn't right, but no one has Tom> caught this since it's blindly fixed up. So as Wolfgang suggests Tom> next, we might need to go with replacing on 0x0 entries and Tom> warning when they don't match what U-Boot has detected.

Quoted 3 lines

It is correct for the (classic) beaglebone. This also hits people using appended dtb unless they have CONFIG_ARM_ATAG_DTB_COMPAT enabled (which the probably do though).

So yes, there are some cases where 256MB is the right value. But we always know dynamically how much we have, so we don't need to hard-code even in that case. And once we do change the behaviour, the appeneded tree hack shouldn't be relevant anyhow :)

- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRJUqnAAoJENk4IS6UOR1WAmgQALOHeh+p9aRLT+Hb0ZjpJk0c XGJzCO1EpdNpQBsgPxI2AzhPEHsVHgcdzXmzljHS4ukPWDbqihM4j7o9OHjuxAGY +8Yebw/E/1F7+wKXy013/3QFbl9mdd1OpTU95xarnaoe4+dP5pfa+Q/kH5mrc0U2 xiA4kDmInityA/DUuEP4d8mhnLQyn11CKS/LPKdT40HUGDk6ffzkmUCYEHBpwk11 QN7w6icIGE9JrMsQUOPir7CNDZsNCbeAtB8+gpStHxL63cHqxAh9R3yFyUc2uVHo 5NNkc71R0qLIrKMTbDjIfm1soTEWP94ob6VVPQafqSC7wQrK5r+2DNg9I7dN7xIr js5Y/BBbPuUZfMWiNWiyF+ONuoNNrz1+iLm9iLdaJajf5EuBQN/qUzNGKFTCsLne nR6cR0x/Ow+rN1TDmnSvmS845XUDK2qLY5nSthKieuFtoDY88j6VpR4ZO7+B6sSa 9MVx6LV8SO4USewl1FIpXoe6KC2AjdSK2rJN5i2SSQD6uxYzPCfBKezG7gi8Mfua v4M9W/jDU/avXo861XLeKgcZx0zA7PHxDhqgZDVbFs3QH3eobzZHGog001vM6mvr dEdUGxu0dVF9ocbF/2F6XxdMVxt2CK7ddbGCZy5V1R6ZCvOVZetCbQao8GB7ZqLU LMZf4b3iDGdrOfM57n5m
=8tud
-----END PGP SIGNATURE-----