regulator: tps6507x: Fix using wrong dev argument for calling of_regulator_match
PATCH 1/1 regulator: tps6507x: Fix using wrong dev argument for calling of_regulator_match
The dev parameter is the device requesting the data.
In this case it should be &pdev->dev rather than pdev->dev.parent.
The dev parameter is used to call devm_kzalloc in of_get_regulator_init_data(), which means this fixes a memory leak because the memory is allocated every time probe() is called, thus it should be freed when this driver is unloaded.
Signed-off-by Axel Lin <[email protected]>
--- drivers/regulator/tps6507x-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/regulator/tps6507x-regulator.c +1 -1
@@ -394,7 +394,7 @@ static struct tps6507x_board *tps6507x_parse_dt_reg_data( count =ARRAY_SIZE (tps6507x_matches); matches = tps6507x_matches; - ret =of_regulator_match (pdev->dev.parent, regulators, matches, count); + ret =of_regulator_match (&pdev->dev, regulators, matches, count);if (ret <0 ) {dev_err (&pdev->dev,"Error parsing regulator init data: %d\n" , ret);
Signature · 1 line
1.7.9.5
Mark Brown
AppliedQuoted 2 lines · Axel Lin
The dev parameter is the device requesting the data.
In this case it should be&pdev->devrather thanpdev->dev.parent.
Applied, thanks.