Skip to contentSkip to conversation

sched: debug: Promote atomic64_read to u64 for printing

PATCH New Fabio Estevam 1 participant 1 message Jan 27, 2013 Scheduler

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sched: debug: Promote atomic64_read to u64 for printing

From: Fabio Estevam <[email protected]>

commit 2d58000fd (sched: Fix print format for u64) introduced the following build warning for x86_64:

kernel/sched/debug.c: In function 'print_cfs_rq':
kernel/sched/debug.c:225:2: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 4 has type 'long int' [-Wformat] kernel/sched/debug.c:225:2: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 3 has type 'long int' [-Wformat]

atomi64_read() function may have a different returning type depending on the architecture, so in order to guarantee that it builds fine on any system without warnings, promote it to u64 for printing purpose.

---
 kernel/sched/debug.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sched/debug.c +1 -1
index b46faf5..2aacabe 100644
@@ -216,7 +216,7 @@ void print_cfs_rq(struct seq_file *m, int cpu, struct cfs_rq *cfs_rq)
 	SEQ_printf(m, "  .%-30s: %lld\n", "blocked_load_avg",
 			cfs_rq->blocked_load_avg);
 	SEQ_printf(m, "  .%-30s: %llu\n", "tg_load_avg",
-			atomic64_read(&cfs_rq->tg->load_avg));
+			(u64)atomic64_read(&cfs_rq->tg->load_avg));
 	SEQ_printf(m, "  .%-30s: %lld\n", "tg_load_contrib",
 			cfs_rq->tg_load_contrib);
 	SEQ_printf(m, "  .%-30s: %d\n", "tg_runnable_contrib",
Signature · 1 line
1.7.9.5