Skip to contentSkip to conversation

drm: Provide helpers for system framebuffers and add efidrm/vesadrm

PATCH Superseded Thomas Zimmermann 5 participants 47 messages Mar 19, 2025 – Apr 2, 2025

Subsystems (4)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Thomas Zimmermann

author maintainer
#0 lore raw

cover drm: Provide helpers for system framebuffers and add efidrm/vesadrm

This series simplifies the existing ofdrm and simepldrm drivers, and adds new drivers for EFI- and VESA-based framebuffers. Existing drivers for system framebuffers, ofdrm and simpledrm, share much of their mode-setting pipeline. The major difference between the two drivers is in how they retrieve the framebuffer from the systems. Hence, it makes sense to share some of the pipeline implementation. With the shared helpers in place, we can then add dedicated drivers for EFI and VESA easily.

Patches 1 to 3 clean up obsolete artifacts from ofdrm and simpledrm.

Patch 4 moves both drivers from tiny/ into their own subdirectory sysfb/. The name aligns with the naming in drivers/firmware/sysfb.c to signal the connection. It's the firmware code that creates most of the system-framebuffer devices that these drivers operate on. The patch also adds a separate menu in Kconfig.

Patches 5 to 11 unify the mode-setting pipeline between ofdrm and simpledrm. Either both drivers already use the same implementation or they can easily do so. There've been previous attempts to unify some of the drivers' code, but with little success. This time the helpers will be shared among 4 drivers, so it's already much more successful than before.

Patch 12 adds EDID support to ofdrm. The EDID data can be found in some Macintosh's DeviceTree next to the framebuffer configuration. EDID support will be useful for EFI and VESA as well.

Patch 13 adds another helper for screen_info that will be required by EFI and VESA drivers.

Patch 14 and 15 add efidrm, a DRM driver that operates on EFI-provided framebuffers. It uses the shared sysfb helpers. The immediate benefit over simpledrm is the support for EFI's various types of memory caching on the framebuffer. Simpledrm only supported WriteCombine caching. There's also EDID support if the kernel's edid_info has been initialized. This feature needs to be implemented in the kernel's efistub library.

Patches 16 to 18 add vesadrm, a DRM driver that operates in VESA- provided framebuffers. It is very much like efidrm, but tailored towards VESA features. It has EDID support and there's a patch at [1] for grub to provide the data as part of the kernel's boot parameters. Vesadrm also supports gamma ramps. Together with EDID, this allows for gamma correction and night mode. Gnome already does that.

Future directions: Efidrm requires EDID data that has to be provided by the efistub library. There is an EFI call to do so. Vesadrm currently requires a discrete color mode. Support for palette modes can be added later. There's still a bit of code duplication among palette handling. We have more drivers that use similar code for palette LUTs, such as ast and mgag200. We should try to provide generic palette helpers for all these drivers.

This series has been tested on various devices that require the provided drivers.

[1] https://build.opensuse.org/projects/home:tdz:branches:Base:System/packages/grub2/files/grub2-provide-edid.patch?expand=1

Thomas Zimmermann (18):
drm/ofdrm: Remove struct ofdrm_device.pdev
drm/ofdrm: Open-code drm_simple_encoder_init() drm/simpledrm: Remove struct simpledrm_device.nformats
drm: Move sysfb drivers into separate subdirectory drm/sysfb: Add struct drm_sysfb_device
drm/sysfb: Provide single mode-init helper
drm/sysfb: Merge mode-config functions
drm/sysfb: Merge connector functions
drm/sysfb: Maintain CRTC state in struct drm_sysfb_crtc_state drm/sysfb: Merge CRTC functions
drm/sysfb: Merge primary-plane functions
drm/sysfb: ofdrm: Add EDID support
firmware: sysfb: Move bpp-depth calculation into screen_info helper drm/sysfb: Add efidrm for EFI displays
drm/sysfb: efidrm: Add EDID support
drm/sysfb: Add vesadrm for VESA displays
drm/sysfb: vesadrm: Add EDID support
drm/sysfb: vesadrm: Add gamma correction

 MAINTAINERS                                 |   3 +-
 drivers/firmware/sysfb_simplefb.c           |  31 +-
 drivers/gpu/drm/Kconfig                     |   2 +
 drivers/gpu/drm/Makefile                    |   1 +
 drivers/gpu/drm/sysfb/Kconfig               |  76 +++
 drivers/gpu/drm/sysfb/Makefile              |   8 +
 drivers/gpu/drm/sysfb/drm_sysfb_helper.c    | 319 ++++++++++
 drivers/gpu/drm/sysfb/drm_sysfb_helper.h    | 136 ++++
 drivers/gpu/drm/sysfb/efidrm.c              | 495 +++++++++++++++
 drivers/gpu/drm/{tiny => sysfb}/ofdrm.c     | 364 ++---------
 drivers/gpu/drm/{tiny => sysfb}/simpledrm.c | 237 +------
 drivers/gpu/drm/sysfb/vesadrm.c             | 660 ++++++++++++++++++++
 drivers/gpu/drm/tiny/Kconfig                |  32 -
 drivers/gpu/drm/tiny/Makefile               |   2 -
 drivers/video/screen_info_generic.c         |  36 ++
 include/linux/screen_info.h                 |   9 +
 include/video/pixel_format.h                |  41 ++
 17 files changed, 1885 insertions(+), 567 deletions(-)
 create mode 100644 drivers/gpu/drm/sysfb/Kconfig
 create mode 100644 drivers/gpu/drm/sysfb/Makefile
 create mode 100644 drivers/gpu/drm/sysfb/drm_sysfb_helper.c
 create mode 100644 drivers/gpu/drm/sysfb/drm_sysfb_helper.h
 create mode 100644 drivers/gpu/drm/sysfb/efidrm.c
 rename drivers/gpu/drm/{tiny => sysfb}/ofdrm.c (75%)
 rename drivers/gpu/drm/{tiny => sysfb}/simpledrm.c (76%)
 create mode 100644 drivers/gpu/drm/sysfb/vesadrm.c
 create mode 100644 include/video/pixel_format.h
Signature · 1 line
2.48.1
author maintainer
#1 lore raw

PATCH 1/18 drm/ofdrm: Remove struct ofdrm_device.pdev

The field pdev is unused. Remove it.

---
 drivers/gpu/drm/tiny/ofdrm.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/tiny/ofdrm.c +0 -1
index 13491c0e704a..7469dd281083 100644
@@ -291,7 +291,6 @@ struct ofdrm_device_funcs {
 
 struct ofdrm_device {
 	struct drm_device dev;
-	struct platform_device *pdev;
 
 	const struct ofdrm_device_funcs *funcs;
 
Signature · 1 line
2.48.1
maintainer Reviewed-by on v1 1/18
#2 lore raw

Re: [PATCH 01/18] drm/ofdrm: Remove struct ofdrm_device.pdev

Quoted 22 lines · Thomas Zimmermann

The field pdev is unused. Remove it.

---
 drivers/gpu/drm/tiny/ofdrm.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/tiny/ofdrm.c +0 -1
index 13491c0e704a..7469dd281083 100644
@@ -291,7 +291,6 @@ struct ofdrm_device_funcs {
 
 struct ofdrm_device {
 	struct drm_device dev;
-	struct platform_device *pdev;
 
 	const struct ofdrm_device_funcs *funcs;
 
Signature · 1 line
2.48.1
Signature · 5 lines
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat
author maintainer
#3 lore raw

PATCH 2/18 drm/ofdrm: Open-code drm_simple_encoder_init()

In reply to Thomas Zimmermann

The helper drm_simple_encoder_init() is a trivial helper around drm_encoder_init() and therefore deprecated. Open-code the function and remove the dependency.

---
 drivers/gpu/drm/tiny/ofdrm.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/gpu/drm/tiny/ofdrm.c +5 -2
index 7469dd281083..7d5beaf6a42c 100644
@@ -21,7 +21,6 @@
 #include <drm/drm_managed.h>
 #include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
-#include <drm/drm_simple_kms_helper.h>
 
 #define DRIVER_NAME	"ofdrm"
 #define DRIVER_DESC	"DRM driver for OF platform devices"
@@ -999,6 +998,10 @@ static const struct drm_crtc_funcs ofdrm_crtc_funcs = {
 	.atomic_destroy_state = ofdrm_crtc_atomic_destroy_state,
 };
 
+static const struct drm_encoder_funcs ofdrm_encoder_funcs = {
+	.destroy = drm_encoder_cleanup,
+};
+
 static int ofdrm_connector_helper_get_modes(struct drm_connector *connector)
 {
 	struct ofdrm_device *odev = ofdrm_device_of_dev(connector->dev);
@@ -1309,7 +1312,7 @@ static struct ofdrm_device *ofdrm_device_create(struct drm_driver *drv,
 	/* Encoder */
 
 	encoder = &odev->encoder;
-	ret = drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_NONE);
+	ret = drm_encoder_init(dev, encoder, &ofdrm_encoder_funcs, DRM_MODE_ENCODER_NONE, NULL);
 	if (ret)
 		return ERR_PTR(ret);
 	encoder->possible_crtcs = drm_crtc_mask(crtc);
Signature · 1 line
2.48.1
maintainer Reviewed-by on v1 2/18
#4 lore raw

Re: [PATCH 02/18] drm/ofdrm: Open-code drm_simple_encoder_init()

Quoted 6 lines · Thomas Zimmermann

The helper drm_simple_encoder_init() is a trivial helper around drm_encoder_init() and therefore deprecated. Open-code the function and remove the dependency.

---

Signature · 5 lines
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat
author maintainer
#5 lore raw

PATCH 3/18 drm/simpledrm: Remove struct simpledrm_device.nformats

In reply to Thomas Zimmermann

The field nformats is unused. Remove it.

---
 drivers/gpu/drm/tiny/simpledrm.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/tiny/simpledrm.c +0 -1
index 5d9ab8adf800..d949713f5ff6 100644
@@ -246,7 +246,6 @@ struct simpledrm_device {
 
 	/* modesetting */
 	uint32_t formats[8];
-	size_t nformats;
 	struct drm_plane primary_plane;
 	struct drm_crtc crtc;
 	struct drm_encoder encoder;
Signature · 1 line
2.48.1
maintainer Reviewed-by on v1 3/18
#6 lore raw

Re: [PATCH 03/18] drm/simpledrm: Remove struct simpledrm_device.nformats

Quoted 22 lines · Thomas Zimmermann

The field nformats is unused. Remove it.

---
 drivers/gpu/drm/tiny/simpledrm.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/tiny/simpledrm.c +0 -1
index 5d9ab8adf800..d949713f5ff6 100644
@@ -246,7 +246,6 @@ struct simpledrm_device {
 
 	/* modesetting */
 	uint32_t formats[8];
-	size_t nformats;
 	struct drm_plane primary_plane;
 	struct drm_crtc crtc;
 	struct drm_encoder encoder;
Signature · 1 line
2.48.1
Signature · 5 lines
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat
author maintainer
#7 lore raw

PATCH 4/18 drm: Move sysfb drivers into separate subdirectory

In reply to Thomas Zimmermann

The ofdrm and simpledrm drivers are special as they operate on externally provided framebuffers. Move them into their own sub- directory. Will let them share common code.

---
 MAINTAINERS                                 |  3 +-
 drivers/gpu/drm/Kconfig                     |  2 ++
 drivers/gpu/drm/Makefile                    |  1 +
 drivers/gpu/drm/sysfb/Kconfig               | 38 +++++++++++++++++++++
 drivers/gpu/drm/sysfb/Makefile              |  4 +++
 drivers/gpu/drm/{tiny => sysfb}/ofdrm.c     |  0
 drivers/gpu/drm/{tiny => sysfb}/simpledrm.c |  0
 drivers/gpu/drm/tiny/Kconfig                | 32 -----------------
 drivers/gpu/drm/tiny/Makefile               |  2 --
 9 files changed, 46 insertions(+), 36 deletions(-)
 create mode 100644 drivers/gpu/drm/sysfb/Kconfig
 create mode 100644 drivers/gpu/drm/sysfb/Makefile
 rename drivers/gpu/drm/{tiny => sysfb}/ofdrm.c (100%)
 rename drivers/gpu/drm/{tiny => sysfb}/simpledrm.c (100%)
MAINTAINERS +1 -2
index 9df9b25fffc3..588cea0e8630 100644
@@ -7247,8 +7247,7 @@ M:	Javier Martinez Canillas <[email protected]>
 L:	[email protected]
 S:	Maintained
 T:	git https://gitlab.freedesktop.org/drm/misc/kernel.git
-F:	drivers/gpu/drm/tiny/ofdrm.c
-F:	drivers/gpu/drm/tiny/simpledrm.c
+F:	drivers/gpu/drm/sysfb/
 F:	drivers/video/aperture.c
 F:	drivers/video/nomodeset.c
 F:	include/linux/aperture.h
drivers/gpu/drm/Kconfig +2 -0
index 1be14d8634f4..200bfbb9f093 100644
@@ -335,6 +335,8 @@ config DRM_SCHED
 	tristate
 	depends on DRM
 
+source "drivers/gpu/drm/sysfb/Kconfig"
+
 source "drivers/gpu/drm/arm/Kconfig"
 
 source "drivers/gpu/drm/radeon/Kconfig"
drivers/gpu/drm/Makefile +1 -0
index ed54a546bbe2..bf5cb7936a1d 100644
@@ -204,6 +204,7 @@ obj-$(CONFIG_DRM_FSL_DCU) += fsl-dcu/
 obj-$(CONFIG_DRM_ETNAVIV) += etnaviv/
 obj-y			+= hisilicon/
 obj-y			+= mxsfb/
+obj-y			+= sysfb/
 obj-y			+= tiny/
 obj-$(CONFIG_DRM_PL111) += pl111/
 obj-$(CONFIG_DRM_TVE200) += tve200/
drivers/gpu/drm/sysfb/Kconfig new file +38 -0
new file mode 100644
index 000000000000..9eafc06b7192
@@ -0,0 +1,38 @@
+# SPDX-License-Identifier: GPL-2.0-only
+
+menu "Drivers for system framebuffers"
+	depends on DRM
+
+config DRM_OFDRM
+	tristate "Open Firmware display driver"
+	depends on DRM && MMU && OF && (PPC || COMPILE_TEST)
+	select APERTURE_HELPERS
+	select DRM_CLIENT_SELECTION
+	select DRM_GEM_SHMEM_HELPER
+	select DRM_KMS_HELPER
+	help
+	  DRM driver for Open Firmware framebuffers.
+
+	  This driver assumes that the display hardware has been initialized
+	  by the Open Firmware before the kernel boots. Scanout buffer, size,
+	  and display format must be provided via device tree.
+
+config DRM_SIMPLEDRM
+	tristate "Simple framebuffer driver"
+	depends on DRM && MMU
+	select APERTURE_HELPERS
+	select DRM_CLIENT_SELECTION
+	select DRM_GEM_SHMEM_HELPER
+	select DRM_KMS_HELPER
+	help
+	  DRM driver for simple platform-provided framebuffers.
+
+	  This driver assumes that the display hardware has been initialized
+	  by the firmware or bootloader before the kernel boots. Scanout
+	  buffer, size, and display format must be provided via device tree,
+	  UEFI, VESA, etc.
+
+	  On x86 BIOS or UEFI systems, you should also select SYSFB_SIMPLEFB
+	  to use UEFI and VESA framebuffers.
+
+endmenu
drivers/gpu/drm/sysfb/Makefile new file +4 -0
new file mode 100644
index 000000000000..f6c03629accb
@@ -0,0 +1,4 @@
+# SPDX-License-Identifier: GPL-2.0-only
+
+obj-$(CONFIG_DRM_OFDRM)		+= ofdrm.o
+obj-$(CONFIG_DRM_SIMPLEDRM)	+= simpledrm.o
drivers/gpu/drm/sysfb/ofdrm.c renamed from drivers/gpu/drm/tiny/ofdrm.c +0 -0
similarity index 100%
rename from drivers/gpu/drm/tiny/ofdrm.c
rename to drivers/gpu/drm/sysfb/ofdrm.c
drivers/gpu/drm/sysfb/simpledrm.c renamed from drivers/gpu/drm/tiny/simpledrm.c +0 -0
similarity index 100%
rename from drivers/gpu/drm/tiny/simpledrm.c
rename to drivers/gpu/drm/sysfb/simpledrm.c
drivers/gpu/drm/tiny/Kconfig +0 -32
index 54c84c9801c1..95c1457d7730 100644
@@ -65,20 +65,6 @@ config DRM_GM12U320
 	 This is a KMS driver for projectors which use the GM12U320 chipset
 	 for video transfer over USB2/3, such as the Acer C120 mini projector.
 
-config DRM_OFDRM
-	tristate "Open Firmware display driver"
-	depends on DRM && MMU && OF && (PPC || COMPILE_TEST)
-	select APERTURE_HELPERS
-	select DRM_CLIENT_SELECTION
-	select DRM_GEM_SHMEM_HELPER
-	select DRM_KMS_HELPER
-	help
-	  DRM driver for Open Firmware framebuffers.
-
-	  This driver assumes that the display hardware has been initialized
-	  by the Open Firmware before the kernel boots. Scanout buffer, size,
-	  and display format must be provided via device tree.
-
 config DRM_PANEL_MIPI_DBI
 	tristate "DRM support for MIPI DBI compatible panels"
 	depends on DRM && SPI
@@ -95,24 +81,6 @@ config DRM_PANEL_MIPI_DBI
 	  https://github.com/notro/panel-mipi-dbi/wiki.
 	  To compile this driver as a module, choose M here.
 
-config DRM_SIMPLEDRM
-	tristate "Simple framebuffer driver"
-	depends on DRM && MMU
-	select APERTURE_HELPERS
-	select DRM_CLIENT_SELECTION
-	select DRM_GEM_SHMEM_HELPER
-	select DRM_KMS_HELPER
-	help
-	  DRM driver for simple platform-provided framebuffers.
-
-	  This driver assumes that the display hardware has been initialized
-	  by the firmware or bootloader before the kernel boots. Scanout
-	  buffer, size, and display format must be provided via device tree,
-	  UEFI, VESA, etc.
-
-	  On x86 BIOS or UEFI systems, you should also select SYSFB_SIMPLEFB
-	  to use UEFI and VESA framebuffers.
-
 config TINYDRM_HX8357D
 	tristate "DRM support for HX8357D display panels"
 	depends on DRM && SPI
drivers/gpu/drm/tiny/Makefile +0 -2
index 0a3a7837a58b..ba4a60bb72bd 100644
@@ -5,9 +5,7 @@ obj-$(CONFIG_DRM_ARCPGU)		+= arcpgu.o
 obj-$(CONFIG_DRM_BOCHS)			+= bochs.o
 obj-$(CONFIG_DRM_CIRRUS_QEMU)		+= cirrus-qemu.o
 obj-$(CONFIG_DRM_GM12U320)		+= gm12u320.o
-obj-$(CONFIG_DRM_OFDRM)			+= ofdrm.o
 obj-$(CONFIG_DRM_PANEL_MIPI_DBI)	+= panel-mipi-dbi.o
-obj-$(CONFIG_DRM_SIMPLEDRM)		+= simpledrm.o
 obj-$(CONFIG_TINYDRM_HX8357D)		+= hx8357d.o
 obj-$(CONFIG_TINYDRM_ILI9163)		+= ili9163.o
 obj-$(CONFIG_TINYDRM_ILI9225)		+= ili9225.o
Signature · 1 line
2.48.1
maintainer Reviewed-by on v1 4/18
#8 lore raw

Re: [PATCH 04/18] drm: Move sysfb drivers into separate subdirectory

Quoted 6 lines · Thomas Zimmermann

The ofdrm and simpledrm drivers are special as they operate on externally provided framebuffers. Move them into their own sub- directory. Will let them share common code.

---

Signature · 5 lines
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat
author maintainer
#9 lore raw

PATCH 5/18 drm/sysfb: Add struct drm_sysfb_device

In reply to Thomas Zimmermann

Add struct drm_sysfb_device that stores the system display's hardware settings. Further helpers for the mode-setting pipeline will use these fields. Convert ofdrm and simpledrm by embedding the sysfb device in their device structs.

---
 drivers/gpu/drm/sysfb/Kconfig            |  6 ++
 drivers/gpu/drm/sysfb/Makefile           |  2 +
 drivers/gpu/drm/sysfb/drm_sysfb_helper.c |  8 +++
 drivers/gpu/drm/sysfb/drm_sysfb_helper.h | 35 +++++++++
 drivers/gpu/drm/sysfb/ofdrm.c            | 78 ++++++++++----------
 drivers/gpu/drm/sysfb/simpledrm.c        | 90 ++++++++++++------------
 6 files changed, 135 insertions(+), 84 deletions(-)
 create mode 100644 drivers/gpu/drm/sysfb/drm_sysfb_helper.c
 create mode 100644 drivers/gpu/drm/sysfb/drm_sysfb_helper.h
drivers/gpu/drm/sysfb/Kconfig +6 -0
index 9eafc06b7192..87094da417f6 100644
@@ -3,6 +3,10 @@
 menu "Drivers for system framebuffers"
 	depends on DRM
 
+config DRM_SYSFB_HELPER
+	tristate
+	depends on DRM
+
 config DRM_OFDRM
 	tristate "Open Firmware display driver"
 	depends on DRM && MMU && OF && (PPC || COMPILE_TEST)
@@ -10,6 +14,7 @@ config DRM_OFDRM
 	select DRM_CLIENT_SELECTION
 	select DRM_GEM_SHMEM_HELPER
 	select DRM_KMS_HELPER
+	select DRM_SYSFB_HELPER
 	help
 	  DRM driver for Open Firmware framebuffers.
 
@@ -24,6 +29,7 @@ config DRM_SIMPLEDRM
 	select DRM_CLIENT_SELECTION
 	select DRM_GEM_SHMEM_HELPER
 	select DRM_KMS_HELPER
+	select DRM_SYSFB_HELPER
 	help
 	  DRM driver for simple platform-provided framebuffers.
 
drivers/gpu/drm/sysfb/Makefile +2 -0
index f6c03629accb..f1e8700c3e35 100644
@@ -1,4 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0-only
 
+obj-$(CONFIG_DRM_SYSFB_HELPER)	+= drm_sysfb_helper.o
+
 obj-$(CONFIG_DRM_OFDRM)		+= ofdrm.o
 obj-$(CONFIG_DRM_SIMPLEDRM)	+= simpledrm.o
drivers/gpu/drm/sysfb/drm_sysfb_helper.c new file +8 -0
new file mode 100644
index 000000000000..c083d21fd9ca
@@ -0,0 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0-only
+
+#include <linux/module.h>
+
+#include "drm_sysfb_helper.h"
+
+MODULE_DESCRIPTION("Helpers for DRM sysfb drivers");
+MODULE_LICENSE("GPL");
drivers/gpu/drm/sysfb/drm_sysfb_helper.h new file +35 -0
new file mode 100644
index 000000000000..8f05eee7f49e
@@ -0,0 +1,35 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#ifndef DRM_SYSFB_HELPER_H
+#define DRM_SYSFB_HELPER_H
+
+#include <linux/container_of.h>
+#include <linux/iosys-map.h>
+
+#include <drm/drm_device.h>
+#include <drm/drm_modes.h>
+
+struct drm_format_info;
+
+/*
+ * Device
+ */
+
+struct drm_sysfb_device {
+	struct drm_device dev;
+
+	/* hardware settings */
+	struct drm_display_mode fb_mode;
+	const struct drm_format_info *fb_format;
+	unsigned int fb_pitch;
+
+	/* hardware-framebuffer kernel address */
+	struct iosys_map fb_addr;
+};
+
+static inline struct drm_sysfb_device *to_drm_sysfb_device(struct drm_device *dev)
+{
+	return container_of(dev, struct drm_sysfb_device, dev);
+}
+
+#endif
drivers/gpu/drm/sysfb/ofdrm.c +39 -39

233 lines not on this page · raw message

drivers/gpu/drm/sysfb/simpledrm.c +45 -45

265 lines not on this page · raw message

Signature · 1 line
2.48.1
maintainer Reviewed-by on v1 5/18
#10 lore raw

Re: [PATCH 05/18] drm/sysfb: Add struct drm_sysfb_device

Quoted 7 lines · Thomas Zimmermann

Add struct drm_sysfb_device that stores the system display's hardware settings. Further helpers for the mode-setting pipeline will use these fields. Convert ofdrm and simpledrm by embedding the sysfb device in their device structs.

---

Nice patch, this makes total sense in hindsight.

Signature · 5 lines
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat
author maintainer
#11 lore raw

PATCH 6/18 drm/sysfb: Provide single mode-init helper

In reply to Thomas Zimmermann

Merge the mode-init functions of ofdrm and simpledrm to the new helper drm_sysfb_mode(). Also implement the DPI defaults there. Replace the code in each driver with the shared helper.

---
 drivers/gpu/drm/sysfb/drm_sysfb_helper.c | 24 ++++++++++++++++++++++++
 drivers/gpu/drm/sysfb/drm_sysfb_helper.h |  5 +++++
 drivers/gpu/drm/sysfb/ofdrm.c            | 17 +----------------
 drivers/gpu/drm/sysfb/simpledrm.c        | 23 +----------------------
 4 files changed, 31 insertions(+), 38 deletions(-)
drivers/gpu/drm/sysfb/drm_sysfb_helper.c +24 -0
index c083d21fd9ca..6deeac81a41d 100644
@@ -6,3 +6,27 @@
 
 MODULE_DESCRIPTION("Helpers for DRM sysfb drivers");
 MODULE_LICENSE("GPL");
+
+struct drm_display_mode drm_sysfb_mode(unsigned int width,
+				       unsigned int height,
+				       unsigned int width_mm,
+				       unsigned int height_mm)
+{
+	/*
+	 * Assume a monitor resolution of 96 dpi to
+	 * get a somewhat reasonable screen size.
+	 */
+	if (!width_mm)
+		width_mm = DRM_MODE_RES_MM(width, 96ul);
+	if (!height_mm)
+		height_mm = DRM_MODE_RES_MM(height, 96ul);
+
+	{
+		const struct drm_display_mode mode = {
+			DRM_MODE_INIT(60, width, height, width_mm, height_mm)
+		};
+
+		return mode;
+	}
+}
+EXPORT_SYMBOL(drm_sysfb_mode);
drivers/gpu/drm/sysfb/drm_sysfb_helper.h +5 -0
index 8f05eee7f49e..8b4cc4af702b 100644
@@ -11,6 +11,11 @@
 
 struct drm_format_info;
 
+struct drm_display_mode drm_sysfb_mode(unsigned int width,
+				       unsigned int height,
+				       unsigned int width_mm,
+				       unsigned int height_mm);
+
 /*
  * Device
  */
drivers/gpu/drm/sysfb/ofdrm.c +1 -16
index d42704facb45..7df6901157fb 100644
@@ -1070,21 +1070,6 @@ static const struct ofdrm_device_funcs ofdrm_qemu_device_funcs = {
 	.cmap_write = ofdrm_qemu_cmap_write,
 };
 
-static struct drm_display_mode ofdrm_mode(unsigned int width, unsigned int height)
-{
-	/*
-	 * Assume a monitor resolution of 96 dpi to
-	 * get a somewhat reasonable screen size.
-	 */
-	const struct drm_display_mode mode = {
-		DRM_MODE_INIT(60, width, height,
-			      DRM_MODE_RES_MM(width, 96ul),
-			      DRM_MODE_RES_MM(height, 96ul))
-	};
-
-	return mode;
-}
-
 static struct ofdrm_device *ofdrm_device_create(struct drm_driver *drv,
 						struct platform_device *pdev)
 {
@@ -1251,7 +1236,7 @@ static struct ofdrm_device *ofdrm_device_create(struct drm_driver *drv,
 	 */
 
 	iosys_map_set_vaddr_iomem(&sysfb->fb_addr, screen_base);
-	sysfb->fb_mode = ofdrm_mode(width, height);
+	sysfb->fb_mode = drm_sysfb_mode(width, height, 0, 0);
 	sysfb->fb_format = format;
 	sysfb->fb_pitch = linebytes;
 
drivers/gpu/drm/sysfb/simpledrm.c +1 -22
index f258d8cdb6b6..149df6941b6c 100644
@@ -756,18 +756,6 @@ static const struct drm_mode_config_funcs simpledrm_mode_config_funcs = {
  * Init / Cleanup
  */
 
-static struct drm_display_mode simpledrm_mode(unsigned int width,
-					      unsigned int height,
-					      unsigned int width_mm,
-					      unsigned int height_mm)
-{
-	const struct drm_display_mode mode = {
-		DRM_MODE_INIT(60, width, height, width_mm, height_mm)
-	};
-
-	return mode;
-}
-
 static struct simpledrm_device *simpledrm_device_create(struct drm_driver *drv,
 							struct platform_device *pdev)
 {
@@ -855,16 +843,7 @@ static struct simpledrm_device *simpledrm_device_create(struct drm_driver *drv,
 			return ERR_PTR(-EINVAL);
 	}
 
-	/*
-	 * Assume a monitor resolution of 96 dpi if physical dimensions
-	 * are not specified to get a somewhat reasonable screen size.
-	 */
-	if (!width_mm)
-		width_mm = DRM_MODE_RES_MM(width, 96ul);
-	if (!height_mm)
-		height_mm = DRM_MODE_RES_MM(height, 96ul);
-
-	sysfb->fb_mode = simpledrm_mode(width, height, width_mm, height_mm);
+	sysfb->fb_mode = drm_sysfb_mode(width, height, width_mm, height_mm);
 	sysfb->fb_format = format;
 	sysfb->fb_pitch = stride;
 
Signature · 1 line
2.48.1
maintainer Reviewed-by on v1 6/18
#12 lore raw

Re: [PATCH 06/18] drm/sysfb: Provide single mode-init helper

Quoted 6 lines · Thomas Zimmermann

Merge the mode-init functions of ofdrm and simpledrm to the new helper drm_sysfb_mode(). Also implement the DPI defaults there. Replace the code in each driver with the shared helper.

---

Signature · 5 lines
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat
author maintainer
#13 lore raw

PATCH 7/18 drm/sysfb: Merge mode-config functions

In reply to Thomas Zimmermann

Provide initializer to set struct drm_mode_config_funcs. Convert ofdrm and simpledrm.

---
 drivers/gpu/drm/sysfb/drm_sysfb_helper.h | 9 +++++++++
 drivers/gpu/drm/sysfb/ofdrm.c            | 4 +---
 drivers/gpu/drm/sysfb/simpledrm.c        | 4 +---
 3 files changed, 11 insertions(+), 6 deletions(-)
drivers/gpu/drm/sysfb/drm_sysfb_helper.h +9 -0
index 8b4cc4af702b..cf80b291014a 100644
@@ -37,4 +37,13 @@ static inline struct drm_sysfb_device *to_drm_sysfb_device(struct drm_device *de
 	return container_of(dev, struct drm_sysfb_device, dev);
 }
 
+/*
+ * Mode config
+ */
+
+#define DRM_SYSFB_MODE_CONFIG_FUNCS \
+	.fb_create = drm_gem_fb_create_with_dirty, \
+	.atomic_check = drm_atomic_helper_check, \
+	.atomic_commit = drm_atomic_helper_commit
+
 #endif
drivers/gpu/drm/sysfb/ofdrm.c +1 -3
index 7df6901157fb..470b93f0f791 100644
@@ -1018,9 +1018,7 @@ static const struct drm_connector_funcs ofdrm_connector_funcs = {
 };
 
 static const struct drm_mode_config_funcs ofdrm_mode_config_funcs = {
-	.fb_create = drm_gem_fb_create_with_dirty,
-	.atomic_check = drm_atomic_helper_check,
-	.atomic_commit = drm_atomic_helper_commit,
+	DRM_SYSFB_MODE_CONFIG_FUNCS,
 };
 
 /*
drivers/gpu/drm/sysfb/simpledrm.c +1 -3
index 149df6941b6c..0cee8e1b2108 100644
@@ -747,9 +747,7 @@ static const struct drm_connector_funcs simpledrm_connector_funcs = {
 };
 
 static const struct drm_mode_config_funcs simpledrm_mode_config_funcs = {
-	.fb_create = drm_gem_fb_create_with_dirty,
-	.atomic_check = drm_atomic_helper_check,
-	.atomic_commit = drm_atomic_helper_commit,
+	DRM_SYSFB_MODE_CONFIG_FUNCS,
 };
 
 /*
Signature · 1 line
2.48.1
author maintainer
#15 lore raw

PATCH 8/18 drm/sysfb: Merge connector functions

In reply to Thomas Zimmermann

Merge the connector functions of ofdrm and simpledrm. Replace the code in each driver with the shared helpers. Set up callbacks with initializer macros.

No effective code changes. The sysfb connector only returns the preconfigured display mode.

---
 drivers/gpu/drm/sysfb/drm_sysfb_helper.c | 14 ++++++++++++++
 drivers/gpu/drm/sysfb/drm_sysfb_helper.h | 15 +++++++++++++++
 drivers/gpu/drm/sysfb/ofdrm.c            | 14 ++------------
 drivers/gpu/drm/sysfb/simpledrm.c        | 14 ++------------
 4 files changed, 33 insertions(+), 24 deletions(-)
drivers/gpu/drm/sysfb/drm_sysfb_helper.c +14 -0
index 6deeac81a41d..355e025c7c62 100644
@@ -2,6 +2,8 @@
 
 #include <linux/module.h>
 
+#include <drm/drm_probe_helper.h>
+
 #include "drm_sysfb_helper.h"
 
 MODULE_DESCRIPTION("Helpers for DRM sysfb drivers");
@@ -30,3 +32,15 @@ struct drm_display_mode drm_sysfb_mode(unsigned int width,
 	}
 }
 EXPORT_SYMBOL(drm_sysfb_mode);
+
+/*
+ * Connector
+ */
+
+int drm_sysfb_connector_helper_get_modes(struct drm_connector *connector)
+{
+	struct drm_sysfb_device *sysfb = to_drm_sysfb_device(connector->dev);
+
+	return drm_connector_helper_get_modes_fixed(connector, &sysfb->fb_mode);
+}
+EXPORT_SYMBOL(drm_sysfb_connector_helper_get_modes);
drivers/gpu/drm/sysfb/drm_sysfb_helper.h +15 -0
index cf80b291014a..7e3fe9fa5cff 100644
@@ -37,6 +37,21 @@ static inline struct drm_sysfb_device *to_drm_sysfb_device(struct drm_device *de
 	return container_of(dev, struct drm_sysfb_device, dev);
 }
 
+/*
+ * Connector
+ */
+
+int drm_sysfb_connector_helper_get_modes(struct drm_connector *connector);
+
+#define DRM_SYSFB_CONNECTOR_HELPER_FUNCS \
+	.get_modes = drm_sysfb_connector_helper_get_modes
+
+#define DRM_SYSFB_CONNECTOR_FUNCS \
+	.reset = drm_atomic_helper_connector_reset, \
+	.fill_modes = drm_helper_probe_single_connector_modes, \
+	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, \
+	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state
+
 /*
  * Mode config
  */
drivers/gpu/drm/sysfb/ofdrm.c +2 -12
index 470b93f0f791..85db7441d1bf 100644
@@ -998,23 +998,13 @@ static const struct drm_encoder_funcs ofdrm_encoder_funcs = {
 	.destroy = drm_encoder_cleanup,
 };
 
-static int ofdrm_connector_helper_get_modes(struct drm_connector *connector)
-{
-	struct drm_sysfb_device *sysfb = to_drm_sysfb_device(connector->dev);
-
-	return drm_connector_helper_get_modes_fixed(connector, &sysfb->fb_mode);
-}
-
 static const struct drm_connector_helper_funcs ofdrm_connector_helper_funcs = {
-	.get_modes = ofdrm_connector_helper_get_modes,
+	DRM_SYSFB_CONNECTOR_HELPER_FUNCS,
 };
 
 static const struct drm_connector_funcs ofdrm_connector_funcs = {
-	.reset = drm_atomic_helper_connector_reset,
-	.fill_modes = drm_helper_probe_single_connector_modes,
+	DRM_SYSFB_CONNECTOR_FUNCS,
 	.destroy = drm_connector_cleanup,
-	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
-	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
 };
 
 static const struct drm_mode_config_funcs ofdrm_mode_config_funcs = {
drivers/gpu/drm/sysfb/simpledrm.c +2 -12
index 0cee8e1b2108..6d76d125d126 100644
@@ -727,23 +727,13 @@ static const struct drm_encoder_funcs simpledrm_encoder_funcs = {
 	.destroy = drm_encoder_cleanup,
 };
 
-static int simpledrm_connector_helper_get_modes(struct drm_connector *connector)
-{
-	struct drm_sysfb_device *sysfb = to_drm_sysfb_device(connector->dev);
-
-	return drm_connector_helper_get_modes_fixed(connector, &sysfb->fb_mode);
-}
-
 static const struct drm_connector_helper_funcs simpledrm_connector_helper_funcs = {
-	.get_modes = simpledrm_connector_helper_get_modes,
+	DRM_SYSFB_CONNECTOR_HELPER_FUNCS,
 };
 
 static const struct drm_connector_funcs simpledrm_connector_funcs = {
-	.reset = drm_atomic_helper_connector_reset,
-	.fill_modes = drm_helper_probe_single_connector_modes,
+	DRM_SYSFB_CONNECTOR_FUNCS,
 	.destroy = drm_connector_cleanup,
-	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
-	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
 };
 
 static const struct drm_mode_config_funcs simpledrm_mode_config_funcs = {
Signature · 1 line
2.48.1
#16 lore raw

Re: [PATCH 08/18] drm/sysfb: Merge connector functions

Quoted 9 lines · Thomas Zimmermann

Merge the connector functions of ofdrm and simpledrm. Replace the code in each driver with the shared helpers. Set up callbacks with initializer macros.

No effective code changes. The sysfb connector only returns the preconfigured display mode.

---

...

Quoted 7 lines
drivers/gpu/drm/sysfb/drm_sysfb_helper.h +6 -0
+#define DRM_SYSFB_CONNECTOR_FUNCS \
+	.reset = drm_atomic_helper_connector_reset, \
+	.fill_modes = drm_helper_probe_single_connector_modes, \
+	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, \
+	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state
+
 /*

...

drivers/gpu/drm/sysfb/ofdrm.c static const struct drm_encoder_funcs ofdrm_encoder_funcs = { · line 1007

Quoted 5 lines

static const struct drm_connector_funcs ofdrm_connector_funcs = {

drivers/gpu/drm/sysfb/ofdrm.c +1 -2
-	.reset = drm_atomic_helper_connector_reset,
-	.fill_modes = drm_helper_probe_single_connector_modes,
+	DRM_SYSFB_CONNECTOR_FUNCS,
 	.destroy = drm_connector_cleanup,

Why not include the .destroy callback in DRM_SYSFB_CONNECTOR_FUNCS ?

Signature · 5 lines
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat
author maintainer
#17 lore raw

Re: [PATCH 08/18] drm/sysfb: Merge connector functions

Hi Javier

Am 23.03.25 um 11:57 schrieb Javier Martinez Canillas:

Quoted 22 lines
Quoted 9 lines · Thomas Zimmermann

Merge the connector functions of ofdrm and simpledrm. Replace the code in each driver with the shared helpers. Set up callbacks with initializer macros.

No effective code changes. The sysfb connector only returns the preconfigured display mode.

---

...

Quoted 7 lines
drivers/gpu/drm/sysfb/drm_sysfb_helper.h +6 -0
+#define DRM_SYSFB_CONNECTOR_FUNCS \
+	.reset = drm_atomic_helper_connector_reset, \
+	.fill_modes = drm_helper_probe_single_connector_modes, \
+	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, \
+	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state
+
  /*

...

Quoted 6 lines

drivers/gpu/drm/sysfb/ofdrm.c static const struct drm_encoder_funcs ofdrm_encoder_funcs = { · line 1007

Quoted 5 lines
  static const struct drm_connector_funcs ofdrm_connector_funcs = {
drivers/gpu/drm/sysfb/ofdrm.c +1 -2
-	.reset = drm_atomic_helper_connector_reset,
-	.fill_modes = drm_helper_probe_single_connector_modes,
+	DRM_SYSFB_CONNECTOR_FUNCS,
  	.destroy = drm_connector_cleanup,

Why not include the .destroy callback in DRM_SYSFB_CONNECTOR_FUNCS ?

These sysfb helpers provide functionality to operate on the output (damage handling, etc).

The destroy callback depends on the way the mode-setting pipeline is organized. The driver controls this. It might wants to allocated the connector separately or use a container structure (e.g., struct ofdrm_connector) that needs separate cleanup. Hence the driver has to control the  destroy callback. That argument goes for all the other elements of the pipeline.

Best regards
Thomas

Quoted 1 line
Signature · 7 lines
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
maintainer Reviewed-by
#18 lore raw

Re: [PATCH 08/18] drm/sysfb: Merge connector functions

Thomas Zimmermann <[email protected]> writes:

Hello Thomas,

Quoted 35 lines

Hi Javier

Am 23.03.25 um 11:57 schrieb Javier Martinez Canillas:

Quoted 22 lines
Quoted 9 lines · Thomas Zimmermann

Merge the connector functions of ofdrm and simpledrm. Replace the code in each driver with the shared helpers. Set up callbacks with initializer macros.

No effective code changes. The sysfb connector only returns the preconfigured display mode.

---

...

Quoted 7 lines
drivers/gpu/drm/sysfb/drm_sysfb_helper.h +6 -0
+#define DRM_SYSFB_CONNECTOR_FUNCS \
+	.reset = drm_atomic_helper_connector_reset, \
+	.fill_modes = drm_helper_probe_single_connector_modes, \
+	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, \
+	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state
+
  /*

...

Quoted 6 lines

drivers/gpu/drm/sysfb/ofdrm.c static const struct drm_encoder_funcs ofdrm_encoder_funcs = { · line 1007

Quoted 5 lines
  static const struct drm_connector_funcs ofdrm_connector_funcs = {
drivers/gpu/drm/sysfb/ofdrm.c +1 -2
-	.reset = drm_atomic_helper_connector_reset,
-	.fill_modes = drm_helper_probe_single_connector_modes,
+	DRM_SYSFB_CONNECTOR_FUNCS,
  	.destroy = drm_connector_cleanup,

Why not include the .destroy callback in DRM_SYSFB_CONNECTOR_FUNCS ?

These sysfb helpers provide functionality to operate on the output (damage handling, etc).

Quoted 7 lines

The destroy callback depends on the way the mode-setting pipeline is organized. The driver controls this. It might wants to allocated the connector separately or use a container structure (e.g., struct ofdrm_connector) that needs separate cleanup. Hence the driver has to control the  destroy callback. That argument goes for all the other elements of the pipeline.

Thanks for the explanation. Makes sense.

Signature · 5 lines
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat
author maintainer
#19 lore raw

PATCH 9/18 drm/sysfb: Maintain CRTC state in struct drm_sysfb_crtc_state

In reply to Thomas Zimmermann

Move ofdrm's struct ofdrm_crtc_state plus functions to sysfb helpers and rename everything to drm_sysfb_crtc_state.

The sysfb CRTC state is a regular CRTC state with information on the primary plane's color format, as required for color management. Helpers for sysfb planes will later set this up automatically.

In ofdrm and simpledrm, replace existing code with the new helpers. Ofdrm continues to use the CRTC state for color management. This has no effect on simpledrm.

---
 drivers/gpu/drm/sysfb/drm_sysfb_helper.c | 59 ++++++++++++++++++
 drivers/gpu/drm/sysfb/drm_sysfb_helper.h | 29 +++++++++
 drivers/gpu/drm/sysfb/ofdrm.c            | 76 ++----------------------
 drivers/gpu/drm/sysfb/simpledrm.c        |  6 +-
 4 files changed, 95 insertions(+), 75 deletions(-)
drivers/gpu/drm/sysfb/drm_sysfb_helper.c +59 -0
index 355e025c7c62..368061b6f514 100644
@@ -1,7 +1,11 @@
 // SPDX-License-Identifier: GPL-2.0-only
 
+#include <linux/export.h>
+#include <linux/slab.h>
 #include <linux/module.h>
 
+#include <drm/drm_atomic_state_helper.h>
+#include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>
 
 #include "drm_sysfb_helper.h"
@@ -33,6 +37,61 @@ struct drm_display_mode drm_sysfb_mode(unsigned int width,
 }
 EXPORT_SYMBOL(drm_sysfb_mode);
 
+/*
+ * CRTC
+ */
+
+static void drm_sysfb_crtc_state_destroy(struct drm_sysfb_crtc_state *sysfb_crtc_state)
+{
+	__drm_atomic_helper_crtc_destroy_state(&sysfb_crtc_state->base);
+
+	kfree(sysfb_crtc_state);
+}
+
+void drm_sysfb_crtc_reset(struct drm_crtc *crtc)
+{
+	struct drm_sysfb_crtc_state *sysfb_crtc_state;
+
+	if (crtc->state)
+		drm_sysfb_crtc_state_destroy(to_drm_sysfb_crtc_state(crtc->state));
+
+	sysfb_crtc_state = kzalloc(sizeof(*sysfb_crtc_state), GFP_KERNEL);
+	if (sysfb_crtc_state)
+		__drm_atomic_helper_crtc_reset(crtc, &sysfb_crtc_state->base);
+	else
+		__drm_atomic_helper_crtc_reset(crtc, NULL);
+}
+EXPORT_SYMBOL(drm_sysfb_crtc_reset);
+
+struct drm_crtc_state *drm_sysfb_crtc_atomic_duplicate_state(struct drm_crtc *crtc)
+{
+	struct drm_device *dev = crtc->dev;
+	struct drm_crtc_state *crtc_state = crtc->state;
+	struct drm_sysfb_crtc_state *new_sysfb_crtc_state;
+	struct drm_sysfb_crtc_state *sysfb_crtc_state;
+
+	if (drm_WARN_ON(dev, !crtc_state))
+		return NULL;
+
+	new_sysfb_crtc_state = kzalloc(sizeof(*new_sysfb_crtc_state), GFP_KERNEL);
+	if (!new_sysfb_crtc_state)
+		return NULL;
+
+	sysfb_crtc_state = to_drm_sysfb_crtc_state(crtc_state);
+
+	__drm_atomic_helper_crtc_duplicate_state(crtc, &new_sysfb_crtc_state->base);
+	new_sysfb_crtc_state->format = sysfb_crtc_state->format;
+
+	return &new_sysfb_crtc_state->base;
+}
+EXPORT_SYMBOL(drm_sysfb_crtc_atomic_duplicate_state);
+
+void drm_sysfb_crtc_atomic_destroy_state(struct drm_crtc *crtc, struct drm_crtc_state *crtc_state)
+{
+	drm_sysfb_crtc_state_destroy(to_drm_sysfb_crtc_state(crtc_state));
+}
+EXPORT_SYMBOL(drm_sysfb_crtc_atomic_destroy_state);
+
 /*
  * Connector
  */
drivers/gpu/drm/sysfb/drm_sysfb_helper.h +29 -0
index 7e3fe9fa5cff..91da27405a46 100644
@@ -6,6 +6,7 @@
 #include <linux/container_of.h>
 #include <linux/iosys-map.h>
 
+#include <drm/drm_crtc.h>
 #include <drm/drm_device.h>
 #include <drm/drm_modes.h>
 
@@ -37,6 +38,34 @@ static inline struct drm_sysfb_device *to_drm_sysfb_device(struct drm_device *de
 	return container_of(dev, struct drm_sysfb_device, dev);
 }
 
+/*
+ * CRTC
+ */
+
+struct drm_sysfb_crtc_state {
+	struct drm_crtc_state base;
+
+	/* Primary-plane format; required for color mgmt. */
+	const struct drm_format_info *format;
+};
+
+static inline struct drm_sysfb_crtc_state *
+to_drm_sysfb_crtc_state(struct drm_crtc_state *base)
+{
+	return container_of(base, struct drm_sysfb_crtc_state, base);
+}
+
+void drm_sysfb_crtc_reset(struct drm_crtc *crtc);
+struct drm_crtc_state *drm_sysfb_crtc_atomic_duplicate_state(struct drm_crtc *crtc);
+void drm_sysfb_crtc_atomic_destroy_state(struct drm_crtc *crtc, struct drm_crtc_state *crtc_state);
+
+#define DRM_SYSFB_CRTC_FUNCS \
+	.reset = drm_sysfb_crtc_reset, \
+	.set_config = drm_atomic_helper_set_config, \
+	.page_flip = drm_atomic_helper_page_flip, \
+	.atomic_duplicate_state = drm_sysfb_crtc_atomic_duplicate_state, \
+	.atomic_destroy_state = drm_sysfb_crtc_atomic_destroy_state
+
 /*
  * Connector
  */
drivers/gpu/drm/sysfb/ofdrm.c +6 -70

110 lines not on this page · raw message

drivers/gpu/drm/sysfb/simpledrm.c +1 -5
index 6d76d125d126..986177e4a0f0 100644
@@ -715,12 +715,8 @@ static const struct drm_crtc_helper_funcs simpledrm_crtc_helper_funcs = {
 };
 
 static const struct drm_crtc_funcs simpledrm_crtc_funcs = {
-	.reset = drm_atomic_helper_crtc_reset,
+	DRM_SYSFB_CRTC_FUNCS,
 	.destroy = drm_crtc_cleanup,
-	.set_config = drm_atomic_helper_set_config,
-	.page_flip = drm_atomic_helper_page_flip,
-	.atomic_duplicate_state = drm_atomic_helper_crtc_duplicate_state,
-	.atomic_destroy_state = drm_atomic_helper_crtc_destroy_state,
 };
 
 static const struct drm_encoder_funcs simpledrm_encoder_funcs = {
Signature · 1 line
2.48.1
maintainer Reviewed-by on v1 9/18
#20 lore raw

Re: [PATCH 09/18] drm/sysfb: Maintain CRTC state in struct drm_sysfb_crtc_state

Quoted 7 lines · Thomas Zimmermann

Move ofdrm's struct ofdrm_crtc_state plus functions to sysfb helpers and rename everything to drm_sysfb_crtc_state.

The sysfb CRTC state is a regular CRTC state with information on the primary plane's color format, as required for color management. Helpers for sysfb planes will later set this up automatically.

Quoted 6 lines

In ofdrm and simpledrm, replace existing code with the new helpers. Ofdrm continues to use the CRTC state for color management. This has no effect on simpledrm.

---

Signature · 5 lines
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat
author maintainer
#21 lore raw

PATCH 10/18 drm/sysfb: Merge CRTC functions

In reply to Thomas Zimmermann

Merge the CRTC functions of ofdrm and simpledrm. Replace the code in each driver with the shared helpers. Set up callbacks with initializer macros.

Ofdrm supports a gamma LUT, while simpledrm does not. So far ofdrm's LUT size has been hard-coded in the driver CRTC's atomic_check helper. Now pass the size of the LUT to the sysfb device. Ofdrm's custom atomic_flush is still required to apply changes to the LUT. Simpledrm passes a LUT size of 0, which disables the gamma LUT.

---
 drivers/gpu/drm/sysfb/drm_sysfb_helper.c | 40 ++++++++++++++++++
 drivers/gpu/drm/sysfb/drm_sysfb_helper.h |  9 ++++
 drivers/gpu/drm/sysfb/ofdrm.c            | 53 ++++--------------------
 drivers/gpu/drm/sysfb/simpledrm.c        | 17 +-------
 4 files changed, 57 insertions(+), 62 deletions(-)
drivers/gpu/drm/sysfb/drm_sysfb_helper.c +40 -0
index 368061b6f514..ed9139f56e59 100644
@@ -4,6 +4,8 @@
 #include <linux/slab.h>
 #include <linux/module.h>
 
+#include <drm/drm_atomic.h>
+#include <drm/drm_atomic_helper.h>
 #include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>
@@ -48,6 +50,44 @@ static void drm_sysfb_crtc_state_destroy(struct drm_sysfb_crtc_state *sysfb_crtc
 	kfree(sysfb_crtc_state);
 }
 
+enum drm_mode_status drm_sysfb_crtc_helper_mode_valid(struct drm_crtc *crtc,
+						      const struct drm_display_mode *mode)
+{
+	struct drm_sysfb_device *sysfb = to_drm_sysfb_device(crtc->dev);
+
+	return drm_crtc_helper_mode_valid_fixed(crtc, mode, &sysfb->fb_mode);
+}
+EXPORT_SYMBOL(drm_sysfb_crtc_helper_mode_valid);
+
+int drm_sysfb_crtc_helper_atomic_check(struct drm_crtc *crtc, struct drm_atomic_state *new_state)
+{
+	struct drm_device *dev = crtc->dev;
+	struct drm_sysfb_device *sysfb = to_drm_sysfb_device(dev);
+	struct drm_crtc_state *new_crtc_state = drm_atomic_get_new_crtc_state(new_state, crtc);
+	int ret;
+
+	if (!new_crtc_state->enable)
+		return 0;
+
+	ret = drm_atomic_helper_check_crtc_primary_plane(new_crtc_state);
+	if (ret)
+		return ret;
+
+	if (new_crtc_state->color_mgmt_changed) {
+		const size_t gamma_lut_length =
+			sysfb->fb_gamma_lut_size * sizeof(struct drm_color_lut);
+		const struct drm_property_blob *gamma_lut = new_crtc_state->gamma_lut;
+
+		if (gamma_lut && (gamma_lut->length != gamma_lut_length)) {
+			drm_dbg(dev, "Incorrect gamma_lut length %zu\n", gamma_lut->length);
+			return -EINVAL;
+		}
+	}
+
+	return 0;
+}
+EXPORT_SYMBOL(drm_sysfb_crtc_helper_atomic_check);
+
 void drm_sysfb_crtc_reset(struct drm_crtc *crtc)
 {
 	struct drm_sysfb_crtc_state *sysfb_crtc_state;
drivers/gpu/drm/sysfb/drm_sysfb_helper.h +9 -0
index 91da27405a46..c8e5ac6b9b63 100644
@@ -28,6 +28,7 @@ struct drm_sysfb_device {
 	struct drm_display_mode fb_mode;
 	const struct drm_format_info *fb_format;
 	unsigned int fb_pitch;
+	unsigned int fb_gamma_lut_size;
 
 	/* hardware-framebuffer kernel address */
 	struct iosys_map fb_addr;
@@ -55,6 +56,14 @@ to_drm_sysfb_crtc_state(struct drm_crtc_state *base)
 	return container_of(base, struct drm_sysfb_crtc_state, base);
 }
 
+enum drm_mode_status drm_sysfb_crtc_helper_mode_valid(struct drm_crtc *crtc,
+						      const struct drm_display_mode *mode);
+int drm_sysfb_crtc_helper_atomic_check(struct drm_crtc *crtc, struct drm_atomic_state *new_state);
+
+#define DRM_SYSFB_CRTC_HELPER_FUNCS \
+	.mode_valid = drm_sysfb_crtc_helper_mode_valid, \
+	.atomic_check = drm_sysfb_crtc_helper_atomic_check
+
 void drm_sysfb_crtc_reset(struct drm_crtc *crtc);
 struct drm_crtc_state *drm_sysfb_crtc_atomic_duplicate_state(struct drm_crtc *crtc);
 void drm_sysfb_crtc_atomic_destroy_state(struct drm_crtc *crtc, struct drm_crtc_state *crtc_state);
drivers/gpu/drm/sysfb/ofdrm.c +7 -46

78 lines not on this page · raw message

drivers/gpu/drm/sysfb/simpledrm.c +1 -16
index 986177e4a0f0..9616e67ea42c 100644
@@ -14,7 +14,6 @@
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_connector.h>
-#include <drm/drm_crtc_helper.h>
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_device.h>
 #include <drm/drm_drv.h>
@@ -696,22 +695,8 @@ static const struct drm_plane_funcs simpledrm_primary_plane_funcs = {
 	DRM_GEM_SHADOW_PLANE_FUNCS,
 };
 
-static enum drm_mode_status simpledrm_crtc_helper_mode_valid(struct drm_crtc *crtc,
-							     const struct drm_display_mode *mode)
-{
-	struct drm_sysfb_device *sysfb = to_drm_sysfb_device(crtc->dev);
-
-	return drm_crtc_helper_mode_valid_fixed(crtc, mode, &sysfb->fb_mode);
-}
-
-/*
- * The CRTC is always enabled. Screen updates are performed by
- * the primary plane's atomic_update function. Disabling clears
- * the screen in the primary plane's atomic_disable function.
- */
 static const struct drm_crtc_helper_funcs simpledrm_crtc_helper_funcs = {
-	.mode_valid = simpledrm_crtc_helper_mode_valid,
-	.atomic_check = drm_crtc_helper_atomic_check,
+	DRM_SYSFB_CRTC_HELPER_FUNCS,
 };
 
 static const struct drm_crtc_funcs simpledrm_crtc_funcs = {
Signature · 1 line
2.48.1
maintainer Reviewed-by on v1 10/18
#22 lore raw

Re: [PATCH 10/18] drm/sysfb: Merge CRTC functions

Quoted 4 lines · Thomas Zimmermann

Merge the CRTC functions of ofdrm and simpledrm. Replace the code in each driver with the shared helpers. Set up callbacks with initializer macros.

Quoted 8 lines

Ofdrm supports a gamma LUT, while simpledrm does not. So far ofdrm's LUT size has been hard-coded in the driver CRTC's atomic_check helper. Now pass the size of the LUT to the sysfb device. Ofdrm's custom atomic_flush is still required to apply changes to the LUT. Simpledrm passes a LUT size of 0, which disables the gamma LUT.

---

Signature · 5 lines
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat
author maintainer
#23 lore raw

PATCH 11/18 drm/sysfb: Merge primary-plane functions

In reply to Thomas Zimmermann

Merge the primary plane code of ofdrm and simpledrm. Replace the plane implementation in each driver with the shared helpers. Set up driver callbacks and format modifiers with initializer macros.

The plane code in ofdrm and simpledrm is very similar. Ofdrm has a more sophisticated implementation of atomic_disable, which clears individual scanlines. The code in simpledrm clears the whole buffer at once. Take the ofdrm version.

Simpledrm supports get_scanout_buffer. Import it into the shared helpers, which makes it available in ofdrm.

The supported formats are all native formats plus an optional enulated XRGB8888 if that's not already a native format. Provide an initializer macro that computes the size of the formats array.

---
 drivers/gpu/drm/sysfb/drm_sysfb_helper.c | 145 +++++++++++++++++++++++
 drivers/gpu/drm/sysfb/drm_sysfb_helper.h |  32 +++++
 drivers/gpu/drm/sysfb/ofdrm.c            | 134 +--------------------
 drivers/gpu/drm/sysfb/simpledrm.c        | 126 +-------------------
 4 files changed, 187 insertions(+), 250 deletions(-)
drivers/gpu/drm/sysfb/drm_sysfb_helper.c +145 -0
index ed9139f56e59..b48e06b25305 100644
@@ -7,6 +7,13 @@
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_atomic_state_helper.h>
+#include <drm/drm_damage_helper.h>
+#include <drm/drm_drv.h>
+#include <drm/drm_fourcc.h>
+#include <drm/drm_framebuffer.h>
+#include <drm/drm_gem_atomic_helper.h>
+#include <drm/drm_gem_framebuffer_helper.h>
+#include <drm/drm_panic.h>
 #include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>
 
@@ -39,6 +46,144 @@ struct drm_display_mode drm_sysfb_mode(unsigned int width,
 }
 EXPORT_SYMBOL(drm_sysfb_mode);
 
+/*
+ * Plane
+ */
+
+int drm_sysfb_plane_helper_atomic_check(struct drm_plane *plane,
+					struct drm_atomic_state *new_state)
+{
+	struct drm_sysfb_device *sysfb = to_drm_sysfb_device(plane->dev);
+	struct drm_plane_state *new_plane_state = drm_atomic_get_new_plane_state(new_state, plane);
+	struct drm_shadow_plane_state *new_shadow_plane_state =
+		to_drm_shadow_plane_state(new_plane_state);
+	struct drm_framebuffer *new_fb = new_plane_state->fb;
+	struct drm_crtc *new_crtc = new_plane_state->crtc;
+	struct drm_crtc_state *new_crtc_state = NULL;
+	struct drm_sysfb_crtc_state *new_sysfb_crtc_state;
+	int ret;
+
+	if (new_crtc)
+		new_crtc_state = drm_atomic_get_new_crtc_state(new_state, new_plane_state->crtc);
+
+	ret = drm_atomic_helper_check_plane_state(new_plane_state, new_crtc_state,
+						  DRM_PLANE_NO_SCALING,
+						  DRM_PLANE_NO_SCALING,
+						  false, false);
+	if (ret)
+		return ret;
+	else if (!new_plane_state->visible)
+		return 0;
+
+	if (new_fb->format != sysfb->fb_format) {
+		void *buf;
+
+		/* format conversion necessary; reserve buffer */
+		buf = drm_format_conv_state_reserve(&new_shadow_plane_state->fmtcnv_state,
+						    sysfb->fb_pitch, GFP_KERNEL);
+		if (!buf)
+			return -ENOMEM;
+	}
+
+	new_crtc_state = drm_atomic_get_new_crtc_state(new_state, new_plane_state->crtc);
+
+	new_sysfb_crtc_state = to_drm_sysfb_crtc_state(new_crtc_state);
+	new_sysfb_crtc_state->format = new_fb->format;
+
+	return 0;
+}
+EXPORT_SYMBOL(drm_sysfb_plane_helper_atomic_check);
+
+void drm_sysfb_plane_helper_atomic_update(struct drm_plane *plane, struct drm_atomic_state *state)
+{
+	struct drm_device *dev = plane->dev;
+	struct drm_sysfb_device *sysfb = to_drm_sysfb_device(dev);
+	struct drm_plane_state *plane_state = drm_atomic_get_new_plane_state(state, plane);
+	struct drm_plane_state *old_plane_state = drm_atomic_get_old_plane_state(state, plane);
+	struct drm_shadow_plane_state *shadow_plane_state = to_drm_shadow_plane_state(plane_state);
+	struct drm_framebuffer *fb = plane_state->fb;
+	unsigned int dst_pitch = sysfb->fb_pitch;
+	const struct drm_format_info *dst_format = sysfb->fb_format;
+	struct drm_atomic_helper_damage_iter iter;
+	struct drm_rect damage;
+	int ret, idx;
+
+	ret = drm_gem_fb_begin_cpu_access(fb, DMA_FROM_DEVICE);
+	if (ret)
+		return;
+
+	if (!drm_dev_enter(dev, &idx))
+		goto out_drm_gem_fb_end_cpu_access;
+
+	drm_atomic_helper_damage_iter_init(&iter, old_plane_state, plane_state);
+	drm_atomic_for_each_plane_damage(&iter, &damage) {
+		struct iosys_map dst = sysfb->fb_addr;
+		struct drm_rect dst_clip = plane_state->dst;
+
+		if (!drm_rect_intersect(&dst_clip, &damage))
+			continue;
+
+		iosys_map_incr(&dst, drm_fb_clip_offset(dst_pitch, dst_format, &dst_clip));
+		drm_fb_blit(&dst, &dst_pitch, dst_format->format, shadow_plane_state->data, fb,
+			    &damage, &shadow_plane_state->fmtcnv_state);
+	}
+
+	drm_dev_exit(idx);
+out_drm_gem_fb_end_cpu_access:
+	drm_gem_fb_end_cpu_access(fb, DMA_FROM_DEVICE);
+}
+EXPORT_SYMBOL(drm_sysfb_plane_helper_atomic_update);
+
+void drm_sysfb_plane_helper_atomic_disable(struct drm_plane *plane,
+					   struct drm_atomic_state *state)
+{
+	struct drm_device *dev = plane->dev;
+	struct drm_sysfb_device *sysfb = to_drm_sysfb_device(dev);
+	struct iosys_map dst = sysfb->fb_addr;
+	struct drm_plane_state *plane_state = drm_atomic_get_new_plane_state(state, plane);
+	void __iomem *dst_vmap = dst.vaddr_iomem; /* TODO: Use mapping abstraction */
+	unsigned int dst_pitch = sysfb->fb_pitch;
+	const struct drm_format_info *dst_format = sysfb->fb_format;
+	struct drm_rect dst_clip;
+	unsigned long lines, linepixels, i;
+	int idx;
+
+	drm_rect_init(&dst_clip,
+		      plane_state->src_x >> 16, plane_state->src_y >> 16,
+		      plane_state->src_w >> 16, plane_state->src_h >> 16);
+
+	lines = drm_rect_height(&dst_clip);
+	linepixels = drm_rect_width(&dst_clip);
+
+	if (!drm_dev_enter(dev, &idx))
+		return;
+
+	/* Clear buffer to black if disabled */
+	dst_vmap += drm_fb_clip_offset(dst_pitch, dst_format, &dst_clip);
+	for (i = 0; i < lines; ++i) {
+		memset_io(dst_vmap, 0, linepixels * dst_format->cpp[0]);
+		dst_vmap += dst_pitch;
+	}
+
+	drm_dev_exit(idx);
+}
+EXPORT_SYMBOL(drm_sysfb_plane_helper_atomic_disable);
+
+int drm_sysfb_plane_helper_get_scanout_buffer(struct drm_plane *plane,
+					      struct drm_scanout_buffer *sb)
+{
+	struct drm_sysfb_device *sysfb = to_drm_sysfb_device(plane->dev);
+
+	sb->width = sysfb->fb_mode.hdisplay;
+	sb->height = sysfb->fb_mode.vdisplay;
+	sb->format = sysfb->fb_format;
+	sb->pitch[0] = sysfb->fb_pitch;
+	sb->map[0] = sysfb->fb_addr;
+
+	return 0;
+}
+EXPORT_SYMBOL(drm_sysfb_plane_helper_get_scanout_buffer);
+
 /*
  * CRTC
  */
drivers/gpu/drm/sysfb/drm_sysfb_helper.h +32 -0
index c8e5ac6b9b63..45e396bf74b7 100644
@@ -39,6 +39,38 @@ static inline struct drm_sysfb_device *to_drm_sysfb_device(struct drm_device *de
 	return container_of(dev, struct drm_sysfb_device, dev);
 }
 
+/*
+ * Plane
+ */
+
+int drm_sysfb_plane_helper_atomic_check(struct drm_plane *plane,
+					struct drm_atomic_state *new_state);
+void drm_sysfb_plane_helper_atomic_update(struct drm_plane *plane,
+					  struct drm_atomic_state *state);
+void drm_sysfb_plane_helper_atomic_disable(struct drm_plane *plane,
+					   struct drm_atomic_state *state);
+int drm_sysfb_plane_helper_get_scanout_buffer(struct drm_plane *plane,
+					      struct drm_scanout_buffer *sb);
+
+#define DRM_SYSFB_PLANE_NFORMATS(_num_native) \
+	((_num_native) + 1)
+
+#define DRM_SYSFB_PLANE_FORMAT_MODIFIERS \
+	DRM_FORMAT_MOD_LINEAR, \
+	DRM_FORMAT_MOD_INVALID
+
+#define DRM_SYSFB_PLANE_HELPER_FUNCS \
+	DRM_GEM_SHADOW_PLANE_HELPER_FUNCS, \
+	.atomic_check = drm_sysfb_plane_helper_atomic_check, \
+	.atomic_update = drm_sysfb_plane_helper_atomic_update, \
+	.atomic_disable = drm_sysfb_plane_helper_atomic_disable, \
+	.get_scanout_buffer = drm_sysfb_plane_helper_get_scanout_buffer
+
+#define DRM_SYSFB_PLANE_FUNCS \
+	.update_plane = drm_atomic_helper_update_plane, \
+	.disable_plane = drm_atomic_helper_disable_plane, \
+	DRM_GEM_SHADOW_PLANE_FUNCS
+
 /*
  * CRTC
  */
drivers/gpu/drm/sysfb/ofdrm.c +5 -129

153 lines not on this page · raw message

drivers/gpu/drm/sysfb/simpledrm.c +5 -121

151 lines not on this page · raw message

Signature · 1 line
2.48.1
maintainer Reviewed-by on v1 11/18
#24 lore raw

Re: [PATCH 11/18] drm/sysfb: Merge primary-plane functions

Quoted 12 lines · Thomas Zimmermann

Merge the primary plane code of ofdrm and simpledrm. Replace the plane implementation in each driver with the shared helpers. Set up driver callbacks and format modifiers with initializer macros.

The plane code in ofdrm and simpledrm is very similar. Ofdrm has a more sophisticated implementation of atomic_disable, which clears individual scanlines. The code in simpledrm clears the whole buffer at once. Take the ofdrm version.

Simpledrm supports get_scanout_buffer. Import it into the shared helpers, which makes it available in ofdrm.

Quoted 6 lines

The supported formats are all native formats plus an optional enulated XRGB8888 if that's not already a native format. Provide an initializer macro that computes the size of the formats array.

---

Signature · 5 lines
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat
author maintainer
#25 lore raw

PATCH 12/18 drm/sysfb: ofdrm: Add EDID support

In reply to Thomas Zimmermann

Add EDID support to sysfb connector helpers. Read the EDID property from the OF node in ofdrm. Without EDID, this does nothing.

Some systems with OF display, such as 32-bit PPC Macintoshs, provide the system display's EDID data as node property in their DT. Exporting this information allows compositors to implement correct DPI and meaningful color management.

---
 drivers/gpu/drm/sysfb/drm_sysfb_helper.c | 29 ++++++++++++++++++++++++
 drivers/gpu/drm/sysfb/drm_sysfb_helper.h |  2 ++
 drivers/gpu/drm/sysfb/ofdrm.c            | 20 ++++++++++++++++
 3 files changed, 51 insertions(+)
drivers/gpu/drm/sysfb/drm_sysfb_helper.c +29 -0
index b48e06b25305..cb65c618f8d3 100644
@@ -9,6 +9,7 @@
 #include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_drv.h>
+#include <drm/drm_edid.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
@@ -281,10 +282,38 @@ EXPORT_SYMBOL(drm_sysfb_crtc_atomic_destroy_state);
  * Connector
  */
 
+static int drm_sysfb_get_edid_block(void *data, u8 *buf, unsigned int block, size_t len)
+{
+	const u8 *edid = data;
+	size_t off = block * EDID_LENGTH;
+	size_t end = off + len;
+
+	if (!edid)
+		return -1;
+	if (end > EDID_LENGTH)
+		return -1;
+	memcpy(buf, &edid[off], len);
+
+	return 0;
+}
+
 int drm_sysfb_connector_helper_get_modes(struct drm_connector *connector)
 {
 	struct drm_sysfb_device *sysfb = to_drm_sysfb_device(connector->dev);
+	const struct drm_edid *drm_edid;
+
+	if (sysfb->edid) {
+		drm_edid = drm_edid_read_custom(connector, drm_sysfb_get_edid_block,
+						(void *)sysfb->edid);
+		if (drm_edid) {
+			drm_edid_connector_update(connector, drm_edid);
+			drm_edid_free(drm_edid);
+		} else {
+			drm_edid_connector_update(connector, NULL);
+		}
+	}
 
+	/* Return the fixed mode even with EDID */
 	return drm_connector_helper_get_modes_fixed(connector, &sysfb->fb_mode);
 }
 EXPORT_SYMBOL(drm_sysfb_connector_helper_get_modes);
drivers/gpu/drm/sysfb/drm_sysfb_helper.h +2 -0
index 45e396bf74b7..3684bd0ef085 100644
@@ -24,6 +24,8 @@ struct drm_display_mode drm_sysfb_mode(unsigned int width,
 struct drm_sysfb_device {
 	struct drm_device dev;
 
+	const u8 *edid; /* can be NULL */
+
 	/* hardware settings */
 	struct drm_display_mode fb_mode;
 	const struct drm_format_info *fb_format;
drivers/gpu/drm/sysfb/ofdrm.c +20 -0
index 71e661ba9329..86c1a0c80ceb 100644
@@ -12,6 +12,7 @@
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_device.h>
 #include <drm/drm_drv.h>
+#include <drm/drm_edid.h>
 #include <drm/drm_fbdev_shmem.h>
 #include <drm/drm_format_helper.h>
 #include <drm/drm_framebuffer.h>
@@ -227,6 +228,16 @@ static u64 display_get_address_of(struct drm_device *dev, struct device_node *of
 	return address;
 }
 
+static const u8 *display_get_edid_of(struct drm_device *dev, struct device_node *of_node,
+				     u8 buf[EDID_LENGTH])
+{
+	int ret = of_property_read_u8_array(of_node, "EDID", buf, EDID_LENGTH);
+
+	if (ret)
+		return NULL;
+	return buf;
+}
+
 static bool is_avivo(u32 vendor, u32 device)
 {
 	/* This will match most R5xx */
@@ -298,6 +309,8 @@ struct ofdrm_device {
 	/* colormap */
 	void __iomem *cmap_base;
 
+	u8 edid[EDID_LENGTH];
+
 	/* modesetting */
 	u32 formats[DRM_SYSFB_PLANE_NFORMATS(1)];
 	struct drm_plane primary_plane;
@@ -840,6 +853,7 @@ static struct ofdrm_device *ofdrm_device_create(struct drm_driver *drv,
 	int width, height, depth, linebytes;
 	const struct drm_format_info *format;
 	u64 address;
+	const u8 *edid;
 	resource_size_t fb_size, fb_base, fb_pgbase, fb_pgsize;
 	struct resource *res, *mem;
 	void __iomem *screen_base;
@@ -989,6 +1003,9 @@ static struct ofdrm_device *ofdrm_device_create(struct drm_driver *drv,
 		}
 	}
 
+	/* EDID is optional */
+	edid = display_get_edid_of(dev, of_node, odev->edid);
+
 	/*
 	 * Firmware framebuffer
 	 */
@@ -999,6 +1016,7 @@ static struct ofdrm_device *ofdrm_device_create(struct drm_driver *drv,
 	sysfb->fb_pitch = linebytes;
 	if (odev->cmap_base)
 		sysfb->fb_gamma_lut_size = OFDRM_GAMMA_LUT_SIZE;
+	sysfb->edid = edid;
 
 	drm_dbg(dev, "display mode={" DRM_MODE_FMT "}\n", DRM_MODE_ARG(&sysfb->fb_mode));
 	drm_dbg(dev, "framebuffer format=%p4cc, size=%dx%d, linebytes=%d byte\n",
@@ -1072,6 +1090,8 @@ static struct ofdrm_device *ofdrm_device_create(struct drm_driver *drv,
 	drm_connector_set_panel_orientation_with_quirk(connector,
 						       DRM_MODE_PANEL_ORIENTATION_UNKNOWN,
 						       width, height);
+	if (edid)
+		drm_connector_attach_edid_property(connector);
 
 	ret = drm_connector_attach_encoder(connector, encoder);
 	if (ret)
Signature · 1 line
2.48.1
#26 lore raw

Re: [PATCH 12/18] drm/sysfb: ofdrm: Add EDID support

Quoted 31 lines · Thomas Zimmermann

Add EDID support to sysfb connector helpers. Read the EDID property from the OF node in ofdrm. Without EDID, this does nothing.

Some systems with OF display, such as 32-bit PPC Macintoshs, provide the system display's EDID data as node property in their DT. Exporting this information allows compositors to implement correct DPI and meaningful color management.

---
 drivers/gpu/drm/sysfb/drm_sysfb_helper.c | 29 ++++++++++++++++++++++++
 drivers/gpu/drm/sysfb/drm_sysfb_helper.h |  2 ++
 drivers/gpu/drm/sysfb/ofdrm.c            | 20 ++++++++++++++++
 3 files changed, 51 insertions(+)
drivers/gpu/drm/sysfb/drm_sysfb_helper.c +1 -0
index b48e06b25305..cb65c618f8d3 100644
@@ -9,6 +9,7 @@
 #include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_drv.h>
+#include <drm/drm_edid.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
@@ -281,10 +282,38 @@ EXPORT_SYMBOL(drm_sysfb_crtc_atomic_destroy_state);
  * Connector
  */
 

drivers/gpu/drm/sysfb/drm_sysfb_helper.c EXPORT_SYMBOL(drm_sysfb_crtc_atomic_destroy_state); · line 294

Quoted 10 lines
drivers/gpu/drm/sysfb/drm_sysfb_helper.c +10 -0
+static int drm_sysfb_get_edid_block(void *data, u8 *buf, unsigned int block, size_t len)
+{
+	const u8 *edid = data;
+	size_t off = block * EDID_LENGTH;
+	size_t end = off + len;
+
+	if (!edid)
+		return -1;
+	if (end > EDID_LENGTH)
+		return -1;

Nitpick, I guess -1 is used elsewhere, but I think I'd prefer actual error codes even if they're not currently propagated. It's just cleaner.

drivers/gpu/drm/sysfb/drm_sysfb_helper.c EXPORT_SYMBOL(drm_sysfb_crtc_atomic_destroy_state); · line 307

Quoted 13 lines
drivers/gpu/drm/sysfb/drm_sysfb_helper.c +10 -0
+	memcpy(buf, &edid[off], len);
+
+	return 0;
+}
+
 int drm_sysfb_connector_helper_get_modes(struct drm_connector *connector)
 {
 	struct drm_sysfb_device *sysfb = to_drm_sysfb_device(connector->dev);
+	const struct drm_edid *drm_edid;
+
+	if (sysfb->edid) {
+		drm_edid = drm_edid_read_custom(connector, drm_sysfb_get_edid_block,
+						(void *)sysfb->edid);

Nitpick, the (void *) cast is superfluous.

drivers/gpu/drm/sysfb/drm_sysfb_helper.c EXPORT_SYMBOL(drm_sysfb_crtc_atomic_destroy_state); · line 313

Quoted 6 lines
drivers/gpu/drm/sysfb/drm_sysfb_helper.c +6 -0
+		if (drm_edid) {
+			drm_edid_connector_update(connector, drm_edid);
+			drm_edid_free(drm_edid);
+		} else {
+			drm_edid_connector_update(connector, NULL);
+		}

Nitpick, the above could just be

		drm_edid_connector_update(connector, drm_edid);
		drm_edid_free(drm_edid);

without the if.

Despite the nitpicks, overall LGTM.

BR,
Jani.

Quoted 92 lines
drivers/gpu/drm/sysfb/drm_sysfb_helper.c +2 -0
+	}
 
+	/* Return the fixed mode even with EDID */
 	return drm_connector_helper_get_modes_fixed(connector, &sysfb->fb_mode);
 }
 EXPORT_SYMBOL(drm_sysfb_connector_helper_get_modes);
drivers/gpu/drm/sysfb/drm_sysfb_helper.h +2 -0
index 45e396bf74b7..3684bd0ef085 100644
@@ -24,6 +24,8 @@ struct drm_display_mode drm_sysfb_mode(unsigned int width,
 struct drm_sysfb_device {
 	struct drm_device dev;
 
+	const u8 *edid; /* can be NULL */
+
 	/* hardware settings */
 	struct drm_display_mode fb_mode;
 	const struct drm_format_info *fb_format;
drivers/gpu/drm/sysfb/ofdrm.c +20 -0
index 71e661ba9329..86c1a0c80ceb 100644
@@ -12,6 +12,7 @@
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_device.h>
 #include <drm/drm_drv.h>
+#include <drm/drm_edid.h>
 #include <drm/drm_fbdev_shmem.h>
 #include <drm/drm_format_helper.h>
 #include <drm/drm_framebuffer.h>
@@ -227,6 +228,16 @@ static u64 display_get_address_of(struct drm_device *dev, struct device_node *of
 	return address;
 }
 
+static const u8 *display_get_edid_of(struct drm_device *dev, struct device_node *of_node,
+				     u8 buf[EDID_LENGTH])
+{
+	int ret = of_property_read_u8_array(of_node, "EDID", buf, EDID_LENGTH);
+
+	if (ret)
+		return NULL;
+	return buf;
+}
+
 static bool is_avivo(u32 vendor, u32 device)
 {
 	/* This will match most R5xx */
@@ -298,6 +309,8 @@ struct ofdrm_device {
 	/* colormap */
 	void __iomem *cmap_base;
 
+	u8 edid[EDID_LENGTH];
+
 	/* modesetting */
 	u32 formats[DRM_SYSFB_PLANE_NFORMATS(1)];
 	struct drm_plane primary_plane;
@@ -840,6 +853,7 @@ static struct ofdrm_device *ofdrm_device_create(struct drm_driver *drv,
 	int width, height, depth, linebytes;
 	const struct drm_format_info *format;
 	u64 address;
+	const u8 *edid;
 	resource_size_t fb_size, fb_base, fb_pgbase, fb_pgsize;
 	struct resource *res, *mem;
 	void __iomem *screen_base;
@@ -989,6 +1003,9 @@ static struct ofdrm_device *ofdrm_device_create(struct drm_driver *drv,
 		}
 	}
 
+	/* EDID is optional */
+	edid = display_get_edid_of(dev, of_node, odev->edid);
+
 	/*
 	 * Firmware framebuffer
 	 */
@@ -999,6 +1016,7 @@ static struct ofdrm_device *ofdrm_device_create(struct drm_driver *drv,
 	sysfb->fb_pitch = linebytes;
 	if (odev->cmap_base)
 		sysfb->fb_gamma_lut_size = OFDRM_GAMMA_LUT_SIZE;
+	sysfb->edid = edid;
 
 	drm_dbg(dev, "display mode={" DRM_MODE_FMT "}\n", DRM_MODE_ARG(&sysfb->fb_mode));
 	drm_dbg(dev, "framebuffer format=%p4cc, size=%dx%d, linebytes=%d byte\n",
@@ -1072,6 +1090,8 @@ static struct ofdrm_device *ofdrm_device_create(struct drm_driver *drv,
 	drm_connector_set_panel_orientation_with_quirk(connector,
 						       DRM_MODE_PANEL_ORIENTATION_UNKNOWN,
 						       width, height);
+	if (edid)
+		drm_connector_attach_edid_property(connector);
 
 	ret = drm_connector_attach_encoder(connector, encoder);
 	if (ret)
Signature · 1 line
Jani Nikula, Intel
author maintainer
#27 lore raw

Re: [PATCH 12/18] drm/sysfb: ofdrm: Add EDID support

Hi

Am 20.03.25 um 13:50 schrieb Jani Nikula:

Quoted 32 lines · Thomas Zimmermann
Quoted 31 lines

Add EDID support to sysfb connector helpers. Read the EDID property from the OF node in ofdrm. Without EDID, this does nothing.

Some systems with OF display, such as 32-bit PPC Macintoshs, provide the system display's EDID data as node property in their DT. Exporting this information allows compositors to implement correct DPI and meaningful color management.

---
  drivers/gpu/drm/sysfb/drm_sysfb_helper.c | 29 ++++++++++++++++++++++++
  drivers/gpu/drm/sysfb/drm_sysfb_helper.h |  2 ++
  drivers/gpu/drm/sysfb/ofdrm.c            | 20 ++++++++++++++++
  3 files changed, 51 insertions(+)
drivers/gpu/drm/sysfb/drm_sysfb_helper.c +1 -0
index b48e06b25305..cb65c618f8d3 100644
@@ -9,6 +9,7 @@
  #include <drm/drm_atomic_state_helper.h>
  #include <drm/drm_damage_helper.h>
  #include <drm/drm_drv.h>
+#include <drm/drm_edid.h>
  #include <drm/drm_fourcc.h>
  #include <drm/drm_framebuffer.h>
  #include <drm/drm_gem_atomic_helper.h>
@@ -281,10 +282,38 @@ EXPORT_SYMBOL(drm_sysfb_crtc_atomic_destroy_state);
   * Connector
   */
 
Quoted 12 lines

drivers/gpu/drm/sysfb/drm_sysfb_helper.c EXPORT_SYMBOL(drm_sysfb_crtc_atomic_destroy_state); · line 294

Quoted 10 lines
drivers/gpu/drm/sysfb/drm_sysfb_helper.c +10 -0
+static int drm_sysfb_get_edid_block(void *data, u8 *buf, unsigned int block, size_t len)
+{
+	const u8 *edid = data;
+	size_t off = block * EDID_LENGTH;
+	size_t end = off + len;
+
+	if (!edid)
+		return -1;
+	if (end > EDID_LENGTH)
+		return -1;

Nitpick, I guess -1 is used elsewhere, but I think I'd prefer actual error codes even if they're not currently propagated. It's just cleaner.

Sure. Somehow I was under the impression that errno codes wouldn't be welcome here.

Quoted 15 lines
Quoted 4 lines
drivers/gpu/drm/sysfb/drm_sysfb_helper.c +3 -0
+	memcpy(buf, &edid[off], len);
+
+	return 0;

drivers/gpu/drm/sysfb/drm_sysfb_helper.c EXPORT_SYMBOL(drm_sysfb_crtc_atomic_destroy_state); · line 307

Quoted 10 lines
drivers/gpu/drm/sysfb/drm_sysfb_helper.c +7 -0
+}
+
  int drm_sysfb_connector_helper_get_modes(struct drm_connector *connector)
  {
  	struct drm_sysfb_device *sysfb = to_drm_sysfb_device(connector->dev);
+	const struct drm_edid *drm_edid;
+
+	if (sysfb->edid) {
+		drm_edid = drm_edid_read_custom(connector, drm_sysfb_get_edid_block,
+						(void *)sysfb->edid);

Nitpick, the (void *) cast is superfluous.

This is a const cast.

Quoted 9 lines

drivers/gpu/drm/sysfb/drm_sysfb_helper.c EXPORT_SYMBOL(drm_sysfb_crtc_atomic_destroy_state); · line 313

Quoted 7 lines
drivers/gpu/drm/sysfb/drm_sysfb_helper.c +6 -0
+		if (drm_edid) {
+			drm_edid_connector_update(connector, drm_edid);
+			drm_edid_free(drm_edid);
+		} else {
+			drm_edid_connector_update(connector, NULL);
+		}

Nitpick, the above could just be

Quoted 4 lines
		drm_edid_connector_update(connector, drm_edid);
		drm_edid_free(drm_edid);

without the if.

Make sense.

Quoted 3 lines

Despite the nitpicks, overall LGTM.

Thanks for reviewing.

Since I have your attention and you're knowledgeable wrt EDID: byte 20 of the EDID header indicates the type of output (analog, HDMI, DP, etc). I intent to use this for setting the connector type to something better then UNKNOWN. Does that make sense?

Best regards
Thomas

Quoted 97 lines

BR,
Jani.

Quoted 92 lines
drivers/gpu/drm/sysfb/drm_sysfb_helper.c +2 -0
+	}
 
+	/* Return the fixed mode even with EDID */
  	return drm_connector_helper_get_modes_fixed(connector, &sysfb->fb_mode);
  }
  EXPORT_SYMBOL(drm_sysfb_connector_helper_get_modes);
drivers/gpu/drm/sysfb/drm_sysfb_helper.h +2 -0
index 45e396bf74b7..3684bd0ef085 100644
@@ -24,6 +24,8 @@ struct drm_display_mode drm_sysfb_mode(unsigned int width,
  struct drm_sysfb_device {
  	struct drm_device dev;
 
+	const u8 *edid; /* can be NULL */
+
  	/* hardware settings */
  	struct drm_display_mode fb_mode;
  	const struct drm_format_info *fb_format;
drivers/gpu/drm/sysfb/ofdrm.c +20 -0
index 71e661ba9329..86c1a0c80ceb 100644
@@ -12,6 +12,7 @@
  #include <drm/drm_damage_helper.h>
  #include <drm/drm_device.h>
  #include <drm/drm_drv.h>
+#include <drm/drm_edid.h>
  #include <drm/drm_fbdev_shmem.h>
  #include <drm/drm_format_helper.h>
  #include <drm/drm_framebuffer.h>
@@ -227,6 +228,16 @@ static u64 display_get_address_of(struct drm_device *dev, struct device_node *of
  	return address;
  }
 
+static const u8 *display_get_edid_of(struct drm_device *dev, struct device_node *of_node,
+				     u8 buf[EDID_LENGTH])
+{
+	int ret = of_property_read_u8_array(of_node, "EDID", buf, EDID_LENGTH);
+
+	if (ret)
+		return NULL;
+	return buf;
+}
+
  static bool is_avivo(u32 vendor, u32 device)
  {
  	/* This will match most R5xx */
@@ -298,6 +309,8 @@ struct ofdrm_device {
  	/* colormap */
  	void __iomem *cmap_base;
 
+	u8 edid[EDID_LENGTH];
+
  	/* modesetting */
  	u32 formats[DRM_SYSFB_PLANE_NFORMATS(1)];
  	struct drm_plane primary_plane;
@@ -840,6 +853,7 @@ static struct ofdrm_device *ofdrm_device_create(struct drm_driver *drv,
  	int width, height, depth, linebytes;
  	const struct drm_format_info *format;
  	u64 address;
+	const u8 *edid;
  	resource_size_t fb_size, fb_base, fb_pgbase, fb_pgsize;
  	struct resource *res, *mem;
  	void __iomem *screen_base;
@@ -989,6 +1003,9 @@ static struct ofdrm_device *ofdrm_device_create(struct drm_driver *drv,
  		}
  	}
 
+	/* EDID is optional */
+	edid = display_get_edid_of(dev, of_node, odev->edid);
+
  	/*
  	 * Firmware framebuffer
  	 */
@@ -999,6 +1016,7 @@ static struct ofdrm_device *ofdrm_device_create(struct drm_driver *drv,
  	sysfb->fb_pitch = linebytes;
  	if (odev->cmap_base)
  		sysfb->fb_gamma_lut_size = OFDRM_GAMMA_LUT_SIZE;
+	sysfb->edid = edid;
 
  	drm_dbg(dev, "display mode={" DRM_MODE_FMT "}\n", DRM_MODE_ARG(&sysfb->fb_mode));
  	drm_dbg(dev, "framebuffer format=%p4cc, size=%dx%d, linebytes=%d byte\n",
@@ -1072,6 +1090,8 @@ static struct ofdrm_device *ofdrm_device_create(struct drm_driver *drv,
  	drm_connector_set_panel_orientation_with_quirk(connector,
  						       DRM_MODE_PANEL_ORIENTATION_UNKNOWN,
  						       width, height);
+	if (edid)
+		drm_connector_attach_edid_property(connector);
 
  	ret = drm_connector_attach_encoder(connector, encoder);
  	if (ret)
Signature · 7 lines
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
maintainer
#28 lore raw

Re: [PATCH 12/18] drm/sysfb: ofdrm: Add EDID support

Quoted 8 lines · Thomas Zimmermann
Quoted 1 line

Despite the nitpicks, overall LGTM.

Thanks for reviewing.

Since I have your attention and you're knowledgeable wrt EDID: byte 20 of the EDID header indicates the type of output (analog, HDMI, DP, etc). I intent to use this for setting the connector type to something better then UNKNOWN. Does that make sense?

I don't think it would work:

- EDID doesn't indicate the kind of KMS output (ie, source) but the type of sink. Ie, what the monitor is capable of dealing with, not what the connector can emit. If we have (passive or active) bridges in between, it does mean that we can have an analog sink connected to a digital connector.

- Since it depends on the sink, it can change over time, ie you plug an analog monitor, remove it, and plug a digital one. That would mean changing the connector type (and thus name exposed to userspace) at runtime, for the same driver.

- Since it depends on the sink, it assumes the sink vendor didn't botch the EDID. This one is a pretty big if :)

Maxime

author maintainer
#29 lore raw

Re: [PATCH 12/18] drm/sysfb: ofdrm: Add EDID support

Hi

Am 31.03.25 um 11:26 schrieb Maxime Ripard:

Quoted 16 lines · Thomas Zimmermann
Quoted 7 lines
Quoted 1 line

Despite the nitpicks, overall LGTM.

Thanks for reviewing.

Since I have your attention and you're knowledgeable wrt EDID: byte 20 of the EDID header indicates the type of output (analog, HDMI, DP, etc). I intent to use this for setting the connector type to something better then UNKNOWN. Does that make sense?

I don't think it would work:

- EDID doesn't indicate the kind of KMS output (ie, source) but the type of sink. Ie, what the monitor is capable of dealing with, not what the connector can emit. If we have (passive or active) bridges in between, it does mean that we can have an analog sink connected to a digital connector.

Quoted 7 lines

- Since it depends on the sink, it can change over time, ie you plug an analog monitor, remove it, and plug a digital one. That would mean changing the connector type (and thus name exposed to userspace) at runtime, for the same driver.

- Since it depends on the sink, it assumes the sink vendor didn't botch the EDID. This one is a pretty big if :)

I see. I'd really just want this for these sysfb outputs that come from the firmware. They should not change much at runtime.  Right now, the connector is always UNKNOWN and giving some type would indicate to the user which display is in use. But it's not really so important.

Best regards
Thomas

Quoted 2 lines

Maxime

Signature · 7 lines
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
maintainer Reviewed-by on v1 12/18
#30 lore raw

Re: [PATCH 12/18] drm/sysfb: ofdrm: Add EDID support

In reply to Thomas Zimmermann
Quoted 10 lines · Thomas Zimmermann

Add EDID support to sysfb connector helpers. Read the EDID property from the OF node in ofdrm. Without EDID, this does nothing.

Some systems with OF display, such as 32-bit PPC Macintoshs, provide the system display's EDID data as node property in their DT. Exporting this information allows compositors to implement correct DPI and meaningful color management.

---

Signature · 5 lines
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat
author maintainer
#31 lore raw

PATCH 13/18 firmware: sysfb: Move bpp-depth calculation into screen_info helper

In reply to Thomas Zimmermann

Move the calculation of the bits per pixels for screen_info into a helper function. This will make it available to other callers besides the firmware code.

---
 drivers/firmware/sysfb_simplefb.c   | 31 +------------------------
 drivers/video/screen_info_generic.c | 36 +++++++++++++++++++++++++++++
 include/linux/screen_info.h         |  2 ++
 3 files changed, 39 insertions(+), 30 deletions(-)
drivers/firmware/sysfb_simplefb.c +1 -30
index 75a186bf8f8e..592d8a644619 100644
@@ -35,36 +35,7 @@ __init bool sysfb_parse_mode(const struct screen_info *si,
 	if (type != VIDEO_TYPE_VLFB && type != VIDEO_TYPE_EFI)
 		return false;
 
-	/*
-	 * The meaning of depth and bpp for direct-color formats is
-	 * inconsistent:
-	 *
-	 *  - DRM format info specifies depth as the number of color
-	 *    bits; including alpha, but not including filler bits.
-	 *  - Linux' EFI platform code computes lfb_depth from the
-	 *    individual color channels, including the reserved bits.
-	 *  - VBE 1.1 defines lfb_depth for XRGB1555 as 16, but later
-	 *    versions use 15.
-	 *  - On the kernel command line, 'bpp' of 32 is usually
-	 *    XRGB8888 including the filler bits, but 15 is XRGB1555
-	 *    not including the filler bit.
-	 *
-	 * It's not easily possible to fix this in struct screen_info,
-	 * as this could break UAPI. The best solution is to compute
-	 * bits_per_pixel from the color bits, reserved bits and
-	 * reported lfb_depth, whichever is highest.  In the loop below,
-	 * ignore simplefb formats with alpha bits, as EFI and VESA
-	 * don't specify alpha channels.
-	 */
-	if (si->lfb_depth > 8) {
-		bits_per_pixel = max(max3(si->red_size + si->red_pos,
-					  si->green_size + si->green_pos,
-					  si->blue_size + si->blue_pos),
-				     si->rsvd_size + si->rsvd_pos);
-		bits_per_pixel = max_t(u32, bits_per_pixel, si->lfb_depth);
-	} else {
-		bits_per_pixel = si->lfb_depth;
-	}
+	bits_per_pixel = __screen_info_lfb_bits_per_pixel(si);
 
 	for (i = 0; i < ARRAY_SIZE(formats); ++i) {
 		const struct simplefb_format *f = &formats[i];
drivers/video/screen_info_generic.c +36 -0
index 64117c6367ab..900e9386eceb 100644
@@ -144,3 +144,39 @@ ssize_t screen_info_resources(const struct screen_info *si, struct resource *r,
 	return pos - r;
 }
 EXPORT_SYMBOL(screen_info_resources);
+
+/*
+ * The meaning of depth and bpp for direct-color formats is
+ * inconsistent:
+ *
+ *  - DRM format info specifies depth as the number of color
+ *    bits; including alpha, but not including filler bits.
+ *  - Linux' EFI platform code computes lfb_depth from the
+ *    individual color channels, including the reserved bits.
+ *  - VBE 1.1 defines lfb_depth for XRGB1555 as 16, but later
+ *    versions use 15.
+ *  - On the kernel command line, 'bpp' of 32 is usually
+ *    XRGB8888 including the filler bits, but 15 is XRGB1555
+ *    not including the filler bit.
+ *
+ * It is not easily possible to fix this in struct screen_info,
+ * as this could break UAPI. The best solution is to compute
+ * bits_per_pixel from the color bits, reserved bits and
+ * reported lfb_depth, whichever is highest.
+ */
+
+u32 __screen_info_lfb_bits_per_pixel(const struct screen_info *si)
+{
+	u32 bits_per_pixel = si->lfb_depth;
+
+	if (bits_per_pixel > 8) {
+		bits_per_pixel = max(max3(si->red_size + si->red_pos,
+					  si->green_size + si->green_pos,
+					  si->blue_size + si->blue_pos),
+				     si->rsvd_size + si->rsvd_pos);
+		bits_per_pixel = max_t(u32, bits_per_pixel, si->lfb_depth);
+	}
+
+	return bits_per_pixel;
+}
+EXPORT_SYMBOL(__screen_info_lfb_bits_per_pixel);
include/linux/screen_info.h +2 -0
index 6a4a3cec4638..ab3cffbb58b7 100644
@@ -128,6 +128,8 @@ static inline unsigned int screen_info_video_type(const struct screen_info *si)
 
 ssize_t screen_info_resources(const struct screen_info *si, struct resource *r, size_t num);
 
+u32 __screen_info_lfb_bits_per_pixel(const struct screen_info *si);
+
 #if defined(CONFIG_PCI)
 void screen_info_apply_fixups(void);
 struct pci_dev *screen_info_pci_dev(const struct screen_info *si);
Signature · 1 line
2.48.1
maintainer Reviewed-by on v1 13/18
#32 lore raw

Re: [PATCH 13/18] firmware: sysfb: Move bpp-depth calculation into screen_info helper

Quoted 6 lines · Thomas Zimmermann

Move the calculation of the bits per pixels for screen_info into a helper function. This will make it available to other callers besides the firmware code.

---

Signature · 5 lines
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat
author maintainer
#33 lore raw

PATCH 14/18 drm/sysfb: Add efidrm for EFI displays

In reply to Thomas Zimmermann

Add support for screen_info setups with VIDEO_TYPE_EFI. Provide the minimum functionality of reading modes, updating and clearing the display.

There is existing support for these displays provided by simpledrm with CONFIG_SYSFB_SIMPLEFB=y. Using efidrm over simpledrm will allows for the mapping of video memory with correct caching. Simpledrm always assumes WC caching, while fully cached memory is possible with efidrm. Efidrm will also allow for the use of additional functionality provided by EFI, such as EDID information.

In addition to efidrm, add struct pixel_format plus initializer macros. The type and macros describe pixel formats in a generic way on order to find the DRM format from the screen_info settings. Similar existing code in SIMPLEFB_FORMATS and fbdev is not really what is needed in efidrm, but SIMPLEFB_FORMATS can later be converted to struct pixel_format.

---
 drivers/gpu/drm/sysfb/Kconfig  |  16 ++
 drivers/gpu/drm/sysfb/Makefile |   1 +
 drivers/gpu/drm/sysfb/efidrm.c | 487 +++++++++++++++++++++++++++++++++
 include/video/pixel_format.h   |  41 +++
 4 files changed, 545 insertions(+)
 create mode 100644 drivers/gpu/drm/sysfb/efidrm.c
 create mode 100644 include/video/pixel_format.h
drivers/gpu/drm/sysfb/Kconfig +16 -0
index 87094da417f6..3ffd8da1224c 100644
@@ -7,6 +7,22 @@ config DRM_SYSFB_HELPER
 	tristate
 	depends on DRM
 
+config DRM_EFIDRM
+	tristate "EFI framebuffer driver"
+	depends on DRM && MMU
+	select APERTURE_HELPERS
+	select DRM_CLIENT_SELECTION
+	select DRM_GEM_SHMEM_HELPER
+	select DRM_KMS_HELPER
+	select DRM_SYSFB_HELPER
+	select SYSFB
+	help
+	  DRM driver for EFI framebuffers.
+
+	  This driver assumes that the display hardware has been initialized
+	  by the firmware or bootloader before the kernel boots. Scanout
+	  buffer, size, and display format must be provided via EFI interfaces.
+
 config DRM_OFDRM
 	tristate "Open Firmware display driver"
 	depends on DRM && MMU && OF && (PPC || COMPILE_TEST)
drivers/gpu/drm/sysfb/Makefile +1 -0
index f1e8700c3e35..2f96f52842e6 100644
@@ -2,5 +2,6 @@
 
 obj-$(CONFIG_DRM_SYSFB_HELPER)	+= drm_sysfb_helper.o
 
+obj-$(CONFIG_DRM_EFIDRM)	+= efidrm.o
 obj-$(CONFIG_DRM_OFDRM)		+= ofdrm.o
 obj-$(CONFIG_DRM_SIMPLEDRM)	+= simpledrm.o
drivers/gpu/drm/sysfb/efidrm.c new file +487 -0

487 lines not on this page · raw message

include/video/pixel_format.h new file +41 -0

41 lines not on this page · raw message

Signature · 1 line
2.48.1
maintainer Reviewed-by on v1 14/18
#34 lore raw

Re: [PATCH 14/18] drm/sysfb: Add efidrm for EFI displays

Quoted 10 lines · Thomas Zimmermann

Add support for screen_info setups with VIDEO_TYPE_EFI. Provide the minimum functionality of reading modes, updating and clearing the display.

There is existing support for these displays provided by simpledrm with CONFIG_SYSFB_SIMPLEFB=y. Using efidrm over simpledrm will allows for the mapping of video memory with correct caching. Simpledrm always assumes WC caching, while fully cached memory is possible with efidrm. Efidrm will also allow for the use of additional functionality provided by EFI, such as EDID information.

Quoted 8 lines

In addition to efidrm, add struct pixel_format plus initializer macros. The type and macros describe pixel formats in a generic way on order to find the DRM format from the screen_info settings. Similar existing code in SIMPLEFB_FORMATS and fbdev is not really what is needed in efidrm, but SIMPLEFB_FORMATS can later be converted to struct pixel_format.

---

Signature · 5 lines
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat
author maintainer
#35 lore raw

PATCH 15/18 drm/sysfb: efidrm: Add EDID support

In reply to Thomas Zimmermann

Enable the connector's EDID property if edid_info contains valid data. Exports the EDID via sysfs for user-space compositors.

EDID information is not always available. Depending on the system and kernel configuration, it is either provided by the boot loader or read by the kernel during early boot stages.

As of now, there's only one EFI display, so that EDID data always belongs to this output. This might change if there's ever more than one EFI display in the system.

---
 drivers/gpu/drm/sysfb/efidrm.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/gpu/drm/sysfb/efidrm.c +8 -0
index 5c1876e34a04..af90064a4c04 100644
@@ -13,6 +13,7 @@
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_device.h>
 #include <drm/drm_drv.h>
+#include <drm/drm_edid.h>
 #include <drm/drm_fbdev_shmem.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
@@ -22,6 +23,7 @@
 #include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 
+#include <video/edid.h>
 #include <video/pixel_format.h>
 
 #include "drm_sysfb_helper.h"
@@ -308,6 +310,10 @@ static struct efidrm_device *efidrm_device_create(struct drm_driver *drv,
 	drm_dbg(dev, "framebuffer format=%p4cc, size=%dx%d, stride=%d bytes\n",
 		&format->format, width, height, stride);
 
+#ifdef CONFIG_X86
+	if (drm_edid_header_is_valid(edid_info.dummy) == 8)
+		sysfb->edid = edid_info.dummy;
+#endif
 	sysfb->fb_mode = drm_sysfb_mode(width, height, 0, 0);
 	sysfb->fb_format = format;
 	sysfb->fb_pitch = stride;
@@ -413,6 +419,8 @@ static struct efidrm_device *efidrm_device_create(struct drm_driver *drv,
 	drm_connector_set_panel_orientation_with_quirk(connector,
 						       DRM_MODE_PANEL_ORIENTATION_UNKNOWN,
 						       width, height);
+	if (sysfb->edid)
+		drm_connector_attach_edid_property(connector);
 
 	ret = drm_connector_attach_encoder(connector, encoder);
 	if (ret)
Signature · 1 line
2.48.1
maintainer Reviewed-by on v1 15/18
#36 lore raw

Re: [PATCH 15/18] drm/sysfb: efidrm: Add EDID support

Quoted 7 lines · Thomas Zimmermann

Enable the connector's EDID property if edid_info contains valid data. Exports the EDID via sysfs for user-space compositors.

EDID information is not always available. Depending on the system and kernel configuration, it is either provided by the boot loader or read by the kernel during early boot stages.

Quoted 6 lines

As of now, there's only one EFI display, so that EDID data always belongs to this output. This might change if there's ever more than one EFI display in the system.

---

Signature · 5 lines
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat
author maintainer
#37 lore raw

PATCH 16/18 drm/sysfb: Add vesadrm for VESA displays

In reply to Thomas Zimmermann

Add support for screen_info setups with VIDEO_TYPE_VLFB. Provide the minimum functionality of reading modes, updating and clearing the display.

There is existing support for these displays provided by simpledrm with CONFIG_SYSFB_SIMPLEFB=y. Using vesadrm over simpledrm will allow for the use of additional functionality provided by VESA, such as EDID information, gamma correction and palette modes. This enhances the user experience and adds support for more display configuratons.

---
 drivers/gpu/drm/sysfb/Kconfig   |  16 ++
 drivers/gpu/drm/sysfb/Makefile  |   1 +
 drivers/gpu/drm/sysfb/vesadrm.c | 448 ++++++++++++++++++++++++++++++++
 3 files changed, 465 insertions(+)
 create mode 100644 drivers/gpu/drm/sysfb/vesadrm.c
drivers/gpu/drm/sysfb/Kconfig +16 -0
index 3ffd8da1224c..008c33eab99a 100644
@@ -57,4 +57,20 @@ config DRM_SIMPLEDRM
 	  On x86 BIOS or UEFI systems, you should also select SYSFB_SIMPLEFB
 	  to use UEFI and VESA framebuffers.
 
+config DRM_VESADRM
+	tristate "VESA framebuffer driver"
+	depends on DRM && MMU
+	select APERTURE_HELPERS
+	select DRM_CLIENT_SELECTION
+	select DRM_GEM_SHMEM_HELPER
+	select DRM_KMS_HELPER
+	select DRM_SYSFB_HELPER
+	select SYSFB
+	help
+	  DRM driver for VESA framebuffers.
+
+	  This driver assumes that the display hardware has been initialized
+	  by the firmware or bootloader before the kernel boots. Scanout
+	  buffer, size, and display format must be provided via VBE interfaces.
+
 endmenu
drivers/gpu/drm/sysfb/Makefile +1 -0
index 2f96f52842e6..0d2518c97163 100644
@@ -5,3 +5,4 @@ obj-$(CONFIG_DRM_SYSFB_HELPER)	+= drm_sysfb_helper.o
 obj-$(CONFIG_DRM_EFIDRM)	+= efidrm.o
 obj-$(CONFIG_DRM_OFDRM)		+= ofdrm.o
 obj-$(CONFIG_DRM_SIMPLEDRM)	+= simpledrm.o
+obj-$(CONFIG_DRM_VESADRM)	+= vesadrm.o
drivers/gpu/drm/sysfb/vesadrm.c new file +448 -0

448 lines not on this page · raw message

Signature · 1 line
2.48.1
maintainer Reviewed-by on v1 16/18
#38 lore raw

Re: [PATCH 16/18] drm/sysfb: Add vesadrm for VESA displays

Quoted 11 lines · Thomas Zimmermann

Add support for screen_info setups with VIDEO_TYPE_VLFB. Provide the minimum functionality of reading modes, updating and clearing the display.

There is existing support for these displays provided by simpledrm with CONFIG_SYSFB_SIMPLEFB=y. Using vesadrm over simpledrm will allow for the use of additional functionality provided by VESA, such as EDID information, gamma correction and palette modes. This enhances the user experience and adds support for more display configuratons.

---

Signature · 5 lines
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat
author maintainer
#39 lore raw

PATCH 17/18 drm/sysfb: vesadrm: Add EDID support

In reply to Thomas Zimmermann

Enable the connector's EDID property if edid_info contains valid data. Exports the EDID via sysfs for user-space compositors.

EDID information is not always available. Depending on the system and kernel configuration, it is either provided by the boot loader or read by the kernel during early boot stages.

There's only one VESA display, so EDID data always belongs to this output.

---
 drivers/gpu/drm/sysfb/vesadrm.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/gpu/drm/sysfb/vesadrm.c +8 -0
index 8a963057ffec..07f59880ce0f 100644
@@ -13,6 +13,7 @@
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_device.h>
 #include <drm/drm_drv.h>
+#include <drm/drm_edid.h>
 #include <drm/drm_fbdev_shmem.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
@@ -22,6 +23,7 @@
 #include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 
+#include <video/edid.h>
 #include <video/pixel_format.h>
 
 #include "drm_sysfb_helper.h"
@@ -280,6 +282,10 @@ static struct vesadrm_device *vesadrm_device_create(struct drm_driver *drv,
 	drm_dbg(dev, "framebuffer format=%p4cc, size=%dx%d, stride=%d bytes\n",
 		&format->format, width, height, stride);
 
+#ifdef CONFIG_X86
+	if (drm_edid_header_is_valid(edid_info.dummy) == 8)
+		sysfb->edid = edid_info.dummy;
+#endif
 	sysfb->fb_mode = drm_sysfb_mode(width, height, 0, 0);
 	sysfb->fb_format = format;
 	sysfb->fb_pitch = stride;
@@ -374,6 +380,8 @@ static struct vesadrm_device *vesadrm_device_create(struct drm_driver *drv,
 	drm_connector_set_panel_orientation_with_quirk(connector,
 						       DRM_MODE_PANEL_ORIENTATION_UNKNOWN,
 						       width, height);
+	if (sysfb->edid)
+		drm_connector_attach_edid_property(connector);
 
 	ret = drm_connector_attach_encoder(connector, encoder);
 	if (ret)
Signature · 1 line
2.48.1
maintainer Reviewed-by on v1 17/18
#40 lore raw

Re: [PATCH 17/18] drm/sysfb: vesadrm: Add EDID support

Quoted 7 lines · Thomas Zimmermann

Enable the connector's EDID property if edid_info contains valid data. Exports the EDID via sysfs for user-space compositors.

EDID information is not always available. Depending on the system and kernel configuration, it is either provided by the boot loader or read by the kernel during early boot stages.

Quoted 5 lines

There's only one VESA display, so EDID data always belongs to this output.

---

Signature · 5 lines
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat
author maintainer
#41 lore raw

PATCH 18/18 drm/sysfb: vesadrm: Add gamma correction

In reply to Thomas Zimmermann

Add palette support and export GAMMA properties via sysfs. User-space compositors can use this interface for programming gamma ramps or night mode.

Vesadrm supports palette updates via VGA DAC registers or VESA palette calls. Up to 256 palette entries are available. Userspace always supplies gamma ramps of 256 entries. If the native color format does not match this because pixel component have less then 8 bits, vesadrm interpolates among the palette entries.

The code uses CamelCase style in a few places to match the VESA manuals.

---
 drivers/gpu/drm/sysfb/vesadrm.c | 204 ++++++++++++++++++++++++++++++++
 include/linux/screen_info.h     |   7 ++
 2 files changed, 211 insertions(+)
drivers/gpu/drm/sysfb/vesadrm.c +204 -0
index 07f59880ce0f..20cf867ad500 100644
@@ -25,6 +25,7 @@
 
 #include <video/edid.h>
 #include <video/pixel_format.h>
+#include <video/vga.h>
 
 #include "drm_sysfb_helper.h"
 
@@ -33,6 +34,8 @@
 #define DRIVER_MAJOR	1
 #define DRIVER_MINOR	0
 
+#define VESADRM_GAMMA_LUT_SIZE 256
+
 static int vesadrm_get_validated_int(struct drm_device *dev, const char *name,
 				     u64 value, u32 max)
 {
@@ -162,6 +165,14 @@ static const struct drm_format_info *vesadrm_get_format_si(struct drm_device *de
 struct vesadrm_device {
 	struct drm_sysfb_device sysfb;
 
+	/* VESA Protected Mode interface */
+	struct {
+		const u8 *PrimaryPalette;
+	} pmi;
+
+	void (*cmap_write)(struct vesadrm_device *vesa, unsigned int index,
+			   u16 red, u16 green, u16 blue);
+
 	/* modesetting */
 	u32 formats[DRM_SYSFB_PLANE_NFORMATS(1)];
 	struct drm_plane primary_plane;
@@ -170,6 +181,151 @@ struct vesadrm_device {
 	struct drm_connector connector;
 };
 
+static struct vesadrm_device *to_vesadrm_device(struct drm_device *dev)
+{
+	return container_of(to_drm_sysfb_device(dev), struct vesadrm_device, sysfb);
+}
+
+/*
+ * Palette
+ */
+
+static void vesadrm_vga_cmap_write(struct vesadrm_device *vesa, unsigned int index,
+				   u16 red, u16 green, u16 blue)
+{
+	u8 i8, r8, g8, b8;
+
+	if (index > 255)
+		return;
+
+	i8 = index;
+	r8 = red >> 8;
+	g8 = green >> 8;
+	b8 = blue >> 8;
+
+	outb_p(i8, VGA_PEL_IW);
+	outb_p(r8, VGA_PEL_D);
+	outb_p(g8, VGA_PEL_D);
+	outb_p(b8, VGA_PEL_D);
+}
+
+#ifdef __i386__
+static void vesadrm_pmi_cmap_write(struct vesadrm_device *vesa, unsigned int index,
+				   u16 red, u16 green, u16 blue)
+{
+	u32 i32 = index;
+	struct {
+		u8 b8;
+		u8 g8;
+		u8 r8;
+		u8 x8;
+	} PaletteEntry = {
+		blue >> 8,
+		green >> 8,
+		red >> 8,
+		0x00,
+	};
+
+	if (index > 255)
+		return;
+
+	__asm__ __volatile__(
+		"call *(%%esi)"
+		: /* no return value */
+		: "a" (0x4f09),
+		  "b" (0),
+		  "c" (1),
+		  "d" (i32),
+		  "D" (&PaletteEntry),
+		  "S" (&vesa->pmi.PrimaryPalette));
+}
+#endif
+
+static void vesadrm_set_gamma_linear(struct vesadrm_device *vesa,
+				     const struct drm_format_info *format)
+{
+	struct drm_device *dev = &vesa->sysfb.dev;
+	size_t i;
+	u16 r16, g16, b16;
+
+	switch (format->format) {
+	case DRM_FORMAT_XRGB1555:
+		for (i = 0; i < 32; ++i) {
+			r16 = i * 8 + i / 4;
+			r16 |= (r16 << 8) | r16;
+			vesa->cmap_write(vesa, i, r16, r16, r16);
+		}
+		break;
+	case DRM_FORMAT_RGB565:
+		for (i = 0; i < 32; ++i) {
+			r16 = i * 8 + i / 4;
+			r16 |= (r16 << 8) | r16;
+			g16 = i * 4 + i / 16;
+			g16 |= (g16 << 8) | g16;
+			b16 = r16;
+			vesa->cmap_write(vesa, i, r16, g16, b16);
+		}
+		for (i = 32; i < 64; ++i) {
+			g16 = i * 4 + i / 16;
+			g16 |= (g16 << 8) | g16;
+			vesa->cmap_write(vesa, i, 0, g16, 0);
+		}
+		break;
+	case DRM_FORMAT_RGB888:
+	case DRM_FORMAT_XRGB8888:
+	case DRM_FORMAT_BGRX8888:
+		for (i = 0; i < 256; ++i) {
+			r16 = (i << 8) | i;
+			vesa->cmap_write(vesa, i, r16, r16, r16);
+		}
+		break;
+	default:
+		drm_warn_once(dev, "Unsupported format %p4cc for gamma correction\n",
+			      &format->format);
+		break;
+	}
+}
+
+static void vesadrm_set_gamma_lut(struct vesadrm_device *vesa,
+				  const struct drm_format_info *format,
+				  struct drm_color_lut *lut)
+{
+	struct drm_device *dev = &vesa->sysfb.dev;
+	size_t i;
+	u16 r16, g16, b16;
+
+	switch (format->format) {
+	case DRM_FORMAT_XRGB1555:
+		for (i = 0; i < 32; ++i) {
+			r16 = lut[i * 8 + i / 4].red;
+			g16 = lut[i * 8 + i / 4].green;
+			b16 = lut[i * 8 + i / 4].blue;
+			vesa->cmap_write(vesa, i, r16, g16, b16);
+		}
+		break;
+	case DRM_FORMAT_RGB565:
+		for (i = 0; i < 32; ++i) {
+			r16 = lut[i * 8 + i / 4].red;
+			g16 = lut[i * 4 + i / 16].green;
+			b16 = lut[i * 8 + i / 4].blue;
+			vesa->cmap_write(vesa, i, r16, g16, b16);
+		}
+		for (i = 32; i < 64; ++i)
+			vesa->cmap_write(vesa, i, 0, lut[i * 4 + i / 16].green, 0);
+		break;
+	case DRM_FORMAT_RGB888:
+	case DRM_FORMAT_XRGB8888:
+	case DRM_FORMAT_BGRX8888:
+		for (i = 0; i < 256; ++i)
+			vesa->cmap_write(vesa, i, lut[i].red, lut[i].green, lut[i].blue);
+		break;
+	default:
+		drm_warn_once(dev, "Unsupported format %p4cc for gamma correction\n",
+			      &format->format);
+		break;
+	}
+}
+
 /*
  * Modesetting
  */
@@ -187,8 +343,36 @@ static const struct drm_plane_funcs vesadrm_primary_plane_funcs = {
 	.destroy = drm_plane_cleanup,
 };
 
+static void vesadrm_crtc_helper_atomic_flush(struct drm_crtc *crtc,
+					     struct drm_atomic_state *state)
+{
+	struct drm_device *dev = crtc->dev;
+	struct drm_sysfb_device *sysfb = to_drm_sysfb_device(dev);
+	struct vesadrm_device *vesa = to_vesadrm_device(dev);
+	struct drm_crtc_state *crtc_state = drm_atomic_get_new_crtc_state(state, crtc);
+	struct drm_sysfb_crtc_state *sysfb_crtc_state = to_drm_sysfb_crtc_state(crtc_state);
+
+	/*
+	 * The gamma LUT has to be reloaded after changing the primary
+	 * plane's color format.
+	 */
+	if (crtc_state->enable && crtc_state->color_mgmt_changed) {
+		if (sysfb_crtc_state->format == sysfb->fb_format) {
+			if (crtc_state->gamma_lut)
+				vesadrm_set_gamma_lut(vesa,
+						      sysfb_crtc_state->format,
+						      crtc_state->gamma_lut->data);
+			else
+				vesadrm_set_gamma_linear(vesa, sysfb_crtc_state->format);
+		} else {
+			vesadrm_set_gamma_linear(vesa, sysfb_crtc_state->format);
+		}
+	}
+}
+
 static const struct drm_crtc_helper_funcs vesadrm_crtc_helper_funcs = {
 	DRM_SYSFB_CRTC_HELPER_FUNCS,
+	.atomic_flush = vesadrm_crtc_helper_atomic_flush,
 };
 
 static const struct drm_crtc_funcs vesadrm_crtc_funcs = {
@@ -282,6 +466,18 @@ static struct vesadrm_device *vesadrm_device_create(struct drm_driver *drv,
 	drm_dbg(dev, "framebuffer format=%p4cc, size=%dx%d, stride=%d bytes\n",
 		&format->format, width, height, stride);
 
+	if (!__screen_info_vbe_mode_nonvga(si)) {
+		vesa->cmap_write = vesadrm_vga_cmap_write;
+#ifdef __i386__
+	} else {
+		phys_addr_t pmi_base = __screen_info_vesapm_info_base(si);
+		const u16 *pmi_addr = phys_to_virt(pmi_base);
+
+		vesa->pmi.PrimaryPalette = (u8 *)pmi_addr + pmi_addr[2];
+		vesa->cmap_write = vesadrm_pmi_cmap_write;
+#endif
+	}
+
 #ifdef CONFIG_X86
 	if (drm_edid_header_is_valid(edid_info.dummy) == 8)
 		sysfb->edid = edid_info.dummy;
@@ -289,6 +485,8 @@ static struct vesadrm_device *vesadrm_device_create(struct drm_driver *drv,
 	sysfb->fb_mode = drm_sysfb_mode(width, height, 0, 0);
 	sysfb->fb_format = format;
 	sysfb->fb_pitch = stride;
+	if (vesa->cmap_write)
+		sysfb->fb_gamma_lut_size = VESADRM_GAMMA_LUT_SIZE;
 
 	/*
 	 * Memory management
@@ -360,6 +558,12 @@ static struct vesadrm_device *vesadrm_device_create(struct drm_driver *drv,
 		return ERR_PTR(ret);
 	drm_crtc_helper_add(crtc, &vesadrm_crtc_helper_funcs);
 
+	if (sysfb->fb_gamma_lut_size) {
+		ret = drm_mode_crtc_set_gamma_size(crtc, sysfb->fb_gamma_lut_size);
+		if (!ret)
+			drm_crtc_enable_color_mgmt(crtc, 0, false, sysfb->fb_gamma_lut_size);
+	}
+
 	/* Encoder */
 
 	encoder = &vesa->encoder;
include/linux/screen_info.h +7 -0
index ab3cffbb58b7..923d68e07679 100644
@@ -126,6 +126,13 @@ static inline unsigned int screen_info_video_type(const struct screen_info *si)
 	return VIDEO_TYPE_CGA;
 }
 
+static inline u32 __screen_info_vesapm_info_base(const struct screen_info *si)
+{
+	if (si->vesapm_seg < 0xc000)
+		return 0;
+	return (si->vesapm_seg << 4) + si->vesapm_off;
+}
+
 ssize_t screen_info_resources(const struct screen_info *si, struct resource *r, size_t num);
 
 u32 __screen_info_lfb_bits_per_pixel(const struct screen_info *si);
Signature · 1 line
2.48.1
maintainer Reviewed-by on v1 18/18
#42 lore raw

Re: [PATCH 18/18] drm/sysfb: vesadrm: Add gamma correction

Quoted 10 lines · Thomas Zimmermann

Add palette support and export GAMMA properties via sysfs. User-space compositors can use this interface for programming gamma ramps or night mode.

Vesadrm supports palette updates via VGA DAC registers or VESA palette calls. Up to 256 palette entries are available. Userspace always supplies gamma ramps of 256 entries. If the native color format does not match this because pixel component have less then 8 bits, vesadrm interpolates among the palette entries.

Quoted 4 lines

The code uses CamelCase style in a few places to match the VESA manuals.

---

Signature · 5 lines
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat
#43 lore raw
In reply to Thomas Zimmermann
Quoted 97 lines · EDT Thomas Zimmermann

This series simplifies the existing ofdrm and simepldrm drivers, and adds new drivers for EFI- and VESA-based framebuffers. Existing drivers for system framebuffers, ofdrm and simpledrm, share much of their mode-setting pipeline. The major difference between the two drivers is in how they retrieve the framebuffer from the systems. Hence, it makes sense to share some of the pipeline implementation. With the shared helpers in place, we can then add dedicated drivers for EFI and VESA easily.

Patches 1 to 3 clean up obsolete artifacts from ofdrm and simpledrm.

Patch 4 moves both drivers from tiny/ into their own subdirectory sysfb/. The name aligns with the naming in drivers/firmware/sysfb.c to signal the connection. It's the firmware code that creates most of the system-framebuffer devices that these drivers operate on. The patch also adds a separate menu in Kconfig.

Patches 5 to 11 unify the mode-setting pipeline between ofdrm and simpledrm. Either both drivers already use the same implementation or they can easily do so. There've been previous attempts to unify some of the drivers' code, but with little success. This time the helpers will be shared among 4 drivers, so it's already much more successful than before.

Patch 12 adds EDID support to ofdrm. The EDID data can be found in some Macintosh's DeviceTree next to the framebuffer configuration. EDID support will be useful for EFI and VESA as well.

Patch 13 adds another helper for screen_info that will be required by EFI and VESA drivers.

Patch 14 and 15 add efidrm, a DRM driver that operates on EFI-provided framebuffers. It uses the shared sysfb helpers. The immediate benefit over simpledrm is the support for EFI's various types of memory caching on the framebuffer. Simpledrm only supported WriteCombine caching. There's also EDID support if the kernel's edid_info has been initialized. This feature needs to be implemented in the kernel's efistub library.

Patches 16 to 18 add vesadrm, a DRM driver that operates in VESA- provided framebuffers. It is very much like efidrm, but tailored towards VESA features. It has EDID support and there's a patch at [1] for grub to provide the data as part of the kernel's boot parameters. Vesadrm also supports gamma ramps. Together with EDID, this allows for gamma correction and night mode. Gnome already does that.

Future directions: Efidrm requires EDID data that has to be provided by the efistub library. There is an EFI call to do so. Vesadrm currently requires a discrete color mode. Support for palette modes can be added later. There's still a bit of code duplication among palette handling. We have more drivers that use similar code for palette LUTs, such as ast and mgag200. We should try to provide generic palette helpers for all these drivers.

This series has been tested on various devices that require the provided drivers.

[1] https://build.opensuse.org/projects/home:tdz:branches:Base:System/packages/grub2/files/grub2-provide-edid.patch?expand=1

Thomas Zimmermann (18):
drm/ofdrm: Remove struct ofdrm_device.pdev
drm/ofdrm: Open-code drm_simple_encoder_init() drm/simpledrm: Remove struct simpledrm_device.nformats
drm: Move sysfb drivers into separate subdirectory drm/sysfb: Add struct drm_sysfb_device
drm/sysfb: Provide single mode-init helper
drm/sysfb: Merge mode-config functions
drm/sysfb: Merge connector functions
drm/sysfb: Maintain CRTC state in struct drm_sysfb_crtc_state drm/sysfb: Merge CRTC functions
drm/sysfb: Merge primary-plane functions
drm/sysfb: ofdrm: Add EDID support
firmware: sysfb: Move bpp-depth calculation into screen_info helper drm/sysfb: Add efidrm for EFI displays
drm/sysfb: efidrm: Add EDID support
drm/sysfb: Add vesadrm for VESA displays
drm/sysfb: vesadrm: Add EDID support
drm/sysfb: vesadrm: Add gamma correction

 MAINTAINERS                                 |   3 +-
 drivers/firmware/sysfb_simplefb.c           |  31 +-
 drivers/gpu/drm/Kconfig                     |   2 +
 drivers/gpu/drm/Makefile                    |   1 +
 drivers/gpu/drm/sysfb/Kconfig               |  76 +++
 drivers/gpu/drm/sysfb/Makefile              |   8 +
 drivers/gpu/drm/sysfb/drm_sysfb_helper.c    | 319 ++++++++++
 drivers/gpu/drm/sysfb/drm_sysfb_helper.h    | 136 ++++
 drivers/gpu/drm/sysfb/efidrm.c              | 495 +++++++++++++++
 drivers/gpu/drm/{tiny => sysfb}/ofdrm.c     | 364 ++---------
 drivers/gpu/drm/{tiny => sysfb}/simpledrm.c | 237 +------
 drivers/gpu/drm/sysfb/vesadrm.c             | 660 ++++++++++++++++++++
 drivers/gpu/drm/tiny/Kconfig                |  32 -
 drivers/gpu/drm/tiny/Makefile               |   2 -
 drivers/video/screen_info_generic.c         |  36 ++
 include/linux/screen_info.h                 |   9 +
 include/video/pixel_format.h                |  41 ++
 17 files changed, 1885 insertions(+), 567 deletions(-)
 create mode 100644 drivers/gpu/drm/sysfb/Kconfig
Quoted 10 lines
 create mode 100644 drivers/gpu/drm/sysfb/Makefile
 create mode 100644 drivers/gpu/drm/sysfb/drm_sysfb_helper.c
 create mode 100644 drivers/gpu/drm/sysfb/drm_sysfb_helper.h
 create mode 100644 drivers/gpu/drm/sysfb/efidrm.c
 rename drivers/gpu/drm/{tiny => sysfb}/ofdrm.c (75%)
 rename drivers/gpu/drm/{tiny => sysfb}/simpledrm.c (76%)
 create mode 100644 drivers/gpu/drm/sysfb/vesadrm.c
 create mode 100644 include/video/pixel_format.h

FYI When this gets merged,
https://gitlab.freedesktop.org/xorg/xserver/-/blob/master/hw/xfree86/common/xf86platformBus.c?ref_type=heads#L589
might need to be updated to add exceptions for vesadrm and efidrm like there is for simpledrm.
I am willing to open a merge request, but freedesktop is readonly for now during their migration.

author maintainer
#44 lore raw

Hi

Am 19.03.25 um 13:50 schrieb nerdopolis:

Quoted 108 lines · EDT Thomas Zimmermann
Quoted 96 lines

This series simplifies the existing ofdrm and simepldrm drivers, and adds new drivers for EFI- and VESA-based framebuffers. Existing drivers for system framebuffers, ofdrm and simpledrm, share much of their mode-setting pipeline. The major difference between the two drivers is in how they retrieve the framebuffer from the systems. Hence, it makes sense to share some of the pipeline implementation. With the shared helpers in place, we can then add dedicated drivers for EFI and VESA easily.

Patches 1 to 3 clean up obsolete artifacts from ofdrm and simpledrm.

Patch 4 moves both drivers from tiny/ into their own subdirectory sysfb/. The name aligns with the naming in drivers/firmware/sysfb.c to signal the connection. It's the firmware code that creates most of the system-framebuffer devices that these drivers operate on. The patch also adds a separate menu in Kconfig.

Patches 5 to 11 unify the mode-setting pipeline between ofdrm and simpledrm. Either both drivers already use the same implementation or they can easily do so. There've been previous attempts to unify some of the drivers' code, but with little success. This time the helpers will be shared among 4 drivers, so it's already much more successful than before.

Patch 12 adds EDID support to ofdrm. The EDID data can be found in some Macintosh's DeviceTree next to the framebuffer configuration. EDID support will be useful for EFI and VESA as well.

Patch 13 adds another helper for screen_info that will be required by EFI and VESA drivers.

Patch 14 and 15 add efidrm, a DRM driver that operates on EFI-provided framebuffers. It uses the shared sysfb helpers. The immediate benefit over simpledrm is the support for EFI's various types of memory caching on the framebuffer. Simpledrm only supported WriteCombine caching. There's also EDID support if the kernel's edid_info has been initialized. This feature needs to be implemented in the kernel's efistub library.

Patches 16 to 18 add vesadrm, a DRM driver that operates in VESA- provided framebuffers. It is very much like efidrm, but tailored towards VESA features. It has EDID support and there's a patch at [1] for grub to provide the data as part of the kernel's boot parameters. Vesadrm also supports gamma ramps. Together with EDID, this allows for gamma correction and night mode. Gnome already does that.

Future directions: Efidrm requires EDID data that has to be provided by the efistub library. There is an EFI call to do so. Vesadrm currently requires a discrete color mode. Support for palette modes can be added later. There's still a bit of code duplication among palette handling. We have more drivers that use similar code for palette LUTs, such as ast and mgag200. We should try to provide generic palette helpers for all these drivers.

This series has been tested on various devices that require the provided drivers.

[1] https://build.opensuse.org/projects/home:tdz:branches:Base:System/packages/grub2/files/grub2-provide-edid.patch?expand=1

Thomas Zimmermann (18):
drm/ofdrm: Remove struct ofdrm_device.pdev
drm/ofdrm: Open-code drm_simple_encoder_init() drm/simpledrm: Remove struct simpledrm_device.nformats
drm: Move sysfb drivers into separate subdirectory drm/sysfb: Add struct drm_sysfb_device
drm/sysfb: Provide single mode-init helper
drm/sysfb: Merge mode-config functions
drm/sysfb: Merge connector functions
drm/sysfb: Maintain CRTC state in struct drm_sysfb_crtc_state drm/sysfb: Merge CRTC functions
drm/sysfb: Merge primary-plane functions
drm/sysfb: ofdrm: Add EDID support
firmware: sysfb: Move bpp-depth calculation into screen_info helper drm/sysfb: Add efidrm for EFI displays
drm/sysfb: efidrm: Add EDID support
drm/sysfb: Add vesadrm for VESA displays
drm/sysfb: vesadrm: Add EDID support
drm/sysfb: vesadrm: Add gamma correction

  MAINTAINERS                                 |   3 +-
  drivers/firmware/sysfb_simplefb.c           |  31 +-
  drivers/gpu/drm/Kconfig                     |   2 +
  drivers/gpu/drm/Makefile                    |   1 +
  drivers/gpu/drm/sysfb/Kconfig               |  76 +++
  drivers/gpu/drm/sysfb/Makefile              |   8 +
  drivers/gpu/drm/sysfb/drm_sysfb_helper.c    | 319 ++++++++++
  drivers/gpu/drm/sysfb/drm_sysfb_helper.h    | 136 ++++
  drivers/gpu/drm/sysfb/efidrm.c              | 495 +++++++++++++++
  drivers/gpu/drm/{tiny => sysfb}/ofdrm.c     | 364 ++---------
  drivers/gpu/drm/{tiny => sysfb}/simpledrm.c | 237 +------
  drivers/gpu/drm/sysfb/vesadrm.c             | 660 ++++++++++++++++++++
  drivers/gpu/drm/tiny/Kconfig                |  32 -
  drivers/gpu/drm/tiny/Makefile               |   2 -
  drivers/video/screen_info_generic.c         |  36 ++
  include/linux/screen_info.h                 |   9 +
  include/video/pixel_format.h                |  41 ++
  17 files changed, 1885 insertions(+), 567 deletions(-)
Quoted 11 lines

create mode 100644 drivers/gpu/drm/sysfb/Kconfig create mode 100644 drivers/gpu/drm/sysfb/Makefile create mode 100644 drivers/gpu/drm/sysfb/drm_sysfb_helper.c create mode 100644 drivers/gpu/drm/sysfb/drm_sysfb_helper.h create mode 100644 drivers/gpu/drm/sysfb/efidrm.c rename drivers/gpu/drm/{tiny => sysfb}/ofdrm.c (75%) rename drivers/gpu/drm/{tiny => sysfb}/simpledrm.c (76%) create mode 100644 drivers/gpu/drm/sysfb/vesadrm.c create mode 100644 include/video/pixel_format.h

Quoted 4 lines

FYI When this gets merged,
https://gitlab.freedesktop.org/xorg/xserver/-/blob/master/hw/xfree86/common/xf86platformBus.c?ref_type=heads#L589
might need to be updated to add exceptions for vesadrm and efidrm like there is for simpledrm.

Yeah, we need a workaround for each of these drivers unfortunately.

Quoted 2 lines

I am willing to open a merge request, but freedesktop is readonly for now during their migration.

No worries, I'll provide the patches.

Best regards
Thomas

Quoted 3 lines
Signature · 7 lines
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
author maintainer
#45 lore raw
In reply to nerdopolis

Hi

Am 19.03.25 um 13:50 schrieb nerdopolis:
[...]

Quoted 6 lines

FYI When this gets merged,
https://gitlab.freedesktop.org/xorg/xserver/-/blob/master/hw/xfree86/common/xf86platformBus.c?ref_type=heads#L589
might need to be updated to add exceptions for vesadrm and efidrm like there is for simpledrm.
I am willing to open a merge request, but freedesktop is readonly for now during their migration.

I've sent out an MR with this update.

Best regards
Thomas

Quoted 3 lines
Signature · 7 lines
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
#46 lore raw
Quoted 11 lines · EDT Thomas Zimmermann

Hi

Am 19.03.25 um 13:50 schrieb nerdopolis:
[...]

Quoted 6 lines

FYI When this gets merged,
https://gitlab.freedesktop.org/xorg/xserver/-/blob/master/hw/xfree86/common/xf86platformBus.c?ref_type=heads#L589
might need to be updated to add exceptions for vesadrm and efidrm like there is for simpledrm.
I am willing to open a merge request, but freedesktop is readonly for now during their migration.

Quoted 5 lines

I've sent out an MR with this update.

Best regards
Thomas

Sweet thanks, Yeah I noticed you were the one that added in those other two drivers as well in the workaround list, but only after I sent that message. I should have checked the commit log. Sorry about the unneeded reminder, as you were obviously already aware that it needs those workarounds

Quoted 5 lines
Quoted 3 lines