Skip to contentSkip to conversation

bluetooth: Rename HFP AG plugin

PATCH In review Frédéric Danis 2 participants 4 messages Jan 29, 2013 – Jan 31, 2013 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 bluetooth: Rename HFP AG plugin

As BlueZ 5 introduced backwards incompatible API changes, and we want to keep support for BlueZ 4 based HFP AG plugin for some time, we need to separate HFP AG plugin which is based on BlueZ 4 from the one based on BlueZ 5.

The hfp_ag.c plugin is renamed to hfp_ag_bluez4. This will make it easy to add an HFP AG plugin for BlueZ 5.

---
 Makefile.am                           |    4 ++--
 plugins/{hfp_ag.c => hfp_ag_bluez4.c} |    5 +++--
 2 files changed, 5 insertions(+), 4 deletions(-)
 rename plugins/{hfp_ag.c => hfp_ag_bluez4.c} (97%)
Makefile.am +2 -2
index f24cac7..ee6d24c 100644
@@ -421,8 +421,8 @@ builtin_sources += plugins/sap.c plugins/bluez4.h
 builtin_modules += hfp_bluez4
 builtin_sources += plugins/hfp_hf_bluez4.c plugins/bluez4.h
 
-builtin_modules += hfp_ag
-builtin_sources += plugins/hfp_ag.c plugins/bluez4.h
+builtin_modules += hfp_ag_bluez4
+builtin_sources += plugins/hfp_ag_bluez4.c plugins/bluez4.h
 
 builtin_modules += dun_gw
 builtin_sources += plugins/dun_gw.c plugins/bluez4.h
plugins/hfp_ag_bluez4.c renamed from plugins/hfp_ag.c +3 -2
similarity index 97%
rename from plugins/hfp_ag.c
rename to plugins/hfp_ag_bluez4.c
index 12374ad..039b665 100644
@@ -213,5 +213,6 @@ static void hfp_ag_exit(void)
 	}
 }
 
-OFONO_PLUGIN_DEFINE(hfp_ag, "Hands-Free Audio Gateway Profile Plugins", VERSION,
-			OFONO_PLUGIN_PRIORITY_DEFAULT, hfp_ag_init, hfp_ag_exit)
+OFONO_PLUGIN_DEFINE(hfp_ag_bluez4, "Hands-Free Audio Gateway Profile Plugins",
+				VERSION, OFONO_PLUGIN_PRIORITY_DEFAULT,
+				hfp_ag_init, hfp_ag_exit)
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 2/2 hfp_ag: Add BlueZ 5 version

This patch adds initial implementation of the D-Bus Profile1 interface and methods responsible for handling Bluetooth connections.

The HFP AG profile interface is registered as soon as a voice capable modem is registered in oFono.

---
 Makefile.am             |    3 +
 plugins/hfp_ag_bluez5.c |  269 +++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 272 insertions(+)
 create mode 100644 plugins/hfp_ag_bluez5.c
Makefile.am +3 -0
index ee6d24c..ef4d314 100644
@@ -439,6 +439,9 @@ builtin_sources += plugins/bluez5.c plugins/bluez5.h
 
 builtin_modules += hfp_bluez5
 builtin_sources += plugins/hfp_hf_bluez5.c plugins/bluez5.h
+
+builtin_modules += hfp_ag_bluez5
+builtin_sources += plugins/hfp_ag_bluez5.c plugins/bluez5.h
 endif
 endif
 endif
plugins/hfp_ag_bluez5.c new file +269 -0

269 lines not on this page · raw message

Signature · 1 line
1.7.9.5
#2 lore raw

Re: [PATCH 2/2] hfp_ag: Add BlueZ 5 version

Hi Frédéric,

Quoted 11 lines · Frédéric Danis

This patch adds initial implementation of the D-Bus Profile1 interface and methods responsible for handling Bluetooth connections.

The HFP AG profile interface is registered as soon as a voice capable modem is registered in oFono.

---
  Makefile.am             |    3 +
  plugins/hfp_ag_bluez5.c |  269 +++++++++++++++++++++++++++++++++++++++++++++++
  2 files changed, 272 insertions(+)

create mode 100644 plugins/hfp_ag_bluez5.c

Patch has been applied, thanks.

Regards,
-Denis

#3 lore raw
In reply to Frédéric Danis

Hi Frédéric,

Quoted 5 lines · Frédéric Danis

As BlueZ 5 introduced backwards incompatible API changes, and we want to keep support for BlueZ 4 based HFP AG plugin for some time, we need to separate HFP AG plugin which is based on BlueZ 4 from the one based on BlueZ 5.

Quoted 7 lines

The hfp_ag.c plugin is renamed to hfp_ag_bluez4. This will make it easy to add an HFP AG plugin for BlueZ 5.

---
  Makefile.am                           |    4 ++--
  plugins/{hfp_ag.c =>  hfp_ag_bluez4.c} |    5 +++--
  2 files changed, 5 insertions(+), 4 deletions(-)

rename plugins/{hfp_ag.c => hfp_ag_bluez4.c} (97%)

Patch has been applied, thanks.

Regards,
-Denis