Skip to contentSkip to conversation

powerpc/corenet: Add workaround for ELBC multi-bit ECC error

PATCH New Shaohui Xie 3 participants 3 messages Jan 28, 2013 – Jan 30, 2013 PowerPC

lore
Share & tools
lore

Shaohui Xie

author
#0 lore raw

PATCH 1/1 powerpc/corenet: Add workaround for ELBC multi-bit ECC error

NAND operations in condition like below will result ELBC internal multi-bit ECC error, DCFG will send this error to MPIC to report it as an error interrupt (Interrupt 0), which causes call trace in kernel, so software should disable the DCFG not to send the ELBC ECC error by setting bit 15 in the register at DCSRBASE + 0x0002_0520. This won't inhibit the reporting of LTESR[PAR]. This workaround is enabled on P2041/P3041/P50x0.

steps to reproduce the issue:
1. power cycle the board
2. use following command to do NAND test:
flashcp -v file-jffs2 /dev/mtdx

The 'mtdx' should be a NAND partition, the file 'file-jffs2' should be page aligned.

Signed-off-by Shaohui Xie <[email protected]>
---
 arch/powerpc/cpu/mpc85xx/cmd_errata.c     |    3 +++
 arch/powerpc/cpu/mpc85xx/cpu_init.c       |   10 ++++++++++
 arch/powerpc/include/asm/config_mpc85xx.h |    4 ++++
 3 files changed, 17 insertions(+), 0 deletions(-)
arch/powerpc/cpu/mpc85xx/cmd_errata.c +3 -0
index e5ecf5d..f26d608 100644
@@ -227,6 +227,9 @@ static int do_errata(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 #ifdef CONFIG_SYS_FSL_ERRATUM_NMG_LBC103
 	puts("Work-around for Erratum NMG_LBC103 enabled\n");
 #endif
+#ifdef CONFIG_SYS_FSL_ELBC_MULTIBIT_ECC
+	puts("Work-around for Erratum ELBC MULTIBIT ECC enabled\n");
+#endif
 #ifdef CONFIG_SYS_FSL_ERRATUM_NMG_ETSEC129
 	if ((SVR_MAJ(svr) == 1) || IS_SVR_REV(svr, 2, 0))
 		puts("Work-around for Erratum NMG ETSEC129 enabled\n");
arch/powerpc/cpu/mpc85xx/cpu_init.c +10 -0
index d1155e8..5d6f996 100644
@@ -564,6 +564,16 @@ skip_l2:
 		}
 	}
 #endif
+#ifdef CONFIG_SYS_FSL_ELBC_MULTIBIT_ECC
+	/*
+	 * On P2041/P3041/P50x0, NAND operations will result internal multi-bit
+	 * ECC error, which causes call trace in kernel, so software should
+	 * disable the ECC error reported from eLBC by setting bit 15 in
+	 * the register at DCSRBASE + 0x0002_0520.
+	 */
+#define DCFG_ECC	(CONFIG_SYS_DCSRBAR + 0x20520)
+	setbits_be32((void *)DCFG_ECC, 1 << (31 - 15));
+#endif
 
 #ifdef CONFIG_SYS_LBC_LCRR
 	/*
arch/powerpc/include/asm/config_mpc85xx.h +4 -0
index 0b9638b..8f8aea7 100644
@@ -345,6 +345,7 @@
 #define CONFIG_SYS_FSL_CORENET_SNOOPVEC_COREONLY 0xf0000000
 #define CONFIG_SYS_FSL_ERRATUM_SRIO_A004034
 #define CONFIG_SYS_FSL_ERRATUM_A004849
+#define CONFIG_SYS_FSL_ELBC_MULTIBIT_ECC
 
 #elif defined(CONFIG_PPC_P3041)
 #define CONFIG_SYS_FSL_QORIQ_CHASSIS1

@@ -377,6 +378,7 @@
 #define CONFIG_SYS_FSL_CORENET_SNOOPVEC_COREONLY 0xf0000000
 #define CONFIG_SYS_FSL_ERRATUM_SRIO_A004034
 #define CONFIG_SYS_FSL_ERRATUM_A004849
+#define CONFIG_SYS_FSL_ELBC_MULTIBIT_ECC
 
 #elif defined(CONFIG_PPC_P4080) /* also supports P4040 */
 #define CONFIG_SYS_FSL_QORIQ_CHASSIS1

@@ -451,6 +453,7 @@
 #define CONFIG_SYS_FSL_ERRATUM_A004510_SVR_REV	0x10
 #define CONFIG_SYS_FSL_CORENET_SNOOPVEC_COREONLY 0xc0000000
 #define CONFIG_SYS_FSL_ERRATUM_SRIO_A004034
+#define CONFIG_SYS_FSL_ELBC_MULTIBIT_ECC
 
 #elif defined(CONFIG_PPC_P5040)
 #define CONFIG_SYS_PPC64

@@ -480,6 +483,7 @@
 #define CONFIG_SYS_FSL_ERRATUM_A004510
 #define CONFIG_SYS_FSL_ERRATUM_A004510_SVR_REV	0x10
 #define CONFIG_SYS_FSL_CORENET_SNOOPVEC_COREONLY 0xf0000000
+#define CONFIG_SYS_FSL_ELBC_MULTIBIT_ECC
 
 #elif defined(CONFIG_BSC9131)
 #define CONFIG_MAX_CPUS			1
Signature · 1 line
1.6.4
#1 lore raw

PATCH 1/1 powerpc/corenet: Add workaround for ELBC multi-bit ECC error

arch/powerpc/cpu/mpc85xx/cmd_errata.c static int do_errata(cmd_tbl_t *cmdtp, int flag, · line 233

Quoted 13 lines · Shaohui Xie
arch/powerpc/cpu/mpc85xx/cmd_errata.c +3 -0
index e5ecf5d..f26d608 100644
@@ -227,6 +227,9 @@ static int do_errata(cmd_tbl_t *cmdtp, int flag,  
 int argc, char * const argv[])
 #ifdef CONFIG_SYS_FSL_ERRATUM_NMG_LBC103
 	puts("Work-around for Erratum NMG_LBC103 enabled\n");
 #endif
+#ifdef CONFIG_SYS_FSL_ELBC_MULTIBIT_ECC
+	puts("Work-around for Erratum ELBC MULTIBIT ECC enabled\n");
+#endif

Is there still no erratum number for this?

-Scott

#2 lore raw

PATCH 1/1 powerpc/corenet: Add workaround for ELBC multi-bit ECC error

Quoted 6 lines · Shaohui Xie
Quoted 5 lines
arch/powerpc/cpu/mpc85xx/cmd_errata.c +0 -0
index e5ecf5d..f26d608 100644
Quoted 8 lines

arch/powerpc/cpu/mpc85xx/cmd_errata.c

Quoted 6 lines
arch/powerpc/cpu/mpc85xx/cmd_errata.c +0 -0
@@ -227,6 +227,9 @@ static int do_errata(cmd_tbl_t *cmdtp, int flag,

int argc, char * const argv[]) #ifdef
CONFIG_SYS_FSL_ERRATUM_NMG_LBC103

arch/powerpc/cpu/mpc85xx/cmd_errata.c +2 -0
 	puts("Work-around for Erratum NMG_LBC103 enabled\n");  #endif
+#ifdef CONFIG_SYS_FSL_ELBC_MULTIBIT_ECC
+	puts("Work-around for Erratum ELBC MULTIBIT ECC enabled\n"); #endif

Is there still no erratum number for this?

[S.H] Yes, I did not find any update from validation for this erratum. It even does not described in any errata doc.

Best Regards,
Shaohui Xie