Skip to contentSkip to conversation

drm/radeon: Calling object_unrefer() when creating fb failure

PATCH In review Su, Xuemin 2 participants 2 messages Jan 31, 2013

Subsystems (2)
lore
Share & tools
lore

Su, Xuemin

author
#0 lore raw

PATCH 1/1 drm/radeon: Calling object_unrefer() when creating fb failure

From: liu chuansheng <[email protected]>
Date: Thu, 31 Jan 2013 22:13:00 +0800
Subject: [PATCH] drm/radeon: Calling object_unrefer() when creating fb
failure

When kzalloc() failed in radeon_user_framebuffer_create(), need to call object_unreference() to match the object_reference().

---
 drivers/gpu/drm/radeon/radeon_display.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
drivers/gpu/drm/radeon/radeon_display.c +3 -1
index ff3def7..05c96fa 100644
@@ -1115,8 +1115,10 @@ radeon_user_framebuffer_create(struct drm_device *dev,
 	}
 
 	radeon_fb = kzalloc(sizeof(*radeon_fb), GFP_KERNEL);
-	if (radeon_fb == NULL)
+	if (radeon_fb == NULL) {
+		drm_gem_object_unreference_unlocked(obj);
 		return ERR_PTR(-ENOMEM);
+	}
 
 	ret = radeon_framebuffer_init(dev, radeon_fb, mode_cmd, obj);
 	if (ret) {
Signature · 1 line
1.7.6
#1 lore raw
Quoted 10 lines · Xuemin

From: liu chuansheng <[email protected]>
Date: Thu, 31 Jan 2013 22:13:00 +0800
Subject: [PATCH] drm/radeon: Calling object_unrefer() when creating fb
failure

When kzalloc() failed in radeon_user_framebuffer_create(), need to call object_unreference() to match the object_reference().

Thanks. I've picked this up.

Alex

Quoted 29 lines
---
 drivers/gpu/drm/radeon/radeon_display.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
drivers/gpu/drm/radeon/radeon_display.c +3 -2
index ff3def7..05c96fa 100644
@@ -1115,8 +1115,10 @@ radeon_user_framebuffer_create(struct drm_device *dev,
        }
 
        radeon_fb = kzalloc(sizeof(*radeon_fb), GFP_KERNEL);
-       if (radeon_fb == NULL)
+       if (radeon_fb == NULL) {
+               drm_gem_object_unreference_unlocked(obj);
                return ERR_PTR(-ENOMEM);
+       }
 
        ret = radeon_framebuffer_init(dev, radeon_fb, mode_cmd, obj);
        if (ret) {
--

1.7.6

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel