Skip to contentSkip to conversation

ARM: OMAP2+: dpll: Add missing soc_is_am33xx() check

PATCH New AnilKumar Ch 2 participants 2 messages Feb 1, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: OMAP2+: dpll: Add missing soc_is_am33xx() check

Add missing soc_is_am33xx() check in noncore DPLL set rate function. Without this, dpll set_rate function throughs warnings for am33xx family of devices.

---
 arch/arm/mach-omap2/dpll3xxx.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/mach-omap2/dpll3xxx.c +2 -1
index 0a02aab5..4bb3f78 100644
@@ -501,7 +501,8 @@ int omap3_noncore_dpll_set_rate(struct clk_hw *hw, unsigned long rate,
 			return -EINVAL;
 
 		/* No freqsel on OMAP4 and OMAP3630 */
-		if (!cpu_is_omap44xx() && !cpu_is_omap3630()) {
+		if (!cpu_is_omap44xx() && !cpu_is_omap3630() &&
+					!soc_is_am33xx()) {
 			freqsel = _omap3_dpll_compute_freqsel(clk,
 						dd->last_rounded_n);
 			WARN_ON(!freqsel);
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 ARM: OMAP2+: dpll: Add missing soc_is_am33xx() check

Quoting AnilKumar Ch (2013-02-01 02:27:04)

Quoted 5 lines

Add missing soc_is_am33xx() check in noncore DPLL set rate function. Without this, dpll set_rate function throughs warnings for am33xx family of devices.

I think that only 3430 needs the freqsel calculation. If this is true, then I think it would be better to just have a check for cpu_is_3430() instead of appending new SoCs to the list that do not care about the freqsel calculation.

Regards,
Mike

Quoted 25 lines
---
 arch/arm/mach-omap2/dpll3xxx.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/mach-omap2/dpll3xxx.c +2 -1
index 0a02aab5..4bb3f78 100644
@@ -501,7 +501,8 @@ int omap3_noncore_dpll_set_rate(struct clk_hw *hw, unsigned long rate,
                        return -EINVAL;
 
                /* No freqsel on OMAP4 and OMAP3630 */
-               if (!cpu_is_omap44xx() && !cpu_is_omap3630()) {
+               if (!cpu_is_omap44xx() && !cpu_is_omap3630() &&
+                                       !soc_is_am33xx()) {
                        freqsel = _omap3_dpll_compute_freqsel(clk,
                                                dd->last_rounded_n);
                        WARN_ON(!freqsel);
Signature · 6 lines
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html