Skip to contentSkip to conversation

SubmittingPatches: add penalty for forcing a maintainer to edit a patch

PATCH In review Greg Kroah-Hartman 5 participants 5 messages Feb 1, 2013 – Feb 2, 2013 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 SubmittingPatches: add penalty for forcing a maintainer to edit a patch

From: Greg Kroah-Hartman <[email protected]>

Maintainers have to hand-edit patches (body of patches and changelog entries) all the time. There needs to be some kind of penalty put into place to keep developers from abusing maintainers.

Documentation/SubmittingPatches +3 -1
index c379a2a..d1bec01 100644
@@ -93,7 +93,9 @@ includes updates for subsystem X.  Please apply."
 
 The maintainer will thank you if you write your patch description in a
 form which can be easily pulled into Linux's source code management
-system, git, as a "commit log".  See #15, below.
+system, git, as a "commit log".  See #15, below.  If the maintainer has
+to hand-edit your patch, you owe them the beverage of their choice the
+next time you see them.
 
 If your description starts to get long, that's a sign that you probably
 need to split up your patch.  See #3, next.
#1 lore raw
Quoted 5 lines · Greg Kroah-Hartman

From: Greg Kroah-Hartman <[email protected]>

Maintainers have to hand-edit patches (body of patches and changelog entries) all the time. There needs to be some kind of penalty put into place to keep developers from abusing maintainers.

No, there doesn't.

It's funny as a joke, it's not as an actual patch.

Reviewed-by
#2 lore raw

Joe, read lkml and decide after that.
I fully apove the pathch.

Comments:
You have 3 kernels to maintain as stable, plus drivers, plus etc. If somebody post something without reading the docs, and you have to repeat to them the same, again and more, then you MUST give an beer.

Quoted 17 lines · Joe Perches
Quoted 5 lines · Greg Kroah-Hartman

From: Greg Kroah-Hartman <[email protected]>

Maintainers have to hand-edit patches (body of patches and changelog entries) all the time. There needs to be some kind of penalty put into place to keep developers from abusing maintainers.

No, there doesn't.

It's funny as a joke, it's not as an actual patch.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

reviewer
#3 lore raw
Quoted 5 lines · Anca Emanuel

Joe, read lkml and decide after that.
I fully apove the pathch.

Quoted 7 lines

Comments:
You have 3 kernels to maintain as stable, plus drivers, plus etc. If somebody post something without reading the docs, and you have to repeat to them the same, again and more, then you MUST give an beer.

If someone is a repeat-repeat offender, they should just learn how to submit patches correctly. I.e., the maintainer should just keep saying to them, Sorry, please submit your patch correctly so that I can apply it.

Quoted 11 lines · Joe Perches
Quoted 10 lines · Greg Kroah-Hartman
Quoted 5 lines

From: Greg Kroah-Hartman <[email protected]>

Maintainers have to hand-edit patches (body of patches and changelog entries) all the time. There needs to be some kind of penalty put into place to keep developers from abusing maintainers.

No, there doesn't.

It's funny as a joke, it's not as an actual patch.

Signature · 1 line
~Randy