Skip to contentSkip to conversation

gdb: build gdbserver with TARGET_MAKE_ENV

PATCH New Thomas Petazzoni 3 participants 3 messages Feb 3, 2013 – Feb 4, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gdb: build gdbserver with TARGET_MAKE_ENV

This commit fixes the exact same problem than 21a0c11a90f9ff19c78a5f32e0a2e9064fd28054, but for the gdbserver build. The problem is that when you use the Crosstool-NG toolchain backend, gawk gets built as a dependency of Crosstool-NG. So the gdb configure scripts detects it, and assumes it is in the PATH (because the gdb configure step gets run with TARGET_MAKE_ENV).

But then, the build fails, because it tries to run gawk, but gawk isn't in the PATH, because we forget to use this TARGET_MAKE_ENV variable when building gdbserver.

Fixes http://autobuild.buildroot.org/results/d0173de533b5e2fffed2eff7327a502ed2d787cd/build-end.log

---
 toolchain/gdb/gdb.mk |    1 +
 1 file changed, 1 insertion(+)
toolchain/gdb/gdb.mk +1 -0
index 4b8fe3a..a932b1f 100644
@@ -144,6 +144,7 @@ $(GDB_SERVER_DIR)/.configured: $(GDB_DIR)/.unpacked
 	touch $@
 
 $(GDB_SERVER_DIR)/gdbserver: $(GDB_SERVER_DIR)/.configured
+	$(TARGET_MAKE_ENV) \
 	$(MAKE) CC="$(TARGET_CC)" MT_CFLAGS="$(TARGET_CFLAGS)" \
 		-C $(GDB_SERVER_DIR)
 
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 gdb: build gdbserver with TARGET_MAKE_ENV

Thomas, All,

Quoting Thomas Petazzoni <[email protected]>:

Quoted 7 lines

This commit fixes the exact same problem than 21a0c11a90f9ff19c78a5f32e0a2e9064fd28054, but for the gdbserver build. The problem is that when you use the Crosstool-NG toolchain backend, gawk gets built as a dependency of Crosstool-NG. So the gdb configure scripts detects it, and assumes it is in the PATH (because the gdb configure step gets run with TARGET_MAKE_ENV).

Quoted 6 lines

But then, the build fails, because it tries to run gawk, but gawk isn't in the PATH, because we forget to use this TARGET_MAKE_ENV variable when building gdbserver.

Fixes

http://autobuild.buildroot.org/results/d0173de533b5e2fffed2eff7327a502ed2d787cd/build-end.log

Quoted 2 lines

Regards,
Yann E. MORIN.

#2 lore raw

PATCH 1/1 gdb: build gdbserver with TARGET_MAKE_ENV

In reply to Thomas Petazzoni
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Thomas> This commit fixes the exact same problem than
Thomas> 21a0c11a90f9ff19c78a5f32e0a2e9064fd28054, but for the gdbserver Thomas> build. The problem is that when you use the Crosstool-NG toolchain Thomas> backend, gawk gets built as a dependency of Crosstool-NG. So the gdb Thomas> configure scripts detects it, and assumes it is in the PATH (because Thomas> the gdb configure step gets run with TARGET_MAKE_ENV).

Thomas> But then, the build fails, because it tries to run gawk, but gawk Thomas> isn't in the PATH, because we forget to use this TARGET_MAKE_ENV Thomas> variable when building gdbserver.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard