Skip to contentSkip to conversation

Added comments to explain watchdog_disabled variable

PATCH In review anish kumar 3 participants 7 messages Feb 3, 2013 – Feb 16, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Added comments to explain watchdog_disabled variable

From: anish kumar <[email protected]>

This watchdog_disabled flag is bit of cryptic.Howerver it's usefullnes is multifold. Uses are:
1. Check if smpboot_register_percpu_thread function passed.
2. Makes sure that user enables and disables the watchdog in sequence i.e. enable watchdog->disable watchdog->enable watchdog
Unlike enable watchdog->enable watchdog which is wrong.

---
 kernel/watchdog.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
kernel/watchdog.c +5 -0
index 75a2ab3..87a19aa 100644
@@ -518,6 +518,11 @@ int proc_dowatchdog(struct ctl_table *table, int write,
 		return ret;
 
 	set_sample_period();
+	/*
+	 * We shouldn't enable watchdog threads if it is
+	 * disabled.This is done by watchdog_disabled
+	 * variable check in watchdog_*_all_cpus function.
+	 */
 	if (watchdog_enabled && watchdog_thresh)
 		watchdog_enable_all_cpus();
 	else
Signature · 1 line
1.7.1
#1 lore raw

Is the below patch picked up?

Quoted 33 lines · anish kumar

From: anish kumar <[email protected]>

This watchdog_disabled flag is bit of cryptic.Howerver it's usefullnes is multifold. Uses are:
1. Check if smpboot_register_percpu_thread function passed.
2. Makes sure that user enables and disables the watchdog in sequence i.e. enable watchdog->disable watchdog->enable watchdog
Unlike enable watchdog->enable watchdog which is wrong.

---
 kernel/watchdog.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
kernel/watchdog.c +5 -1
index 75a2ab3..87a19aa 100644
@@ -518,6 +518,11 @@ int proc_dowatchdog(struct ctl_table *table, int write,
                return ret;
 
        set_sample_period();
+       /*
+        * We shouldn't enable watchdog threads if it is
+        * disabled.This is done by watchdog_disabled
+        * variable check in watchdog_*_all_cpus function.
+        */
        if (watchdog_enabled && watchdog_thresh)
                watchdog_enable_all_cpus();
        else
--

1.7.1

#2 lore raw
Quoted 24 lines · anish singh

Is the below patch picked up?

Quoted 21 lines · anish kumar

From: anish kumar <[email protected]>

This watchdog_disabled flag is bit of cryptic.Howerver it's usefullnes is multifold. Uses are:
1. Check if smpboot_register_percpu_thread function passed.
2. Makes sure that user enables and disables the watchdog in sequence i.e. enable watchdog->disable watchdog->enable watchdog
Unlike enable watchdog->enable watchdog which is wrong.

---
 kernel/watchdog.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
kernel/watchdog.c +0 -0
index 75a2ab3..87a19aa 100644
@@ -518,6 +518,11 @@ int proc_dowatchdog(struct ctl_table *table, int write,
                return ret;
 
Quoted 5 lines

kernel/watchdog.c int proc_dowatchdog(struct ctl_table *table, int write, · line 524

Quoted 5 lines
kernel/watchdog.c +4 -0
        set_sample_period();
+       /*
+        * We shouldn't enable watchdog threads if it is
+        * disabled.This is done by watchdog_disabled
+        * variable check in watchdog_*_all_cpus function.

It has two grammatic and a stylistic error in it, plus misses the convention that function names are mentioned with a '()'.

Thanks,

Ingo

#3 lore raw
Quoted 27 lines · Ingo Molnar
Quoted 24 lines · anish singh

Is the below patch picked up?

Quoted 21 lines · anish kumar

From: anish kumar <[email protected]>

This watchdog_disabled flag is bit of cryptic.Howerver it's usefullnes is multifold. Uses are:
1. Check if smpboot_register_percpu_thread function passed.
2. Makes sure that user enables and disables the watchdog in sequence i.e. enable watchdog->disable watchdog->enable watchdog
Unlike enable watchdog->enable watchdog which is wrong.

---
 kernel/watchdog.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
kernel/watchdog.c +0 -0
index 75a2ab3..87a19aa 100644
@@ -518,6 +518,11 @@ int proc_dowatchdog(struct ctl_table *table, int write,
                return ret;
 
Quoted 7 lines
Quoted 5 lines

kernel/watchdog.c int proc_dowatchdog(struct ctl_table *table, int write, · line 524

Quoted 5 lines
kernel/watchdog.c +4 -0
        set_sample_period();
+       /*
+        * We shouldn't enable watchdog threads if it is
+        * disabled.This is done by watchdog_disabled
+        * variable check in watchdog_*_all_cpus function.

It has two grammatic and a stylistic error in it, plus misses

Would you mind pointing it out to me the grammatical mistakes as I am not that good with grammar.
I thought I followed the conventions as below:
/*
*
*
*/

Quoted 5 lines

the convention that function names are mentioned with a '()'.

Thanks,

Ingo

#4 lore raw
Quoted 35 lines · anish singh
Quoted 27 lines · Ingo Molnar
Quoted 24 lines · anish singh

Is the below patch picked up?

Quoted 21 lines · anish kumar

From: anish kumar <[email protected]>

This watchdog_disabled flag is bit of cryptic.Howerver it's usefullnes is multifold. Uses are:
1. Check if smpboot_register_percpu_thread function passed.
2. Makes sure that user enables and disables the watchdog in sequence i.e. enable watchdog->disable watchdog->enable watchdog
Unlike enable watchdog->enable watchdog which is wrong.

---
 kernel/watchdog.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
kernel/watchdog.c +0 -0
index 75a2ab3..87a19aa 100644
@@ -518,6 +518,11 @@ int proc_dowatchdog(struct ctl_table *table, int write,
                return ret;
 
Quoted 7 lines
Quoted 5 lines

kernel/watchdog.c int proc_dowatchdog(struct ctl_table *table, int write, · line 524

Quoted 5 lines
kernel/watchdog.c +4 -0
        set_sample_period();
+       /*
+        * We shouldn't enable watchdog threads if it is
+        * disabled.This is done by watchdog_disabled
+        * variable check in watchdog_*_all_cpus function.

It has two grammatic and a stylistic error in it, plus misses

Quoted 2 lines

Would you mind pointing it out to me the grammatical mistakes as I am not that good with grammar.

I am not entirely sure which ones Ingo is referring to, but what I see are

'disabled.This' needs a space after period
'This is done by watchdog_disabled' needs a 'the' after 'by' 'variable check in watchdog..' needs a 'the' after 'in'.

in addition to the missing ()'s after 'watchdog_*_all_cpus.

Unless I am missing something else, I think that is it.

Cheers,
Don

Quoted 10 lines

I thought I followed the conventions as below:
/*
*
*
*/

Quoted 5 lines

the convention that function names are mentioned with a '()'.

Thanks,

Ingo

#5 lore raw
Quoted 9 lines · Don Zickus
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

kernel/watchdog.c int proc_dowatchdog(struct ctl_table *table, int write, · line 524

Quoted 4 lines
kernel/watchdog.c +4 -0
+       /*
+        * We shouldn't enable watchdog threads if it is
+        * disabled.This is done by watchdog_disabled
+        * variable check in watchdog_*_all_cpus function.

It has two grammatic and a stylistic error in it, plus misses

Would you mind pointing it out to me the grammatical mistakes as I am not that good with grammar.

Quoted 7 lines

I am not entirely sure which ones Ingo is referring to, but what I see are

'disabled.This' needs a space after period
'This is done by watchdog_disabled' needs a 'the' after 'by' 'variable check in watchdog..' needs a 'the' after 'in'.

in addition to the missing ()'s after 'watchdog_*_all_cpus.

There's also a plural/singular mismatch between 'watchdog threads' and 'if it is disabled'.

Thanks,

Ingo

#6 lore raw
Quoted 13 lines · Ingo Molnar
Quoted 11 lines · Don Zickus
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

kernel/watchdog.c int proc_dowatchdog(struct ctl_table *table, int write, · line 524

Quoted 4 lines
kernel/watchdog.c +4 -0
+       /*
+        * We shouldn't enable watchdog threads if it is
+        * disabled.This is done by watchdog_disabled
+        * variable check in watchdog_*_all_cpus function.

It has two grammatic and a stylistic error in it, plus misses

Would you mind pointing it out to me the grammatical mistakes as I am not that good with grammar.

I am not entirely sure which ones Ingo is referring to, but what I see are

Quoted 8 lines
Quoted 5 lines

'disabled.This' needs a space after period
'This is done by watchdog_disabled' needs a 'the' after 'by' 'variable check in watchdog..' needs a 'the' after 'in'.

in addition to the missing ()'s after 'watchdog_*_all_cpus.

There's also a plural/singular mismatch between 'watchdog threads' and 'if it is disabled'.

Thanks, I will update the same in the next patch.

Quoted 4 lines

Thanks,

Ingo