mcast: do not check 'rv' twice in a row
Subsystems (3)
PATCH 1/1 mcast: do not check 'rv' twice in a row
With the loop, don't check 'rv' twice in a row. Without the loop, 'rv' doesn't even need to be checked.
Make the comment more grammar-friendly.
Signed-off-by Jean Sacren <[email protected]>
--- net/ipv6/mcast.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
net/ipv6/mcast.c +2 -4
@@ -427,11 +427,9 @@ int ip6_mc_source(int add, int omode, struct sock *sk, rv =1 ;/* > 0 for insert logic below if sl_count is 0 */ for (i=0 ; i<psl->sl_count; i++) { rv = !ipv6_addr_equal (&psl->sl_addr[i], source); -if (rv ==0 ) -break ; +if (rv ==0 )/* There is an error in the address. */ + goto done; } -if (rv ==0 )/* address already there is an error */ - goto done;for (j=psl->sl_count-1 ; j>=i; j--) psl->sl_addr[j+1 ] = psl->sl_addr[j]; psl->sl_addr[i] = *source;
From: Jean Sacren <[email protected]>
Date: Mon, 4 Feb 2013 00:34:10 -0700
Quoted 6 lines
With the loop, don't check 'rv' twice in a row. Without the loop, 'rv' doesn't even need to be checked.
Make the comment more grammar-friendly.
Signed-off-by Jean Sacren <[email protected]>
Applied.