Skip to contentSkip to conversation

tools/xc: fix logic error in stdiostream_progress

PATCH In review Olaf Hering 2 participants 2 messages Feb 1, 2013 – Feb 4, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools/xc: fix logic error in stdiostream_progress

# HG changeset patch
# User Olaf Hering <[email protected]>
# Date 1359738883 -3600
# Node ID 6d1d516ecaade56f796e3216e9931fdcc12282cd # Parent 6727070b4129cf852199b66b6a81042ee6966a98 tools/xc: fix logic error in stdiostream_progress

Setting XTL_STDIOSTREAM_HIDE_PROGRESS should disable progress reporting, instead of not setting it.

tools/libxc/xtl_logger_stdio.c +1 -1
diff -r 6727070b4129 -r 6d1d516ecaad tools/libxc/xtl_logger_stdio.c
@@ -89,7 +89,7 @@ static void stdiostream_progress(struct 
     int newpel, extra_erase;
     xentoollog_level this_level;
 
-    if (!(lg->flags & XTL_STDIOSTREAM_HIDE_PROGRESS))
+    if (lg->flags & XTL_STDIOSTREAM_HIDE_PROGRESS)
         return;
 
     if (percent < lg->progress_last_percent) {
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Olaf Hering

# HG changeset patch
# User Olaf Hering <[email protected]>
# Date 1359738883 -3600
# Node ID 6d1d516ecaade56f796e3216e9931fdcc12282cd # Parent 6727070b4129cf852199b66b6a81042ee6966a98 tools/xc: fix logic error in stdiostream_progress

Setting XTL_STDIOSTREAM_HIDE_PROGRESS should disable progress reporting, instead of not setting it.

Oops!

Quoted 1 line
Quoted 18 lines

diff -r 6727070b4129 -r 6d1d516ecaad tools/libxc/xtl_logger_stdio.c

tools/libxc/xtl_logger_stdio.c +1 -1
@@ -89,7 +89,7 @@ static void stdiostream_progress(struct 
     int newpel, extra_erase;
     xentoollog_level this_level;
 
-    if (!(lg->flags & XTL_STDIOSTREAM_HIDE_PROGRESS))
+    if (lg->flags & XTL_STDIOSTREAM_HIDE_PROGRESS)
         return;
 
     if (percent < lg->progress_last_percent) {

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel