Skip to contentSkip to conversation

sunrpc: fix comment in struct xdr_buf definition

PATCH In review Jeff Layton 2 participants 2 messages Feb 4, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sunrpc: fix comment in struct xdr_buf definition

...these pages aren't necessarily contiguous.

---
 include/linux/sunrpc/xdr.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/sunrpc/xdr.h +1 -1
index 6398899..224d060 100644
@@ -56,7 +56,7 @@ struct xdr_buf {
 	struct kvec	head[1],	/* RPC header + non-page data */
 			tail[1];	/* Appended after page data */
 
-	struct page **	pages;		/* Array of contiguous pages */
+	struct page **	pages;		/* Array of pages */
 	unsigned int	page_base,	/* Start of page data */
 			page_len,	/* Length of page data */
 			flags;		/* Flags for data disposition */
Signature · 1 line
1.7.11.7
#1 lore raw
Quoted 1 line · Jeff Layton

...these pages aren't necessarily contiguous.

I guess you could say it was correct if you took "contiguous" to mean that the xdr data they hold is meant to be contiguous.

But, yeah, at best I can't see how that comment would help anyone.

Applying absent any objections.

--b.

Quoted 22 lines
---
 include/linux/sunrpc/xdr.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/sunrpc/xdr.h +1 -1
index 6398899..224d060 100644
@@ -56,7 +56,7 @@ struct xdr_buf {
 	struct kvec	head[1],	/* RPC header + non-page data */
 			tail[1];	/* Appended after page data */
 
-	struct page **	pages;		/* Array of contiguous pages */
+	struct page **	pages;		/* Array of pages */
 	unsigned int	page_base,	/* Start of page data */
 			page_len,	/* Length of page data */
 			flags;		/* Flags for data disposition */
Signature · 1 line
1.7.11.7