regulator: core: Optimize _regulator_do_set_voltage if voltage does not change
PATCH 1/2 regulator: core: Optimize _regulator_do_set_voltage if voltage does not change
Optimize _regulator_do_set_voltage() for the case selector is equal to old_selector. Since the voltage does not change, we don't need to call set_voltage_sel() and set_voltage_time_sel() in this case.
--- drivers/regulator/core.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/regulator/core.c +6 -3
@@ -2239,8 +2239,11 @@ static int _regulator_do_set_voltage(struct regulator_dev *rdev, best_val = rdev->desc->ops->list_voltage (rdev, ret);if (min_uV <= best_val && max_uV >= best_val) { selector = ret; - ret = rdev->desc->ops->set_voltage_sel (rdev, - ret); +if (old_selector == selector) + ret =0 ; +else + ret = rdev->desc->ops->set_voltage_sel ( + rdev, ret); }else { ret = -EINVAL ; }
@@ -2251,7 +2254,7 @@ static int _regulator_do_set_voltage(struct regulator_dev *rdev,/* Call set_voltage_time_sel if successfully obtained old_selector */ if (ret ==0 &&_regulator_is_enabled (rdev) && old_selector >=0 && - rdev->desc->ops->set_voltage_time_sel) { + old_selector != selector && rdev->desc->ops->set_voltage_time_sel) { delay = rdev->desc->ops->set_voltage_time_sel (rdev, old_selector, selector);
Signature · 1 line
1.7.9.5
PATCH 2/2 regulator: max8998: Let regulator core handle the case selector == old_selector
--- drivers/regulator/max8998.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-)
drivers/regulator/max8998.c +1 -13
@@ -311,25 +311,13 @@ static int max8998_set_voltage_buck_sel(struct regulator_dev *rdev,dev_get_platdata (max8998->iodev->dev);struct i2c_client *i2c = max8998->iodev->i2c;int buck =rdev_get_id (rdev); -int reg, shift =0 , mask, ret; -int j, previous_sel; +int reg, shift =0 , mask, ret, j;static u8 buck1_last_val; ret =max8998_get_voltage_register (rdev, ®, &shift, &mask);if (ret)return ret; - previous_sel =max8998_get_voltage_sel (rdev); - -/* Check if voltage needs to be changed */ -/* if previous_voltage equal new voltage, return */ -if (previous_sel == selector) { -dev_dbg (max8998->dev,"No voltage change, old:%d, new:%d\n" , -regulator_list_voltage_linear (rdev, previous_sel), -regulator_list_voltage_linear (rdev, selector)); -return ret; - } -switch (buck) {case MAX8998_BUCK1 : dev_dbg(max8998->dev,
Signature · 1 line
1.7.9.5
Mark Brown
AppliedQuoted 3 lines · Axel Lin
Optimize
_regulator_do_set_voltage()for the case selector is equal toold_selector. Since the voltage does not change, we don't need to callset_voltage_sel()andset_voltage_time_sel()in this case.
Applied, thanks.
Mark Brown
AppliedQuoted 3 lines · Axel Lin
Optimize
_regulator_do_set_voltage()for the case selector is equal toold_selector. Since the voltage does not change, we don't need to callset_voltage_sel()andset_voltage_time_sel()in this case.
Applied, thanks.