Skip to contentSkip to conversation

prctl.2: EINAL when no CONFIG_SECCOMP_FILTER, also excess "TP" typo

PATCH In review Shawn Landden 2 participants 2 messages Feb 6, 2013 – Feb 8, 2013 1 message not in the archive Man-pages: manual pages for Linux -- Sections 2, 3, 4, 5, and 7

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 prctl.2: EINAL when no CONFIG_SECCOMP_FILTER, also excess "TP" typo

---
 man2/prctl.2 |   11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
man2/prctl.2 +10 -1
index fd78f48..e9ad0a5 100644
@@ -803,6 +803,16 @@ and the kernel was not configured with
 .B EINVAL
 .I option
 is
+.BR PR_SET_SECCOMP ,
+.I arg2
+is
+.BR SECCOMP_MODE_FILTER ,
+and the kernel was not configured with
+.BR CONFIG_SECCOMP_FILTER .
+.TP
+.B EINVAL
+.I option
+is
 .BR PR_SET_MM ,
 and one of the following is true
 .RS
@@ -850,7 +860,6 @@ is not 0,
 .BR PR_SET_PTRACER_ANY ,
 or the PID of an existing process.
 .TP
-TP
 .B EPERM
 .I option
 is
Signature · 6 lines
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 1360178170-9381-1-git-send-email-shawnlandden-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

#2 lore raw

Hi Shawn

Thanks for the patch. A few comments.

* When you send a patch like this please provide an explanation. In particular, explain how you obtained the info. This helps me verify it.

* Write separate patches for separate pieces. The typo patch should be separate. That said, someone else sent in a patch to fix this a couple of days ago (but only just pushed to kernel.org) so that this piece is fixed.

* The patch for the SECCOMP stuff is not quite correct, AFAICS. But more to the point, this seems to be documented by similar text that is already in the page; am I missing something?

EINVAL option is PR_SET_SECCOMP or PR_GET_SECCOMP, and the ker‐
nel was not configured with CONFIG_SECCOMP.

Thanks,

Michael

Quoted 36 lines · Shawn Landden
---
 man2/prctl.2 |   11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
man2/prctl.2 +10 -2
index fd78f48..e9ad0a5 100644
@@ -803,6 +803,16 @@ and the kernel was not configured with
 .B EINVAL
 .I option
 is
+.BR PR_SET_SECCOMP ,
+.I arg2
+is
+.BR SECCOMP_MODE_FILTER ,
+and the kernel was not configured with
+.BR CONFIG_SECCOMP_FILTER .
+.TP
+.B EINVAL
+.I option
+is
 .BR PR_SET_MM ,
 and one of the following is true
 .RS
@@ -850,7 +860,6 @@ is not 0,
 .BR PR_SET_PTRACER_ANY ,
 or the PID of an existing process.
 .TP
-TP
 .B EPERM
 .I option
 is
--

1.7.9.5

Signature · 7 lines
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Author of "The Linux Programming Interface"; http://man7.org/tlpi/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html