Skip to contentSkip to conversation

regmap: debugfs: Add a `max_reg' member in struct regmap_debugfs_off_cache

PATCH Applied Dimitris Papastamos 2 participants 2 messages Feb 7, 2013 – Feb 8, 2013

Subsystems (2)

v1 of 2 Applied Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 regmap: debugfs: Add a `max_reg' member in struct regmap_debugfs_off_cache

We are keeping track of the maximum register as well, this will make things easier for us in sharing this code with the code implementing the register ranges functionality. It also simplifies a bit the calculations when looking for the relevant block:offset from within the cache.

Change-Id I961320c4a56fdd25d74f1a6cc1b470ff22d8dbca
---
 drivers/base/regmap/internal.h       | 1 +
 drivers/base/regmap/regmap-debugfs.c | 6 ++++++
 2 files changed, 7 insertions(+)
drivers/base/regmap/internal.h +1 -0
index ef61b24..71d9b0a 100644
@@ -25,6 +25,7 @@ struct regmap_debugfs_off_cache {
 	off_t min;
 	off_t max;
 	unsigned int base_reg;
+	unsigned int max_reg;
 };
 
 struct regmap_format {
drivers/base/regmap/regmap-debugfs.c +6 -0
index 96990d2..c2c51f7 100644
@@ -93,6 +93,9 @@ static unsigned int regmap_debugfs_get_dump_start(struct regmap *map,
 			    regmap_precious(map, i)) {
 				if (c) {
 					c->max = p - 1;
+					fpos_offset = c->max - c->min;
+					reg_offset = fpos_offset / map->debugfs_tot_len;
+					c->max_reg = c->base_reg + reg_offset;
 					list_add_tail(&c->list,
 						      &map->debugfs_off_cache);
 					c = NULL;
@@ -119,6 +122,9 @@ static unsigned int regmap_debugfs_get_dump_start(struct regmap *map,
 	/* Close the last entry off if we didn't scan beyond it */
 	if (c) {
 		c->max = p - 1;
+		fpos_offset = c->max - c->min;
+		reg_offset = fpos_offset / map->debugfs_tot_len;
+		c->max_reg = c->base_reg + reg_offset;
 		list_add_tail(&c->list,
 			      &map->debugfs_off_cache);
 	}
Signature · 1 line
1.8.1.2
Applied
#1 lore raw
Quoted 5 lines · Dimitris Papastamos

We are keeping track of the maximum register as well, this will make things easier for us in sharing this code with the code implementing the register ranges functionality. It also simplifies a bit the calculations when looking for the relevant block:offset from within the cache.

Applied, thanks.

Quoted 1 line

Change-Id: I961320c4a56fdd25d74f1a6cc1b470ff22d8dbca

Things like this shouldn't appear in upstream submissions.