dw_dmac: add support for Lynxpoint DMA controllers
PATCH 1/1 dw_dmac: add support for Lynxpoint DMA controllers
From: Mika Westerberg <[email protected]>
Intel Lynxpoint PCH Low Power Subsystem has DMA controller to support general purpose serial buses like SPI, I2C, and HSUART. This controller is enumerated from ACPI namespace with ACPI ID INTL9C60.
--- drivers/dma/dw_dmac.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/dma/dw_dmac.c +6 -0
@@ -1977,6 +1977,11 @@ static const struct of_device_id dw_dma_id_table[] = {MODULE_DEVICE_TABLE (of, dw_dma_id_table);#endif +static const struct platform_device_id dw_dma_ids[] = { + {"INTL9C60" ,0 }, + { } +}; +static struct platform_driver dw_driver = { .probe = dw_probe, .remove = dw_remove,
@@ -1986,6 +1991,7 @@ static struct platform_driver dw_driver = { .pm = &dw_dev_pm_ops, .of_match_table = of_match_ptr(dw_dma_id_table), }, + .id_table = dw_dma_ids, };static int __init dw_init (void )
Signature · 1 line
1.7.10.4
Quoted 7 lines · Andy Shevchenko
From: Mika Westerberg <[email protected]>
Intel Lynxpoint PCH Low Power Subsystem has DMA controller to support general purpose serial buses like SPI, I2C, and HSUART. This controller is enumerated from ACPI namespace with ACPI ID INTL9C60.
Signed-off-by Andy Shevchenko <[email protected]>
Looks like Mika is Author and you have your signed-off :)
Quoted 11 lines · Viresh Kumar
Quoted 7 lines · Andy Shevchenko
From: Mika Westerberg <[email protected]>
Intel Lynxpoint PCH Low Power Subsystem has DMA controller to support general purpose serial buses like SPI, I2C, and HSUART. This controller is enumerated from ACPI namespace with ACPI ID INTL9C60.
Signed-off-by Andy Shevchenko <[email protected]>Looks like Mika is Author and you have your signed-off :)
In this literally small and clear patch it doesn't matter who is who. However for sake of equity I could add Mika's signed-off-by as well.
It should be:
Quoted 1 line
Acked-by Viresh Kumar <[email protected]>
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 9 lines · Andy Shevchenko
Quoted 8 lines · Viresh Kumar
Quoted 6 lines · Andy Shevchenko
From: Mika Westerberg <[email protected]>
Intel Lynxpoint PCH Low Power Subsystem has DMA controller to support general purpose serial buses like SPI, I2C, and HSUART. This controller is enumerated from ACPI namespace with ACPI ID INTL9C60.
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Andy Shevchenko <[email protected]>Looks like Mika is Author and you have your signed-off :)
In this literally small and clear patch it doesn't matter who is who.
I believe it doesn't matter how small or big is the patch, but the author should be there in SOBs too..
Quoted 4 lines
However for sake of equity I could add Mika's signed-off-by as well.
It should be:
Signed-off-by Mika Westerberg <[email protected]>
Thanks.
Quoted 6 lines · Viresh Kumar
Quoted 4 lines · Andy Shevchenko
Quoted 3 lines · Viresh Kumar
Quoted 1 line · Andy Shevchenko
From: Mika Westerberg <[email protected]>
...
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Andy Shevchenko <[email protected]>Looks like Mika is Author and you have your signed-off :)
In this literally small and clear patch it doesn't matter who is who.
I believe it doesn't matter how small or big is the patch, but the author should be there in SOBs too..
True.
Quoted 7 lines
Quoted 5 lines
However for sake of equity I could add Mika's signed-off-by as well.
It should be:
Signed-off-by Mika Westerberg <[email protected]>Thanks.
Shall I resend it?
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 1 line · Andy Shevchenko
Shall I resend it?
Naah!! Vinod can manage it, i believe :)
Quoted 10 lines · Andy Shevchenko
Quoted 6 lines · Viresh Kumar
Quoted 4 lines · Andy Shevchenko
Quoted 3 lines · Viresh Kumar
Quoted 1 line · Andy Shevchenko
From: Mika Westerberg <[email protected]>
...
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 1 line
Signed-off-by Andy Shevchenko <[email protected]>
Quoted 7 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Looks like Mika is Author and you have your signed-off :)
In this literally small and clear patch it doesn't matter who is who.
I believe it doesn't matter how small or big is the patch, but the author should be there in SOBs too..
True.
Then in that case you need to re-read Documentation/SubmittingPatches SOB is also acnowlegement of Origin of the Code, hence mandatory even for single line of change.
Quoted 9 lines
Quoted 7 lines
Quoted 5 lines
However for sake of equity I could add Mika's signed-off-by as well.
It should be:
Signed-off-by Mika Westerberg <[email protected]>Thanks.
Shall I resend it?
It will fix it up, and thanks to greg now you owe me a beverage :)
Quoted 4 lines
Signature · 3 lines
-- With Best Regards, Andy Shevchenko
Quoted 6 lines · Andy Shevchenko
From: Mika Westerberg <[email protected]>
Intel Lynxpoint PCH Low Power Subsystem has DMA controller to support general purpose serial buses like SPI, I2C, and HSUART. This controller is enumerated from ACPI namespace with ACPI ID INTL9C60.
Applied with correct SOBs...
Quoted 32 lines
Signed-off-by Andy Shevchenko <[email protected]>--- drivers/dma/dw_dmac.c | 6 ++++++ 1 file changed, 6 insertions(+)drivers/dma/dw_dmac.c +6
-0@@ -1977,6 +1977,11 @@ static const struct of_device_id dw_dma_id_table[] = {MODULE_DEVICE_TABLE (of, dw_dma_id_table);#endif +static const struct platform_device_id dw_dma_ids[] = { + {"INTL9C60" ,0 }, + { } +}; +static struct platform_driver dw_driver = { .probe = dw_probe, .remove = dw_remove,@@ -1986,6 +1991,7 @@ static struct platform_driver dw_driver = { .pm = &dw_dev_pm_ops, .of_match_table = of_match_ptr(dw_dma_id_table), }, + .id_table = dw_dma_ids, };static int __init dw_init (void )Signature · 1 line
1.7.10.4