Skip to contentSkip to conversation

i.MX53 - add WEIM register defines

DISCUSSION George Pontis 3 participants 3 messages Feb 8, 2013 – Feb 11, 2013

lore
Share & tools
lore
#0 lore raw

Subject: i.MX53: Add WEIM register defines ( same as i.MX51 )

diff -Naur bb.a/arch/arm/mach-imx/include/mach/imx53-regs.h bb.b/arch/arm/mach-imx/include/mach/imx53-regs.h
--- bb.a/arch/arm/mach-imx/include/mach/imx53-regs.h 2013-02-04
06:24:51.000000000 -0800
+++ bb.b/arch/arm/mach-imx/include/mach/imx53-regs.h 2013-02-06
23:14:45.982747680 -0800
@@ -1,6 +1,17 @@
#ifndef __MACH_IMX53_REGS_H
#define __MACH_IMX53_REGS_H

+/* WEIM registers */

+#define WEIM_CSxGCR1(n)        (((n) * 0x18) + 0x00)
+#define WEIM_CSxGCR2(n)        (((n) * 0x18) + 0x04)
+#define WEIM_CSxRCR1(n)        (((n) * 0x18) + 0x08)
+#define WEIM_CSxRCR2(n)        (((n) * 0x18) + 0x0c)
+#define WEIM_CSxWCR1(n)        (((n) * 0x18) + 0x10)
+#define WEIM_CSxWCR2(n)        (((n) * 0x18) + 0x14)
+#define WEIM_WCR       0x90
+#define WEIM_WIAR      0x94
+#define WEIM_EAR       0x98

+
#define MX53_IROM_BASE_ADDR 0x0

#define MX53_SATA_BASE_ADDR 0x10000000

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

#1 lore raw
Quoted 14 lines

Subject: i.MX53: Add WEIM register defines ( same as i.MX51 )

diff -Naur bb.a/arch/arm/mach-imx/include/mach/imx53-regs.h bb.b/arch/arm/mach-imx/include/mach/imx53-regs.h
--- bb.a/arch/arm/mach-imx/include/mach/imx53-regs.h 2013-02-04
06:24:51.000000000 -0800
+++ bb.b/arch/arm/mach-imx/include/mach/imx53-regs.h 2013-02-06
23:14:45.982747680 -0800

(quoted diff) +0 -0
@@ -1,6 +1,17 @@
 #ifndef __MACH_IMX53_REGS_H
 #define __MACH_IMX53_REGS_H
 

Review line 13

Quoted 10 lines
(quoted diff) +10 -0
+/* WEIM registers */
+#define WEIM_CSxGCR1(n)        (((n) * 0x18) + 0x00)
+#define WEIM_CSxGCR2(n)        (((n) * 0x18) + 0x04)
+#define WEIM_CSxRCR1(n)        (((n) * 0x18) + 0x08)
+#define WEIM_CSxRCR2(n)        (((n) * 0x18) + 0x0c)
+#define WEIM_CSxWCR1(n)        (((n) * 0x18) + 0x10)
+#define WEIM_CSxWCR2(n)        (((n) * 0x18) + 0x14)
+#define WEIM_WCR       0x90
+#define WEIM_WIAR      0x94
+#define WEIM_EAR       0x98

If register set is really same as i.MX51, then probably we should move these definitions from imx51-regs.h to imx5.h. Sascha?

---
_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

#2 lore raw
Quoted 14 lines · Alexander Shiyan
Quoted 14 lines

Subject: i.MX53: Add WEIM register defines ( same as i.MX51 )

diff -Naur bb.a/arch/arm/mach-imx/include/mach/imx53-regs.h bb.b/arch/arm/mach-imx/include/mach/imx53-regs.h
--- bb.a/arch/arm/mach-imx/include/mach/imx53-regs.h 2013-02-04
06:24:51.000000000 -0800
+++ bb.b/arch/arm/mach-imx/include/mach/imx53-regs.h 2013-02-06
23:14:45.982747680 -0800

(quoted diff) +0 -0
@@ -1,6 +1,17 @@
 #ifndef __MACH_IMX53_REGS_H
 #define __MACH_IMX53_REGS_H
 
Quoted 13 lines

Review line 13

Quoted 10 lines
(quoted diff) +10 -0
+/* WEIM registers */
+#define WEIM_CSxGCR1(n)        (((n) * 0x18) + 0x00)
+#define WEIM_CSxGCR2(n)        (((n) * 0x18) + 0x04)
+#define WEIM_CSxRCR1(n)        (((n) * 0x18) + 0x08)
+#define WEIM_CSxRCR2(n)        (((n) * 0x18) + 0x0c)
+#define WEIM_CSxWCR1(n)        (((n) * 0x18) + 0x10)
+#define WEIM_CSxWCR2(n)        (((n) * 0x18) + 0x14)
+#define WEIM_WCR       0x90
+#define WEIM_WIAR      0x94
+#define WEIM_EAR       0x98

If register set is really same as i.MX51, then probably we should move these definitions from imx51-regs.h to imx5.h. Sascha?

Even better add a imx53_setup_weimcs() function like we have for various other i.MXes in mach/weim.h.

(add a imx5_setup_weimcs function which has an additional base address argument. This would then be called from imx51_setup_weimcs/imx53_setup_weimcs).

Sascha

Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox