memcg: fix kmemcg registration for late caches
Subsystems (3)
PATCH 1/1 memcg: fix kmemcg registration for late caches
The designed workflow for the caches in kmemcg is: register it with memcg_register_cache() if kmemcg is already available or later on when a new kmemcg appears at memcg_update_cache_sizes() which will handle all caches in the system. The caches created at boot time will be handled by the later, and the memcg-caches as well as any system caches that are registered later on by the former.
There is a bug, however, in memcg_register_cache: we correctly set up the array size, but do not mark the cache as a root cache. This means that allocations for any cache appearing late in the game will see memcg->memcg_params->is_root_cache == false, and in particular, trigger VM_BUG_ON(!cachep->memcg_params->is_root_cache) in __memcg_kmem_cache_get.
The obvious fix is to include the missing assignment.
--- mm/memcontrol.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
mm/memcontrol.c +3 -1
@@ -3147,7 +3147,9 @@ int memcg_register_cache(struct mem_cgroup *memcg, struct kmem_cache *s,if (memcg) { s->memcg_params->memcg = memcg; s->memcg_params->root_cache = root_cache; - } + }else + s->memcg_params->is_root_cache = true; +return 0 ; }
Signature · 7 lines
1.8.1.2 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 14 lines · Glauber Costa
The designed workflow for the caches in kmemcg is: register it with
memcg_register_cache()if kmemcg is already available or later on when a new kmemcg appears atmemcg_update_cache_sizes()which will handle all caches in the system. The caches created at boot time will be handled by the later, and the memcg-caches as well as any system caches that are registered later on by the former.There is a bug, however, in
memcg_register_cache: we correctly set up the array size, but do not mark the cache as a root cache. This means that allocations for any cache appearing late in the game will seememcg->memcg_params->is_root_cache== false, and in particular, triggerVM_BUG_ON(!cachep->memcg_params->is_root_cache)in__memcg_kmem_cache_get.
Quoted 3 lines
The obvious fix is to include the missing assignment.
Signed-off-by Glauber Costa <[email protected]>
Quoted 27 lines
--- mm/memcontrol.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)mm/memcontrol.c +3
-1@@ -3147,7 +3147,9 @@ int memcg_register_cache(struct mem_cgroup *memcg, struct kmem_cache *s,if (memcg) { s->memcg_params->memcg = memcg; s->memcg_params->root_cache = root_cache; - } + }else + s->memcg_params->is_root_cache = true; +return 0 ; }Signature · 7 lines
1.8.1.2 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Signature · 8 lines
Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 14 lines · Glauber Costa
The designed workflow for the caches in kmemcg is: register it with
memcg_register_cache()if kmemcg is already available or later on when a new kmemcg appears atmemcg_update_cache_sizes()which will handle all caches in the system. The caches created at boot time will be handled by the later, and the memcg-caches as well as any system caches that are registered later on by the former.There is a bug, however, in
memcg_register_cache: we correctly set up the array size, but do not mark the cache as a root cache. This means that allocations for any cache appearing late in the game will seememcg->memcg_params->is_root_cache== false, and in particular, triggerVM_BUG_ON(!cachep->memcg_params->is_root_cache)in__memcg_kmem_cache_get.
Quoted 3 lines
The obvious fix is to include the missing assignment.
Signed-off-by Glauber Costa <[email protected]>
Quoted 20 lines
--- mm/memcontrol.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)mm/memcontrol.c +3
-1@@ -3147,7 +3147,9 @@ int memcg_register_cache(struct mem_cgroup *memcg, struct kmem_cache *s,if (memcg) { s->memcg_params->memcg = memcg; s->memcg_params->root_cache = root_cache; - } + }else + s->memcg_params->is_root_cache = true; +return 0 ; }