Skip to contentSkip to conversation

befs: befs_get_block(): remove unreachable code

PATCH New Tim Gardner 1 participant 1 message Feb 12, 2013 Befs file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 befs: befs_get_block(): remove unreachable code

'sector_t block' is unsigned and can therefore never be '< 0'.

smatch analysis:

fs/befs/linuxvfs.c:131 befs_get_block() warn: unsigned 'block'
is never less than zero.

Cc Al Viro <[email protected]>
Cc Andrew Morton <[email protected]>
Cc "Eric W. Biederman" <[email protected]>
Cc "Kirill A. Shutemov" <[email protected]>
---
 fs/befs/linuxvfs.c |    7 -------
 1 file changed, 7 deletions(-)
fs/befs/linuxvfs.c +0 -7
index 2b3bda8..6a237e7 100644
@@ -128,13 +128,6 @@ befs_get_block(struct inode *inode, sector_t block,
 	befs_debug(sb, "---> befs_get_block() for inode %lu, block %ld",
 		   inode->i_ino, block);
 
-	if (block < 0) {
-		befs_error(sb, "befs_get_block() was asked for a block "
-			   "number less than zero: block %ld in inode %lu",
-			   block, inode->i_ino);
-		return -EIO;
-	}
-
 	if (create) {
 		befs_error(sb, "befs_get_block() was asked to write to "
 			   "block %ld in inode %lu", block, inode->i_ino);
Signature · 1 line
1.7.9.5