Skip to contentSkip to conversation

usb: ehci: ehci-vt8500 bus glue as separate module

PATCH Superseded manjunath.goudar at linaro.org 2 participants 3 messages Feb 13, 2013

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 usb: ehci: ehci-vt8500 bus glue as separate module

From: Manjunath Goudar <[email protected]>

Separate the vt8500 On-Chip host controller driver from ehci-hcd host code into its own static driver module

Manjunath Goudar (1):
USB: EHCI: make ehci-vt8500 a separate driver

 drivers/usb/host/Kconfig       |    8 +++++
 drivers/usb/host/Makefile      |    1 +
 drivers/usb/host/ehci-hcd.c    |    6 +---
 drivers/usb/host/ehci-vt8500.c |   73 ++++++++++++++++++----------------------
 4 files changed, 43 insertions(+), 45 deletions(-)
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 USB: EHCI: make ehci-vt8500 a separate driver

From: Manjunath Goudar <[email protected]>

Separate the vt8500 host controller driver from ehci-hcd host code into its own driver module.

Cc Greg KH <[email protected]>
Cc Alan Stern <[email protected]>
Cc Tony Prisk <[email protected]>
Cc Alexey Charkov <[email protected]>
Cc linux-usb at vger.kernel.org
Cc linux-kernel at vger.kernel.org
---
 drivers/usb/host/Kconfig       |    8 +++++
 drivers/usb/host/Makefile      |    1 +
 drivers/usb/host/ehci-hcd.c    |    6 +---
 drivers/usb/host/ehci-vt8500.c |   73 ++++++++++++++++++----------------------
 4 files changed, 43 insertions(+), 45 deletions(-)
drivers/usb/host/Kconfig +8 -0
index 2aa4ece..4e15b87 100644
@@ -162,6 +162,14 @@ config USB_EHCI_HCD_OMAP
 	  Enables support for the on-chip EHCI controller on
 	  OMAP3 and later chips.
 
+config USB_EHCI_HCD_VT8500
+        tristate "Support for VT8500 on-chip EHCI USB controller"
+        depends on USB_EHCI_HCD && ARCH_VT8500
+        default y
+        ---help---
+          Enables support for the on-chip EHCI controller on
+          VT8500 chips.
+
 config USB_EHCI_HCD_SPEAR
         tristate "Support for ST SPEAr on-chip EHCI USB controller"
         depends on USB_EHCI_HCD && PLAT_SPEAR
drivers/usb/host/Makefile +1 -0
index d593017..1fe0579 100644
@@ -32,6 +32,7 @@ obj-$(CONFIG_USB_OXU210HP_HCD)	+= oxu210hp-hcd.o
 obj-$(CONFIG_USB_EHCI_HCD_AT91) += ehci-atmel.o
 obj-$(CONFIG_USB_EHCI_S5P)      += ehci-s5p.o
 obj-$(CONFIG_USB_EHCI_MV)       += ehci-mv.o
+obj-$(CONFIG_USB_EHCI_HCD_VT8500)+= ehci-vt8500.o
 obj-$(CONFIG_USB_ISP116X_HCD)	+= isp116x-hcd.o
 obj-$(CONFIG_USB_ISP1362_HCD)	+= isp1362-hcd.o
 obj-$(CONFIG_USB_OHCI_HCD)	+= ohci-hcd.o
drivers/usb/host/ehci-hcd.c +1 -5
index 9cf4d73..eefa3d7 100644
@@ -1287,11 +1287,6 @@ MODULE_LICENSE ("GPL");
 #define PLATFORM_DRIVER		ehci_octeon_driver
 #endif
 
-#ifdef CONFIG_ARCH_VT8500
-#include "ehci-vt8500.c"
-#define	PLATFORM_DRIVER		vt8500_ehci_driver
-#endif
-
 #ifdef CONFIG_USB_EHCI_MSM
 #include "ehci-msm.c"
 #define PLATFORM_DRIVER		ehci_msm_driver
@@ -1331,6 +1326,7 @@ MODULE_LICENSE ("GPL");
 	!IS_ENABLED(CONFIG_ARCH_AT91) && \
 	!IS_ENABLED(CONFIG_USB_EHCI_S5P) && \
 	!IS_ENABLED(CONFIG_USB_EHCI_MV) && \
+	!IS_ENABLED(CONFIG_ARCH_VT8500) && \
 	!defined(PS3_SYSTEM_BUS_DRIVER) && \
 	!defined(OF_PLATFORM_DRIVER) && \
 	!defined(XILINX_OF_PLATFORM_DRIVER)
drivers/usb/host/ehci-vt8500.c +33 -40

96 lines not on this page · raw message

Signature · 1 line
1.7.9.5
#2 lore raw

PATCH v2 1/1 usb: ehci: ehci-vt8500 bus glue as separate module

In reply to manjunath.goudar at linaro.org
Quoted 4 lines · manjunath.goudar at linaro.org

From: Manjunath Goudar <[email protected]>

Separate the vt8500 On-Chip host controller driver from ehci-hcd host code into its own static driver module

Hi Manjunath,

I see you are getting better with the patch submission procedure. I don't know what you did different this time, but the patch actually ended up coming out as a reply to the introductory mail this time. Whatever you did there, please keep doing it.

There are a few things that you should improve though:

1. I did not see any replies to the review comments you got from the other reviewers, which means either you did not reply, or you were doing 'reply to author' rather than 'reply to all'. Please make it a habit to reply to each reviewer, and keep the Cc list. You don't always have to reply to each comment in one email, but when people spend time to look at your patches and point out mistakes, they deserve to know how you are addressing their comments.

2. For this specific patch, you sent out a single patch that is supposed to be part of a longer series, and I expect that it would not apply by itself. It's normally better wait until you have received a number of comments to different patches, and then send out the entire series again, in order to make it possible to actually try them out. If you want to quickly send out a new version of a single patch out of a larger series, it's better to reply with the new version to the old patch.

3. You really need to improve the text in the cover letter. Remember that you cannot overcommmunicate here, and more information about the patch can only help. In this case, the cover letter has the exact same contents as the actual patch, which is not helpful. Instead you could have put a text like

| This is the third version of the ehci cleanup series, which
| I based on Greg's usb-next branch from Feb 12. I addressed
| review comments from ...

Arnd