Skip to contentSkip to conversation

regmap: debugfs: Simplify calculation of `c->max_reg'

PATCH Applied Dimitris Papastamos 2 participants 2 messages Feb 14, 2013

Subsystems (2)

v1 of 3 Applied Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 regmap: debugfs: Simplify calculation of `c->max_reg'

We don't need to use any of the file position information to calculate the base and max register of each block. Just use the counter directly.

---
 drivers/base/regmap/regmap-debugfs.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
drivers/base/regmap/regmap-debugfs.c +2 -6
index 78d5f20..5fb23cb 100644
@@ -95,9 +95,7 @@ static unsigned int regmap_debugfs_get_dump_start(struct regmap *map,
 			    regmap_precious(map, i)) {
 				if (c) {
 					c->max = p - 1;
-					fpos_offset = c->max - c->min;
-					reg_offset = fpos_offset / map->debugfs_tot_len;
-					c->max_reg = c->base_reg + reg_offset;
+					c->max_reg = i - 1;
 					list_add_tail(&c->list,
 						      &map->debugfs_off_cache);
 					c = NULL;
@@ -124,9 +122,7 @@ static unsigned int regmap_debugfs_get_dump_start(struct regmap *map,
 	/* Close the last entry off if we didn't scan beyond it */
 	if (c) {
 		c->max = p - 1;
-		fpos_offset = c->max - c->min;
-		reg_offset = fpos_offset / map->debugfs_tot_len;
-		c->max_reg = c->base_reg + reg_offset;
+		c->max_reg = i - 1;
 		list_add_tail(&c->list,
 			      &map->debugfs_off_cache);
 	}
Signature · 1 line
1.8.1.3
Applied
#1 lore raw
Quoted 3 lines · Dimitris Papastamos

We don't need to use any of the file position information to calculate the base and max register of each block. Just use the counter directly.

Applied, thanks.