arptables: defeat multi-job for install
PATCH 1/1 arptables: defeat multi-job for install
CQID: 399299
The make install target is not parallel job safe, but doesn't do all that much, so we limit make to one job for that.
The make target is of the form
install: x y z
Unfortunately, z depends on y, so if z is started before y (almost) completes, we will fail.
--- recipes-support/arptables/arptables_0.0.3-4.bb | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)
recipes-support/arptables/arptables_0.0.3-4.bb +7 -0
@@ -3,6 +3,8 @@ PRIORITY = "optional" LICENSE = "GPL-2.0" SECTION = "console/network" +PR = "r2" + RDEPENDS_${PN} += "perl" LIC_FILES_CHKSUM = "file://${COREBASE}/meta/files/common-licenses/GPL-2.0;md5=801f80980d171dd6425610833a22dbe6"
@@ -20,6 +22,11 @@ do_compile () { oe_runmake } +# the install target is not multi-job safe, but it doesn't do much +# so we just install seriatim +# +PARALLEL_MAKEINST = "-j1" + fakeroot do_install () { oe_runmake 'BINDIR=${sbindir}' 'MANDIR=${mandir}/' 'DESTDIR=${D}' install }
Signature · 1 line
1.7.3.4
Hi Joe,
Quoted 34 lines · On Thursday 14 February 2013 13:40:04 Joe Slater wrote:
CQID: 399299
The make install target is not parallel job safe, but doesn't do all that much, so we limit make to one job for that.
The make target is of the form
install: x y z
Unfortunately, z depends on y, so if z is started before y (almost) completes, we will fail.
Signed-off-by Joe Slater <[email protected]>--- recipes-support/arptables/arptables_0.0.3-4.bb | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)(quoted diff) +0
-0b/recipes-support/arptables/arptables_0.0.3-4.bb index 2faccec..de3f62d 100644
recipes-support/arptables/arptables_0.0.3-4.bb +2
-0@@ -3,6 +3,8 @@ PRIORITY = "optional" LICENSE = "GPL-2.0" SECTION = "console/network" +PR = "r2" + RDEPENDS_${PN} += "perl" LIC_FILES_CHKSUM ="file://${COREBASE}/meta/files/common-licenses/GPL-2.0;md5=801f80980d171dd6
425610833a22dbe6" @@ -20,6 +22,11 @@do_compile() {
recipes-support/arptables/arptables_0.0.3-4.bb do_compile () { · line 27
Quoted 6 lines
recipes-support/arptables/arptables_0.0.3-4.bb +3
-0oe_runmake } +# the install target is not multi-job safe, but it doesn't do much +# so we just install seriatim +#
I hope I don't expose my ignorance too much by saying I just learned a new word thanks to the above comment... ;)
Quoted 1 line
+PARALLEL_MAKEINST = "-j1"
Of course this will work but typically we would just set PARALLEL_MAKEINST = "" to accomplish this.
More importantly, this appears to be a patch for the meta-networking layer and should therefore have [meta-networking] in the subject and use the meta- networking/ path.
Cheers,
Paul
Hi Paul,
I apologize for the patch path. I applied it to a repository for meta-networking, not meta-openembedded. I should have guessed that the subject qualifier should be more specific than [oe].
As to PARALLEL_MAKEINST, I did note that usually it is "", but I think that "-j1" makes it very clear what the form of this variable is and doesn't cost all that much, so that's what I went for.
Joe
________________________________________
From: Paul Eggleton [[email protected]]
Sent: Saturday, February 16, 2013 12:31 PM
To: Slater, Joseph
Cc: [email protected]
Subject: Re: [oe] [PATCH] arptables: defeat multi-job for install
Hi Joe,
Quoted 37 lines · On Thursday 14 February 2013 13:40:04 Joe Slater wrote:
CQID: 399299
The make install target is not parallel job safe, but doesn't do all that much, so we limit make to one job for that.
The make target is of the form
install: x y z
Unfortunately, z depends on y, so if z is started before y (almost) completes, we will fail.
Signed-off-by Joe Slater <[email protected]>--- recipes-support/arptables/arptables_0.0.3-4.bb | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)(quoted diff) +0
-0b/recipes-support/arptables/arptables_0.0.3-4.bb index 2faccec..de3f62d 100644
recipes-support/arptables/arptables_0.0.3-4.bb +2
-0@@ -3,6 +3,8 @@ PRIORITY = "optional" LICENSE = "GPL-2.0" SECTION = "console/network" +PR = "r2" + RDEPENDS_${PN} += "perl" LIC_FILES_CHKSUM ="file://${COREBASE}/meta/files/common-licenses/GPL-2.0;md5=801f80980d171dd6
425610833a22dbe6" @@ -20,6 +22,11 @@do_compile() {
oe_runmake
}
recipes-support/arptables/arptables_0.0.3-4.bb do_compile () { · line 27
Quoted 3 lines
recipes-support/arptables/arptables_0.0.3-4.bb +3
-0+# the install target is not multi-job safe, but it doesn't do much +# so we just install seriatim +#
I hope I don't expose my ignorance too much by saying I just learned a new word thanks to the above comment... ;)
Quoted 1 line
+PARALLEL_MAKEINST = "-j1"
Of course this will work but typically we would just set PARALLEL_MAKEINST = "" to accomplish this.
More importantly, this appears to be a patch for the meta-networking layer and should therefore have [meta-networking] in the subject and use the meta- networking/ path.
Cheers,
Paul