tipc: fix missing spinlock init in broadcast code
Subsystems (3)
PATCH 1/1 tipc: fix missing spinlock init in broadcast code
From: Erik Hugne <[email protected]>
After commit 3c294cb3 "tipc: remove the bearer congestion mechanism", we try to grab the broadcast bearer lock when sending multicast messages over the broadcast link. This will cause an oops because the lock is never initialized. This is an old bug, but the lock was never actually used before commit 3c294cb3, so that why it was not visible until now. The oops will look something like:
BUG: spinlock bad magic on CPU#2, daemon/147 lock: bcast_bearer+0x48/0xffffffffffffd19a [tipc], .magic: 00000000, .owner: <none>/-1, .owner_cpu: 0 Pid: 147, comm: daemon Not tainted 3.8.0-rc3+ #206 Call Trace: spin_dump+0x8a/0x8f spin_bug+0x21/0x26 do_raw_spin_lock+0x114/0x150 _raw_spin_lock_bh+0x19/0x20 tipc_bearer_blocked+0x1f/0x40 [tipc] tipc_link_send_buf+0x82/0x280 [tipc] ? __alloc_skb+0x9f/0x2b0 tipc_bclink_send_msg+0x77/0xa0 [tipc] tipc_multicast+0x11b/0x1b0 [tipc] send_msg+0x225/0x530 [tipc] sock_sendmsg+0xca/0xe0
The above can be triggered by running the multicast demo program.
---
[PG: I've marked this as "net" since git describe --contains 3c294cb3 gives v3.8-rc1~139^2~242^2~5 --- i.e. the now closing 3.8 dev cycle.]
net/tipc/bcast.c | 1 + 1 file changed, 1 insertion(+)
net/tipc/bcast.c +1 -0
@@ -774,6 +774,7 @@ void tipc_bclink_init(void) bcl->owner = &bclink->node; bcl->max_pkt =MAX_PKT_DEFAULT_MCAST ;tipc_link_set_queue_limits (bcl,BCLINK_WIN_DEFAULT ); +spin_lock_init (&bcbearer->bearer.lock); bcl->b_ptr = &bcbearer->bearer; bcl->state =WORKING_WORKING ;strlcpy (bcl->name, tipc_bclink_name,TIPC_MAX_LINK_NAME );
Signature · 1 line
1.8.1.2
From: Paul Gortmaker <[email protected]>
Date: Thu, 14 Feb 2013 19:43:33 -0500
Quoted 26 lines
From: Erik Hugne <[email protected]>
After commit
3c294cb3"tipc: remove the bearer congestion mechanism", we try to grab the broadcast bearer lock when sending multicast messages over the broadcast link. This will cause an oops because the lock is never initialized. This is an old bug, but the lock was never actually used before commit3c294cb3, so that why it was not visible until now. The oops will look something like:BUG: spinlock bad magic on CPU#2, daemon/147 lock: bcast_bearer+0x48/0xffffffffffffd19a [tipc], .magic: 00000000, .owner: <none>/-1, .owner_cpu: 0 Pid: 147, comm: daemon Not tainted 3.8.0-rc3+ #206 Call Trace: spin_dump+0x8a/0x8f spin_bug+0x21/0x26 do_raw_spin_lock+0x114/0x150 _raw_spin_lock_bh+0x19/0x20 tipc_bearer_blocked+0x1f/0x40 [tipc] tipc_link_send_buf+0x82/0x280 [tipc] ? __alloc_skb+0x9f/0x2b0 tipc_bclink_send_msg+0x77/0xa0 [tipc] tipc_multicast+0x11b/0x1b0 [tipc] send_msg+0x225/0x530 [tipc] sock_sendmsg+0xca/0xe0
Quoted 4 lines
The above can be triggered by running the multicast demo program.
Signed-off-by Erik Hugne <[email protected]>Signed-off-by Paul Gortmaker <[email protected]>
Applied, thanks.