Skip to contentSkip to conversation

tools/libxl: Disable useless empty floppy drive with qemu-xen

PATCH In review Fabio Fantoni 3 participants 5 messages Feb 5, 2013 – Feb 15, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools/libxl: Disable useless empty floppy drive with qemu-xen

tools/libxl: Disable useless empty floppy drive with
qemu-xen

---
 tools/libxl/libxl_dm.c |    3 +++
 1 file changed, 3 insertions(+)
tools/libxl/libxl_dm.c +3 -0
index 51f9914..c265618 100644
@@ -406,6 +406,9 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc,
     if (b_info->type == LIBXL_DOMAIN_TYPE_HVM) {
         int ioemu_nics = 0;
 
+        /* Disable useless empty floppy drive */
+        flexarray_vappend(dm_args, "-global", "isa-fdc.driveA=", NULL);
+
         if (b_info->u.hvm.serial) {
             flexarray_vappend(dm_args, "-serial", 
b_info->u.hvm.serial, NULL);
         }
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 2 lines · Fabio Fantoni

tools/libxl: Disable useless empty floppy drive with
qemu-xen

We used to get occasional requests to enable the floppy disk image to be selected, but perhaps that need has passed (was something to do with Windows sysprep IIRC).

Unfortunately the patch is whitespace damaged. 'git send-email' is your friend...

Quoted 21 lines
---
  tools/libxl/libxl_dm.c |    3 +++
  1 file changed, 3 insertions(+)
tools/libxl/libxl_dm.c +3 -0
index 51f9914..c265618 100644
@@ -406,6 +406,9 @@ static char ** 
 libxl__build_device_model_args_new(libxl__gc *gc,
      if (b_info->type == LIBXL_DOMAIN_TYPE_HVM) {
          int ioemu_nics = 0;
 
+        /* Disable useless empty floppy drive */
+        flexarray_vappend(dm_args, "-global", "isa-fdc.driveA=", NULL);
+
          if (b_info->u.hvm.serial) {
              flexarray_vappend(dm_args, "-serial", 
b_info->u.hvm.serial, NULL);
          }
Acked-by on v1 1/1
#2 lore raw
In reply to Fabio Fantoni
Quoted 4 lines · Fabio Fantoni

tools/libxl: Disable useless empty floppy drive with
qemu-xen

Quoted 23 lines
  tools/libxl/libxl_dm.c |    3 +++
  1 file changed, 3 insertions(+)
tools/libxl/libxl_dm.c +3 -0
index 51f9914..c265618 100644
@@ -406,6 +406,9 @@ static char ** 
 libxl__build_device_model_args_new(libxl__gc *gc,
      if (b_info->type == LIBXL_DOMAIN_TYPE_HVM) {
          int ioemu_nics = 0;
 
+        /* Disable useless empty floppy drive */
+        flexarray_vappend(dm_args, "-global", "isa-fdc.driveA=", NULL);
+
          if (b_info->u.hvm.serial) {
              flexarray_vappend(dm_args, "-serial", 
b_info->u.hvm.serial, NULL);
          }
Signature · 1 line
1.7.9.5
#3 lore raw
In reply to Fabio Fantoni
Quoted 22 lines · Fabio Fantoni

tools/libxl: Disable useless empty floppy drive with
qemu-xen

---
  tools/libxl/libxl_dm.c |    3 +++
  1 file changed, 3 insertions(+)
tools/libxl/libxl_dm.c +3 -0
index 51f9914..c265618 100644
@@ -406,6 +406,9 @@ static char ** 
 libxl__build_device_model_args_new(libxl__gc *gc,
      if (b_info->type == LIBXL_DOMAIN_TYPE_HVM) {
          int ioemu_nics = 0;
 
+        /* Disable useless empty floppy drive */
+        flexarray_vappend(dm_args, "-global", "isa-fdc.driveA=", NULL);
+
          if (b_info->u.hvm.serial) {
              flexarray_vappend(dm_args, "-serial", 
Quoted 1 line

b_info->u.hvm.serial, NULL);

I'm afraid this patch is whitespace corrupted.

I strongly recommend that you investigate the use of git send-email.

Ian.

#4 lore raw

Il 15/02/2013 13:18, Ian Campbell ha scritto:

Quoted 26 lines · Fabio Fantoni
Quoted 22 lines

tools/libxl: Disable useless empty floppy drive with
qemu-xen

---
   tools/libxl/libxl_dm.c |    3 +++
   1 file changed, 3 insertions(+)
tools/libxl/libxl_dm.c +3 -0
index 51f9914..c265618 100644
@@ -406,6 +406,9 @@ static char **
 libxl__build_device_model_args_new(libxl__gc *gc,
       if (b_info->type == LIBXL_DOMAIN_TYPE_HVM) {
           int ioemu_nics = 0;
 
+        /* Disable useless empty floppy drive */
+        flexarray_vappend(dm_args, "-global", "isa-fdc.driveA=", NULL);
+
           if (b_info->u.hvm.serial) {
               flexarray_vappend(dm_args, "-serial",
Quoted 1 line

b_info->u.hvm.serial, NULL);

I'm afraid this patch is whitespace corrupted.

Quoted 4 lines

I strongly recommend that you investigate the use of git send-email.

Ian.

I already resent with git send-email:
http://lists.xen.org/archives/html/xen-devel/2013-02/msg00391.html