drm: don't add inferred modes for monitors that don't support them
Subsystems (2)
PATCH 1/1 drm: don't add inferred modes for monitors that don't support them
From: Paulo Zanoni <[email protected]>
If bit 0 of the features byte (0x18) is set to 0, then, according to the EDID spec, "the display is non-continuous frequency (multi-mode) and is only specified to accept the video timing formats that are listed in Base EDID and certain Extension Blocks".
For more information, please see the EDID spec, check the notes of the table that explains the "Feature Support" byte (18h) and also the notes on the tables of the section that explains "Display Range Limits & Additional Timing Description Definition (tag #FDh)".
Cc: Adam Jackson <[email protected]>
Cc: [email protected]
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=45729
--- drivers/gpu/drm/drm_edid.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
I still need to ask some specific people to test the patch, but I believe it is correct.
drivers/gpu/drm/drm_edid.c +2 -1
@@ -2053,7 +2053,8 @@ int drm_add_edid_modes(struct drm_connector *connector, struct edid *edid) num_modes +=add_cvt_modes (connector, edid); num_modes +=add_standard_modes (connector, edid); num_modes +=add_established_modes (connector, edid); - num_modes +=add_inferred_modes (connector, edid); +if (edid->features &DRM_EDID_FEATURE_DEFAULT_GTF ) + num_modes +=add_inferred_modes (connector, edid); num_modes +=add_cea_modes (connector, edid);if (quirks & (EDID_QUIRK_PREFER_LARGE_60 |EDID_QUIRK_PREFER_LARGE_75 ))
Signature · 1 line
1.7.10.4
Quoted 12 lines · Paulo Zanoni
From: Paulo Zanoni <[email protected]>
If bit 0 of the features byte (
0x18) is set to 0, then, according to the EDID spec, "the display is non-continuous frequency (multi-mode) and is only specified to accept the video timing formats that are listed in Base EDID and certain Extension Blocks".For more information, please see the EDID spec, check the notes of the table that explains the "Feature Support" byte (18h) and also the notes on the tables of the section that explains "Display Range Limits & Additional Timing Description Definition (tag #FDh)".
Quoted 4 lines
Cc: Adam Jackson <[email protected]>
Cc: [email protected]
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=45729Signed-off-by Paulo Zanoni <[email protected]>
I fixed this same bug years ago in the X server in the pre-KMS days.
Quoted 28 lines
--- drivers/gpu/drm/drm_edid.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)I still need to ask some specific people to test the patch, but I believe it is correct.
drivers/gpu/drm/drm_edid.c +2
-2@@ -2053,7 +2053,8 @@ int drm_add_edid_modes(struct drm_connector *connector, struct edid *edid) num_modes +=add_cvt_modes (connector, edid); num_modes +=add_standard_modes (connector, edid); num_modes +=add_established_modes (connector, edid); - num_modes +=add_inferred_modes (connector, edid); +if (edid->features &DRM_EDID_FEATURE_DEFAULT_GTF ) + num_modes +=add_inferred_modes (connector, edid); num_modes +=add_cea_modes (connector, edid);if (quirks & (EDID_QUIRK_PREFER_LARGE_60 |EDID_QUIRK_PREFER_LARGE_75 )) --1.7.10.4
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 11 lines · Paulo Zanoni
From: Paulo Zanoni <[email protected]>
If bit 0 of the features byte (
0x18) is set to 0, then, according to the EDID spec, "the display is non-continuous frequency (multi-mode) and is only specified to accept the video timing formats that are listed in Base EDID and certain Extension Blocks".For more information, please see the EDID spec, check the notes of the table that explains the "Feature Support" byte (18h) and also the notes on the tables of the section that explains "Display Range Limits & Additional Timing Description Definition (tag #FDh)".
Seems sane.
- ajax