Skip to contentSkip to conversation

xfstests 100: do not use scratch

PATCH In review Lukas Czerner 2 participants 2 messages Feb 18, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfstests 100: do not use scratch

Test #100 does not use scratch device at all but it still _require_scratch and _check_scratch_fs. This might also be a problem if the test before this one failed and corrupted scratch partition.

Remove the _require_scratch() and _check_scratch_fs() from the test.

---
 100 |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
100 +0 -2
index f3504ce..ad61823 100755
@@ -69,7 +69,6 @@ _populate_fs -n $NDIRS -f $NFILES -d $DEPTH -r $POPULATED_DIR -s $SIZE >>$here/$
 tar -cvf $TEMP_DIR/$TAR_FILE $POPULATED_DIR >>$here/$seq.full 2>&1
 
 # create f/s
-_require_scratch
 _setup_testdir
 
 # untar on f/s
@@ -84,7 +83,6 @@ diff -qr $POPULATED_DIR ${testdir}${POPULATED_DIR}
 
 cd /
 _cleanup_testdir
-_check_scratch_fs
 
 status=0
 exit
Signature · 6 lines
1.7.7.6

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
#1 lore raw
Quoted 5 lines · Lukas Czerner

Test #100 does not use scratch device at all but it still _require_scratch and _check_scratch_fs. This might also be a problem if the test before this one failed and corrupted scratch partition.

Remove the _require_scratch() and _check_scratch_fs() from the test.

Actaully, I think it should be using scratch - have a look at where TEMP_DIR is located. Yeah, it's /tmp, not the scratch device.

i.e. it should be using the TEST_DIR rather than tmp for building the tarball, and scratch for restoring it....

Cheers,

Dave.

Signature · 7 lines
Dave Chinner
[email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs