arm: pxa: Add support for ICP DAS LP-8x4x
PATCH 1/1 arm: pxa: Add support for ICP DAS LP-8x4x
LP-8x4x is a programmable automation controller by ICP DAS. It is shipped with outdated U-Boot v1.3.0
This patch adds enough supports to boot the board:
- 128M of 128M SDRAM
- 32M of 48M NOR Flash memory
- 1 of 4 Serial console (PXA FFUART)
- 1 of 2 Ethernet controller (DM9000)
--- arch/arm/include/asm/mach-types.h | 13 ++ board/icpdas/lp8x4x/Makefile | 41 ++++++ board/icpdas/lp8x4x/lp8x4x.c | 133 ++++++++++++++++++ boards.cfg | 1 + include/configs/lp8x4x.h | 272 +++++++++++++++++++++++++++++++++++++ 5 files changed, 460 insertions(+) create mode 100644 board/icpdas/lp8x4x/Makefile create mode 100644 board/icpdas/lp8x4x/lp8x4x.c create mode 100644 include/configs/lp8x4x.h
arch/arm/include/asm/mach-types.h +13 -0
@@ -1107,6 +1107,7 @@ extern unsigned int __machine_arch_type;#define MACH_TYPE_OMAP5_SEVM 3777#define MACH_TYPE_ARMADILLO_800EVA 3863#define MACH_TYPE_KZM9G 4140 +#define MACH_TYPE_LP8X4X 4539#ifdef CONFIG_ARCH_EBSA110 # ifdef machine_arch_type
@@ -14248,6 +14249,18 @@ extern unsigned int __machine_arch_type;# define machine_is_kzm9g () (0)#endif +#ifdef CONFIG_MACH_LP8X4X +# ifdef machine_arch_type +# undef machine_arch_type +# define machine_arch_type __machine_arch_type +# else +# define machine_arch_type MACH_TYPE_LP8X4X +# endif +# define machine_is_lp8x4x () (machine_arch_type == MACH_TYPE_LP8X4X) +#else +# define machine_is_lp8x4x () (0) +#endif +/* * These have not yet been registered */
board/icpdas/lp8x4x/Makefile new file +41 -0
41 lines not on this page · raw message
board/icpdas/lp8x4x/lp8x4x.c new file +133 -0
133 lines not on this page · raw message
boards.cfg +1 -0
@@ -1123,5 +1123,6 @@ gr_ep2s60 sparc leon3 - gaisler grsim sparc leon3 - gaisler gr_xc3s_1500 sparc leon3 - gaisler coreboot-x86 x86 x86 coreboot chromebook-x86 coreboot coreboot:SYS_TEXT_BASE=0x01110000 +lp8x4x arm pxa lp8x4x icpdas # Target ARCH CPU Board name Vendor SoC Options ########################################################################################################################
include/configs/lp8x4x.h new file +272 -0
272 lines not on this page · raw message
Signature · 1 line
1.7.10.4
PATCH 1/1 arm: pxa: Add support for ICP DAS LP-8x4x
Quoted 10 lines · Sergey Yanovich
LP-8x4x is a programmable automation controller by ICP DAS. It is shipped with outdated U-Boot v1.3.0
This patch adds enough supports to boot the board:
- 128M of 128M SDRAM
- 32M of 48M NOR Flash memory
- 1 of 4 Serial console (PXA FFUART)
- 1 of 2 Ethernet controller (DM9000)Signed-off-by Sergey Yanovich <[email protected]>
Some general comments follow:
Quoted 2 lines
--- arch/arm/include/asm/mach-types.h | 13 ++
Don't modify this file, instead add the MACH_TYPE define to the config file and set CONFIG_MACH_TYPE if needed really.
board/icpdas/lp8x4x/lp8x4x.c line 58
Quoted 4 lines
board/icpdas/lp8x4x/lp8x4x.c new file +4
-0+int dram_init (void ) +{ +pxa2xx_dram_init (); + gd->ram_size =PHYS_SDRAM_1_SIZE ;
Use get_ram_size(...) here please.
Quoted 1 line
+#ifdef
CONFIG_CMD_USB
Spaces not tab. And this is probably indicitive of other style problems, please run the patch over ./tools/checkpatch.pl before re-posting.
include/configs/lp8x4x.h line 30
Quoted 6 lines
include/configs/lp8x4x.h new file +6
-0+/* +* High Level Board Configuration Options +*/ +#define CONFIG_CPU_PXA27X 1/* Marvell PXA270 CPU */ +#define CONFIG_MACH_LP8X4X 1/* ICP DAS LP-8x4x */ +#define CONFIG_SYS_TEXT_BASE 0x00000000
In addition to tabs vs spaces, please just use '#define CONFIG_FOO' when you don't need to know what the value is, just set/unset.
include/configs/lp8x4x.h line 38
Quoted 8 lines
include/configs/lp8x4x.h new file +8
-0+ +/* +* Environment settings +*/ +#define CONFIG_ENV_OVERWRITE +#define CONFIG_SYS_CONSOLE_IS_IN_ENV +#define CONFIG_EXTRA_ENV_SETTINGS \ + "ethaddr=00:c0:26:28:96:30\0" \
No hardcoding ethaddr.
include/configs/lp8x4x.h line 41
Quoted 3 lines
include/configs/lp8x4x.h new file +3
-0+"ipaddr=192.168.0.10\0" \ +"netmask=255.255.255.0\0" \ +"serverip=192.168.0.1\0" \
Also, don't do this please.
include/configs/lp8x4x.h line 44
Quoted 3 lines
include/configs/lp8x4x.h new file +3
-0+"stdin=serial\0" \ +"stdout=serial\0" \ +"stderr=serial\0"
And these shouldn't be needed.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130328/82f52bcc/attachment.pgp>
PATCH v2 1/1 arm: pxa: Add support for ICP DAS LP-8x4x
LP-8x4x is a programmable automation controller by ICP DAS. It is shipped with outdated U-Boot v1.3.0
This patch adds enough supports to boot the board:
- 128M of 128M SDRAM
- 32M of 48M NOR Flash memory
- 1 of 4 Serial consoles (PXA FFUART)
- 2 of 2 Ethernet controllers (DM9000)
Series-to: u-boot
Series-cc: marex
---
Changes for v2:
- use get_ram_size(...) to init ram size
- fix defines
- fix formatting
- fix board GPIO settings
- initialize eth1 MAC for kernel
- use proper CONFIG_MACH_TYPE to init r1 in kernel call
- use proper image format in default boot cmd
MAINTAINERS | 4 + board/icpdas/lp8x4x/Makefile | 41 +++++++ board/icpdas/lp8x4x/lp8x4x.c | 147 ++++++++++++++++++++++++ boards.cfg | 1 + include/configs/lp8x4x.h | 262 ++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 455 insertions(+) create mode 100644 board/icpdas/lp8x4x/Makefile create mode 100644 board/icpdas/lp8x4x/lp8x4x.c create mode 100644 include/configs/lp8x4x.h
MAINTAINERS +4 -0
@@ -1052,6 +1052,10 @@ Eric Nelson <[email protected]> nitrogen6s i.MX6S 512MB nitrogen6s1g i.MX6S 1GB +Sergey Yanovich <[email protected]> + + lp8x4x xscale/pxa + ------------------------------------------------------------------------- Unknown / orphaned boards:
board/icpdas/lp8x4x/Makefile new file +41 -0
41 lines not on this page · raw message
board/icpdas/lp8x4x/lp8x4x.c new file +147 -0
147 lines not on this page · raw message
boards.cfg +1 -0
@@ -1147,5 +1147,6 @@ gr_ep2s60 sparc leon3 - gaisler grsim sparc leon3 - gaisler gr_xc3s_1500 sparc leon3 - gaisler coreboot-x86 x86 x86 coreboot chromebook-x86 coreboot coreboot:SYS_TEXT_BASE=0x01110000 +lp8x4x arm pxa lp8x4x icpdas # Target ARCH CPU Board name Vendor SoC Options ########################################################################################################################
include/configs/lp8x4x.h new file +262 -0
262 lines not on this page · raw message
Signature · 1 line
1.7.10.4
PATCH v2 1/1 arm: pxa: Add support for ICP DAS LP-8x4x
Dear Sergey Yanovich,
Quoted 9 lines
LP-8x4x is a programmable automation controller by ICP DAS. It is shipped with outdated U-Boot v1.3.0
This patch adds enough supports to boot the board:
- 128M of 128M SDRAM
- 32M of 48M NOR Flash memory
- 1 of 4 Serial consoles (PXA FFUART)
- 2 of 2 Ethernet controllers (DM9000)
Quoted 3 lines
Signed-off-by Sergey Yanovich <[email protected]>Series-to: u-boot
Series-cc: marex
Looks good.
Best regards,
Marek Vasut
PATCH 1/1 arm: pxa: Add support for ICP DAS LP-8x4x
In reply to Sergey YanovichQuoted 10 lines · Sergey Yanovich
LP-8x4x is a programmable automation controller by ICP DAS. It is shipped with outdated U-Boot v1.3.0
This patch adds enough supports to boot the board:
- 128M of 128M SDRAM
- 32M of 48M NOR Flash memory
- 1 of 4 Serial console (PXA FFUART)
- 1 of 2 Ethernet controller (DM9000)Signed-off-by Sergey Yanovich <[email protected]>
Quoted 10 lines
--- arch/arm/include/asm/mach-types.h | 13 ++ board/icpdas/lp8x4x/Makefile | 41 ++++++ board/icpdas/lp8x4x/lp8x4x.c | 133 ++++++++++++++++++ boards.cfg | 1 + include/configs/lp8x4x.h | 272 +++++++++++++++++++++++++++++++++++++ 5 files changed, 460 insertions(+) create mode 100644 board/icpdas/lp8x4x/Makefile create mode 100644 board/icpdas/lp8x4x/lp8x4x.c create mode 100644 include/configs/lp8x4x.h
Any chance to get any feedback?