perf: use hrtimer for event multiplexing
v4 cover perf: use hrtimer for event multiplexing
The current scheme of using the timer tick was fine for per-thread events. However, it was causing bias issues in system-wide mode (including for uncore PMUs). Event groups would not get their fair share of runtime on the PMU. With tickless kernels, if a core is idle there is no timer tick, and thus no event rotation (multiplexing). However, there are events (especially uncore events) which do count even though cores are asleep.
This patch changes the timer source for multiplexing. It introduces a per-cpu hrtimer. The advantage is that even when the core goes idle, it will come back to service the hrtimer, thus multiplexing on system-wide events works much better.
In order to minimize the impact of the hrtimer, it is turned on and off on demand. When the PMU on a CPU is overcommitted, the hrtimer is activated. It is stopped when the PMU is not overcommitted.
In order for this to work properly with HOTPLUG_CPU, we had to change the order of initialization in start_kernel() such that hrtimer_init() is run before perf_event_init().
The second patch provide a sysctl control to adjust the multiplexing interval. Unit is milliseconds.
Here is a simple before/after example with two event groups which do require multiplexing. This is done in system-wide mode on an idle system. What matters here is the scaling factor in [] in not the total counts.
Before:
# perf stat -a -e ref-cycles,ref-cycles sleep 10 Performance counter stats for 'sleep 10': 34,319,545 ref-cycles [56.51%] 31,917,229 ref-cycles [43.50%]
10.000827569 seconds time elapsed
After:
# perf stat -a -e ref-cycles,ref-cycles sleep 10 Performance counter stats for 'sleep 10': 11,144,822,193 ref-cycles [50.00%] 11,103,760,513 ref-cycles [50.00%]
10.000672946 seconds time elapsed
What matters here is the 50% not the actual count. Ref-cycles runs only on one fixed counter. With two instances, each should get 50% of the PMU which is now true. This helps mitigate the error introduced by the scaling.
In this second version of the patchset, we now have the hrtimer_interval per PMU instance. The tunable is in /sys/devices/XXX/mux_interval_ms, where XXX is the name of the PMU instance. Due to initialization changes of each hrtimer, we had to introduce hrtimer_init_cpu() to initialize a hrtimer from another CPU.
In the 3rd version, we simplify the code a bit by using hrtimer_active(). We stopped using the rotation_list for perf_cpu_hrtimer_cancel(). We also fix an intialization problem.
In the 4th version, we rebase to 3.8.0-rc7 and we kept SW event on the rotation list which is now used only for unthrottling. We also renamed the sysfs tunable to perf_event_mux_interval_ms to be more consistent with the existing sysctl entries.
---
Stephane Eranian (2):
perf: use hrtimer for event multiplexing
perf: add sysfs entry to adjust multiplexing interval per PMU
include/linux/perf_event.h | 4 +- init/main.c | 2 +- kernel/events/core.c | 169 +++++++++++++++++++++++++++++++++++++++++--- 3 files changed, 164 insertions(+), 11 deletions(-)
Signature · 1 line
1.7.9.5
PATCH v4 1/2 perf: use hrtimer for event multiplexing
The current scheme of using the timer tick was fine for per-thread events. However, it was causing bias issues in system-wide mode (including for uncore PMUs). Event groups would not get their fair share of runtime on the PMU. With tickless kernels, if a core is idle there is no timer tick, and thus no event rotation (multiplexing). However, there are events (especially uncore events) which do count even though cores are asleep.
This patch changes the timer source for multiplexing. It introduces a per-PMU per-cpu hrtimer. The advantage is that even when a core goes idle, it will come back to service the hrtimer, thus multiplexing on system-wide events works much better.
The per-PMU implementation (suggested by PeterZ) enables adjusting the multiplexing interval per PMU. The preferred interval is stashed into the struct pmu. If not set, it will be forced to the default interval value.
In order to minimize the impact of the hrtimer, it is turned on and off on demand. When the PMU on a CPU is overcommited, the hrtimer is activated. It is stopped when the PMU is not overcommitted.
In order for this to work properly, we had to change the order of initialization in start_kernel() such that hrtimer_init() is run before perf_event_init().
The default interval in milliseconds is set to a timer tick just like with the old code. We will provide a sysctl to tune this in another patch.
--- include/linux/perf_event.h | 3 +- init/main.c | 2 +- kernel/events/core.c | 117 +++++++++++++++++++++++++++++++++++++++++--- 3 files changed, 113 insertions(+), 9 deletions(-)
include/linux/perf_event.h +2 -1
@@ -516,8 +516,9 @@ struct perf_cpu_context {struct perf_event_context *task_ctx;int active_oncpu;int exclusive; +struct hrtimer hrtimer; +ktime_t hrtimer_interval;struct list_head rotation_list; -int jiffies_interval;struct pmu *unique_pmu;struct perf_cgroup *cgrp; };
init/main.c +1 -1
@@ -543,7 +543,6 @@ asmlinkage void __init start_kernel(void)local_irq_disable (); }idr_init_cache (); -perf_event_init ();rcu_init ();radix_tree_init ();/* init some links before init_ISA_irqs() */
@@ -554,6 +553,7 @@ asmlinkage void __init start_kernel(void)softirq_init ();timekeeping_init ();time_init (); +perf_event_init ();profile_init ();call_function_init ();if (!irqs_disabled ())
kernel/events/core.c +110 -7
178 lines not on this page · raw message
Signature · 1 line
1.7.9.5
PATCH v4 2/2 perf: add sysfs entry to adjust multiplexing interval per PMU
In reply to Stephane EranianThis patch adds /sys/device/xxx/perf_event_mux_interval_ms to ajust the multiplexing interval per PMU. The unit is milliseconds. Value has to be >= 1.
In the 4th version, we renamed the sysfs file to be more consistent with the other /proc/sys/kernel entries for perf_events.
--- include/linux/perf_event.h | 1 + kernel/events/core.c | 56 ++++++++++++++++++++++++++++++++++++++++---- 2 files changed, 53 insertions(+), 4 deletions(-)
include/linux/perf_event.h +1 -0
@@ -194,6 +194,7 @@ struct pmu {int *__percpu pmu_disable_count;struct perf_cpu_context *__percpu pmu_cpu_context;int task_ctx_nr; +int hrtimer_interval_ms;/* * Fully disable/enable this PMU, can be used to protect from the PMI
kernel/events/core.c +52 -4
74 lines not on this page · raw message
Signature · 1 line
1.7.9.5
Re: [PATCH v4 2/2] perf: add sysfs entry to adjust multiplexing interval per PMU
On Mon, Feb 18, 2013 at 06:54:44PM +0100, Stephane Eranian wrote:
SNIP
Quoted 12 lines
(quoted diff) +12
-0+perf_event_mux_interval_ms_store(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t count) +{ + struct pmu *pmu = dev_get_drvdata(dev); + int timer, cpu, ret; + + ret = kstrtoint(buf, 0, &timer); + if (ret) + return ret; + + if (timer < 1)
Review
Quoted 10 lines
(quoted diff) +10
-0+ return -EINVAL; + + pmu->hrtimer_interval_ms = timer; + + /* update all cpuctx for this PMU */ + for_each_possible_cpu(cpu) { + struct perf_cpu_context *cpuctx; + cpuctx = per_cpu_ptr(pmu->pmu_cpu_context, cpu); + cpuctx->hrtimer_interval = ns_to_ktime(NSEC_PER_MSEC * timer); + }
If we set the timer to some big value like few minutes, then run the meassurements and then set the value back to 1, we actually need to wait till the big timer is expired before the new value takes place.
I think we need to cancel the possible running timer in here like in the atached patch, but maybe consider some locking.
jirka
kernel/events/core.c +3 -0
@@ -6038,6 +6038,9 @@ perf_event_mux_interval_ms_store(struct device *dev,struct perf_cpu_context *cpuctx; cpuctx =per_cpu_ptr (pmu->pmu_cpu_context, cpu); cpuctx->hrtimer_interval =ns_to_ktime (NSEC_PER_MSEC * timer); + +if (hrtimer_active (&cpuctx->hrtimer)) +hrtimer_cancel (&cpuctx->hrtimer); }return count;
Re: [PATCH v4 2/2] perf: add sysfs entry to adjust multiplexing interval per PMU
Quoted 32 lines · Jiri Olsa
On Mon, Feb 18, 2013 at 06:54:44PM +0100, Stephane Eranian wrote:
SNIP
Quoted 12 lines
(quoted diff) +12
-0+perf_event_mux_interval_ms_store(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t count) +{ + struct pmu *pmu = dev_get_drvdata(dev); + int timer, cpu, ret; + + ret = kstrtoint(buf, 0, &timer); + if (ret) + return ret; + + if (timer < 1)Review
Quoted 10 lines
(quoted diff) +10
-0+ return -EINVAL; + + pmu->hrtimer_interval_ms = timer; + + /* update all cpuctx for this PMU */ + for_each_possible_cpu(cpu) { + struct perf_cpu_context *cpuctx; + cpuctx = per_cpu_ptr(pmu->pmu_cpu_context, cpu); + cpuctx->hrtimer_interval = ns_to_ktime(NSEC_PER_MSEC * timer); + }If we set the timer to some big value like few minutes, then run the meassurements and then set the value back to 1, we actually need to wait till the big timer is expired before the new value takes place.
Quoted 3 lines
I think we need to cancel the possible running timer in here like in the atached patch, but maybe consider some locking.
I will fix that. Thanks for pointing this out.
Quoted 17 lines
jirka
kernel/events/core.c +3
-0@@ -6038,6 +6038,9 @@ perf_event_mux_interval_ms_store(struct device *dev,struct perf_cpu_context *cpuctx; cpuctx =per_cpu_ptr (pmu->pmu_cpu_context, cpu); cpuctx->hrtimer_interval =ns_to_ktime (NSEC_PER_MSEC * timer); + +if (hrtimer_active (&cpuctx->hrtimer)) +hrtimer_cancel (&cpuctx->hrtimer); }return count;