Skip to contentSkip to conversation

cpqarray: do_ida_request() - reduce stack frame size

PATCH New Tim Gardner 1 participant 1 message Feb 18, 2013 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cpqarray: do_ida_request() - reduce stack frame size

do_ida_request() can be called from within interrupt context. A stack frame of more then 1K runs the risk of overflowing the kernel stack. Correct this situation by dynamically allocating the large (and temporary) scatter/gather array. A failure from kmalloc() will leave a stack trace in the kernel log.

drivers/block/cpqarray.c: In function ‘do_ida_request’:
drivers/block/cpqarray.c:969:1: warning: the frame size of 1072 bytes is larger than 1024 bytes [-Wframe-larger-than=]

---
 drivers/block/cpqarray.c |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/block/cpqarray.c +6 -1
index 3f08713..2715b35 100644
@@ -908,9 +908,13 @@ static void do_ida_request(struct request_queue *q)
 	ctlr_info_t *h = q->queuedata;
 	cmdlist_t *c;
 	struct request *creq;
-	struct scatterlist tmp_sg[SG_MAX];
+	struct scatterlist *tmp_sg;
 	int i, dir, seg;
 
+	tmp_sg = kmalloc(sizeof(*tmp_sg) * SG_MAX, GFP_ATOMIC);
+	if (!tmp_sg)
+		return;
+
 queue_next:
 	creq = blk_peek_request(q);
 	if (!creq)
@@ -966,6 +970,7 @@ DBGPX(	printk("Submitting %u sectors in %d segments\n", blk_rq_sectors(creq), se
 
 startio:
 	start_io(h);
+	kfree(tmp_sg);
 }
 
 /* 
Signature · 1 line
1.7.9.5