Skip to contentSkip to conversation

b44: use helper function for aligning IP header

PATCH New Rafał Miłecki 1 participant 1 message Feb 19, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 b44: use helper function for aligning IP header

Don't duplicate netdev_alloc_skb_ip_align which by the way uses NET_IP_ALIGN instead of hardcoded "2".

---
I don't have hardware to check this, so please review if it's OK. It's quite trivial so I hope I couldn't do anything wrong.

---
 drivers/net/ethernet/broadcom/b44.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/ethernet/broadcom/b44.c +1 -2
index 330b090..041aea6 100644
@@ -809,11 +809,10 @@ static int b44_rx(struct b44 *bp, int budget)
 			struct sk_buff *copy_skb;
 
 			b44_recycle_rx(bp, cons, bp->rx_prod);
-			copy_skb = netdev_alloc_skb(bp->dev, len + 2);
+			copy_skb = netdev_alloc_skb_ip_align(bp->dev, len);
 			if (copy_skb == NULL)
 				goto drop_it_no_recycle;
 
-			skb_reserve(copy_skb, 2);
 			skb_put(copy_skb, len);
 			/* DMA sync done above, copy just the actual packet */
 			skb_copy_from_linear_data_offset(skb, RX_PKT_OFFSET,
Signature · 1 line
1.7.10.4