drm: Keep a reference to the active plane framebuffer
Subsystems (2)
PATCH 1/1 drm: Keep a reference to the active plane framebuffer
When updating a plane, the DRM core always sets the plane's framebuffer to NULL. This in turn will cause the reference count on the plane's active framebuffer to become unbalanced because on the next update, the old framebuffer will be NULL.
--- drivers/gpu/drm/drm_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/drm_crtc.c +1 -1
@@ -1984,9 +1984,9 @@ int drm_mode_setplane(struct drm_device *dev, void *data, plane_req->src_w, plane_req->src_h);if (!ret) { old_fb = plane->fb; + plane->fb = fb; fb =NULL ; plane->crtc = crtc; - plane->fb = fb; }drm_modeset_unlock_all (dev);
Signature · 1 line
1.8.1.2
Quoted 6 lines · Thierry Reding
When updating a plane, the DRM core always sets the plane's framebuffer to NULL. This in turn will cause the reference count on the plane's active framebuffer to become unbalanced because on the next update, the old framebuffer will be NULL.
Signed-off-by Thierry Reding <[email protected]>
http://lists.freedesktop.org/archives/dri-devel/2013-February/034978.html
Signature · 2 lines
Ville Syrjälä Intel OTC
Quoted 9 lines · Ville Syrjälä
Quoted 6 lines · Thierry Reding
When updating a plane, the DRM core always sets the plane's framebuffer to NULL. This in turn will cause the reference count on the plane's active framebuffer to become unbalanced because on the next update, the old framebuffer will be NULL.
Signed-off-by Thierry Reding <[email protected]>http://lists.freedesktop.org/archives/dri-devel/2013-February/034978.html
Darn, I had searched for it but must have missed it. Thanks.
Thierry
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel