Add Boundary Devices Nitrogen6X boards
PATCH 1/1 Add Boundary Devices Nitrogen6X boards
--- MAINTAINERS | 8 + board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg | 58 ++ board/boundary/nitrogen6x/1066mhz_4x256mx16.cfg | 58 ++ board/boundary/nitrogen6x/6x_bootscript.txt | 63 ++ .../boundary/nitrogen6x/6x_bootscript_android.txt | 64 ++ .../nitrogen6x/6x_bootscript_android_recovery.txt | 64 ++ board/boundary/nitrogen6x/6x_upgrade.txt | 45 + board/boundary/nitrogen6x/800mhz_2x128mx16.cfg | 58 ++ board/boundary/nitrogen6x/800mhz_2x256mx16.cfg | 58 ++ board/boundary/nitrogen6x/800mhz_4x128mx16.cfg | 57 ++ board/boundary/nitrogen6x/800mhz_4x256mx16.cfg | 58 ++ board/boundary/nitrogen6x/Makefile | 41 + board/boundary/nitrogen6x/README | 92 ++ board/boundary/nitrogen6x/clocks.cfg | 46 + board/boundary/nitrogen6x/ddr-setup.cfg | 112 +++ board/boundary/nitrogen6x/nitrogen6dl.cfg | 45 + board/boundary/nitrogen6x/nitrogen6dl2g.cfg | 45 + board/boundary/nitrogen6x/nitrogen6q.cfg | 45 + board/boundary/nitrogen6x/nitrogen6q2g.cfg | 45 + board/boundary/nitrogen6x/nitrogen6s.cfg | 45 + board/boundary/nitrogen6x/nitrogen6s1g.cfg | 45 + board/boundary/nitrogen6x/nitrogen6x.c | 901 ++++++++++++++++++++ boards.cfg | 6 + include/configs/nitrogen6x.h | 287 +++++++ 24 files changed, 2346 insertions(+) create mode 100644 board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg create mode 100644 board/boundary/nitrogen6x/1066mhz_4x256mx16.cfg create mode 100644 board/boundary/nitrogen6x/6x_bootscript.txt create mode 100644 board/boundary/nitrogen6x/6x_bootscript_android.txt create mode 100644 board/boundary/nitrogen6x/6x_bootscript_android_recovery.txt create mode 100644 board/boundary/nitrogen6x/6x_upgrade.txt create mode 100644 board/boundary/nitrogen6x/800mhz_2x128mx16.cfg create mode 100644 board/boundary/nitrogen6x/800mhz_2x256mx16.cfg create mode 100644 board/boundary/nitrogen6x/800mhz_4x128mx16.cfg create mode 100644 board/boundary/nitrogen6x/800mhz_4x256mx16.cfg create mode 100644 board/boundary/nitrogen6x/Makefile create mode 100644 board/boundary/nitrogen6x/README create mode 100644 board/boundary/nitrogen6x/clocks.cfg create mode 100644 board/boundary/nitrogen6x/ddr-setup.cfg create mode 100644 board/boundary/nitrogen6x/nitrogen6dl.cfg create mode 100644 board/boundary/nitrogen6x/nitrogen6dl2g.cfg create mode 100644 board/boundary/nitrogen6x/nitrogen6q.cfg create mode 100644 board/boundary/nitrogen6x/nitrogen6q2g.cfg create mode 100644 board/boundary/nitrogen6x/nitrogen6s.cfg create mode 100644 board/boundary/nitrogen6x/nitrogen6s1g.cfg create mode 100644 board/boundary/nitrogen6x/nitrogen6x.c create mode 100644 include/configs/nitrogen6x.h
MAINTAINERS +8 -0
@@ -1029,6 +1029,14 @@ Pali Roh?r <[email protected]> nokia_rx51 ARM ARMV7 (OMAP34xx SoC) +Eric Nelson <[email protected]> + nitrogen6dl i.MX6DL 1GB + nitrogen6dl2g i.MX6DL 2GB + nitrogen6q i.MX6Q/6D 1GB + nitrogen6q2g i.MX6Q/6D 2GB + nitrogen6s i.MX6S 512MB + nitrogen6s1g i.MX6S 1GB + ------------------------------------------------------------------------- Unknown / orphaned boards:
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +58 -0
58 lines not on this page · raw message
board/boundary/nitrogen6x/1066mhz_4x256mx16.cfg new file +58 -0
58 lines not on this page · raw message
board/boundary/nitrogen6x/6x_bootscript.txt new file +63 -0
63 lines not on this page · raw message
board/boundary/nitrogen6x/6x_bootscript_android.txt new file +64 -0
64 lines not on this page · raw message
board/boundary/nitrogen6x/6x_bootscript_android_recovery.txt new file +64 -0
64 lines not on this page · raw message
board/boundary/nitrogen6x/6x_upgrade.txt new file +45 -0
45 lines not on this page · raw message
board/boundary/nitrogen6x/800mhz_2x128mx16.cfg new file +58 -0
58 lines not on this page · raw message
board/boundary/nitrogen6x/800mhz_2x256mx16.cfg new file +58 -0
58 lines not on this page · raw message
board/boundary/nitrogen6x/800mhz_4x128mx16.cfg new file +57 -0
57 lines not on this page · raw message
board/boundary/nitrogen6x/800mhz_4x256mx16.cfg new file +58 -0
58 lines not on this page · raw message
board/boundary/nitrogen6x/Makefile new file +41 -0
41 lines not on this page · raw message
board/boundary/nitrogen6x/README new file +92 -0
92 lines not on this page · raw message
board/boundary/nitrogen6x/clocks.cfg new file +46 -0
46 lines not on this page · raw message
board/boundary/nitrogen6x/ddr-setup.cfg new file +112 -0
112 lines not on this page · raw message
board/boundary/nitrogen6x/nitrogen6dl.cfg new file +45 -0
45 lines not on this page · raw message
board/boundary/nitrogen6x/nitrogen6dl2g.cfg new file +45 -0
45 lines not on this page · raw message
board/boundary/nitrogen6x/nitrogen6q.cfg new file +45 -0
45 lines not on this page · raw message
board/boundary/nitrogen6x/nitrogen6q2g.cfg new file +45 -0
45 lines not on this page · raw message
board/boundary/nitrogen6x/nitrogen6s.cfg new file +45 -0
45 lines not on this page · raw message
board/boundary/nitrogen6x/nitrogen6s1g.cfg new file +45 -0
45 lines not on this page · raw message
board/boundary/nitrogen6x/nitrogen6x.c new file +901 -0
901 lines not on this page · raw message
boards.cfg +6 -0
@@ -253,6 +253,12 @@ mx6qsabreauto arm armv7 mx6qsabreauto freesca mx6qsabrelite arm armv7 mx6qsabrelite freescale mx6 mx6qsabrelite:IMX_CONFIG=board/freescale/imx/ddr/mx6q_4x_mt41j128.cfg mx6qsabresd arm armv7 mx6qsabresd freescale mx6 mx6qsabresd:IMX_CONFIG=board/freescale/imx/ddr/mx6q_4x_mt41j128.cfg eco5pk arm armv7 eco5pk 8dtech omap3 +nitrogen6dl arm armv7 nitrogen6x boundary mx6 nitrogen6x:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6dl.cfg,MX6DL +nitrogen6dl2g arm armv7 nitrogen6x boundary mx6 nitrogen6x:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6dl2g.cfg,MX6DL +nitrogen6q arm armv7 nitrogen6x boundary mx6 nitrogen6x:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6q.cfg,MX6Q +nitrogen6q2g arm armv7 nitrogen6x boundary mx6 nitrogen6x:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6q2g.cfg,MX6Q +nitrogen6s arm armv7 nitrogen6x boundary mx6 nitrogen6x:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6s.cfg,MX6S +nitrogen6s1g arm armv7 nitrogen6x boundary mx6 nitrogen6x:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6s1g.cfg,MX6S cm_t35 arm armv7 cm_t35 - omap3 omap3_overo arm armv7 overo - omap3 omap3_pandora arm armv7 pandora - omap3
include/configs/nitrogen6x.h new file +287 -0
287 lines not on this page · raw message
Signature · 1 line
1.7.9.5
PATCH 1/1 Add Boundary Devices Nitrogen6X boards
Hi Eric,
On Tuesday, February 19, 2013 9:20:48 PM, Eric Nelson wrote:
[--snip--]
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg
Quoted 6 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +0
-0
[--snip--]
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg line 24
Quoted 2 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +2
-0+DATA 4, MX6_MMDC_P0_MDPDC, 0x00020036 +DATA 4, MX6_MMDC_P0_MDCFG0, 0x555B7974
^A?
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg line 28
Quoted 4 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +4
-0+DATA 4, MX6_MMDC_P0_MDCFG1, 0xDB538F64 +DATA 4, MX6_MMDC_P0_MDCFG2, 0x01FF00DB +DATA 4, MX6_MMDC_P0_MDRWD, 0x000026D2 +DATA 4, MX6_MMDC_P0_MDOR, 0x005B1023
^A?
Quoted 20 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +20
-0+DATA 4, MX6_MMDC_P0_MDOTC, 0x09444040 +DATA 4, MX6_MMDC_P0_MDPDC, 0x00025576 +DATA 4, MX6_MMDC_P0_MDASP, 0x00000027 +DATA 4, MX6_MMDC_P0_MDCTL, 0x831A0000 +DATA 4, MX6_MMDC_P0_MDSCR, 0x04088032 +DATA 4, MX6_MMDC_P0_MDSCR, 0x00008033 +DATA 4, MX6_MMDC_P0_MDSCR, 0x00428031 +DATA 4, MX6_MMDC_P0_MDSCR, 0x19308030 +DATA 4, MX6_MMDC_P0_MDSCR, 0x04008040 +DATA 4, MX6_MMDC_P0_MPZQHWCTRL, 0xA1390003 +DATA 4, MX6_MMDC_P1_MPZQHWCTRL, 0xA1390003 +DATA 4, MX6_MMDC_P0_MDREF, 0x00005800 +DATA 4, MX6_MMDC_P0_MPODTCTRL, 0x00022227 +DATA 4, MX6_MMDC_P1_MPODTCTRL, 0x00022227 +DATA 4, MX6_MMDC_P0_MPDGCTRL0, 0x42720306 +DATA 4, MX6_MMDC_P0_MPDGCTRL1, 0x026F0266 +DATA 4, MX6_MMDC_P1_MPDGCTRL0, 0x4273030A +DATA 4, MX6_MMDC_P1_MPDGCTRL1, 0x02740240 +DATA 4, MX6_MMDC_P0_MPRDDLCTL, 0x45393B3E +DATA 4, MX6_MMDC_P1_MPRDDLCTL, 0x403A3747
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg line 58
Quoted 10 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +10
-0+DATA 4, MX6_MMDC_P0_MPWRDLCTL, 0x40434541 +DATA 4, MX6_MMDC_P1_MPWRDLCTL, 0x473E4A3B +DATA 4, MX6_MMDC_P0_MPWLDECTRL0, 0x0011000E +DATA 4, MX6_MMDC_P0_MPWLDECTRL1, 0x000E001B +DATA 4, MX6_MMDC_P1_MPWLDECTRL0, 0x00190015 +DATA 4, MX6_MMDC_P1_MPWLDECTRL1, 0x00070018 +DATA 4, MX6_MMDC_P0_MPMUR0, 0x00000800 +DATA 4, MX6_MMDC_P1_MPMUR0, 0x00000800 +DATA 4, MX6_MMDC_P0_MDSCR, 0x00000000 +DATA 4, MX6_MMDC_P0_MAPSR, 0x00011006
[--snip--]
tXS = tXPR = 170 ns -> 91 nCK -> 91 - 1 -> 0x5A.
Best regards,
Beno?t
PATCH 1/1 Add Boundary Devices Nitrogen6X boards
Quoted 51 lines · Beno?t Th?baudeau
Hi Eric,
On Tuesday, February 19, 2013 9:20:48 PM, Eric Nelson wrote:
[--snip--]board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg
Quoted 6 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +0
-0[--snip--]
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg line 24
Quoted 2 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +2
-0+DATA 4, MX6_MMDC_P0_MDPDC, 0x00020036 +DATA 4, MX6_MMDC_P0_MDCFG0, 0x555B7974^A?board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg line 28
Quoted 4 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +4
-0+DATA 4, MX6_MMDC_P0_MDCFG1, 0xDB538F64 +DATA 4, MX6_MMDC_P0_MDCFG2, 0x01FF00DB +DATA 4, MX6_MMDC_P0_MDRWD, 0x000026D2 +DATA 4, MX6_MMDC_P0_MDOR, 0x005B1023^A?Quoted 20 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +20
-0+DATA 4, MX6_MMDC_P0_MDOTC, 0x09444040 +DATA 4, MX6_MMDC_P0_MDPDC, 0x00025576 +DATA 4, MX6_MMDC_P0_MDASP, 0x00000027 +DATA 4, MX6_MMDC_P0_MDCTL, 0x831A0000 +DATA 4, MX6_MMDC_P0_MDSCR, 0x04088032 +DATA 4, MX6_MMDC_P0_MDSCR, 0x00008033 +DATA 4, MX6_MMDC_P0_MDSCR, 0x00428031 +DATA 4, MX6_MMDC_P0_MDSCR, 0x19308030 +DATA 4, MX6_MMDC_P0_MDSCR, 0x04008040 +DATA 4, MX6_MMDC_P0_MPZQHWCTRL, 0xA1390003 +DATA 4, MX6_MMDC_P1_MPZQHWCTRL, 0xA1390003 +DATA 4, MX6_MMDC_P0_MDREF, 0x00005800 +DATA 4, MX6_MMDC_P0_MPODTCTRL, 0x00022227 +DATA 4, MX6_MMDC_P1_MPODTCTRL, 0x00022227 +DATA 4, MX6_MMDC_P0_MPDGCTRL0, 0x42720306 +DATA 4, MX6_MMDC_P0_MPDGCTRL1, 0x026F0266 +DATA 4, MX6_MMDC_P1_MPDGCTRL0, 0x4273030A +DATA 4, MX6_MMDC_P1_MPDGCTRL1, 0x02740240 +DATA 4, MX6_MMDC_P0_MPRDDLCTL, 0x45393B3E +DATA 4, MX6_MMDC_P1_MPRDDLCTL, 0x403A3747board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg line 58
Quoted 10 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +10
-0+DATA 4, MX6_MMDC_P0_MPWRDLCTL, 0x40434541 +DATA 4, MX6_MMDC_P1_MPWRDLCTL, 0x473E4A3B +DATA 4, MX6_MMDC_P0_MPWLDECTRL0, 0x0011000E +DATA 4, MX6_MMDC_P0_MPWLDECTRL1, 0x000E001B +DATA 4, MX6_MMDC_P1_MPWLDECTRL0, 0x00190015 +DATA 4, MX6_MMDC_P1_MPWLDECTRL1, 0x00070018 +DATA 4, MX6_MMDC_P0_MPMUR0, 0x00000800 +DATA 4, MX6_MMDC_P1_MPMUR0, 0x00000800 +DATA 4, MX6_MMDC_P0_MDSCR, 0x00000000 +DATA 4, MX6_MMDC_P0_MAPSR, 0x00011006[--snip--]
Quoted 2 lines
tXS = tXPR = 170 ns -> 91 nCK -> 91 - 1 ->
0x5A.
Thanks Beno?t,
I was going to bring this up in a separate thread.
While working through the details of our 800MHz variants (Solo, Dual-Lite), and x256mx16 variants, I re-worked these numbers and it seems that we have an off-by-one issue with those fields.
According to the JEDEC spec and data sheets, both tXS and tXPR should be 10nS greater than tRFC.
Since the nominal clock for i.MX6 is 528MHz (1.89nS), this should be a delta of 6 clocks, not 5.
This change should apply to mx6q_4x_mt41j128.cfg as well.
There are some other things in that file that should be fixed as well. The biggest among them is the settings for P1_MPWLDECTRL0/1.
These settings are indicative of a fly-by topology, which isn't used on SABRE Lite, and I don't think is used on SABRE SD.
DATA 4 0x021b480c 0x00440044 DATA 4 0x021b4810 0x00440044
This was the primary thing that caused crashes under stress on SABRE Lite and led to our flurry of calibration tests as discussed here:
http://boundarydevices.com/i-mx-6dq-u-boot-updates/
Should we take this up in a separate thread? It seems un-related to our Nitrogen6X board.
Regards,
Eric
PATCH 1/1 Add Boundary Devices Nitrogen6X boards
Quoted 55 lines · Eric Nelson
Quoted 51 lines · Beno?t Th?baudeau
Hi Eric,
On Tuesday, February 19, 2013 9:20:48 PM, Eric Nelson wrote:
[--snip--]board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg
Quoted 6 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +0
-0[--snip--]
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg line 24
Quoted 2 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +2
-0+DATA 4, MX6_MMDC_P0_MDPDC, 0x00020036 +DATA 4, MX6_MMDC_P0_MDCFG0, 0x555B7974^A?board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg line 28
Quoted 4 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +4
-0+DATA 4, MX6_MMDC_P0_MDCFG1, 0xDB538F64 +DATA 4, MX6_MMDC_P0_MDCFG2, 0x01FF00DB +DATA 4, MX6_MMDC_P0_MDRWD, 0x000026D2 +DATA 4, MX6_MMDC_P0_MDOR, 0x005B1023^A?Quoted 20 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +20
-0+DATA 4, MX6_MMDC_P0_MDOTC, 0x09444040 +DATA 4, MX6_MMDC_P0_MDPDC, 0x00025576 +DATA 4, MX6_MMDC_P0_MDASP, 0x00000027 +DATA 4, MX6_MMDC_P0_MDCTL, 0x831A0000 +DATA 4, MX6_MMDC_P0_MDSCR, 0x04088032 +DATA 4, MX6_MMDC_P0_MDSCR, 0x00008033 +DATA 4, MX6_MMDC_P0_MDSCR, 0x00428031 +DATA 4, MX6_MMDC_P0_MDSCR, 0x19308030 +DATA 4, MX6_MMDC_P0_MDSCR, 0x04008040 +DATA 4, MX6_MMDC_P0_MPZQHWCTRL, 0xA1390003 +DATA 4, MX6_MMDC_P1_MPZQHWCTRL, 0xA1390003 +DATA 4, MX6_MMDC_P0_MDREF, 0x00005800 +DATA 4, MX6_MMDC_P0_MPODTCTRL, 0x00022227 +DATA 4, MX6_MMDC_P1_MPODTCTRL, 0x00022227 +DATA 4, MX6_MMDC_P0_MPDGCTRL0, 0x42720306 +DATA 4, MX6_MMDC_P0_MPDGCTRL1, 0x026F0266 +DATA 4, MX6_MMDC_P1_MPDGCTRL0, 0x4273030A +DATA 4, MX6_MMDC_P1_MPDGCTRL1, 0x02740240 +DATA 4, MX6_MMDC_P0_MPRDDLCTL, 0x45393B3E +DATA 4, MX6_MMDC_P1_MPRDDLCTL, 0x403A3747board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg line 58
Quoted 10 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +10
-0+DATA 4, MX6_MMDC_P0_MPWRDLCTL, 0x40434541 +DATA 4, MX6_MMDC_P1_MPWRDLCTL, 0x473E4A3B +DATA 4, MX6_MMDC_P0_MPWLDECTRL0, 0x0011000E +DATA 4, MX6_MMDC_P0_MPWLDECTRL1, 0x000E001B +DATA 4, MX6_MMDC_P1_MPWLDECTRL0, 0x00190015 +DATA 4, MX6_MMDC_P1_MPWLDECTRL1, 0x00070018 +DATA 4, MX6_MMDC_P0_MPMUR0, 0x00000800 +DATA 4, MX6_MMDC_P1_MPMUR0, 0x00000800 +DATA 4, MX6_MMDC_P0_MDSCR, 0x00000000 +DATA 4, MX6_MMDC_P0_MAPSR, 0x00011006[--snip--]
Quoted 2 lines
tXS = tXPR = 170 ns -> 91 nCK -> 91 - 1 ->
0x5A.
Quoted 8 lines
Thanks Beno?t,
I was going to bring this up in a separate thread.
While working through the details of our 800MHz variants (Solo, Dual-Lite), and x256mx16 variants, I re-worked these numbers and it seems that we have an off-by-one issue with those fields.
Probably because it has been missed that the bit-field value is the number of clock cycles minus 1.
Quoted 2 lines
According to the JEDEC spec and data sheets, both tXS and tXPR should be 10nS greater than tRFC.
Indeed, or more precisely, max(5 nCK, tRFC + 10 ns).
Quoted 1 line
Since the nominal clock for i.MX6 is 528MHz (1.89nS),
I used 532 MHz because this is a more standard value, and I found several close different values in the documentation, so in the doubt, I chose the worst case. With 528 MHz, the bit-field value would be 0x59.
Quoted 1 line
this should be a delta of 6 clocks, not 5.
Delta with what?
Quoted 1 line
This change should apply to mx6q_4x_mt41j128.cfg as well.
Sure.
Quoted 3 lines
There are some other things in that file that should be fixed as well. The biggest among them is the settings for P1_MPWLDECTRL0/1.
Note that in this series, I have only reviewed the register values that changed in my series, and only for 1066mhz_4x128mx16.cfg.
Quoted 4 lines
These settings are indicative of a fly-by topology, which isn't used on SABRE Lite, and I don't think is used on SABRE SD.
Quoted 8 lines
DATA 4 0x021b480c 0x00440044 DATA 4 0x021b4810 0x00440044This was the primary thing that caused crashes under stress on SABRE Lite and led to our flurry of calibration tests as discussed here:
OK. I had not looked in detail into this.
Quoted 2 lines
Should we take this up in a separate thread? It seems un-related to our Nitrogen6X board.
As you prefer. This is related to this series, but a very specific subject per se.
Best regards,
Beno?t
PATCH 1/1 Add Boundary Devices Nitrogen6X boards
Hi Beno?t,
Quoted 60 lines · Beno?t Th?baudeau
Quoted 59 lines · Eric Nelson
Quoted 51 lines · Beno?t Th?baudeau
Hi Eric,
On Tuesday, February 19, 2013 9:20:48 PM, Eric Nelson wrote:
[--snip--]board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg
Quoted 6 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +0
-0[--snip--]
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg line 24
Quoted 2 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +2
-0+DATA 4, MX6_MMDC_P0_MDPDC, 0x00020036 +DATA 4, MX6_MMDC_P0_MDCFG0, 0x555B7974^A?board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg line 28
Quoted 4 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +4
-0+DATA 4, MX6_MMDC_P0_MDCFG1, 0xDB538F64 +DATA 4, MX6_MMDC_P0_MDCFG2, 0x01FF00DB +DATA 4, MX6_MMDC_P0_MDRWD, 0x000026D2 +DATA 4, MX6_MMDC_P0_MDOR, 0x005B1023^A?Quoted 20 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +20
-0+DATA 4, MX6_MMDC_P0_MDOTC, 0x09444040 +DATA 4, MX6_MMDC_P0_MDPDC, 0x00025576 +DATA 4, MX6_MMDC_P0_MDASP, 0x00000027 +DATA 4, MX6_MMDC_P0_MDCTL, 0x831A0000 +DATA 4, MX6_MMDC_P0_MDSCR, 0x04088032 +DATA 4, MX6_MMDC_P0_MDSCR, 0x00008033 +DATA 4, MX6_MMDC_P0_MDSCR, 0x00428031 +DATA 4, MX6_MMDC_P0_MDSCR, 0x19308030 +DATA 4, MX6_MMDC_P0_MDSCR, 0x04008040 +DATA 4, MX6_MMDC_P0_MPZQHWCTRL, 0xA1390003 +DATA 4, MX6_MMDC_P1_MPZQHWCTRL, 0xA1390003 +DATA 4, MX6_MMDC_P0_MDREF, 0x00005800 +DATA 4, MX6_MMDC_P0_MPODTCTRL, 0x00022227 +DATA 4, MX6_MMDC_P1_MPODTCTRL, 0x00022227 +DATA 4, MX6_MMDC_P0_MPDGCTRL0, 0x42720306 +DATA 4, MX6_MMDC_P0_MPDGCTRL1, 0x026F0266 +DATA 4, MX6_MMDC_P1_MPDGCTRL0, 0x4273030A +DATA 4, MX6_MMDC_P1_MPDGCTRL1, 0x02740240 +DATA 4, MX6_MMDC_P0_MPRDDLCTL, 0x45393B3E +DATA 4, MX6_MMDC_P1_MPRDDLCTL, 0x403A3747board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg line 58
Quoted 10 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +10
-0+DATA 4, MX6_MMDC_P0_MPWRDLCTL, 0x40434541 +DATA 4, MX6_MMDC_P1_MPWRDLCTL, 0x473E4A3B +DATA 4, MX6_MMDC_P0_MPWLDECTRL0, 0x0011000E +DATA 4, MX6_MMDC_P0_MPWLDECTRL1, 0x000E001B +DATA 4, MX6_MMDC_P1_MPWLDECTRL0, 0x00190015 +DATA 4, MX6_MMDC_P1_MPWLDECTRL1, 0x00070018 +DATA 4, MX6_MMDC_P0_MPMUR0, 0x00000800 +DATA 4, MX6_MMDC_P1_MPMUR0, 0x00000800 +DATA 4, MX6_MMDC_P0_MDSCR, 0x00000000 +DATA 4, MX6_MMDC_P0_MAPSR, 0x00011006[--snip--]
Quoted 2 lines
tXS = tXPR = 170 ns -> 91 nCK -> 91 - 1 ->
0x5A.Thanks Beno?t,
I was going to bring this up in a separate thread.
Quoted 8 lines
Quoted 4 lines
While working through the details of our 800MHz variants (Solo, Dual-Lite), and x256mx16 variants, I re-worked these numbers and it seems that we have an off-by-one issue with those fields.
Probably because it has been missed that the bit-field value is the number of clock cycles minus 1.
Right. All of these fields are plus 1.
MDCFG0.tRFC
MDCFG0.tXS
MDOR.tXPR
Since they're all in the same units, the requirements are:
MDCFG0.tXS >= MDCFG0.tRFC + 10nS and MDOR.tXPR >= MDCFG0.tRFC + 10nS
Since we operate at ~528MHz, each clock is less than 2 nS, and we need 6 more clocks for each.
Quoted 5 lines
Quoted 2 lines
According to the JEDEC spec and data sheets, both tXS and tXPR should be 10nS greater than tRFC.
Indeed, or more precisely,
max(5 nCK, tRFC + 10 ns).
Yep. I shortened because nothing approaches 5nCK.
And note that this is the minimum spec, not the target.
Quoted 6 lines
Quoted 1 line
Since the nominal clock for i.MX6 is 528MHz (1.89nS),
I used 532 MHz because this is a more standard value, and I found several close different values in the documentation, so in the doubt, I chose the worst case. With 528 MHz, the bit-field value would be
0x59.
Either way, we need 6 clocks to get > 10nS.
Quoted 4 lines
Quoted 1 line
this should be a delta of 6 clocks, not 5.
Delta with what?
Sorry. I meant the Delta between MDCFG0.tRFC and the other two fields.
Quoted 11 lines
Quoted 1 line
This change should apply to mx6q_4x_mt41j128.cfg as well.
Sure.
Quoted 3 lines
There are some other things in that file that should be fixed as well. The biggest among them is the settings for P1_MPWLDECTRL0/1.
Note that in this series, I have only reviewed the register values that changed in my series, and only for 1066mhz_4x128mx16.cfg.
Thanks for that. More eyeballs are better, especially when looking at bit-fields...
Also note that these relationships make a pretty good case for having expression support in these files.
It would be nice to express tXS and tXPR as tRFC+6.
But this is a topic for another day.
Quoted 13 lines
Quoted 4 lines
These settings are indicative of a fly-by topology, which isn't used on SABRE Lite, and I don't think is used on SABRE SD.
Quoted 8 lines
DATA 4 0x021b480c 0x00440044 DATA 4 0x021b4810 0x00440044This was the primary thing that caused crashes under stress on SABRE Lite and led to our flurry of calibration tests as discussed here:
Quoted 8 lines
OK. I had not looked in detail into this.
Quoted 2 lines
Should we take this up in a separate thread? It seems un-related to our Nitrogen6X board.
As you prefer. This is related to this series, but a very specific subject per se.
I'll start a separate thread regarding the SABRE-Lite and SABRE SD memory settings.
Regards,
Eric
PATCH 1/1 Add Boundary Devices Nitrogen6X boards
Hi Eric,
Quoted 108 lines · Eric Nelson
Hi Beno?t,
Quoted 60 lines · Beno?t Th?baudeau
Quoted 59 lines · Eric Nelson
Quoted 51 lines · Beno?t Th?baudeau
Hi Eric,
On Tuesday, February 19, 2013 9:20:48 PM, Eric Nelson wrote:
[--snip--]board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg
Quoted 6 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +0
-0[--snip--]
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg line 24
Quoted 2 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +2
-0+DATA 4, MX6_MMDC_P0_MDPDC, 0x00020036 +DATA 4, MX6_MMDC_P0_MDCFG0, 0x555B7974^A?board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg line 28
Quoted 4 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +4
-0+DATA 4, MX6_MMDC_P0_MDCFG1, 0xDB538F64 +DATA 4, MX6_MMDC_P0_MDCFG2, 0x01FF00DB +DATA 4, MX6_MMDC_P0_MDRWD, 0x000026D2 +DATA 4, MX6_MMDC_P0_MDOR, 0x005B1023^A?Quoted 20 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +20
-0+DATA 4, MX6_MMDC_P0_MDOTC, 0x09444040 +DATA 4, MX6_MMDC_P0_MDPDC, 0x00025576 +DATA 4, MX6_MMDC_P0_MDASP, 0x00000027 +DATA 4, MX6_MMDC_P0_MDCTL, 0x831A0000 +DATA 4, MX6_MMDC_P0_MDSCR, 0x04088032 +DATA 4, MX6_MMDC_P0_MDSCR, 0x00008033 +DATA 4, MX6_MMDC_P0_MDSCR, 0x00428031 +DATA 4, MX6_MMDC_P0_MDSCR, 0x19308030 +DATA 4, MX6_MMDC_P0_MDSCR, 0x04008040 +DATA 4, MX6_MMDC_P0_MPZQHWCTRL, 0xA1390003 +DATA 4, MX6_MMDC_P1_MPZQHWCTRL, 0xA1390003 +DATA 4, MX6_MMDC_P0_MDREF, 0x00005800 +DATA 4, MX6_MMDC_P0_MPODTCTRL, 0x00022227 +DATA 4, MX6_MMDC_P1_MPODTCTRL, 0x00022227 +DATA 4, MX6_MMDC_P0_MPDGCTRL0, 0x42720306 +DATA 4, MX6_MMDC_P0_MPDGCTRL1, 0x026F0266 +DATA 4, MX6_MMDC_P1_MPDGCTRL0, 0x4273030A +DATA 4, MX6_MMDC_P1_MPDGCTRL1, 0x02740240 +DATA 4, MX6_MMDC_P0_MPRDDLCTL, 0x45393B3E +DATA 4, MX6_MMDC_P1_MPRDDLCTL, 0x403A3747board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg line 58
Quoted 10 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +10
-0+DATA 4, MX6_MMDC_P0_MPWRDLCTL, 0x40434541 +DATA 4, MX6_MMDC_P1_MPWRDLCTL, 0x473E4A3B +DATA 4, MX6_MMDC_P0_MPWLDECTRL0, 0x0011000E +DATA 4, MX6_MMDC_P0_MPWLDECTRL1, 0x000E001B +DATA 4, MX6_MMDC_P1_MPWLDECTRL0, 0x00190015 +DATA 4, MX6_MMDC_P1_MPWLDECTRL1, 0x00070018 +DATA 4, MX6_MMDC_P0_MPMUR0, 0x00000800 +DATA 4, MX6_MMDC_P1_MPMUR0, 0x00000800 +DATA 4, MX6_MMDC_P0_MDSCR, 0x00000000 +DATA 4, MX6_MMDC_P0_MAPSR, 0x00011006[--snip--]
Quoted 2 lines
tXS = tXPR = 170 ns -> 91 nCK -> 91 - 1 ->
0x5A.Thanks Beno?t,
I was going to bring this up in a separate thread.
Quoted 8 lines
Quoted 4 lines
While working through the details of our 800MHz variants (Solo, Dual-Lite), and x256mx16 variants, I re-worked these numbers and it seems that we have an off-by-one issue with those fields.
Probably because it has been missed that the bit-field value is the number of clock cycles minus 1.
Right. All of these fields are plus 1.
MDCFG0.tRFC
MDCFG0.tXS
MDOR.tXPRSince they're all in the same units, the requirements are:
MDCFG0.tXS >= MDCFG0.tRFC + 10nS and MDOR.tXPR >= MDCFG0.tRFC + 10nSSince we operate at ~528MHz, each clock is less than 2 nS, and we need 6 more clocks for each.
Quoted 5 lines
Quoted 2 lines
According to the JEDEC spec and data sheets, both tXS and tXPR should be 10nS greater than tRFC.
Indeed, or more precisely,
max(5 nCK, tRFC + 10 ns).Yep. I shortened because nothing approaches 5nCK.
And note that this is the minimum spec, not the target.
Quoted 8 lines
Quoted 1 line
Since the nominal clock for i.MX6 is 528MHz (1.89nS),
I used 532 MHz because this is a more standard value, and I found several close
different values in the documentation, so in the doubt, I chose the worst case.
With 528 MHz, the bit-field value would be0x59.Either way, we need 6 clocks to get > 10nS.
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
this should be a delta of 6 clocks, not 5.
Delta with what?
Sorry. I meant the Delta between MDCFG0.tRFC and the other two fields.
OK, now I see what you mean and how you got these values. But I disagree.
tXS(min) and tXPR(min) are defined by the JEDEC DDR3 specification as max(5 nCK, tRFC(min) + 10 ns). tRFC(min) is used here, not tRFC.
Moreover, tXS and tXPR are timings depending on internal features of the RAM, not on external operations from the host processor. It's not as if they were the result of the combination of two external operations. E.g., see tXS on figures 14, 15 and 62 in JESD79-3F.
Hence, tXS and tXPR should not be considered as tRFC(MMDC) + 10 ns, but really as tRFC(min) + 10 ns, i.e. a single 170 ns timing (for 2-Gib density) to be converted into a number of clock cycles.
I don't feel like it's possible to interpret the specification in a different way. But perhaps I'm wrong.
Quoted 15 lines
Quoted 11 lines
Quoted 1 line
This change should apply to mx6q_4x_mt41j128.cfg as well.
Sure.
Quoted 3 lines
There are some other things in that file that should be fixed as well. The biggest among them is the settings for P1_MPWLDECTRL0/1.
Note that in this series, I have only reviewed the register values that changed in my series, and only for 1066mhz_4x128mx16.cfg.
Thanks for that. More eyeballs are better, especially when looking at bit-fields...
Quoted 6 lines
Also note that these relationships make a pretty good case for having expression support in these files.
It would be nice to express tXS and tXPR as tRFC+6.
But this is a topic for another day.
Yes, it would be easier to read if all bit-fields were #defined as expression building macros.
Quoted 18 lines
Quoted 18 lines
Quoted 4 lines
These settings are indicative of a fly-by topology, which isn't used on SABRE Lite, and I don't think is used on SABRE SD.
Quoted 8 lines
DATA 4 0x021b480c 0x00440044 DATA 4 0x021b4810 0x00440044This was the primary thing that caused crashes under stress on SABRE Lite and led to our flurry of calibration tests as discussed here:
OK. I had not looked in detail into this.
Quoted 2 lines
Should we take this up in a separate thread? It seems un-related to our Nitrogen6X board.
Quoted 6 lines
Quoted 3 lines
As you prefer. This is related to this series, but a very specific subject per se.
I'll start a separate thread regarding the SABRE-Lite and SABRE SD memory settings.
OK.
Best regards,
Beno?t
PATCH 1/1 Add Boundary Devices Nitrogen6X boards
Hi Eric,
Quoted 124 lines · Beno?t Th?baudeau
Hi Eric,
Quoted 108 lines · Eric Nelson
Hi Beno?t,
Quoted 60 lines · Beno?t Th?baudeau
Quoted 59 lines · Eric Nelson
Quoted 51 lines · Beno?t Th?baudeau
Hi Eric,
On Tuesday, February 19, 2013 9:20:48 PM, Eric Nelson wrote:
[--snip--]board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg
Quoted 6 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +0
-0[--snip--]
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg line 24
Quoted 2 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +2
-0+DATA 4, MX6_MMDC_P0_MDPDC, 0x00020036 +DATA 4, MX6_MMDC_P0_MDCFG0, 0x555B7974^A?board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg line 28
Quoted 4 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +4
-0+DATA 4, MX6_MMDC_P0_MDCFG1, 0xDB538F64 +DATA 4, MX6_MMDC_P0_MDCFG2, 0x01FF00DB +DATA 4, MX6_MMDC_P0_MDRWD, 0x000026D2 +DATA 4, MX6_MMDC_P0_MDOR, 0x005B1023^A?Quoted 20 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +20
-0+DATA 4, MX6_MMDC_P0_MDOTC, 0x09444040 +DATA 4, MX6_MMDC_P0_MDPDC, 0x00025576 +DATA 4, MX6_MMDC_P0_MDASP, 0x00000027 +DATA 4, MX6_MMDC_P0_MDCTL, 0x831A0000 +DATA 4, MX6_MMDC_P0_MDSCR, 0x04088032 +DATA 4, MX6_MMDC_P0_MDSCR, 0x00008033 +DATA 4, MX6_MMDC_P0_MDSCR, 0x00428031 +DATA 4, MX6_MMDC_P0_MDSCR, 0x19308030 +DATA 4, MX6_MMDC_P0_MDSCR, 0x04008040 +DATA 4, MX6_MMDC_P0_MPZQHWCTRL, 0xA1390003 +DATA 4, MX6_MMDC_P1_MPZQHWCTRL, 0xA1390003 +DATA 4, MX6_MMDC_P0_MDREF, 0x00005800 +DATA 4, MX6_MMDC_P0_MPODTCTRL, 0x00022227 +DATA 4, MX6_MMDC_P1_MPODTCTRL, 0x00022227 +DATA 4, MX6_MMDC_P0_MPDGCTRL0, 0x42720306 +DATA 4, MX6_MMDC_P0_MPDGCTRL1, 0x026F0266 +DATA 4, MX6_MMDC_P1_MPDGCTRL0, 0x4273030A +DATA 4, MX6_MMDC_P1_MPDGCTRL1, 0x02740240 +DATA 4, MX6_MMDC_P0_MPRDDLCTL, 0x45393B3E +DATA 4, MX6_MMDC_P1_MPRDDLCTL, 0x403A3747board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg line 58
Quoted 10 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +10
-0+DATA 4, MX6_MMDC_P0_MPWRDLCTL, 0x40434541 +DATA 4, MX6_MMDC_P1_MPWRDLCTL, 0x473E4A3B +DATA 4, MX6_MMDC_P0_MPWLDECTRL0, 0x0011000E +DATA 4, MX6_MMDC_P0_MPWLDECTRL1, 0x000E001B +DATA 4, MX6_MMDC_P1_MPWLDECTRL0, 0x00190015 +DATA 4, MX6_MMDC_P1_MPWLDECTRL1, 0x00070018 +DATA 4, MX6_MMDC_P0_MPMUR0, 0x00000800 +DATA 4, MX6_MMDC_P1_MPMUR0, 0x00000800 +DATA 4, MX6_MMDC_P0_MDSCR, 0x00000000 +DATA 4, MX6_MMDC_P0_MAPSR, 0x00011006[--snip--]
Quoted 2 lines
tXS = tXPR = 170 ns -> 91 nCK -> 91 - 1 ->
0x5A.Thanks Beno?t,
I was going to bring this up in a separate thread.
Quoted 8 lines
Quoted 4 lines
While working through the details of our 800MHz variants (Solo, Dual-Lite), and x256mx16 variants, I re-worked these numbers and it seems that we have an off-by-one issue with those fields.
Probably because it has been missed that the bit-field value is the number of clock cycles minus 1.
Right. All of these fields are plus 1.
MDCFG0.tRFC
MDCFG0.tXS
MDOR.tXPRSince they're all in the same units, the requirements are:
MDCFG0.tXS >= MDCFG0.tRFC + 10nS and MDOR.tXPR >= MDCFG0.tRFC + 10nSSince we operate at ~528MHz, each clock is less than 2 nS, and we need 6 more clocks for each.
Quoted 5 lines
Quoted 2 lines
According to the JEDEC spec and data sheets, both tXS and tXPR should be 10nS greater than tRFC.
Indeed, or more precisely,
max(5 nCK, tRFC + 10 ns).Yep. I shortened because nothing approaches 5nCK.
And note that this is the minimum spec, not the
target.Quoted 8 lines
Quoted 1 line
Since the nominal clock for i.MX6 is 528MHz (1.89nS),
I used 532 MHz because this is a more standard value, and I found several close
different values in the documentation, so in the doubt, I chose the worst case.
With 528 MHz, the bit-field value would be0x59.Either way, we need 6 clocks to get > 10nS.
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
this should be a delta of 6 clocks, not 5.
Delta with what?
Sorry. I meant the Delta between MDCFG0.tRFC and the other two fields.
OK, now I see what you mean and how you got these values. But I disagree.
tXS(min) and tXPR(min) are defined by the JEDEC DDR3 specification as
max(5 nCK, tRFC(min) + 10 ns). tRFC(min) is used here, not tRFC.
Quoted 6 lines
Moreover, tXS and tXPR are timings depending on internal features of the RAM, not on external operations from the host processor. It's not as if they were the
result of the combination of two external operations. E.g., see tXS on figures
14, 15 and 62 in JESD79-3F.
I don't know if that's clear enough, but here I mean that tXS and tXPR are intrinsic RAM timings, and that there is no way tRFC(MMDC) can interfere with either tXS/XPR(DDR3) or tXS/XPR(MMDC), so there is no reason to take tRFC(MMDC) into account to determine tXS or tXPR. Only tRFC(min) should be used here.
Quoted 7 lines
Hence, tXS and tXPR should not be considered as tRFC(MMDC) + 10 ns, but really
as tRFC(min) + 10 ns, i.e. a single 170 ns timing (for 2-Gib density) to be converted into a number of clock cycles.I don't feel like it's possible to interpret the specification in a different way. But perhaps I'm wrong.
Best regards,
Beno?t
PATCH 1/1 Add Boundary Devices Nitrogen6X boards
Hi Beno?t,
Quoted 106 lines · Beno?t Th?baudeau
Hi Eric,
Quoted 96 lines · Beno?t Th?baudeau
Hi Eric,
Quoted 80 lines · Eric Nelson
Hi Beno?t,
Quoted 32 lines · Beno?t Th?baudeau
Quoted 31 lines · Eric Nelson
Quoted 19 lines · Beno?t Th?baudeau
Hi Eric,
On Tuesday, February 19, 2013 9:20:48 PM, Eric Nelson wrote:
[--snip--]board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg
Quoted 6 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +0
-0[--snip--]
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg
Quoted 2 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +2
-0+DATA 4, MX6_MMDC_P0_MDPDC, 0x00020036 +DATA 4, MX6_MMDC_P0_MDCFG0, 0x555B7974^A?board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg
Quoted 4 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +4
-0+DATA 4, MX6_MMDC_P0_MDCFG1, 0xDB538F64 +DATA 4, MX6_MMDC_P0_MDCFG2, 0x01FF00DB +DATA 4, MX6_MMDC_P0_MDRWD, 0x000026D2 +DATA 4, MX6_MMDC_P0_MDOR, 0x005B1023^A?Quoted 6 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg
Quoted 2 lines
board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg new file +2
-0+DATA 4, MX6_MMDC_P0_MDOTC, 0x09444040 +DATA 4, MX6_MMDC_P0_MDPDC, 0x00025576[--snip--]
tXS = tXPR = 170 ns -> 91 nCK -> 91 - 1 ->
0x5A.Thanks Beno?t,
I was going to bring this up in a separate thread.
Quoted 8 lines
Quoted 4 lines
While working through the details of our 800MHz variants (Solo, Dual-Lite), and x256mx16 variants, I re-worked these numbers and it seems that we have an off-by-one issue with those fields.
Probably because it has been missed that the bit-field value is the number of clock cycles minus 1.
Right. All of these fields are plus 1.
MDCFG0.tRFC
MDCFG0.tXS
MDOR.tXPRSince they're all in the same units, the requirements are:
MDCFG0.tXS >= MDCFG0.tRFC + 10nS and MDOR.tXPR >= MDCFG0.tRFC + 10nSSince we operate at ~528MHz, each clock is less than 2 nS, and we need 6 more clocks for each.
Quoted 5 lines
Quoted 2 lines
According to the JEDEC spec and data sheets, both tXS and tXPR should be 10nS greater than tRFC.
Indeed, or more precisely,
max(5 nCK, tRFC + 10 ns).Yep. I shortened because nothing approaches 5nCK.
And note that this is the minimum spec, not the
target.Quoted 8 lines
Quoted 1 line
Since the nominal clock for i.MX6 is 528MHz (1.89nS),
I used 532 MHz because this is a more standard value, and I found several close
different values in the documentation, so in the doubt, I chose the worst case.
With 528 MHz, the bit-field value would be0x59.Either way, we need 6 clocks to get > 10nS.
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
this should be a delta of 6 clocks, not 5.
Delta with what?
Sorry. I meant the Delta between MDCFG0.tRFC and the other two fields.
OK, now I see what you mean and how you got these values. But I disagree.
tXS(min) and tXPR(min) are defined by the JEDEC DDR3 specification as
max(5 nCK, tRFC(min) + 10 ns). tRFC(min) is used here, not tRFC.Quoted 6 lines
Moreover, tXS and tXPR are timings depending on internal features of the RAM, not on external operations from the host processor. It's not as if they were the
result of the combination of two external operations. E.g., see tXS on figures
14, 15 and 62 in JESD79-3F.
Quoted 5 lines
I don't know if that's clear enough, but here I mean that tXS and tXPR are intrinsic RAM timings, and that there is no way tRFC(MMDC) can interfere with either tXS/XPR(DDR3) or tXS/XPR(MMDC), so there is no reason to take tRFC(MMDC) into account to determine tXS or tXPR. Only tRFC(min) should be used here.
You're right of course. And this description was very clear. We don't communicate __our__ tRFC to the device, so there's no reason our tRFC couldn't be higher than tXS/XPR.
Quoted 7 lines
Quoted 7 lines
Hence, tXS and tXPR should not be considered as tRFC(MMDC) + 10 ns, but really
as tRFC(min) + 10 ns, i.e. a single 170 ns timing (for 2-Gib density) to be converted into a number of clock cycles.I don't feel like it's possible to interpret the specification in a different way. But perhaps I'm wrong.
I also have no evidence of failures because of these settings and will drop the +1 in a V2 patch set.
Thanks again for your detailed review.
Regards,
Eric
PATCH 1/1 Add Boundary Devices Nitrogen6X boards
In reply to Eric NelsonDear Eric Nelson,
Quoted 3 lines · In message <1361305248-24598-1-git-send-email-eric.nelson@boundarydevices.com>…
board/boundary/nitrogen6x/nitrogen6x.c new file +3
-0+static int detect_hdmi (struct display_info_t const *dev) +{ +return __raw_readb (HDMI_ARB_BASE_ADDR +HDMI_PHY_STAT0 ) &HDMI_PHY_HPD ;
...
board/boundary/nitrogen6x/nitrogen6x.c line 497
Quoted 3 lines
board/boundary/nitrogen6x/nitrogen6x.c new file +3
-0+ reg =__raw_readb ( +HDMI_ARB_BASE_ADDR + +HDMI_PHY_CONF0 );
etc. etc.
NAK!! We do not allow device access through base address plus offset notation. Please use a proper C Struct to access thes device.
Also, are you absolutely sure that the __raw_* accessors are the right thing to use here? Are you really sure no memory barriers etc. are needed here?
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The heart is not a logical organ. -- Dr. Janet Wallace, "The Deadly Years", stardate 3479.4
PATCH 1/1 Add Boundary Devices Nitrogen6X boards
Hi Wolfgang,
Quoted 8 lines · Wolfgang Denk
Dear Eric Nelson,
Quoted 3 lines · In message <1361305248-24598-1-git-send-email-eric.nelson@boundarydevices.com>…
board/boundary/nitrogen6x/nitrogen6x.c new file +3
-0+static int detect_hdmi (struct display_info_t const *dev) +{ +return __raw_readb (HDMI_ARB_BASE_ADDR +HDMI_PHY_STAT0 ) &HDMI_PHY_HPD ;...
Quoted 9 lines
board/boundary/nitrogen6x/nitrogen6x.c line 497
Quoted 3 lines
board/boundary/nitrogen6x/nitrogen6x.c new file +3
-0+ reg =__raw_readb ( +HDMI_ARB_BASE_ADDR + +HDMI_PHY_CONF0 );etc. etc.
NAK!! We do not allow device access through base address plus offset notation. Please use a proper C Struct to access thes device.
This tells me that there's other breakage here. In particular, this usage follows the lead of drivers/video/ipu_common.c and the detect code is also present in mx6qsabrelite.c:
http://git.denx.de/u-boot.git/?p=u-boot.git;a=blob;f=board/freescale/mx6qsabrelite/mx6qsabrelite.c;h=f010d0c60d25734d2b81579b6d2806d365a415e6;hb=HEAD#l456
Quoted 4 lines
Also, are you absolutely sure that the __raw_* accessors are the right thing to use here? Are you really sure no memory barriers etc. are needed here?
Good catch. readb() would be more appropriate, though this particular register is unlikely to produce a different value.
Regards,
Eric