Skip to contentSkip to conversation

documentation: add palmas dts definition

PATCH In review J Keerthy 3 participants 6 messages Feb 20, 2013 – Mar 2, 2013

Subsystems (2)
lore
Share & tools
lore

J Keerthy

author
#0 lore raw

PATCH 1/4 documentation: add palmas dts definition

From: Graeme Gregory <[email protected]>

Add the DTS definition for the palmas device including the MFD children.

[[email protected]: changed the DT node property names to follow the convention]

---
 Documentation/devicetree/bindings/mfd/palmas.txt |   67 ++++++++++++++++++++++
 1 files changed, 67 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/mfd/palmas.txt
Documentation/devicetree/bindings/mfd/palmas.txt new file +67 -0
new file mode 100644
index 0000000..5fa922e
@@ -0,0 +1,67 @@
+Texas Instruments Palmas family
+
+The Palmas familly are Integrated Power Management Chips.
+These chips are connected to an i2c bus.
+
+
+Required properties:
+- compatible : Must be "ti,palmas";
+  For Integrated power-management in the palmas series, twl6035, twl6037,
+  tps65913
+- interrupts : This i2c device has an IRQ line connected to the main SoC
+- interrupt-controller : Since the palmas support several interrupts internally,
+  it is considered as an interrupt controller cascaded to the SoC one.
+- #interrupt-cells = <1>;
+- interrupt-parent : The parent interrupt controller.
+
+Optional node:
+- Child nodes contain in the palmas. The palmas family is made of several
+  variants that support a different number of features.
+  The child nodes will thus depend of the capability of the variant.
+- mux-pad1 if a value is given it will be used for the pad1 mux
+- mux-pad2 if a value us given it will be used for the pad2 mux
+- power-ctrl if a value is given it will be written to the POWER_CTRL register
+
+Example:
+/*
+ * Integrated Power Management Chip Palmas
+ */
+palmas@48 {
+    compatible = "ti,palmas";
+    reg = <0x48>;
+    interrupts = <39>; /* IRQ_SYS_1N cascaded to gic */
+    interrupt-controller;
+    #interrupt-cells = <1>;
+    interrupt-parent = <&gic>;
+    #address-cells = <1>;
+    #size-cells = <0>;
+
+	ti,mux-pad1 = <0x00>;
+	ti,mux-pad2 = <0x00>;
+	ti,power-ctrl = <0x03>;
+
+	palmas_pmic {
+		compatible = "ti,palmas_pmic";
+		regulators {
+			smps12_reg: smps12 {
+				regulator-min-microvolt = < 600000>;
+                regulator-max-microvolt = <1500000>;
+				regulator-always-on;
+				regulator-boot-on;
+                ti,warm-sleep = <0>;
+                ti,roof-floor = <0>;
+                ti,mode-sleep = <0>;
+                ti,warm-reset = <0>;
+                ti,tstep = <0>;
+                ti,vsel = <0>;
+			};
+		};
+		ti,ldo6-vibrator = <0>;
+	};
+
+    palmas_rtc {
+        compatible = "ti,palmas_rtc";
+        interrupts = <8 9>;
+        reg = <0>;
+    };
+};
Signature · 1 line
1.7.5.4
#1 lore raw
Quoted 19 lines · J Keerthy

From: Graeme Gregory <[email protected]>

Add the DTS definition for the palmas device including the MFD children.

[[email protected]: changed the DT node property names to follow the convention]

---
 Documentation/devicetree/bindings/mfd/palmas.txt |   67 ++++++++++++++++++++++
 1 files changed, 67 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/mfd/palmas.txt
Documentation/devicetree/bindings/mfd/palmas.txt new file +0 -0
new file mode 100644
index 0000000..5fa922e

Documentation/devicetree/bindings/mfd/palmas.txt line 4

Quoted 4 lines
Documentation/devicetree/bindings/mfd/palmas.txt new file +4 -0
@@ -0,0 +1,67 @@
+Texas Instruments Palmas family
+
+The Palmas familly are Integrated Power Management Chips.
+These chips are connected to an i2c bus.

I would expect this to enumerate the regulators that the user can select but it doesn't appear to do that.

author
#2 lore raw
Quoted 29 lines

-----Original Message-----
From: Mark Brown [mailto:[email protected]]
Sent: Wednesday, February 20, 2013 4:57 PM
To: J, KEERTHY
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH 1/4] documentation: add palmas dts definition

Quoted 3 lines · J Keerthy

From: Graeme Gregory <[email protected]>

Add the DTS definition for the palmas device including the MFD

children.

Quoted 7 lines

[[email protected]: changed the DT node property names to follow the convention]

---
 Documentation/devicetree/bindings/mfd/palmas.txt |   67

++++++++++++++++++++++

Quoted 1 line
 1 files changed, 67 insertions(+), 0 deletions(-)  create mode

100644

Quoted 2 lines

Documentation/devicetree/bindings/mfd/palmas.txt

Quoted 14 lines

Documentation/devicetree/bindings/mfd/palmas.txt line 4

Quoted 11 lines
Documentation/devicetree/bindings/mfd/palmas.txt new file +4 -0
new file mode 100644
index 0000000..5fa922e
@@ -0,0 +1,67 @@
+Texas Instruments Palmas family
+
+The Palmas familly are Integrated Power Management Chips.
+These chips are connected to an i2c bus.

I would expect this to enumerate the regulators that the user can select but it doesn't appear to do that.

Mark,

Thanks for reviewing the patch.

I went through the DT Documentation files in the regulator/ folder. So shall I add a list of regulators which are in the Palmas device Under a separate file under Documentation/devicetree/bindings/regulator ? Is that what you are looking for?

Regards,
Keerthy

#3 lore raw
Quoted 5 lines · KEERTHY

Mark Brown wrote at Wednesday, February 20, 2013 4:57 PM:

Quoted 4 lines · J Keerthy
Quoted 3 lines

From: Graeme Gregory <[email protected]>

Add the DTS definition for the palmas device including the MFD children.

...

Quoted 1 line
Quoted 1 line
Quoted 1 line
Documentation/devicetree/bindings/mfd/palmas.txt +0 -0

...

Quoted 8 lines
Quoted 7 lines

Documentation/devicetree/bindings/mfd/palmas.txt line 4

Quoted 4 lines
Documentation/devicetree/bindings/mfd/palmas.txt +4 -0
+Texas Instruments Palmas family
+
+The Palmas familly are Integrated Power Management Chips.
+These chips are connected to an i2c bus.

I would expect this to enumerate the regulators that the user can select but it doesn't appear to do that.

Quoted 8 lines

Mark,

Thanks for reviewing the patch.

I went through the DT Documentation files in the regulator/ folder. So shall I add a list of regulators which are in the Palmas device Under a separate file under Documentation/devicetree/bindings/regulator ? Is that what you are looking for?

I believe what Mark wants is something like the following in this file (take from Documentation/devicetree/bindings/regulator/tps6586x.txt):

Quoted 6 lines

- regulators: A node that houses a sub-node for each regulator within the device. Each sub-node is identified using the node's name (or the deprecated regulator-compatible property if present), with valid values listed below. The content of each sub-node is defined by the standard binding for regulators; see regulator.txt.
sys, sm[0-2], ldo[0-9] and ldo_rtc

#4 lore raw
Quoted 9 lines · Stephen Warren

I believe what Mark wants is something like the following in this file (take from Documentation/devicetree/bindings/regulator/tps6586x.txt):

Quoted 6 lines

- regulators: A node that houses a sub-node for each regulator within the device. Each sub-node is identified using the node's name (or the deprecated regulator-compatible property if present), with valid values listed below. The content of each sub-node is defined by the standard binding for regulators; see regulator.txt.
sys, sm[0-2], ldo[0-9] and ldo_rtc

Yes, exactly.

author
#5 lore raw
In reply to Mark Brown
Quoted 59 lines

-----Original Message-----
From: J, KEERTHY
Sent: Wednesday, February 20, 2013 7:19 PM
To: 'Mark Brown'
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: RE: [PATCH 1/4] documentation: add palmas dts definition

Quoted 27 lines

-----Original Message-----
From: Mark Brown [mailto:[email protected]]
Sent: Wednesday, February 20, 2013 4:57 PM
To: J, KEERTHY
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH 1/4] documentation: add palmas dts definition

Quoted 3 lines · J Keerthy

From: Graeme Gregory <[email protected]>

Add the DTS definition for the palmas device including the MFD

children.

Quoted 7 lines

[[email protected]: changed the DT node property names to follow the convention]

---
 Documentation/devicetree/bindings/mfd/palmas.txt |   67

++++++++++++++++++++++

Quoted 1 line
 1 files changed, 67 insertions(+), 0 deletions(-)  create mode

100644

Quoted 2 lines

Documentation/devicetree/bindings/mfd/palmas.txt

Quoted 14 lines

Documentation/devicetree/bindings/mfd/palmas.txt line 4

Quoted 11 lines
Documentation/devicetree/bindings/mfd/palmas.txt new file +4 -0
new file mode 100644
index 0000000..5fa922e
@@ -0,0 +1,67 @@
+Texas Instruments Palmas family
+
+The Palmas familly are Integrated Power Management Chips.
+These chips are connected to an i2c bus.

I would expect this to enumerate the regulators that the user can select but it doesn't appear to do that.

Mark,

Quoted 7 lines

Thanks for reviewing the patch.

I went through the DT Documentation files in the regulator/ folder. So shall I add a list of regulators which are in the Palmas device Under a separate file under Documentation/devicetree/bindings/regulator ?
Is that what you are looking for?

Any inputs on this Mark? Sorry I did not understand the comment.

Quoted 3 lines

Regards,
Keerthy

Regards,
Keerthy