Skip to contentSkip to conversation

qt: install QML imports on target

PATCH New Daniel Nyström 4 participants 6 messages Feb 20, 2013 – Feb 27, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qt: install QML imports on target

When selecting the Qt declarative module, all the QML imports was built and installed to staging, but never installed to the target.

---
 package/qt/qt.mk |   10 ++++++++++
 1 file changed, 10 insertions(+)
package/qt/qt.mk +10 -0
index ee1a88b..3767810 100644
@@ -498,6 +498,7 @@ define QT_CONFIGURE_CMDS
 		-no-separate-debug-info \
 		-prefix /usr \
 		-plugindir /usr/lib/qt/plugins \
+		-importdir /usr/lib/qt/imports \
 		-hostprefix $(STAGING_DIR) \
 		-fast \
 		-no-rpath \
@@ -610,6 +611,14 @@ define QT_INSTALL_TARGET_PLUGINS
 	fi
 endef
 
+# Import installation
+define QT_INSTALL_TARGET_IMPORTS
+	if [ -d $(STAGING_DIR)/usr/lib/qt/imports/ ] ; then \
+		mkdir -p $(TARGET_DIR)/usr/lib/qt/imports ; \
+		cp -dpfr $(STAGING_DIR)/usr/lib/qt/imports/* $(TARGET_DIR)/usr/lib/qt/imports ; \
+	fi
+endef
+
 # Fonts installation
 ifneq ($(QT_FONTS),)
 define QT_INSTALL_TARGET_FONTS
@@ -628,6 +637,7 @@ endif
 define QT_INSTALL_TARGET_CMDS
 	$(QT_INSTALL_TARGET_LIBS)
 	$(QT_INSTALL_TARGET_PLUGINS)
+	$(QT_INSTALL_TARGET_IMPORTS)
 	$(QT_INSTALL_TARGET_FONTS)
 	$(QT_INSTALL_TARGET_FONTS_TTF)
 endef
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 qt: install QML imports on target

Quoted 5 lines · Daniel Nystr?m

When selecting the Qt declarative module, all the QML imports was built and installed to staging, but never installed to the target.

Bumping this patch as I think this is a good candidate for the 2013.02 release. Currently QtDeclarative is supported by Buildroot, but the QML imports are not installed to target. The current imports are:

./QtWebKit/libqmlwebkitplugin.so ./Qt/labs/folderlistmodel/libqmlfolderlistmodelplugin.so ./Qt/labs/gestures/libqmlgesturesplugin.so ./Qt/labs/particles/libqmlparticlesplugin.so

(note that the webkitplugin is built even when "WebKit Module" is unchecked in menuconfig!)

Maybe imports installation should be optional in the future, but right now many QML examples and demos depends on their existance.

Best regards
Daniel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130225/fe1720cb/attachment.html>

#2 lore raw

PATCH 1/1 qt: install QML imports on target

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Daniel" == Daniel Nystr?m <[email protected]> writes:

Daniel> On Wed, Feb 20, 2013 at 11:18 AM, Daniel Nystr?m < Daniel> daniel.nystrom at timeterminal.se> wrote:

Daniel> When selecting the Qt declarative module, all the QML imports was
Daniel> built and installed to staging, but never installed to the target.

Daniel> Signed-off-by: Daniel Nystr?m <[email protected]>

Daniel> Bumping this patch as I think this is a good candidate for the Daniel> 2013.02 release. Currently QtDeclarative is supported by Daniel> Buildroot, but the QML imports are not installed to target. The Daniel> current imports are:

Daniel> ./QtWebKit/libqmlwebkitplugin.so
Daniel> ./Qt/labs/folderlistmodel/libqmlfolderlistmodelplugin.so Daniel> ./Qt/labs/gestures/libqmlgesturesplugin.so Daniel> ./Qt/labs/particles/libqmlparticlesplugin.so

It would be good if someone who knows anything about Qt can ack this patch for 2013.02.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 1/1 qt: install QML imports on target

Hi, Daniel, Peter, All!

Quoted 7 lines · Peter Korsgaard
 Daniel>     When selecting the Qt declarative module, all the QML imports was
 Daniel>     built and installed to staging, but never installed to the target.
 Daniel>     Signed-off-by: Daniel Nystr?m <[email protected]>

Daniel> Bumping this patch as I think this is a good candidate for the Daniel> 2013.02 release. Currently QtDeclarative is supported by
It would be good if someone who knows anything about Qt can ack this patch for 2013.02.

I don't yet have much reputation here but looks a nice thing to add to 2013.02,
and implemented just as should be. At least, I had to do exactly the same thing a couple of months ago (based on Buildroot 2012.08) when doing a QML project, and wished it were in the next release :) So here it comes.

--
Best regards,
Alexander Lukichev

#4 lore raw

PATCH 1/1 qt: install QML imports on target

In reply to Peter Korsgaard
Quoted 15 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Daniel" == Daniel Nystr?m<[email protected]> writes:

Daniel> On Wed, Feb 20, 2013 at 11:18 AM, Daniel Nystr?m < Daniel>daniel.nystrom at timeterminal.se> wrote:

Daniel> When selecting the Qt declarative module, all the QML imports was
Daniel> built and installed to staging, but never installed to the target.

Daniel> Signed-off-by: Daniel Nystr?m<[email protected]>

Daniel> Bumping this patch as I think this is a good candidate for the Daniel> 2013.02 release. Currently QtDeclarative is supported by Daniel> Buildroot, but the QML imports are not installed to target. The Daniel> current imports are:

Quoted 7 lines

Daniel> ./QtWebKit/libqmlwebkitplugin.so
Daniel> ./Qt/labs/folderlistmodel/libqmlfolderlistmodelplugin.so Daniel> ./Qt/labs/gestures/libqmlgesturesplugin.so Daniel> ./Qt/labs/particles/libqmlparticlesplugin.so

It would be good if someone who knows anything about Qt can ack this patch for 2013.02.

Basic QML works without this patch. (Actually, I can't be 100% sure
because the display on my board is currently broken, but at least the application doesn't report an error when I start it.) So I don't think this is really needed for 2013.02.

This patch is only necessary if you want to use one of those plugins in
your QML application. I therefore don't agree with always installing them. There should be a configure option to enable it. Although, maybe making this 200K installation configurable for a package that already consumes 15M is perhaps a bit silly... Therefore:

(for next)

(build-test)

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#5 lore raw

PATCH 1/1 qt: install QML imports on target

In reply to Daniel Nyström
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Daniel" == Daniel Nystr?m <[email protected]> writes:

Daniel> When selecting the Qt declarative module, all the QML imports was Daniel> built and installed to staging, but never installed to the target.

Committed to next, thanks.

Signature · 1 line
Bye, Peter Korsgaard