Skip to contentSkip to conversation

libxl: fix build on 32-bit

PATCH Applied Ian Campbell 2 participants 2 messages Feb 21, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libxl: fix build on 32-bit

aab4d1b266ce "libxl: Add qxl vga interface support for upstream qemu"
introduced:
libxl_dm.c: In function ‘libxl__build_device_model_args_new’:
libxl_dm.c:449: error: format ‘%lu’ expects type ‘long unsigned int’, but argument 3 has type ‘long long unsigned int’ libxl_dm.c:451: error: format ‘%lu’ expects type ‘long unsigned int’, but argument 3 has type ‘long long unsigned int’

on arm32 and x86_32.

Use the inttypes.h PRId64 macro.

---
 tools/libxl/libxl_dm.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
tools/libxl/libxl_dm.c +2 -2
index c4ca11e..a8a36d7 100644
@@ -446,9 +446,9 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc,
             flexarray_vappend(dm_args, "-vga", "qxl", NULL);
             if (b_info->video_memkb) {
                 flexarray_vappend(dm_args, "-global",
-                    GCSPRINTF("qxl-vga.vram_size_mb=%lu",
+                    GCSPRINTF("qxl-vga.vram_size_mb=%"PRIu64,
                     (b_info->video_memkb/2/1024)), "-global",
-                    GCSPRINTF("qxl-vga.ram_size_mb=%lu",
+                    GCSPRINTF("qxl-vga.ram_size_mb=%"PRIu64,
                     (b_info->video_memkb/2/1024)), NULL);
             }
             break;
Signature · 7 lines
1.7.9.1


_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel
Applied
#1 lore raw

Ian Campbell writes ("[PATCH] libxl: fix build on 32-bit"):

Quoted 11 lines

aab4d1b266ce "libxl: Add qxl vga interface support for upstream qemu"
introduced:
libxl_dm.c: In function ‘libxl__build_device_model_args_new’:
libxl_dm.c:449: error: format ‘%lu’ expects type ‘long unsigned int’, but argument 3 has type ‘long long unsigned int’ libxl_dm.c:451: error: format ‘%lu’ expects type ‘long unsigned int’, but argument 3 has type ‘long long unsigned int’

on arm32 and x86_32.

Use the inttypes.h PRId64 macro.

Applied, thanks.

Ian.

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel