Skip to contentSkip to conversation

arch/x86/xen: remove depends on CONFIG_EXPERIMENTAL

PATCH In review Kees Cook 6 participants 16 messages Feb 23, 2013 – Feb 25, 2013

Subsystems (4)
lore
Share & tools
lore

Kees Cook

author
#0 lore raw

PATCH 1/1 arch/x86/xen: remove depends on CONFIG_EXPERIMENTAL

The CONFIG_EXPERIMENTAL config item has not carried much meaning for a while now and is almost always enabled by default. As agreed during the Linux kernel summit, remove it from any "depends on" lines in Kconfigs.

Cc Stefano Stabellini <[email protected]>
Cc Mukesh Rathor <[email protected]>
Cc Konrad Rzeszutek Wilk <[email protected]>
---
 arch/x86/xen/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/xen/Kconfig +1 -1
index 93ff4e1..8cada4c 100644
@@ -53,7 +53,7 @@ config XEN_DEBUG_FS
 
 config XEN_X86_PVH
 	bool "Support for running as a PVH guest (EXPERIMENTAL)"
-	depends on X86_64 && XEN && EXPERIMENTAL
+	depends on X86_64 && XEN
 	default n
 	help
 	   This option enables support for running as a PVH guest (PV guest
Signature · 6 lines
1.7.9.5


-- 
Kees Cook
Chrome OS Security
#1 lore raw
Quoted 18 lines · Kees Cook

The CONFIG_EXPERIMENTAL config item has not carried much meaning for a while now and is almost always enabled by default. As agreed during the Linux kernel summit, remove it from any "depends on" lines in Kconfigs.

Cc Stefano Stabellini <[email protected]>
Cc Mukesh Rathor <[email protected]>
Cc Konrad Rzeszutek Wilk <[email protected]>
---
 arch/x86/xen/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/xen/Kconfig +0 -0
index 93ff4e1..8cada4c 100644

arch/x86/xen/Kconfig config XEN_DEBUG_FS · line 55

Quoted 3 lines
arch/x86/xen/Kconfig +0 -0
@@ -53,7 +53,7 @@ config XEN_DEBUG_FS
 
 config XEN_X86_PVH
        bool "Support for running as a PVH guest (EXPERIMENTAL)"

Why not remove this 'EXPERIMENTAL' too ?

Quoted 17 lines
arch/x86/xen/Kconfig +1 -2
-       depends on X86_64 && XEN && EXPERIMENTAL
+       depends on X86_64 && XEN
        default n
        help
           This option enables support for running as a PVH guest (PV guest
--

1.7.9.5

--
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

author
#2 lore raw
Quoted 20 lines · Dongsheng Song
Quoted 19 lines · Kees Cook

The CONFIG_EXPERIMENTAL config item has not carried much meaning for a while now and is almost always enabled by default. As agreed during the Linux kernel summit, remove it from any "depends on" lines in Kconfigs.

Cc Stefano Stabellini <[email protected]>
Cc Mukesh Rathor <[email protected]>
Cc Konrad Rzeszutek Wilk <[email protected]>
---
 arch/x86/xen/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/xen/Kconfig +0 -0
index 93ff4e1..8cada4c 100644
@@ -53,7 +53,7 @@ config XEN_DEBUG_FS
 
Quoted 4 lines

arch/x86/xen/Kconfig config XEN_DEBUG_FS · line 55

Quoted 2 lines
arch/x86/xen/Kconfig +0 -0
 config XEN_X86_PVH
        bool "Support for running as a PVH guest (EXPERIMENTAL)"

Why not remove this 'EXPERIMENTAL' too ?

It was unclear to me if the feature was actually considered unstable. I can resend with the text removed from the title too, if that's the correct action here?

-Kees

Quoted 18 lines
Quoted 18 lines
arch/x86/xen/Kconfig +1 -2
-       depends on X86_64 && XEN && EXPERIMENTAL
+       depends on X86_64 && XEN
        default n
        help
           This option enables support for running as a PVH guest (PV guest
--

1.7.9.5

--
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Signature · 2 lines
Kees Cook
Chrome OS Security
#3 lore raw
Quoted 22 lines · Kees Cook
Quoted 20 lines · Dongsheng Song
Quoted 19 lines · Kees Cook

The CONFIG_EXPERIMENTAL config item has not carried much meaning for a while now and is almost always enabled by default. As agreed during the Linux kernel summit, remove it from any "depends on" lines in Kconfigs.

Cc Stefano Stabellini <[email protected]>
Cc Mukesh Rathor <[email protected]>
Cc Konrad Rzeszutek Wilk <[email protected]>
---
 arch/x86/xen/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/xen/Kconfig +0 -0
index 93ff4e1..8cada4c 100644
@@ -53,7 +53,7 @@ config XEN_DEBUG_FS
 
Quoted 8 lines
Quoted 4 lines

arch/x86/xen/Kconfig config XEN_DEBUG_FS · line 55

Quoted 2 lines
arch/x86/xen/Kconfig +0 -0
 config XEN_X86_PVH
        bool "Support for running as a PVH guest (EXPERIMENTAL)"

Why not remove this 'EXPERIMENTAL' too ?

It was unclear to me if the feature was actually considered unstable. I can resend with the text removed from the title too, if that's the correct action here?

It certainly is unstable right now (which is why it was unstaged from the v3.9 train). I hope that by v3.10 it won't be - at which point this patch (and the EXPERIMENTAL) makes sense.

So could you respin it please with the text removed as well - and I will queue it up in the branch that carries the PVH feature?

Thanks!

Quoted 27 lines

-Kees

Quoted 18 lines
Quoted 18 lines
arch/x86/xen/Kconfig +1 -2
-       depends on X86_64 && XEN && EXPERIMENTAL
+       depends on X86_64 && XEN
        default n
        help
           This option enables support for running as a PVH guest (PV guest
--

1.7.9.5

--
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Signature · 2 lines
Kees Cook
Chrome OS Security
#4 lore raw
Quoted 32 lines · Konrad Rzeszutek Wilk
Quoted 22 lines · Kees Cook
Quoted 20 lines · Dongsheng Song
Quoted 19 lines · Kees Cook

The CONFIG_EXPERIMENTAL config item has not carried much meaning for a while now and is almost always enabled by default. As agreed during the Linux kernel summit, remove it from any "depends on" lines in Kconfigs.

Cc Stefano Stabellini <[email protected]>
Cc Mukesh Rathor <[email protected]>
Cc Konrad Rzeszutek Wilk <[email protected]>
---
 arch/x86/xen/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/xen/Kconfig +0 -0
index 93ff4e1..8cada4c 100644
@@ -53,7 +53,7 @@ config XEN_DEBUG_FS
 
Quoted 8 lines
Quoted 4 lines

arch/x86/xen/Kconfig config XEN_DEBUG_FS · line 55

Quoted 2 lines
arch/x86/xen/Kconfig +0 -0
 config XEN_X86_PVH
        bool "Support for running as a PVH guest (EXPERIMENTAL)"

Why not remove this 'EXPERIMENTAL' too ?

It was unclear to me if the feature was actually considered unstable. I can resend with the text removed from the title too, if that's the correct action here?

Quoted 6 lines

It certainly is unstable right now (which is why it was unstaged from the v3.9 train). I hope that by v3.10 it won't be - at which point this patch (and the EXPERIMENTAL) makes sense.

So could you respin it please with the text removed as well - and I will queue it up in the branch that carries the PVH feature?

We also have the same flag on Xen ARM, and the reason is that the ABI is not stable yet. As soon as it is (I think soon now), I'll send a patch to remove EXPERIMENTAL from there too.

#5 lore raw
Quoted 37 lines · Stefano Stabellini
Quoted 36 lines · Konrad Rzeszutek Wilk
Quoted 22 lines · Kees Cook
Quoted 20 lines · Dongsheng Song
Quoted 19 lines · Kees Cook

The CONFIG_EXPERIMENTAL config item has not carried much meaning for a while now and is almost always enabled by default. As agreed during the Linux kernel summit, remove it from any "depends on" lines in Kconfigs.

Cc Stefano Stabellini <[email protected]>
Cc Mukesh Rathor <[email protected]>
Cc Konrad Rzeszutek Wilk <[email protected]>
---
 arch/x86/xen/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/xen/Kconfig +0 -0
index 93ff4e1..8cada4c 100644
@@ -53,7 +53,7 @@ config XEN_DEBUG_FS
 
Quoted 8 lines
Quoted 4 lines

arch/x86/xen/Kconfig config XEN_DEBUG_FS · line 55

Quoted 2 lines
arch/x86/xen/Kconfig +0 -0
 config XEN_X86_PVH
        bool "Support for running as a PVH guest (EXPERIMENTAL)"

Why not remove this 'EXPERIMENTAL' too ?

It was unclear to me if the feature was actually considered unstable. I can resend with the text removed from the title too, if that's the correct action here?

It certainly is unstable right now (which is why it was unstaged from the v3.9 train). I hope that by v3.10 it won't be - at which point this patch (and the EXPERIMENTAL) makes sense.

Quoted 6 lines
Quoted 2 lines

So could you respin it please with the text removed as well - and I will queue it up in the branch that carries the PVH feature?

We also have the same flag on Xen ARM, and the reason is that the ABI is not stable yet. As soon as it is (I think soon now), I'll send a patch to remove EXPERIMENTAL from there too.

In the meantime if the depends EXPERIMENTAL is going away perhaps we should explain the EXPERIMENTAL in the title:

8<----------------------------------------------------

From bc22bd0f7b20296c449a05d82be950922042bc92 Mon Sep 17 00:00:00 2001
From: Ian Campbell <[email protected]>
Date: Thu, 4 Oct 2012 09:12:51 +0100
Subject: [PATCH] arm: xen: explain the EXPERIMENTAL dependency in the Kconfig help

---
 arch/arm/Kconfig |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
arch/arm/Kconfig +8 -0
index 67874b8..ef14873 100644
@@ -1865,6 +1865,14 @@ config XEN
 	help
 	  Say Y if you want to run Linux in a Virtual Machine on Xen on ARM.
 
+
+	  This option is EXPERIMENTAL because the hypervisor
+	  interfaces which it uses are not yet considered stable
+	  therefore backwards and forwards compatibility is not yet
+	  guaranteed.
+
+	  If unsure, say N.
+
 endmenu
 
 menu "Boot options"
Signature · 1 line
1.7.2.5
#6 lore raw
Quoted 50 lines · Ian Campbell
Quoted 37 lines · Stefano Stabellini
Quoted 36 lines · Konrad Rzeszutek Wilk
Quoted 22 lines · Kees Cook
Quoted 20 lines · Dongsheng Song
Quoted 19 lines · Kees Cook

The CONFIG_EXPERIMENTAL config item has not carried much meaning for a while now and is almost always enabled by default. As agreed during the Linux kernel summit, remove it from any "depends on" lines in Kconfigs.

Cc Stefano Stabellini <[email protected]>
Cc Mukesh Rathor <[email protected]>
Cc Konrad Rzeszutek Wilk <[email protected]>
---
 arch/x86/xen/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/xen/Kconfig +0 -0
index 93ff4e1..8cada4c 100644
@@ -53,7 +53,7 @@ config XEN_DEBUG_FS
 
Quoted 8 lines
Quoted 4 lines

arch/x86/xen/Kconfig config XEN_DEBUG_FS · line 55

Quoted 2 lines
arch/x86/xen/Kconfig +0 -0
 config XEN_X86_PVH
        bool "Support for running as a PVH guest (EXPERIMENTAL)"

Why not remove this 'EXPERIMENTAL' too ?

It was unclear to me if the feature was actually considered unstable. I can resend with the text removed from the title too, if that's the correct action here?

It certainly is unstable right now (which is why it was unstaged from the v3.9 train). I hope that by v3.10 it won't be - at which point this patch (and the EXPERIMENTAL) makes sense.

Quoted 6 lines
Quoted 2 lines

So could you respin it please with the text removed as well - and I will queue it up in the branch that carries the PVH feature?

We also have the same flag on Xen ARM, and the reason is that the ABI is not stable yet. As soon as it is (I think soon now), I'll send a patch to remove EXPERIMENTAL from there too.

In the meantime if the depends EXPERIMENTAL is going away perhaps we should explain the EXPERIMENTAL in the title:

8<----------------------------------------------------

Quoted 8 lines

From bc22bd0f7b20296c449a05d82be950922042bc92 Mon Sep 17 00:00:00 2001
From: Ian Campbell <[email protected]>
Date: Thu, 4 Oct 2012 09:12:51 +0100
Subject: [PATCH] arm: xen: explain the EXPERIMENTAL dependency in the Kconfig help

Quoted 28 lines
 arch/arm/Kconfig |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
arch/arm/Kconfig +8 -0
index 67874b8..ef14873 100644
@@ -1865,6 +1865,14 @@ config XEN
 	help
 	  Say Y if you want to run Linux in a Virtual Machine on Xen on ARM.
 
+
+	  This option is EXPERIMENTAL because the hypervisor
+	  interfaces which it uses are not yet considered stable
+	  therefore backwards and forwards compatibility is not yet
+	  guaranteed.
+
+	  If unsure, say N.
+
 endmenu
 
 menu "Boot options"
Signature · 1 line
1.7.2.5
#7 lore raw
In reply to Kees Cook
Quoted 27 lines · Kees Cook
Quoted 20 lines · Dongsheng Song
Quoted 19 lines · Kees Cook

The CONFIG_EXPERIMENTAL config item has not carried much meaning for a while now and is almost always enabled by default. As agreed during the Linux kernel summit, remove it from any "depends on" lines in Kconfigs.

Cc Stefano Stabellini <[email protected]>
Cc Mukesh Rathor <[email protected]>
Cc Konrad Rzeszutek Wilk <[email protected]>
---
 arch/x86/xen/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/xen/Kconfig +0 -0
index 93ff4e1..8cada4c 100644
@@ -53,7 +53,7 @@ config XEN_DEBUG_FS
 
Quoted 4 lines

arch/x86/xen/Kconfig config XEN_DEBUG_FS · line 55

Quoted 2 lines
arch/x86/xen/Kconfig +0 -0
 config XEN_X86_PVH
        bool "Support for running as a PVH guest (EXPERIMENTAL)"

Why not remove this 'EXPERIMENTAL' too ?

Quoted 6 lines

It was unclear to me if the feature was actually considered unstable. I can resend with the text removed from the title too, if that's the correct action here?

-Kees

If such a feature was considered unstable, it should depends on EXPERIMENTAL. We should not surprised users.

Quoted 24 lines
Quoted 10 lines
Quoted 10 lines
arch/x86/xen/Kconfig +1 -2
-       depends on X86_64 && XEN && EXPERIMENTAL
+       depends on X86_64 && XEN
        default n
        help
           This option enables support for running as a PVH guest (PV guest
--

1.7.9.5

Quoted 8 lines
Quoted 8 lines

--
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

--
Kees Cook
Chrome OS Security

#8 lore raw
Quoted 28 lines · Dongsheng Song
Quoted 27 lines · Kees Cook
Quoted 24 lines · Dongsheng Song
Quoted 18 lines · Kees Cook

The CONFIG_EXPERIMENTAL config item has not carried much meaning for a while now and is almost always enabled by default. As agreed during the Linux kernel summit, remove it from any "depends on" lines in Kconfigs.

Cc Stefano Stabellini <[email protected]>
Cc Mukesh Rathor <[email protected]>
Cc Konrad Rzeszutek Wilk <[email protected]>
---
 arch/x86/xen/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/xen/Kconfig +0 -0
index 93ff4e1..8cada4c 100644

arch/x86/xen/Kconfig config XEN_DEBUG_FS · line 55

Quoted 3 lines
arch/x86/xen/Kconfig +0 -0
@@ -53,7 +53,7 @@ config XEN_DEBUG_FS
 
 config XEN_X86_PVH
        bool "Support for running as a PVH guest (EXPERIMENTAL)"

Why not remove this 'EXPERIMENTAL' too ?

Quoted 8 lines
Quoted 6 lines

It was unclear to me if the feature was actually considered unstable. I can resend with the text removed from the title too, if that's the correct action here?

-Kees

If such a feature was considered unstable, it should depends on EXPERIMENTAL.

CONFIG_EXPERIMENTAL is going away.

Quoted 1 line

We should not surprised users.

You should not have unstable options in the kernel in the first place, sorry.

greg k-h

#9 lore raw
Quoted 36 lines · Greg Kroah-Hartman
Quoted 35 lines · Dongsheng Song
Quoted 33 lines · Kees Cook
Quoted 20 lines · Dongsheng Song
Quoted 19 lines · Kees Cook

The CONFIG_EXPERIMENTAL config item has not carried much meaning for a while now and is almost always enabled by default. As agreed during the Linux kernel summit, remove it from any "depends on" lines in Kconfigs.

Cc Stefano Stabellini <[email protected]>
Cc Mukesh Rathor <[email protected]>
Cc Konrad Rzeszutek Wilk <[email protected]>
---
 arch/x86/xen/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/xen/Kconfig +0 -0
index 93ff4e1..8cada4c 100644
@@ -53,7 +53,7 @@ config XEN_DEBUG_FS
 
Quoted 4 lines

arch/x86/xen/Kconfig config XEN_DEBUG_FS · line 55

Quoted 2 lines
arch/x86/xen/Kconfig +0 -0
 config XEN_X86_PVH
        bool "Support for running as a PVH guest (EXPERIMENTAL)"

Why not remove this 'EXPERIMENTAL' too ?

It was unclear to me if the feature was actually considered unstable. I can resend with the text removed from the title too, if that's the correct action here?

-Kees

Quoted 8 lines
Quoted 1 line

If such a feature was considered unstable, it should depends on EXPERIMENTAL.

CONFIG_EXPERIMENTAL is going away.

Quoted 1 line

We should not surprised users.

You should not have unstable options in the kernel in the first place, sorry.

With the premise that the removal of CONFIG_EXPERIMENTAL is not an issue for me personally or my work, I am going to give you my 2 cents on the matter, but feel free to ignore them :)

While I understand that CONFIG_EXPERIMENTAL has been abused, I feel that rejecting everything that is not fully stable and with external interfaces set in stones, might hinder the development of new features.

After all, given how fast the kernel is moving nowadays, maintaining a project out-of-tree until is completely ready for production can be very expensive. Merging the project earlier and completing the development upstream can bring better results. But in these cases one wouldn't want to "market" the feature as stable yet, because it just isn't. If CONFIG_EXPERIMENTAL is going away, is there anything in the kernel that can be used to tag a feature as "I wouldn't use it in production if I were you"? Maybe just a comment in the kconfig description?

#10 lore raw
Quoted 37 lines · Stefano Stabellini
Quoted 36 lines · Greg Kroah-Hartman
Quoted 35 lines · Dongsheng Song
Quoted 33 lines · Kees Cook
Quoted 20 lines · Dongsheng Song
Quoted 19 lines · Kees Cook

The CONFIG_EXPERIMENTAL config item has not carried much meaning for a while now and is almost always enabled by default. As agreed during the Linux kernel summit, remove it from any "depends on" lines in Kconfigs.

Cc Stefano Stabellini <[email protected]>
Cc Mukesh Rathor <[email protected]>
Cc Konrad Rzeszutek Wilk <[email protected]>
---
 arch/x86/xen/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/xen/Kconfig +0 -0
index 93ff4e1..8cada4c 100644
@@ -53,7 +53,7 @@ config XEN_DEBUG_FS
 
Quoted 4 lines

arch/x86/xen/Kconfig config XEN_DEBUG_FS · line 55

Quoted 2 lines
arch/x86/xen/Kconfig +0 -0
 config XEN_X86_PVH
        bool "Support for running as a PVH guest (EXPERIMENTAL)"

Why not remove this 'EXPERIMENTAL' too ?

It was unclear to me if the feature was actually considered unstable. I can resend with the text removed from the title too, if that's the correct action here?

-Kees

Quoted 8 lines
Quoted 8 lines
Quoted 1 line

If such a feature was considered unstable, it should depends on EXPERIMENTAL.

CONFIG_EXPERIMENTAL is going away.

Quoted 1 line

We should not surprised users.

You should not have unstable options in the kernel in the first place, sorry.

Just to clarify - this 'unstable' part is that the hypercall interface has not been nailed down. As such the patchseries ('PVH') is not going in Linus's tree until that is nailed down. However, the 'PVH' is going in in 3.10 merge window (barring again delays).

Initially it was scheduled to be in v3.8, hence the reason it has been lingering in #linux-next.

Quoted 18 lines

With the premise that the removal of CONFIG_EXPERIMENTAL is not an issue for me personally or my work, I am going to give you my 2 cents on the matter, but feel free to ignore them :)

While I understand that CONFIG_EXPERIMENTAL has been abused, I feel that rejecting everything that is not fully stable and with external interfaces set in stones, might hinder the development of new features.

After all, given how fast the kernel is moving nowadays, maintaining a project out-of-tree until is completely ready for production can be very expensive. Merging the project earlier and completing the development upstream can bring better results. But in these cases one wouldn't want to "market" the feature as stable yet, because it just isn't. If CONFIG_EXPERIMENTAL is going away, is there anything in the kernel that can be used to tag a feature as "I wouldn't use it in production if I were you"? Maybe just a comment in the kconfig description?

#11 lore raw
In reply to Stefano Stabellini
Quoted 5 lines · Stefano Stabellini
Quoted 3 lines · Greg Kroah-Hartman

You should not have unstable options in the kernel in the first place, sorry.

Quoted 7 lines

With the premise that the removal of CONFIG_EXPERIMENTAL is not an issue for me personally or my work, I am going to give you my 2 cents on the matter, but feel free to ignore them :)

While I understand that CONFIG_EXPERIMENTAL has been abused, I feel that rejecting everything that is not fully stable and with external interfaces set in stones, might hinder the development of new features.

It's been this way for _years_ this isn't something new (the "you have to get it right really quickly" problem). See Documentation/ABI/ for some words about how you can try to do this.

Quoted 1 line

After all, given how fast the kernel is moving nowadays,

No faster than it has in the past.

Quoted 3 lines

maintaining a project out-of-tree until is completely ready for production can be very expensive. Merging the project earlier and completing the development upstream can bring better results.

Yes, but don't go changing user-visable apis when you do so. That's been a hard rule for a LONG time.

Quoted 5 lines

But in these cases one wouldn't want to "market" the feature as stable yet, because it just isn't. If CONFIG_EXPERIMENTAL is going away, is there anything in the kernel that can be used to tag a feature as "I wouldn't use it in production if I were you"? Maybe just a comment in the kconfig description?

I know this is hard, I've had my own problems with it in the past. You don't know if you get an api right until you have a lot of users. See our previous "discussions" about this topic on lkml if you are curious as to the eventual outcome of threads like this:

Yes, it's hard, but that's kernel programming.

Sorry,

greg k-h

#12 lore raw
In reply to Stefano Stabellini
Quoted 5 lines · Stefano Stabellini
Quoted 3 lines · Greg Kroah-Hartman

You should not have unstable options in the kernel in the first place, sorry.

Quoted 7 lines

With the premise that the removal of CONFIG_EXPERIMENTAL is not an issue for me personally or my work, I am going to give you my 2 cents on the matter, but feel free to ignore them :)

While I understand that CONFIG_EXPERIMENTAL has been abused, I feel that rejecting everything that is not fully stable and with external interfaces set in stones, might hinder the development of new features.

It's been this way for _years_ this isn't something new (the "you have to get it right really quickly" problem). See Documentation/ABI/ for some words about how you can try to do this.

Quoted 1 line

After all, given how fast the kernel is moving nowadays,

No faster than it has in the past.

Quoted 3 lines

maintaining a project out-of-tree until is completely ready for production can be very expensive. Merging the project earlier and completing the development upstream can bring better results.

Yes, but don't go changing user-visable apis when you do so. That's been a hard rule for a LONG time.

Quoted 5 lines

But in these cases one wouldn't want to "market" the feature as stable yet, because it just isn't. If CONFIG_EXPERIMENTAL is going away, is there anything in the kernel that can be used to tag a feature as "I wouldn't use it in production if I were you"? Maybe just a comment in the kconfig description?

I know this is hard, I've had my own problems with it in the past. You don't know if you get an api right until you have a lot of users. See our previous "discussions" about this topic on lkml if you are curious as to the eventual outcome of threads like this:

Yes, it's hard, but that's kernel programming.

Sorry,

greg k-h

#13 lore raw
In reply to Kees Cook
Quoted 27 lines · Kees Cook
Quoted 20 lines · Dongsheng Song
Quoted 19 lines · Kees Cook

The CONFIG_EXPERIMENTAL config item has not carried much meaning for a while now and is almost always enabled by default. As agreed during the Linux kernel summit, remove it from any "depends on" lines in Kconfigs.

Cc Stefano Stabellini <[email protected]>
Cc Mukesh Rathor <[email protected]>
Cc Konrad Rzeszutek Wilk <[email protected]>
---
 arch/x86/xen/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/xen/Kconfig +0 -0
index 93ff4e1..8cada4c 100644
@@ -53,7 +53,7 @@ config XEN_DEBUG_FS
 
Quoted 4 lines

arch/x86/xen/Kconfig config XEN_DEBUG_FS · line 55

Quoted 2 lines
arch/x86/xen/Kconfig +0 -0
 config XEN_X86_PVH
        bool "Support for running as a PVH guest (EXPERIMENTAL)"

Why not remove this 'EXPERIMENTAL' too ?

Quoted 6 lines

It was unclear to me if the feature was actually considered unstable. I can resend with the text removed from the title too, if that's the correct action here?

-Kees

If such a feature was considered unstable, it should depends on EXPERIMENTAL. We should not surprised users.

Quoted 24 lines
Quoted 10 lines
Quoted 10 lines
arch/x86/xen/Kconfig +1 -2
-       depends on X86_64 && XEN && EXPERIMENTAL
+       depends on X86_64 && XEN
        default n
        help
           This option enables support for running as a PVH guest (PV guest
--

1.7.9.5

Quoted 8 lines
Quoted 8 lines

--
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

--
Kees Cook
Chrome OS Security

author
#14 lore raw
In reply to Dongsheng Song
Quoted 20 lines · Dongsheng Song
Quoted 19 lines · Kees Cook

The CONFIG_EXPERIMENTAL config item has not carried much meaning for a while now and is almost always enabled by default. As agreed during the Linux kernel summit, remove it from any "depends on" lines in Kconfigs.

Cc Stefano Stabellini <[email protected]>
Cc Mukesh Rathor <[email protected]>
Cc Konrad Rzeszutek Wilk <[email protected]>
---
 arch/x86/xen/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/xen/Kconfig +0 -0
index 93ff4e1..8cada4c 100644
@@ -53,7 +53,7 @@ config XEN_DEBUG_FS
 
Quoted 4 lines

arch/x86/xen/Kconfig config XEN_DEBUG_FS · line 55

Quoted 2 lines
arch/x86/xen/Kconfig +0 -0
 config XEN_X86_PVH
        bool "Support for running as a PVH guest (EXPERIMENTAL)"

Why not remove this 'EXPERIMENTAL' too ?

It was unclear to me if the feature was actually considered unstable. I can resend with the text removed from the title too, if that's the correct action here?

-Kees

Quoted 18 lines
Quoted 18 lines
arch/x86/xen/Kconfig +1 -2
-       depends on X86_64 && XEN && EXPERIMENTAL
+       depends on X86_64 && XEN
        default n
        help
           This option enables support for running as a PVH guest (PV guest
--

1.7.9.5

--
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Signature · 2 lines
Kees Cook
Chrome OS Security
#15 lore raw
In reply to Kees Cook
Quoted 18 lines · Kees Cook

The CONFIG_EXPERIMENTAL config item has not carried much meaning for a while now and is almost always enabled by default. As agreed during the Linux kernel summit, remove it from any "depends on" lines in Kconfigs.

Cc Stefano Stabellini <[email protected]>
Cc Mukesh Rathor <[email protected]>
Cc Konrad Rzeszutek Wilk <[email protected]>
---
 arch/x86/xen/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/xen/Kconfig +0 -0
index 93ff4e1..8cada4c 100644

arch/x86/xen/Kconfig config XEN_DEBUG_FS · line 55

Quoted 3 lines
arch/x86/xen/Kconfig +0 -0
@@ -53,7 +53,7 @@ config XEN_DEBUG_FS
 
 config XEN_X86_PVH
        bool "Support for running as a PVH guest (EXPERIMENTAL)"

Why not remove this 'EXPERIMENTAL' too ?

Quoted 17 lines
arch/x86/xen/Kconfig +1 -2
-       depends on X86_64 && XEN && EXPERIMENTAL
+       depends on X86_64 && XEN
        default n
        help
           This option enables support for running as a PVH guest (PV guest
--

1.7.9.5

--
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/