Skip to contentSkip to conversation

menu: fix remove superfluous newline: change puts() -> printf("%s", )

PATCH Applied Fabio Porcedda 2 participants 2 messages Feb 25, 2013 – Feb 26, 2013

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 menu: fix remove superfluous newline: change puts() -> printf("%s", )

Fix previous commit:
638f91b "fix compiler warnings: use puts() instead of printf()".

Because puts() function add a newline, use instead printf("%s", ).

Cc Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
Cc Vicente Bergas <[email protected]>

---

Notes:
v2:
- corrected two typos in the description

 common/menu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/menu.c +1 -1
index 30dced7..a672e59 100644
@@ -274,7 +274,7 @@ int menu_show(struct menu *m)
 			printf("Auto Select in");
 		} else {
 			auto_display_len = strlen(m->auto_display);
-			puts(m->auto_display);
+			printf("%s", m->auto_display);
 		}
 		printf(" %2d", countdown--);
 	}
Signature · 7 lines
1.8.1.1


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Applied
#1 lore raw
Quoted 8 lines · Fabio Porcedda

Fix previous commit:
638f91b "fix compiler warnings: use puts() instead of printf()".

Because puts() function add a newline, use instead printf("%s", ).

Cc Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
Cc Vicente Bergas <[email protected]>

Applied, thanks

Sascha

Quoted 31 lines

---

Notes:
v2:
- corrected two typos in the description

 common/menu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/menu.c +1 -1
index 30dced7..a672e59 100644
@@ -274,7 +274,7 @@ int menu_show(struct menu *m)
 			printf("Auto Select in");
 		} else {
 			auto_display_len = strlen(m->auto_display);
-			puts(m->auto_display);
+			printf("%s", m->auto_display);
 		}
 		printf(" %2d", countdown--);
 	}
Signature · 7 lines
1.8.1.1


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox