Skip to contentSkip to conversation

ARM: tegra: pmc: add specific compatible DT string for Tegra30 and Tegra114

PATCH Superseded Joseph Lo 3 participants 3 messages Feb 26, 2013

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Joseph Lo

author
#0 lore raw

PATCH 1/2 ARM: tegra: pmc: add specific compatible DT string for Tegra30 and Tegra114

The PMC HW dose not 100% compatible across all Tegra series. We need to specify each of them in the DT match table.

---
 arch/arm/mach-tegra/pmc.c | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/mach-tegra/pmc.c +2 -0
index d4fdb5f..1b5a908 100644
@@ -37,6 +37,8 @@ static inline void tegra_pmc_writel(u32 val, u32 reg)
 #ifdef CONFIG_OF
 static const struct of_device_id matches[] __initconst = {
 	{ .compatible = "nvidia,tegra20-pmc" },
+	{ .compatible = "nvidia,tegra30-pmc" },
+	{ .compatible = "nvidia,tegra114-pmc" },
 	{ }
 };
 #endif
Signature · 1 line
1.8.1.1
#1 lore raw

PATCH 1/2 ARM: tegra: pmc: add specific compatible DT string for Tegra30 and Tegra114

arch/arm/mach-tegra/pmc.c static inline void tegra_pmc_writel(u32 val, u32 reg) · line 43

Quoted 11 lines · Joseph Lo

The PMC HW dose not 100% compatible across all Tegra series. We need to specify each of them in the DT match table.

arch/arm/mach-tegra/pmc.c +2 -0
 
 static const struct of_device_id matches[] __initconst = {
 	{ .compatible = "nvidia,tegra20-pmc" },
+	{ .compatible = "nvidia,tegra30-pmc" },
+	{ .compatible = "nvidia,tegra114-pmc" },
 	{ }
 };

Those should be listed in order of most recent device through least recent device, i.e. in the opposite order.

#2 lore raw

PATCH 1/2 ARM: tegra: pmc: add specific compatible DT string for Tegra30 and Tegra114

In reply to Joseph Lo

Hello.

On 26-02-2013 13:58, Joseph Lo wrote:

Almost the same mistake.

Quoted 1 line

The PMC HW dose

    s/dose/is/
Quoted 4 lines

not 100% compatible across all Tegra series. We need to specify each of them in the DT match table.

WBR, Sergei