Skip to contentSkip to conversation

xkeyboard-config: this is architecture-indepedent, so set PACKAGE_ARCH

PATCH In review Ross Burton 4 participants 12 messages Feb 26, 2013 – Mar 1, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xkeyboard-config: this is architecture-indepedent, so set PACKAGE_ARCH

---
 meta/recipes-graphics/xorg-lib/xkeyboard-config_2.8.bb |    2 ++
 1 file changed, 2 insertions(+)
meta/recipes-graphics/xorg-lib/xkeyboard-config_2.8.bb +2 -0
index 8ca2f6a..ee3e20c 100644
@@ -19,6 +19,8 @@ SRC_URI[sha256sum] = "4e1cf5468d488aaf320ddfd439e03cbda0b213550fd734026d23138e4b
 SECTION = "x11/libs"
 DEPENDS = "intltool-native xkbcomp-native glib-2.0 virtual/gettext"
 
+PACKAGE_ARCH = "all"
+
 PR = "r0"
 
 EXTRA_OECONF = "--with-xkb-rules-symlink=xorg --disable-runtime-deps"
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 10 lines · Ross Burton
---
 meta/recipes-graphics/xorg-lib/xkeyboard-config_2.8.bb |    2 ++
 1 file changed, 2 insertions(+)
meta/recipes-graphics/xorg-lib/xkeyboard-config_2.8.bb +0 -0
index 8ca2f6a..ee3e20c 100644

meta/recipes-graphics/xorg-lib/xkeyboard-config_2.8.bb SRC_URI[sha256sum] = "4e1cf5468d488aaf320ddfd439e03cbda0b213550fd734026d23138e4b · line 26

Quoted 8 lines
meta/recipes-graphics/xorg-lib/xkeyboard-config_2.8.bb +2 -0
@@ -19,6 +19,8 @@ SRC_URI[sha256sum] = "4e1cf5468d488aaf320ddfd439e03cbda0b213550fd734026d23138e4b
 SECTION = "x11/libs"
 DEPENDS = "intltool-native xkbcomp-native glib-2.0 virtual/gettext"
 
+PACKAGE_ARCH = "all"
+
 PR = "r0"
 
 EXTRA_OECONF = "--with-xkb-rules-symlink=xorg --disable-runtime-deps"

Please inherit allarch

Signature · 3 lines
Otavio Salvador                             O.S. Systems
E-mail: [email protected]  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
#2 lore raw
Quoted 1 line · Otavio Salvador

Please inherit allarch

That doesn't play nicely with autotools:

| checking build system type... x86_64-pc-linux-gnu
| checking host system type... Invalid configuration allarch-poky-linux': machine allarch-poky' not recognized | configure: error: /bin/bash ./config.sub allarch-poky-linux failed

Considering a lot of allarch is designed to remove dependencies that this package uses and thus will need to be restored, directly setting PACKAGE_ARCH is the cleaner solution.

Ross

#3 lore raw
Quoted 5 lines · Ross
Quoted 1 line · Otavio Salvador

Please inherit allarch

That doesn't play nicely with autotools:

Quoted 8 lines

| checking build system type... x86_64-pc-linux-gnu
| checking host system type... Invalid configuration allarch-poky-linux': machine allarch-poky' not recognized | configure: error: /bin/bash ./config.sub allarch-poky-linux failed

Considering a lot of allarch is designed to remove dependencies that this package uses and thus will need to be restored, directly setting PACKAGE_ARCH is the cleaner solution.

If it changes the build depending in target and host, in the end it is not architecture independant code.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
E-mail: [email protected]  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
#4 lore raw
Quoted 2 lines · Otavio Salvador

If it changes the build depending in target and host, in the end it is not architecture independant code.

I think this is just autotools being nosy and failing when it doesn't know what "alllinux" is. The files don't change as they are literally just installed.

Ross

#5 lore raw
Quoted 7 lines · Ross
Quoted 2 lines · Otavio Salvador

If it changes the build depending in target and host, in the end it is not architecture independant code.

I think this is just autotools being nosy and failing when it doesn't know what "alllinux" is. The files don't change as they are literally just installed.

allarch does more than PACKAGE_ARCH so I think it'd be good to use it. Maybe it'd not be hard to disable this call in configure.ac? I don't have a strong opinion about it but using PACKAGE_ARCH only seems like a workaround for me.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
E-mail: [email protected]  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
#6 lore raw
In reply to Burton, Ross
Quoted 7 lines · Ross
Quoted 2 lines · Otavio Salvador

If it changes the build depending in target and host, in the end it is not architecture independant code.

I think this is just autotools being nosy and failing when it doesn't know what "alllinux" is. The files don't change as they are literally just installed.

Check exactly what is in configure.ac. You should be able to use allarch and if you can't, it means the configure script is referencing the compiler, even if it shouldn't be using it. Its designed such that these accesses fail verbosely. It should be a simple fix if the recipe really is just configuration.

Using the allarch class is infinitely preferable as it gets the sstate bits right.

Cheers,

Richard

#7 lore raw
Quoted 5 lines · Richard Purdie

Check exactly what is in configure.ac. You should be able to use allarch and if you can't, it means the configure script is referencing the compiler, even if it shouldn't be using it. Its designed such that these accesses fail verbosely. It should be a simple fix if the recipe really is just configuration.

| configure:2707: checking host system type
| configure:2716: error: /bin/bash ./config.sub allarch-poky-linux failed

The configure.ac ends up running AC_CANONICAL_HOST because it uses different manpage sections for Solaris and everything else.

I think they should be using AC_CANONICAL_SYSTEM, but that calls AC_CANONICAL_HOST anyway so that wouldn't achieve anything.

So, extend my patch, or intrusively patch out the documentation build code in xkeyboard-config.

Ross

#8 lore raw
Quoted 11 lines · Ross
Quoted 5 lines · Richard Purdie

Check exactly what is in configure.ac. You should be able to use allarch and if you can't, it means the configure script is referencing the compiler, even if it shouldn't be using it. Its designed such that these accesses fail verbosely. It should be a simple fix if the recipe really is just configuration.

| configure:2707: checking host system type
| configure:2716: error: /bin/bash ./config.sub allarch-poky-linux failed

Quoted 8 lines

The configure.ac ends up running AC_CANONICAL_HOST because it uses different manpage sections for Solaris and everything else.

I think they should be using AC_CANONICAL_SYSTEM, but that calls AC_CANONICAL_HOST anyway so that wouldn't achieve anything.

So, extend my patch, or intrusively patch out the documentation build code in xkeyboard-config.

I'd say to drop the AC_CANONICAL_HOST call and make it fake Linux as a fixed value.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
E-mail: [email protected]  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
#9 lore raw
Quoted 2 lines · Otavio Salvador

I'd say to drop the AC_CANONICAL_HOST call and make it fake Linux as a fixed value.

Did that in xorg-macros as that's where the definition is, but intltool's configure fragment links a program to set DATADIRNAME (although that appears to be deprecated), so it's trying to find a C compiler now.

How do I *properly* set allarch so sstate "works" but still allow a compiler to run so it can identify distribution-specific values (that have nothing to do with the architecture)?

Ross

#10 lore raw
Quoted 4 lines · Ross
Quoted 2 lines · Otavio Salvador

I'd say to drop the AC_CANONICAL_HOST call and make it fake Linux as a fixed value.

Quoted 8 lines

Did that in xorg-macros as that's where the definition is, but intltool's configure fragment links a program to set DATADIRNAME (although that appears to be deprecated), so it's trying to find a C compiler now.

How do I *properly* set allarch so sstate "works" but still allow a compiler to run so it can identify distribution-specific values (that have nothing to do with the architecture)?

Inherit the class, then set the compiler options to point to the native compiler? I'm very nervous about doing that mind and would prefer to "fix" the macros if we can.

Cheers,

Richard

#11 lore raw
In reply to Ross Burton
Quoted 10 lines · Ross Burton
---
 meta/recipes-graphics/xorg-lib/xkeyboard-config_2.8.bb |    2 ++
 1 file changed, 2 insertions(+)
meta/recipes-graphics/xorg-lib/xkeyboard-config_2.8.bb +0 -0
index 8ca2f6a..ee3e20c 100644

meta/recipes-graphics/xorg-lib/xkeyboard-config_2.8.bb SRC_URI[sha256sum] = "4e1cf5468d488aaf320ddfd439e03cbda0b213550fd734026d23138e4b · line 22

Quoted 4 lines
meta/recipes-graphics/xorg-lib/xkeyboard-config_2.8.bb +1 -0
@@ -19,6 +19,8 @@ SRC_URI[sha256sum] = "4e1cf5468d488aaf320ddfd439e03cbda0b213550fd734026d23138e4b
 SECTION = "x11/libs"
 DEPENDS = "intltool-native xkbcomp-native glib-2.0 virtual/gettext"
 
+PACKAGE_ARCH = "all"

Why not inherit allarch?

Quoted 12 lines
meta/recipes-graphics/xorg-lib/xkeyboard-config_2.8.bb +1 -0
+
 PR = "r0"
 
 EXTRA_OECONF = "--with-xkb-rules-symlink=xorg --disable-runtime-deps"
Signature · 7 lines
1.7.10.4


_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]