Skip to contentSkip to conversation

myri10ge: Remove redundant NULL check before kfree

PATCH New Syam Sidhardhan 1 participant 1 message Feb 26, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 myri10ge: Remove redundant NULL check before kfree

kfree on NULL pointer is a no-op.

---
 drivers/net/ethernet/myricom/myri10ge/myri10ge.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/ethernet/myricom/myri10ge/myri10ge.c +1 -2
index 4f9937e..2f9efe8 100644
@@ -4005,8 +4005,7 @@ static void myri10ge_remove(struct pci_dev *pdev)
 		mtrr_del(mgp->mtrr, mgp->iomem_base, mgp->board_span);
 #endif
 	myri10ge_free_slices(mgp);
-	if (mgp->msix_vectors != NULL)
-		kfree(mgp->msix_vectors);
+	kfree(mgp->msix_vectors);
 	dma_free_coherent(&pdev->dev, sizeof(*mgp->cmd),
 			  mgp->cmd, mgp->cmd_bus);
 
Signature · 1 line
1.7.9.5